)]}'
{"nova/api/openstack/compute/console_auth_tokens.py":[{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"b19c2a7cb97780e548a24ac7f8cdc95677f117a1","unresolved":false,"context_lines":[{"line_number":62,"context_line":"        return self._show(req, id, True)"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"    @wsgi.Controller.api_version(\"2.31\")  # noqa"},{"line_number":65,"context_line":"    @extensions.expected_errors((400, 401, 404))"},{"line_number":66,"context_line":"    def show(self, req, id):"},{"line_number":67,"context_line":"        return self._show(req, id, False)"},{"line_number":68,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5a9d85d2_e463d73f","line":65,"range":{"start_line":65,"start_character":38,"end_line":65,"end_character":41},"updated":"2016-06-21 07:54:31.000000000","message":"So I think we needn\u0027t 401 at here.","commit_id":"b89c52f40fef9bef443c14a34144d8a87a3521cb"},{"author":{"_account_id":9172,"name":"Radoslav Gerganov","email":"rgerganov@vmware.com","username":"rgerganov"},"change_message_id":"c858082e028b628045a36a5c9cd8abcfb8c7c925","unresolved":false,"context_lines":[{"line_number":62,"context_line":"        return self._show(req, id, True)"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"    @wsgi.Controller.api_version(\"2.31\")  # noqa"},{"line_number":65,"context_line":"    @extensions.expected_errors((400, 401, 404))"},{"line_number":66,"context_line":"    def show(self, req, id):"},{"line_number":67,"context_line":"        return self._show(req, id, False)"},{"line_number":68,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5a9d85d2_1cabd3d7","line":65,"range":{"start_line":65,"start_character":38,"end_line":65,"end_character":41},"in_reply_to":"5a9d85d2_e463d73f","updated":"2016-06-21 10:17:37.000000000","message":"Done","commit_id":"b89c52f40fef9bef443c14a34144d8a87a3521cb"}],"nova/api/openstack/rest_api_version_history.rst":[{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"b19c2a7cb97780e548a24ac7f8cdc95677f117a1","unresolved":false,"context_lines":[{"line_number":322,"context_line":"2.31"},{"line_number":323,"context_line":"----"},{"line_number":324,"context_line":""},{"line_number":325,"context_line":"  Fix os-console-auth-tokens to work for all console types."}],"source_content_type":"text/x-rst","patch_set":2,"id":"5a9d85d2_c4597b5c","line":325,"updated":"2016-06-21 07:54:31.000000000","message":"I prefer explain more at here. Like in the commit message said \"The current API allows getting connection info only for tokens which\ncorrespond to RDP consoles.........\". Those are useful background for people understand what is the goal of this microvresion.","commit_id":"b89c52f40fef9bef443c14a34144d8a87a3521cb"},{"author":{"_account_id":9172,"name":"Radoslav Gerganov","email":"rgerganov@vmware.com","username":"rgerganov"},"change_message_id":"c858082e028b628045a36a5c9cd8abcfb8c7c925","unresolved":false,"context_lines":[{"line_number":322,"context_line":"2.31"},{"line_number":323,"context_line":"----"},{"line_number":324,"context_line":""},{"line_number":325,"context_line":"  Fix os-console-auth-tokens to work for all console types."}],"source_content_type":"text/x-rst","patch_set":2,"id":"5a9d85d2_dc7f8b64","line":325,"in_reply_to":"5a9d85d2_c4597b5c","updated":"2016-06-21 10:17:37.000000000","message":"Done","commit_id":"b89c52f40fef9bef443c14a34144d8a87a3521cb"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"6b3a4910199f793b3a7fcf05910b8ec837943ee6","unresolved":false,"context_lines":[{"line_number":323,"context_line":"----"},{"line_number":324,"context_line":""},{"line_number":325,"context_line":"  Fix os-console-auth-tokens to return connection info for all types of tokens,"},{"line_number":326,"context_line":"  not only RDP."}],"source_content_type":"text/x-rst","patch_set":3,"id":"3aaa91ec_9349bbd3","line":326,"range":{"start_line":326,"start_character":6,"end_line":326,"end_character":10},"updated":"2016-06-21 18:30:05.000000000","message":"s/only/just","commit_id":"0a1875438a3c2f394a37eab18fa321ae84fb2223"},{"author":{"_account_id":9172,"name":"Radoslav Gerganov","email":"rgerganov@vmware.com","username":"rgerganov"},"change_message_id":"9d34530ebc1c8554f5e65a2f7aee5fac394d13bf","unresolved":false,"context_lines":[{"line_number":323,"context_line":"----"},{"line_number":324,"context_line":""},{"line_number":325,"context_line":"  Fix os-console-auth-tokens to return connection info for all types of tokens,"},{"line_number":326,"context_line":"  not only RDP."}],"source_content_type":"text/x-rst","patch_set":3,"id":"3aaa91ec_1c365603","line":326,"range":{"start_line":326,"start_character":6,"end_line":326,"end_character":10},"in_reply_to":"3aaa91ec_9349bbd3","updated":"2016-06-22 10:18:53.000000000","message":"Done","commit_id":"0a1875438a3c2f394a37eab18fa321ae84fb2223"}],"nova/tests/unit/api/openstack/compute/test_console_auth_tokens.py":[{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"b19c2a7cb97780e548a24ac7f8cdc95677f117a1","unresolved":false,"context_lines":[{"line_number":80,"context_line":"                          self.controller.show, self.req, fakes.FAKE_UUID)"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"class ConsoleAuthTokensExtensionTestV231(ConsoleAuthTokensExtensionTestV21):"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"    def setUp(self):"},{"line_number":86,"context_line":"        super(ConsoleAuthTokensExtensionTestV231, self).setUp()"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a9d85d2_647367e8","line":83,"updated":"2016-06-21 07:54:31.000000000","message":"there is a discussion about people didn\u0027t like subclass tests http://lists.openstack.org/pipermail/openstack-dev/2016-June/097657.html","commit_id":"b89c52f40fef9bef443c14a34144d8a87a3521cb"},{"author":{"_account_id":9172,"name":"Radoslav Gerganov","email":"rgerganov@vmware.com","username":"rgerganov"},"change_message_id":"c858082e028b628045a36a5c9cd8abcfb8c7c925","unresolved":false,"context_lines":[{"line_number":80,"context_line":"                          self.controller.show, self.req, fakes.FAKE_UUID)"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"class ConsoleAuthTokensExtensionTestV231(ConsoleAuthTokensExtensionTestV21):"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"    def setUp(self):"},{"line_number":86,"context_line":"        super(ConsoleAuthTokensExtensionTestV231, self).setUp()"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a9d85d2_5cba7b0b","line":83,"in_reply_to":"5a9d85d2_647367e8","updated":"2016-06-21 10:17:37.000000000","message":"I think subclassing in this case is appropriate as we want to ensure that no regressions are being made","commit_id":"b89c52f40fef9bef443c14a34144d8a87a3521cb"}]}
