)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8190,"name":"Drew Thorstensen (thorst)","email":"thorst@us.ibm.com","username":"thorst"},"change_message_id":"739e5ae45029438a19d300ecfffcd81b530debe6","unresolved":false,"context_lines":[{"line_number":12,"context_line":"By examining compute log on source Host, you can determine if"},{"line_number":13,"context_line":"InstanceInfoCache has been updated to active\u003dTrue or not."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"When such a VM is evacuated to destination host, since vif state is not active"},{"line_number":16,"context_line":"it goes into stale state and any attempt to plug goes nowhere. This is due to"},{"line_number":17,"context_line":"communication is sent to wrong host (source instead of destination)."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"This patchset fixes this problem by adding logic to rebuild_instance method"},{"line_number":20,"context_line":"in compute manager. It sets active state of all VIFs in the VM to true. This"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5a9d85d2_a03ba0ea","line":17,"range":{"start_line":15,"start_character":0,"end_line":17,"end_character":68},"updated":"2016-06-20 14:58:22.000000000","message":"A couple paragraphs have too long of a message.","commit_id":"32ae001c64e514c204575edb378afcb03a300ec2"},{"author":{"_account_id":8190,"name":"Drew Thorstensen (thorst)","email":"thorst@us.ibm.com","username":"thorst"},"change_message_id":"739e5ae45029438a19d300ecfffcd81b530debe6","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"This patchset fixes this problem by adding logic to rebuild_instance method"},{"line_number":20,"context_line":"in compute manager. It sets active state of all VIFs in the VM to true. This"},{"line_number":21,"context_line":"is how it will be if  VIF state becomes active on source host before it goes"},{"line_number":22,"context_line":"down."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"All corresponding unit tests in test_compute and test_compute_mgr have been"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5a9d85d2_401d9c72","line":21,"range":{"start_line":21,"start_character":20,"end_line":21,"end_character":22},"updated":"2016-06-20 14:58:22.000000000","message":"Double space.","commit_id":"32ae001c64e514c204575edb378afcb03a300ec2"}],"nova/compute/manager.py":[{"author":{"_account_id":8190,"name":"Drew Thorstensen (thorst)","email":"thorst@us.ibm.com","username":"thorst"},"change_message_id":"739e5ae45029438a19d300ecfffcd81b530debe6","unresolved":false,"context_lines":[{"line_number":2623,"context_line":"                LOG.exception(_LE(\u0027Failed to get compute_info for %s\u0027),"},{"line_number":2624,"context_line":"                                self.host)"},{"line_number":2625,"context_line":""},{"line_number":2626,"context_line":"        # NOTE(svenkat): During evacuate, if any of the vif is not"},{"line_number":2627,"context_line":"        # active, it causes vif-plugged event not to be processed. We"},{"line_number":2628,"context_line":"        # need to update vif active status to True before plug is"},{"line_number":2629,"context_line":"        # attempted."}],"source_content_type":"text/x-python","patch_set":1,"id":"5a9d85d2_eb68e9bc","line":2626,"range":{"start_line":2626,"start_character":10,"end_line":2626,"end_character":23},"updated":"2016-06-20 14:58:22.000000000","message":"I don\u0027t know that your name needs to be here.","commit_id":"32ae001c64e514c204575edb378afcb03a300ec2"},{"author":{"_account_id":8190,"name":"Drew Thorstensen (thorst)","email":"thorst@us.ibm.com","username":"thorst"},"change_message_id":"739e5ae45029438a19d300ecfffcd81b530debe6","unresolved":false,"context_lines":[{"line_number":2629,"context_line":"        # attempted."},{"line_number":2630,"context_line":"        network_info \u003d instance.info_cache.network_info"},{"line_number":2631,"context_line":"        for nw in network_info:"},{"line_number":2632,"context_line":"            nw[\u0027active\u0027] \u003d True"},{"line_number":2633,"context_line":"        base_net_api.update_instance_cache_with_nw_info("},{"line_number":2634,"context_line":"                         self.network_api, context,"},{"line_number":2635,"context_line":"                         instance,"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a9d85d2_ab20a19c","line":2632,"range":{"start_line":2632,"start_character":12,"end_line":2632,"end_character":31},"updated":"2016-06-20 14:58:22.000000000","message":"This seems fairly drastic.  As such, I\u0027d think you would only want to set this if it was not active.\n\nThe reason I say that is so that you add a log.warning operation to log that this needed to be updated.","commit_id":"32ae001c64e514c204575edb378afcb03a300ec2"},{"author":{"_account_id":8190,"name":"Drew Thorstensen (thorst)","email":"thorst@us.ibm.com","username":"thorst"},"change_message_id":"739e5ae45029438a19d300ecfffcd81b530debe6","unresolved":false,"context_lines":[{"line_number":2630,"context_line":"        network_info \u003d instance.info_cache.network_info"},{"line_number":2631,"context_line":"        for nw in network_info:"},{"line_number":2632,"context_line":"            nw[\u0027active\u0027] \u003d True"},{"line_number":2633,"context_line":"        base_net_api.update_instance_cache_with_nw_info("},{"line_number":2634,"context_line":"                         self.network_api, context,"},{"line_number":2635,"context_line":"                         instance,"},{"line_number":2636,"context_line":"                         nw_info\u003dnetwork_info)"},{"line_number":2637,"context_line":""},{"line_number":2638,"context_line":"        with self._error_out_instance_on_exception(context, instance):"},{"line_number":2639,"context_line":"            try:"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a9d85d2_6b4d1972","line":2636,"range":{"start_line":2633,"start_character":0,"end_line":2636,"end_character":46},"updated":"2016-06-20 14:58:22.000000000","message":"This formatting seems odd.","commit_id":"32ae001c64e514c204575edb378afcb03a300ec2"}]}