)]}'
{"nova/tests/virt/powervm/test_powervm.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"30a23fb8cd4c2f6bc517554781f3c62d85528814","unresolved":false,"context_lines":[{"line_number":174,"context_line":""},{"line_number":175,"context_line":"def fake_get_powervm_operator():"},{"line_number":176,"context_line":"    return FakeIVMOperator(common.Connection(\u0027fake_host\u0027, \u0027fake_user\u0027,"},{"line_number":177,"context_line":"                                             \u0027fake_password\u0027))"},{"line_number":178,"context_line":""},{"line_number":179,"context_line":""},{"line_number":180,"context_line":"def create_instance(testcase):"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAPn%2F%2F%2BWE%3D","line":177,"updated":"2013-06-16 20:02:27.000000000","message":"I don\u0027t know why this string isn\u0027t lined up here, it looks fine in vim on my system.","commit_id":"8ca0e2fdf0a3e8795f3d536fdff5e8049b154d52"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"2a18bf69cd2522f687a07be51ddba105c8d5b9e0","unresolved":false,"context_lines":[{"line_number":174,"context_line":""},{"line_number":175,"context_line":"def fake_get_powervm_operator():"},{"line_number":176,"context_line":"    return FakeIVMOperator(common.Connection(\u0027fake_host\u0027, \u0027fake_user\u0027,"},{"line_number":177,"context_line":"                                             \u0027fake_password\u0027))"},{"line_number":178,"context_line":""},{"line_number":179,"context_line":""},{"line_number":180,"context_line":"def create_instance(testcase):"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAPn%2F%2Fk%2Fk%3D","line":177,"in_reply_to":"AAAAPn%2F%2F%2BWE%3D","updated":"2013-06-27 13:25:31.000000000","message":"I think this is an issue with Gerrit. I\u0027ve seen it on reviews before and it looks fine when on my development instance.","commit_id":"8ca0e2fdf0a3e8795f3d536fdff5e8049b154d52"}],"nova/virt/powervm/command.py":[{"author":{"_account_id":5371,"name":"Mathew Odden","email":"locke105@gmail.com","username":"locke105"},"change_message_id":"26e57f3c61badf22cfb7047ba3fc567c6a7e9a69","unresolved":false,"context_lines":[{"line_number":71,"context_line":"    def sysstat(self, args\u003d\u0027\u0027):"},{"line_number":72,"context_line":"        \"\"\""},{"line_number":73,"context_line":"        Returns a string of the formatted sysstat command to run."},{"line_number":74,"context_line":"        Typically this command should be ran with the -short option"},{"line_number":75,"context_line":"        and a User operand should be provided to narrow the results."},{"line_number":76,"context_line":"        :returns: string - formatted sysstat command"},{"line_number":77,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAPn%2F%2F6Pc%3D","line":74,"updated":"2013-06-18 14:30:57.000000000","message":"nit: ran \u003d\u003e run , I think?","commit_id":"d255cf78567a8c46cb482ffa3a84298a0cc52474"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"6dc7913f57014d99e7287cc23d3f5ff8f00ee451","unresolved":false,"context_lines":[{"line_number":71,"context_line":"    def sysstat(self, args\u003d\u0027\u0027):"},{"line_number":72,"context_line":"        \"\"\""},{"line_number":73,"context_line":"        Returns a string of the formatted sysstat command to run."},{"line_number":74,"context_line":"        Typically this command should be ran with the -short option"},{"line_number":75,"context_line":"        and a User operand should be provided to narrow the results."},{"line_number":76,"context_line":"        :returns: string - formatted sysstat command"},{"line_number":77,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAPn%2F%2F5mI%3D","line":74,"in_reply_to":"AAAAPn%2F%2F6Pc%3D","updated":"2013-06-18 17:57:52.000000000","message":"Damn it, my wife is always correcting me on that one too. Now I have two wives!","commit_id":"d255cf78567a8c46cb482ffa3a84298a0cc52474"}],"nova/virt/powervm/operator.py":[{"author":{"_account_id":7282,"name":"Qing Xin Meng","email":"mengqxqx@cn.ibm.com","username":"mengqxqx"},"change_message_id":"1e53e16ee3b66ef7ddd51e1319cc648cdd3d21f5","unresolved":false,"context_lines":[{"line_number":640,"context_line":"        cmd \u003d self.command.sysstat(\u0027-short %s\u0027 % self.connection_data.username)"},{"line_number":641,"context_line":"        output \u003d self.run_vios_command(cmd)"},{"line_number":642,"context_line":"        # parse the sysstat output so we just return the uptime"},{"line_number":643,"context_line":"        system_time, uptime \u003d output[0].split(\u0027,\u0027)[0:2]"},{"line_number":644,"context_line":"        return system_time + uptime"},{"line_number":645,"context_line":""},{"line_number":646,"context_line":"    def get_cpu_info(self):"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAPn%2F%2FeUI%3D","line":643,"updated":"2013-07-01 07:24:21.000000000","message":"According to the api-example file, I don\u0027t think this split operation is needed.\n\n---\nhttps://github.com/openstack/nova/blob/master/doc/api_samples/os-hypervisors/hypervisors-uptime-resp.json\n\n{\n    \"hypervisor\": {\n        \"hypervisor_hostname\": \"fake-mini\",\n        \"id\": 1,\n        \"uptime\": \" 08:32:11 up 93 days, 18:25, 12 users, load average: 0.20, 0.12, 0.14\"\n    }\n}\n---","commit_id":"0946017e289cc865913980dbe199106d9b152cf3"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"29453e7efdbec91af05f6512a740e7998c036d8d","unresolved":false,"context_lines":[{"line_number":641,"context_line":"        output \u003d self.run_vios_command(cmd)"},{"line_number":642,"context_line":"        # parse the sysstat output so we just return the uptime"},{"line_number":643,"context_line":"        system_time, uptime \u003d output[0].split(\u0027,\u0027)[0:2]"},{"line_number":644,"context_line":"        return system_time + uptime"},{"line_number":645,"context_line":""},{"line_number":646,"context_line":"    def get_cpu_info(self):"},{"line_number":647,"context_line":"        \"\"\"Get CPU info."}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAPn%2F%2Fk%2B8%3D","line":644,"updated":"2013-06-27 13:30:29.000000000","message":"Wondering if we should concatenate these variables or not and leave it up to the calling method to do whatever with either the system_time or uptime. I guess it all depends on what is using it. Just a thought.","commit_id":"0946017e289cc865913980dbe199106d9b152cf3"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"368615f887ede61a4e58ce6ecd0ef9624cb6b454","unresolved":false,"context_lines":[{"line_number":641,"context_line":"        output \u003d self.run_vios_command(cmd)"},{"line_number":642,"context_line":"        # parse the sysstat output so we just return the uptime"},{"line_number":643,"context_line":"        system_time, uptime \u003d output[0].split(\u0027,\u0027)[0:2]"},{"line_number":644,"context_line":"        return system_time + uptime"},{"line_number":645,"context_line":""},{"line_number":646,"context_line":"    def get_cpu_info(self):"},{"line_number":647,"context_line":"        \"\"\"Get CPU info."}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAPn%2F%2Fk80%3D","line":644,"in_reply_to":"AAAAPn%2F%2Fk%2B8%3D","updated":"2013-06-27 13:43:24.000000000","message":"The problem with that is the goofy way that VIOS reports the uptime, i.e. I\u0027m splitting on comma but part of the uptime is in the first part of the split (the 24 days in the example).  The rest of the up time is in the second part of the split (the 5 hours, 41 minutes).  So I concatenate them for the total uptime rather than have to parse around \u0027up*days\u0027 or something in the output.","commit_id":"0946017e289cc865913980dbe199106d9b152cf3"},{"author":{"_account_id":6722,"name":"ChangBo Guo(gcb)","email":"guochbo@cn.ibm.com","username":"guochbo"},"change_message_id":"30d33e2c7734e1a76dc696e3dfde1f7064760b1b","unresolved":false,"context_lines":[{"line_number":642,"context_line":"        # parse the sysstat output so we just return the uptime"},{"line_number":643,"context_line":"        system_time, uptime \u003d output[0].split(\u0027,\u0027)[0:2]"},{"line_number":644,"context_line":"        return system_time + uptime"},{"line_number":645,"context_line":""},{"line_number":646,"context_line":"    def get_cpu_info(self):"},{"line_number":647,"context_line":"        \"\"\"Get CPU info."},{"line_number":648,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAPn%2F%2Fi4I%3D","line":645,"updated":"2013-06-28 03:02:47.000000000","message":"vios has uptime  command  as root . The following is a example.\n$ sysstat -short padmin\n  09:58PM   up 159 days,  17:29,  7 users,  load average: 1.86, 1.93, 1.29\n$ oem_setup_env\n# uptime\n  09:58PM   up 159 days,  17:29,  7 users,  load average: 1.73, 1.90, 1.29\n#","commit_id":"0946017e289cc865913980dbe199106d9b152cf3"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"65836eda2afc06da7f012406f1b2bb1c190596d4","unresolved":false,"context_lines":[{"line_number":642,"context_line":"        # parse the sysstat output so we just return the uptime"},{"line_number":643,"context_line":"        system_time, uptime \u003d output[0].split(\u0027,\u0027)[0:2]"},{"line_number":644,"context_line":"        return system_time + uptime"},{"line_number":645,"context_line":""},{"line_number":646,"context_line":"    def get_cpu_info(self):"},{"line_number":647,"context_line":"        \"\"\"Get CPU info."},{"line_number":648,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAPn%2F%2Fh4g%3D","line":645,"in_reply_to":"AAAAPn%2F%2Fi4I%3D","updated":"2013-06-28 13:34:39.000000000","message":"There is no documentation of \u0027uptime\u0027 in the VIOS/IVM InfoCenter.  I found this for oem_setup_env:\n\nhttp://pic.dhe.ibm.com/infocenter/powersys/v3r1m5/index.jsp?topic\u003d/iphcg/oem_setup_env.htm\n\nIt says that it shouldn\u0027t be used for VIOS administration, but only for installation and working with vendor devices, so I\u0027m inclined to not play with that but rather use the supported IVM command sysstat which gives the same info.","commit_id":"0946017e289cc865913980dbe199106d9b152cf3"}]}