)]}'
{"nova/conf/compute.py":[{"author":{"_account_id":18337,"name":"Sujitha","email":"sujitha.neti@intel.com","username":"Sujitha"},"change_message_id":"817e54cf7a2f5a6d1cb4599b1968aaa18a11cb7a","unresolved":false,"context_lines":[{"line_number":185,"context_line":"               help\u003d\"\"\""},{"line_number":186,"context_line":"Interval to pull network bandwidth usage info. Not supported on all"},{"line_number":187,"context_line":"hypervisors. If a hypervisor doesn\u0027t support bandwidth usage, it"},{"line_number":188,"context_line":"doesn\u0027t break anything instead it just don\u0027t get the info in the"},{"line_number":189,"context_line":"usage events."},{"line_number":190,"context_line":""},{"line_number":191,"context_line":"Possible values:"}],"source_content_type":"text/x-python","patch_set":3,"id":"3aaa91ec_2804c6c4","line":188,"updated":"2016-06-27 18:32:08.000000000","message":"I think this can be changed to: If a hypervisor doesn\u0027t support bandwidth usage, it will not get the info in the usage events.","commit_id":"17d1cf1ce72435c6f42168a37e5370ecb3e01f76"},{"author":{"_account_id":20217,"name":"Anusha Unnam","email":"anusha.unnam25@gmail.com","username":"aunnam"},"change_message_id":"bb0a9ab631a801d6a4f4c89b7dc9c99429d8dcfd","unresolved":false,"context_lines":[{"line_number":185,"context_line":"               help\u003d\"\"\""},{"line_number":186,"context_line":"Interval to pull network bandwidth usage info. Not supported on all"},{"line_number":187,"context_line":"hypervisors. If a hypervisor doesn\u0027t support bandwidth usage, it"},{"line_number":188,"context_line":"doesn\u0027t break anything instead it just don\u0027t get the info in the"},{"line_number":189,"context_line":"usage events."},{"line_number":190,"context_line":""},{"line_number":191,"context_line":"Possible values:"}],"source_content_type":"text/x-python","patch_set":3,"id":"3aaa91ec_62d95057","line":188,"in_reply_to":"3aaa91ec_2804c6c4","updated":"2016-06-29 20:47:31.000000000","message":"Done","commit_id":"17d1cf1ce72435c6f42168a37e5370ecb3e01f76"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"cfea0b87a868b8c405e95119d9898ffb300e7334","unresolved":false,"context_lines":[{"line_number":191,"context_line":"Possible values:"},{"line_number":192,"context_line":""},{"line_number":193,"context_line":"    * 0: Will run at the default periodic interval."},{"line_number":194,"context_line":"    * -1: Disables the option."},{"line_number":195,"context_line":"    * Any positive integer in seconds(default is 600)."},{"line_number":196,"context_line":""},{"line_number":197,"context_line":"Related options:"}],"source_content_type":"text/x-python","patch_set":3,"id":"3aaa91ec_fd4a5a26","line":194,"range":{"start_line":194,"start_character":6,"end_line":194,"end_character":30},"updated":"2016-06-28 10:43:43.000000000","message":"Maybe if range is defined on at least one end, we should add min/max flag to IntOpts? In this case min\u003d-1","commit_id":"17d1cf1ce72435c6f42168a37e5370ecb3e01f76"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"cfea0b87a868b8c405e95119d9898ffb300e7334","unresolved":false,"context_lines":[{"line_number":194,"context_line":"    * -1: Disables the option."},{"line_number":195,"context_line":"    * Any positive integer in seconds(default is 600)."},{"line_number":196,"context_line":""},{"line_number":197,"context_line":"Related options:"},{"line_number":198,"context_line":""},{"line_number":199,"context_line":"    * None"},{"line_number":200,"context_line":"\"\"\"),"},{"line_number":201,"context_line":"    cfg.IntOpt(\u0027sync_power_state_interval\u0027,"},{"line_number":202,"context_line":"               default\u003d600,"}],"source_content_type":"text/x-python","patch_set":3,"id":"3aaa91ec_7d9aeac6","line":199,"range":{"start_line":197,"start_character":0,"end_line":199,"end_character":10},"updated":"2016-06-28 10:43:43.000000000","message":"Drop this section","commit_id":"17d1cf1ce72435c6f42168a37e5370ecb3e01f76"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"cfea0b87a868b8c405e95119d9898ffb300e7334","unresolved":false,"context_lines":[{"line_number":218,"context_line":"Possible values:"},{"line_number":219,"context_line":""},{"line_number":220,"context_line":"    * 0: Will run at the default periodic interval."},{"line_number":221,"context_line":"    * -1: Disables the option."},{"line_number":222,"context_line":"    * Any positive integer in seconds(default is 600)."},{"line_number":223,"context_line":""},{"line_number":224,"context_line":"Related options:"}],"source_content_type":"text/x-python","patch_set":3,"id":"3aaa91ec_5d09eedc","line":221,"range":{"start_line":221,"start_character":6,"end_line":221,"end_character":30},"updated":"2016-06-28 10:43:43.000000000","message":"Maybe if range is defined on at least one end, we should add min/max flag to IntOpts? In this case min\u003d-1","commit_id":"17d1cf1ce72435c6f42168a37e5370ecb3e01f76"},{"author":{"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},"change_message_id":"424d8cbcace0b23b98d85642410437d7f7d50e7a","unresolved":false,"context_lines":[{"line_number":231,"context_line":"               default\u003d60,"},{"line_number":232,"context_line":"               help\u003d\"\"\""},{"line_number":233,"context_line":"Number of seconds between instance network information cache updates."},{"line_number":234,"context_line":""},{"line_number":235,"context_line":"For every heal_instance_info_cache_interval number of seconds, each"},{"line_number":236,"context_line":"compute node runs the task of querying Neutron for all of its instances"},{"line_number":237,"context_line":"networking information, then updates the Nova db with that information."},{"line_number":238,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3aaa91ec_e3d99b58","line":235,"range":{"start_line":234,"start_character":0,"end_line":235,"end_character":43},"updated":"2016-06-24 14:40:24.000000000","message":"nit: I don\u0027t think you need this. It is kind of redundant. \"Number of seconds after which each ..\"","commit_id":"17d1cf1ce72435c6f42168a37e5370ecb3e01f76"},{"author":{"_account_id":20217,"name":"Anusha Unnam","email":"anusha.unnam25@gmail.com","username":"aunnam"},"change_message_id":"bb0a9ab631a801d6a4f4c89b7dc9c99429d8dcfd","unresolved":false,"context_lines":[{"line_number":231,"context_line":"               default\u003d60,"},{"line_number":232,"context_line":"               help\u003d\"\"\""},{"line_number":233,"context_line":"Number of seconds between instance network information cache updates."},{"line_number":234,"context_line":""},{"line_number":235,"context_line":"For every heal_instance_info_cache_interval number of seconds, each"},{"line_number":236,"context_line":"compute node runs the task of querying Neutron for all of its instances"},{"line_number":237,"context_line":"networking information, then updates the Nova db with that information."},{"line_number":238,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3aaa91ec_b5a24dac","line":235,"range":{"start_line":234,"start_character":0,"end_line":235,"end_character":43},"in_reply_to":"3aaa91ec_e3d99b58","updated":"2016-06-29 20:47:31.000000000","message":"Done","commit_id":"17d1cf1ce72435c6f42168a37e5370ecb3e01f76"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"cfea0b87a868b8c405e95119d9898ffb300e7334","unresolved":false,"context_lines":[{"line_number":238,"context_line":""},{"line_number":239,"context_line":"Possible values:"},{"line_number":240,"context_line":""},{"line_number":241,"context_line":"    * Any positive integer in seconds(default is 60)."},{"line_number":242,"context_line":"    * Nova will never update it\u0027s cache if this option is set to 0, which is"},{"line_number":243,"context_line":"      why it is not recommended."},{"line_number":244,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3aaa91ec_9d13560d","line":241,"range":{"start_line":241,"start_character":6,"end_line":241,"end_character":53},"updated":"2016-06-28 10:43:43.000000000","message":"Maybe if range is defined on at least one end, we should add min/max flag to IntOpts? In this case min\u003d0","commit_id":"17d1cf1ce72435c6f42168a37e5370ecb3e01f76"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"cfea0b87a868b8c405e95119d9898ffb300e7334","unresolved":false,"context_lines":[{"line_number":242,"context_line":"    * Nova will never update it\u0027s cache if this option is set to 0, which is"},{"line_number":243,"context_line":"      why it is not recommended."},{"line_number":244,"context_line":""},{"line_number":245,"context_line":"Related options:"},{"line_number":246,"context_line":""},{"line_number":247,"context_line":"    * None"},{"line_number":248,"context_line":"\"\"\"),"},{"line_number":249,"context_line":"    cfg.IntOpt(\u0027reclaim_instance_interval\u0027,"},{"line_number":250,"context_line":"               min\u003d0,"}],"source_content_type":"text/x-python","patch_set":3,"id":"3aaa91ec_1d0006aa","line":247,"range":{"start_line":245,"start_character":0,"end_line":247,"end_character":10},"updated":"2016-06-28 10:43:43.000000000","message":"Drop this section","commit_id":"17d1cf1ce72435c6f42168a37e5370ecb3e01f76"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"cfea0b87a868b8c405e95119d9898ffb300e7334","unresolved":false,"context_lines":[{"line_number":267,"context_line":"    * Any positive integer(in seconds) greater than 0 will enable this option."},{"line_number":268,"context_line":"    * Default value is 0 which means the option is disabled."},{"line_number":269,"context_line":""},{"line_number":270,"context_line":"Related options:"},{"line_number":271,"context_line":""},{"line_number":272,"context_line":"    * None"},{"line_number":273,"context_line":"\"\"\"),"},{"line_number":274,"context_line":"    cfg.IntOpt(\u0027volume_usage_poll_interval\u0027,"},{"line_number":275,"context_line":"               default\u003d0,"}],"source_content_type":"text/x-python","patch_set":3,"id":"3aaa91ec_5d30ce9e","line":272,"range":{"start_line":270,"start_character":0,"end_line":272,"end_character":10},"updated":"2016-06-28 10:43:43.000000000","message":"Drop","commit_id":"17d1cf1ce72435c6f42168a37e5370ecb3e01f76"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"cfea0b87a868b8c405e95119d9898ffb300e7334","unresolved":false,"context_lines":[{"line_number":279,"context_line":""},{"line_number":280,"context_line":"Possible values:"},{"line_number":281,"context_line":""},{"line_number":282,"context_line":"    * Any positive integer(in seconds) greater than 0 will enable this option."},{"line_number":283,"context_line":"    * Default value is 0 which means the option is disabled."},{"line_number":284,"context_line":""},{"line_number":285,"context_line":"Related options:"},{"line_number":286,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3aaa91ec_5dd72e23","line":283,"range":{"start_line":282,"start_character":6,"end_line":283,"end_character":60},"updated":"2016-06-28 10:43:43.000000000","message":"Maybe if range is defined on at least one end, we should add min/max flag to IntOpts? In this case min\u003d0","commit_id":"17d1cf1ce72435c6f42168a37e5370ecb3e01f76"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"cfea0b87a868b8c405e95119d9898ffb300e7334","unresolved":false,"context_lines":[{"line_number":282,"context_line":"    * Any positive integer(in seconds) greater than 0 will enable this option."},{"line_number":283,"context_line":"    * Default value is 0 which means the option is disabled."},{"line_number":284,"context_line":""},{"line_number":285,"context_line":"Related options:"},{"line_number":286,"context_line":""},{"line_number":287,"context_line":"    * None"},{"line_number":288,"context_line":"\"\"\"),"},{"line_number":289,"context_line":"    cfg.IntOpt(\u0027shelved_poll_interval\u0027,"},{"line_number":290,"context_line":"               default\u003d3600,"}],"source_content_type":"text/x-python","patch_set":3,"id":"3aaa91ec_fde6da14","line":287,"range":{"start_line":285,"start_character":0,"end_line":287,"end_character":10},"updated":"2016-06-28 10:43:43.000000000","message":"Drop this section","commit_id":"17d1cf1ce72435c6f42168a37e5370ecb3e01f76"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"cfea0b87a868b8c405e95119d9898ffb300e7334","unresolved":false,"context_lines":[{"line_number":298,"context_line":""},{"line_number":299,"context_line":"Possible values:"},{"line_number":300,"context_line":""},{"line_number":301,"context_line":"    * 0: Will run at the default periodic interval."},{"line_number":302,"context_line":"    * -1: Disables the option."},{"line_number":303,"context_line":"    * Any positive integer in seconds(default is 3600)."},{"line_number":304,"context_line":""},{"line_number":305,"context_line":"Related options:"},{"line_number":306,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3aaa91ec_5dbe0ed5","line":303,"range":{"start_line":301,"start_character":4,"end_line":303,"end_character":55},"updated":"2016-06-28 10:43:43.000000000","message":"Maybe if range is defined on at least one end, we should add min/max flag to IntOpts? In this case min\u003d-1","commit_id":"17d1cf1ce72435c6f42168a37e5370ecb3e01f76"},{"author":{"_account_id":18337,"name":"Sujitha","email":"sujitha.neti@intel.com","username":"Sujitha"},"change_message_id":"817e54cf7a2f5a6d1cb4599b1968aaa18a11cb7a","unresolved":false,"context_lines":[{"line_number":309,"context_line":"    cfg.IntOpt(\u0027shelved_offload_time\u0027,"},{"line_number":310,"context_line":"               default\u003d0,"},{"line_number":311,"context_line":"               help\u003d\"\"\""},{"line_number":312,"context_line":"Time in seconds before a shelved instance is eligible for removing from"},{"line_number":313,"context_line":"a host. By default this option is set to 0 and the shelved instance will"},{"line_number":314,"context_line":"be removed from the hypervisor immediately after shelve operation."},{"line_number":315,"context_line":"Otherwise, the instance will be kept for the value of shelved_offload_time"}],"source_content_type":"text/x-python","patch_set":3,"id":"3aaa91ec_52d742bf","line":312,"updated":"2016-06-27 18:32:08.000000000","message":"s/removing/removal","commit_id":"17d1cf1ce72435c6f42168a37e5370ecb3e01f76"},{"author":{"_account_id":20217,"name":"Anusha Unnam","email":"anusha.unnam25@gmail.com","username":"aunnam"},"change_message_id":"bb0a9ab631a801d6a4f4c89b7dc9c99429d8dcfd","unresolved":false,"context_lines":[{"line_number":309,"context_line":"    cfg.IntOpt(\u0027shelved_offload_time\u0027,"},{"line_number":310,"context_line":"               default\u003d0,"},{"line_number":311,"context_line":"               help\u003d\"\"\""},{"line_number":312,"context_line":"Time in seconds before a shelved instance is eligible for removing from"},{"line_number":313,"context_line":"a host. By default this option is set to 0 and the shelved instance will"},{"line_number":314,"context_line":"be removed from the hypervisor immediately after shelve operation."},{"line_number":315,"context_line":"Otherwise, the instance will be kept for the value of shelved_offload_time"}],"source_content_type":"text/x-python","patch_set":3,"id":"3aaa91ec_150b612b","line":312,"in_reply_to":"3aaa91ec_52d742bf","updated":"2016-06-29 20:47:31.000000000","message":"Done","commit_id":"17d1cf1ce72435c6f42168a37e5370ecb3e01f76"},{"author":{"_account_id":18337,"name":"Sujitha","email":"sujitha.neti@intel.com","username":"Sujitha"},"change_message_id":"817e54cf7a2f5a6d1cb4599b1968aaa18a11cb7a","unresolved":false,"context_lines":[{"line_number":315,"context_line":"Otherwise, the instance will be kept for the value of shelved_offload_time"},{"line_number":316,"context_line":"(in seconds) so that during the time period the unshelve action will be"},{"line_number":317,"context_line":"faster, then the periodic task will remove the instance from hypervisor after"},{"line_number":318,"context_line":"shelved_offload_time time passes. Set the this option to -1 make it"},{"line_number":319,"context_line":"never offload."},{"line_number":320,"context_line":""},{"line_number":321,"context_line":"Possible values:"}],"source_content_type":"text/x-python","patch_set":3,"id":"3aaa91ec_ad6bab84","line":318,"updated":"2016-06-27 18:32:08.000000000","message":"s/shelved_offload_time time passes/shelved_offload_time","commit_id":"17d1cf1ce72435c6f42168a37e5370ecb3e01f76"},{"author":{"_account_id":20217,"name":"Anusha Unnam","email":"anusha.unnam25@gmail.com","username":"aunnam"},"change_message_id":"bb0a9ab631a801d6a4f4c89b7dc9c99429d8dcfd","unresolved":false,"context_lines":[{"line_number":315,"context_line":"Otherwise, the instance will be kept for the value of shelved_offload_time"},{"line_number":316,"context_line":"(in seconds) so that during the time period the unshelve action will be"},{"line_number":317,"context_line":"faster, then the periodic task will remove the instance from hypervisor after"},{"line_number":318,"context_line":"shelved_offload_time time passes. Set the this option to -1 make it"},{"line_number":319,"context_line":"never offload."},{"line_number":320,"context_line":""},{"line_number":321,"context_line":"Possible values:"}],"source_content_type":"text/x-python","patch_set":3,"id":"3aaa91ec_d80bd022","line":318,"in_reply_to":"3aaa91ec_ad6bab84","updated":"2016-06-29 20:47:31.000000000","message":"Done","commit_id":"17d1cf1ce72435c6f42168a37e5370ecb3e01f76"},{"author":{"_account_id":18337,"name":"Sujitha","email":"sujitha.neti@intel.com","username":"Sujitha"},"change_message_id":"817e54cf7a2f5a6d1cb4599b1968aaa18a11cb7a","unresolved":false,"context_lines":[{"line_number":322,"context_line":""},{"line_number":323,"context_line":"    * 0: Instance will be immediately offloaded after being shelved(default)."},{"line_number":324,"context_line":"    * -1: An instance will never offload."},{"line_number":325,"context_line":"    * Any positive integer in seconds: The instance will exists these many"},{"line_number":326,"context_line":"      number of seconds before being offloaded."},{"line_number":327,"context_line":""},{"line_number":328,"context_line":"Related options:"}],"source_content_type":"text/x-python","patch_set":3,"id":"3aaa91ec_0d247fad","line":325,"updated":"2016-06-27 18:32:08.000000000","message":"I think this sounds better: The instance will exist for the specified number of seconds before being offloaded.","commit_id":"17d1cf1ce72435c6f42168a37e5370ecb3e01f76"},{"author":{"_account_id":20217,"name":"Anusha Unnam","email":"anusha.unnam25@gmail.com","username":"aunnam"},"change_message_id":"bb0a9ab631a801d6a4f4c89b7dc9c99429d8dcfd","unresolved":false,"context_lines":[{"line_number":322,"context_line":""},{"line_number":323,"context_line":"    * 0: Instance will be immediately offloaded after being shelved(default)."},{"line_number":324,"context_line":"    * -1: An instance will never offload."},{"line_number":325,"context_line":"    * Any positive integer in seconds: The instance will exists these many"},{"line_number":326,"context_line":"      number of seconds before being offloaded."},{"line_number":327,"context_line":""},{"line_number":328,"context_line":"Related options:"}],"source_content_type":"text/x-python","patch_set":3,"id":"3aaa91ec_58188075","line":325,"in_reply_to":"3aaa91ec_0d247fad","updated":"2016-06-29 20:47:31.000000000","message":"Done","commit_id":"17d1cf1ce72435c6f42168a37e5370ecb3e01f76"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"cfea0b87a868b8c405e95119d9898ffb300e7334","unresolved":false,"context_lines":[{"line_number":320,"context_line":""},{"line_number":321,"context_line":"Possible values:"},{"line_number":322,"context_line":""},{"line_number":323,"context_line":"    * 0: Instance will be immediately offloaded after being shelved(default)."},{"line_number":324,"context_line":"    * -1: An instance will never offload."},{"line_number":325,"context_line":"    * Any positive integer in seconds: The instance will exists these many"},{"line_number":326,"context_line":"      number of seconds before being offloaded."},{"line_number":327,"context_line":""},{"line_number":328,"context_line":"Related options:"},{"line_number":329,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3aaa91ec_9dafd693","line":326,"range":{"start_line":323,"start_character":5,"end_line":326,"end_character":47},"updated":"2016-06-28 10:43:43.000000000","message":"Maybe if range is defined on at least one end, we should add min/max flag to IntOpts? In this case min\u003d-1","commit_id":"17d1cf1ce72435c6f42168a37e5370ecb3e01f76"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"cfea0b87a868b8c405e95119d9898ffb300e7334","unresolved":false,"context_lines":[{"line_number":325,"context_line":"    * Any positive integer in seconds: The instance will exists these many"},{"line_number":326,"context_line":"      number of seconds before being offloaded."},{"line_number":327,"context_line":""},{"line_number":328,"context_line":"Related options:"},{"line_number":329,"context_line":""},{"line_number":330,"context_line":"    * None"},{"line_number":331,"context_line":"\"\"\"),"},{"line_number":332,"context_line":"    cfg.IntOpt(\u0027instance_delete_interval\u0027,"},{"line_number":333,"context_line":"               default\u003d300,"}],"source_content_type":"text/x-python","patch_set":3,"id":"3aaa91ec_fd941a45","line":330,"range":{"start_line":328,"start_character":0,"end_line":330,"end_character":10},"updated":"2016-06-28 10:43:43.000000000","message":"Drop this section","commit_id":"17d1cf1ce72435c6f42168a37e5370ecb3e01f76"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"cfea0b87a868b8c405e95119d9898ffb300e7334","unresolved":false,"context_lines":[{"line_number":340,"context_line":""},{"line_number":341,"context_line":"Possible values:"},{"line_number":342,"context_line":""},{"line_number":343,"context_line":"    * 0: Will run at the default periodic interval."},{"line_number":344,"context_line":"    * -1: Disables the option."},{"line_number":345,"context_line":"    * Any postive integer in seconds(default is 300)."},{"line_number":346,"context_line":""},{"line_number":347,"context_line":"Related options:"},{"line_number":348,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3aaa91ec_3d76a23e","line":345,"range":{"start_line":343,"start_character":5,"end_line":345,"end_character":53},"updated":"2016-06-28 10:43:43.000000000","message":"Maybe if range is defined on at least one end, we should add min/max flag to IntOpts? In this case min\u003d-1","commit_id":"17d1cf1ce72435c6f42168a37e5370ecb3e01f76"},{"author":{"_account_id":18337,"name":"Sujitha","email":"sujitha.neti@intel.com","username":"Sujitha"},"change_message_id":"817e54cf7a2f5a6d1cb4599b1968aaa18a11cb7a","unresolved":false,"context_lines":[{"line_number":342,"context_line":""},{"line_number":343,"context_line":"    * 0: Will run at the default periodic interval."},{"line_number":344,"context_line":"    * -1: Disables the option."},{"line_number":345,"context_line":"    * Any postive integer in seconds(default is 300)."},{"line_number":346,"context_line":""},{"line_number":347,"context_line":"Related options:"},{"line_number":348,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3aaa91ec_48b832e6","line":345,"updated":"2016-06-27 18:32:08.000000000","message":"s/postive/positive","commit_id":"17d1cf1ce72435c6f42168a37e5370ecb3e01f76"},{"author":{"_account_id":20217,"name":"Anusha Unnam","email":"anusha.unnam25@gmail.com","username":"aunnam"},"change_message_id":"bb0a9ab631a801d6a4f4c89b7dc9c99429d8dcfd","unresolved":false,"context_lines":[{"line_number":342,"context_line":""},{"line_number":343,"context_line":"    * 0: Will run at the default periodic interval."},{"line_number":344,"context_line":"    * -1: Disables the option."},{"line_number":345,"context_line":"    * Any postive integer in seconds(default is 300)."},{"line_number":346,"context_line":""},{"line_number":347,"context_line":"Related options:"},{"line_number":348,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3aaa91ec_f81dec62","line":345,"in_reply_to":"3aaa91ec_48b832e6","updated":"2016-06-29 20:47:31.000000000","message":"Done","commit_id":"17d1cf1ce72435c6f42168a37e5370ecb3e01f76"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"cfea0b87a868b8c405e95119d9898ffb300e7334","unresolved":false,"context_lines":[{"line_number":358,"context_line":""},{"line_number":359,"context_line":"Possible values:"},{"line_number":360,"context_line":""},{"line_number":361,"context_line":"    * Any positive integer in seconds."},{"line_number":362,"context_line":"    * Default value is 3."},{"line_number":363,"context_line":""},{"line_number":364,"context_line":"Related options:"},{"line_number":365,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3aaa91ec_5d93ae4f","line":362,"range":{"start_line":361,"start_character":4,"end_line":362,"end_character":25},"updated":"2016-06-28 10:43:43.000000000","message":"Maybe if range is defined on at least one end, we should add min/max flag to IntOpts? In this case min\u003d0","commit_id":"17d1cf1ce72435c6f42168a37e5370ecb3e01f76"},{"author":{"_account_id":18337,"name":"Sujitha","email":"sujitha.neti@intel.com","username":"Sujitha"},"change_message_id":"817e54cf7a2f5a6d1cb4599b1968aaa18a11cb7a","unresolved":false,"context_lines":[{"line_number":375,"context_line":""},{"line_number":376,"context_line":"If the out of sync situations are not very common, this interval can be"},{"line_number":377,"context_line":"increased to lower the number of RPC messages being sent. Likewise, if"},{"line_number":378,"context_line":"sync issues trun out to be a problem, the interval can be lowered to"},{"line_number":379,"context_line":"check more frequently."},{"line_number":380,"context_line":""},{"line_number":381,"context_line":"Possible values:"}],"source_content_type":"text/x-python","patch_set":3,"id":"3aaa91ec_2d433b6e","line":378,"updated":"2016-06-27 18:32:08.000000000","message":"s/trun/turn","commit_id":"17d1cf1ce72435c6f42168a37e5370ecb3e01f76"},{"author":{"_account_id":20217,"name":"Anusha Unnam","email":"anusha.unnam25@gmail.com","username":"aunnam"},"change_message_id":"bb0a9ab631a801d6a4f4c89b7dc9c99429d8dcfd","unresolved":false,"context_lines":[{"line_number":375,"context_line":""},{"line_number":376,"context_line":"If the out of sync situations are not very common, this interval can be"},{"line_number":377,"context_line":"increased to lower the number of RPC messages being sent. Likewise, if"},{"line_number":378,"context_line":"sync issues trun out to be a problem, the interval can be lowered to"},{"line_number":379,"context_line":"check more frequently."},{"line_number":380,"context_line":""},{"line_number":381,"context_line":"Possible values:"}],"source_content_type":"text/x-python","patch_set":3,"id":"3aaa91ec_98530817","line":378,"in_reply_to":"3aaa91ec_2d433b6e","updated":"2016-06-29 20:47:31.000000000","message":"Done","commit_id":"17d1cf1ce72435c6f42168a37e5370ecb3e01f76"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"cfea0b87a868b8c405e95119d9898ffb300e7334","unresolved":false,"context_lines":[{"line_number":380,"context_line":""},{"line_number":381,"context_line":"Possible values:"},{"line_number":382,"context_line":""},{"line_number":383,"context_line":"    * Any positive integer in seconds."},{"line_number":384,"context_line":"    * Default value is 120."},{"line_number":385,"context_line":""},{"line_number":386,"context_line":"Related options:"},{"line_number":387,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3aaa91ec_fda25a99","line":384,"range":{"start_line":383,"start_character":4,"end_line":384,"end_character":27},"updated":"2016-06-28 10:43:43.000000000","message":"Maybe if range is defined on at least one end, we should add min/max flag to IntOpts? In this case min\u003d0","commit_id":"17d1cf1ce72435c6f42168a37e5370ecb3e01f76"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"cfea0b87a868b8c405e95119d9898ffb300e7334","unresolved":false,"context_lines":[{"line_number":400,"context_line":""},{"line_number":401,"context_line":"Possible values:"},{"line_number":402,"context_line":""},{"line_number":403,"context_line":"    * 0: Will run at the default periodic interval(default)."},{"line_number":404,"context_line":"    * -1: Disables the option."},{"line_number":405,"context_line":"    * Any positive integer in seconds."},{"line_number":406,"context_line":""},{"line_number":407,"context_line":"Related options:"},{"line_number":408,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3aaa91ec_dd9f9e4e","line":405,"range":{"start_line":403,"start_character":4,"end_line":405,"end_character":38},"updated":"2016-06-28 10:43:43.000000000","message":"Maybe if range is defined on at least one end, we should add min/max flag to IntOpts? In this case min\u003d-1","commit_id":"17d1cf1ce72435c6f42168a37e5370ecb3e01f76"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"cfea0b87a868b8c405e95119d9898ffb300e7334","unresolved":false,"context_lines":[{"line_number":404,"context_line":"    * -1: Disables the option."},{"line_number":405,"context_line":"    * Any positive integer in seconds."},{"line_number":406,"context_line":""},{"line_number":407,"context_line":"Related options:"},{"line_number":408,"context_line":""},{"line_number":409,"context_line":"    * None"},{"line_number":410,"context_line":"\"\"\"),"},{"line_number":411,"context_line":"]"},{"line_number":412,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3aaa91ec_5dba8ec1","line":409,"range":{"start_line":407,"start_character":0,"end_line":409,"end_character":10},"updated":"2016-06-28 10:43:43.000000000","message":"Drop this section","commit_id":"17d1cf1ce72435c6f42168a37e5370ecb3e01f76"},{"author":{"_account_id":18337,"name":"Sujitha","email":"sujitha.neti@intel.com","username":"Sujitha"},"change_message_id":"817e54cf7a2f5a6d1cb4599b1968aaa18a11cb7a","unresolved":false,"context_lines":[{"line_number":460,"context_line":""},{"line_number":461,"context_line":"Possible values:"},{"line_number":462,"context_line":""},{"line_number":463,"context_line":"    * Any postive integer that specifies the number of attempts."},{"line_number":464,"context_line":"    * Default value is 5."},{"line_number":465,"context_line":""},{"line_number":466,"context_line":"Related options:"}],"source_content_type":"text/x-python","patch_set":3,"id":"3aaa91ec_380ed7e5","line":463,"updated":"2016-06-27 18:32:08.000000000","message":"s/postive/positive","commit_id":"17d1cf1ce72435c6f42168a37e5370ecb3e01f76"},{"author":{"_account_id":20217,"name":"Anusha Unnam","email":"anusha.unnam25@gmail.com","username":"aunnam"},"change_message_id":"bb0a9ab631a801d6a4f4c89b7dc9c99429d8dcfd","unresolved":false,"context_lines":[{"line_number":460,"context_line":""},{"line_number":461,"context_line":"Possible values:"},{"line_number":462,"context_line":""},{"line_number":463,"context_line":"    * Any postive integer that specifies the number of attempts."},{"line_number":464,"context_line":"    * Default value is 5."},{"line_number":465,"context_line":""},{"line_number":466,"context_line":"Related options:"}],"source_content_type":"text/x-python","patch_set":3,"id":"3aaa91ec_cbb81c78","line":463,"in_reply_to":"3aaa91ec_380ed7e5","updated":"2016-06-29 20:47:31.000000000","message":"Done","commit_id":"17d1cf1ce72435c6f42168a37e5370ecb3e01f76"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"cfea0b87a868b8c405e95119d9898ffb300e7334","unresolved":false,"context_lines":[{"line_number":460,"context_line":""},{"line_number":461,"context_line":"Possible values:"},{"line_number":462,"context_line":""},{"line_number":463,"context_line":"    * Any postive integer that specifies the number of attempts."},{"line_number":464,"context_line":"    * Default value is 5."},{"line_number":465,"context_line":""},{"line_number":466,"context_line":"Related options:"},{"line_number":467,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3aaa91ec_bdaf327c","line":464,"range":{"start_line":463,"start_character":4,"end_line":464,"end_character":25},"updated":"2016-06-28 10:43:43.000000000","message":"Maybe if range is defined on at least one end, we should add min/max flag to IntOpts? In this case min\u003d0","commit_id":"17d1cf1ce72435c6f42168a37e5370ecb3e01f76"},{"author":{"_account_id":18337,"name":"Sujitha","email":"sujitha.neti@intel.com","username":"Sujitha"},"change_message_id":"817e54cf7a2f5a6d1cb4599b1968aaa18a11cb7a","unresolved":false,"context_lines":[{"line_number":466,"context_line":"Related options:"},{"line_number":467,"context_line":""},{"line_number":468,"context_line":"    * ``instance_delete_interval`` in interval_opts group."},{"line_number":469,"context_line":"\"\"\"),"},{"line_number":470,"context_line":"]"},{"line_number":471,"context_line":""},{"line_number":472,"context_line":"rpcapi_opts \u003d ["}],"source_content_type":"text/x-python","patch_set":3,"id":"3aaa91ec_f8d1ef30","line":469,"updated":"2016-06-27 18:32:08.000000000","message":"nit: End of options. remove ,","commit_id":"17d1cf1ce72435c6f42168a37e5370ecb3e01f76"},{"author":{"_account_id":20217,"name":"Anusha Unnam","email":"anusha.unnam25@gmail.com","username":"aunnam"},"change_message_id":"bb0a9ab631a801d6a4f4c89b7dc9c99429d8dcfd","unresolved":false,"context_lines":[{"line_number":466,"context_line":"Related options:"},{"line_number":467,"context_line":""},{"line_number":468,"context_line":"    * ``instance_delete_interval`` in interval_opts group."},{"line_number":469,"context_line":"\"\"\"),"},{"line_number":470,"context_line":"]"},{"line_number":471,"context_line":""},{"line_number":472,"context_line":"rpcapi_opts \u003d ["}],"source_content_type":"text/x-python","patch_set":3,"id":"3aaa91ec_eb6a38ec","line":469,"in_reply_to":"3aaa91ec_f8d1ef30","updated":"2016-06-29 20:47:31.000000000","message":"Done","commit_id":"17d1cf1ce72435c6f42168a37e5370ecb3e01f76"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"890938a53e26c2883a7d784d1873b20151b0afbb","unresolved":false,"context_lines":[{"line_number":202,"context_line":""},{"line_number":203,"context_line":"The sync_power_state_interval is the interval that Nova"},{"line_number":204,"context_line":"checks the actual virtual machine power state and the power"},{"line_number":205,"context_line":"state that Nova has in its database. If the actual state"},{"line_number":206,"context_line":"does not match the state in the database, Nova issues"},{"line_number":207,"context_line":"commands to change the actual virtual machine power state. If a"},{"line_number":208,"context_line":"virtual machine is powered on, without using Nova, the"},{"line_number":209,"context_line":"sync_power_state function powers off the virtual machine."},{"line_number":210,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"3aaa91ec_d7d896f1","line":207,"range":{"start_line":205,"start_character":37,"end_line":207,"end_character":58},"updated":"2016-07-12 09:22:09.000000000","message":"Almost. Its a little complicated, but worth explaining.\n\nIf a user powers down their VM, Nova spots this, and updates the API to report the VM has been powered down.\n\nShould something turn on the VM unexpectedly, Nova will turn the VM back off, to ensure the system respects what the user has requested.","commit_id":"e676e674e95f7e633647ed0371d4f0ed532e797b"},{"author":{"_account_id":20217,"name":"Anusha Unnam","email":"anusha.unnam25@gmail.com","username":"aunnam"},"change_message_id":"9104fc5f08eed3124509105b75d9b25ece1d87e9","unresolved":false,"context_lines":[{"line_number":202,"context_line":""},{"line_number":203,"context_line":"The sync_power_state_interval is the interval that Nova"},{"line_number":204,"context_line":"checks the actual virtual machine power state and the power"},{"line_number":205,"context_line":"state that Nova has in its database. If the actual state"},{"line_number":206,"context_line":"does not match the state in the database, Nova issues"},{"line_number":207,"context_line":"commands to change the actual virtual machine power state. If a"},{"line_number":208,"context_line":"virtual machine is powered on, without using Nova, the"},{"line_number":209,"context_line":"sync_power_state function powers off the virtual machine."},{"line_number":210,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"1aa78d24_10322f10","line":207,"range":{"start_line":205,"start_character":37,"end_line":207,"end_character":58},"in_reply_to":"3aaa91ec_d7d896f1","updated":"2016-07-12 17:20:36.000000000","message":"done, this clearly explains the situation.","commit_id":"e676e674e95f7e633647ed0371d4f0ed532e797b"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"890938a53e26c2883a7d784d1873b20151b0afbb","unresolved":false,"context_lines":[{"line_number":210,"context_line":""},{"line_number":211,"context_line":"Set the sync_power_state_interval to -1 to prevent Nova"},{"line_number":212,"context_line":"from changing the power state of virtual machines that do not"},{"line_number":213,"context_line":"match the power state that Nova has in it\u0027s database."},{"line_number":214,"context_line":""},{"line_number":215,"context_line":"Possible values:"},{"line_number":216,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"3aaa91ec_772d62fd","line":213,"updated":"2016-07-12 09:22:09.000000000","message":"So it should be noted that this breaks the expected API semantics.\n\nI know VMware tells folks to set this to -1 if using external VM HA systems, but lets not include that here.","commit_id":"e676e674e95f7e633647ed0371d4f0ed532e797b"},{"author":{"_account_id":20217,"name":"Anusha Unnam","email":"anusha.unnam25@gmail.com","username":"aunnam"},"change_message_id":"9104fc5f08eed3124509105b75d9b25ece1d87e9","unresolved":false,"context_lines":[{"line_number":210,"context_line":""},{"line_number":211,"context_line":"Set the sync_power_state_interval to -1 to prevent Nova"},{"line_number":212,"context_line":"from changing the power state of virtual machines that do not"},{"line_number":213,"context_line":"match the power state that Nova has in it\u0027s database."},{"line_number":214,"context_line":""},{"line_number":215,"context_line":"Possible values:"},{"line_number":216,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"1aa78d24_90261fcc","line":213,"in_reply_to":"3aaa91ec_772d62fd","updated":"2016-07-12 17:20:36.000000000","message":"So, I shouldn\u0027t say that this option can be disabled?\nIf so then I should remove the related options section since I used- setting this option to negative. And also in the handle_virt_lifecycle_events config option help text it was mentioned about this option setting to negative. So can I remove related option section in both the cases?","commit_id":"e676e674e95f7e633647ed0371d4f0ed532e797b"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"890938a53e26c2883a7d784d1873b20151b0afbb","unresolved":false,"context_lines":[{"line_number":239,"context_line":""},{"line_number":240,"context_line":"    * Any positive integer in seconds(default is 60)."},{"line_number":241,"context_line":"    * Nova will never update it\u0027s cache if this option is set to 0,"},{"line_number":242,"context_line":"      which is why it is not recommended."},{"line_number":243,"context_line":"\"\"\"),"},{"line_number":244,"context_line":"    cfg.IntOpt(\u0027reclaim_instance_interval\u0027,"},{"line_number":245,"context_line":"               default\u003d0,"}],"source_content_type":"text/x-python","patch_set":4,"id":"1aa78d24_083dffdc","line":242,"range":{"start_line":242,"start_character":6,"end_line":242,"end_character":41},"updated":"2016-07-12 09:22:09.000000000","message":"We should probably say why thats not recommended. If we don\u0027t update it, the metadata service and nova-api endpoints will be proxying incorrect network data about the instance.","commit_id":"e676e674e95f7e633647ed0371d4f0ed532e797b"},{"author":{"_account_id":20217,"name":"Anusha Unnam","email":"anusha.unnam25@gmail.com","username":"aunnam"},"change_message_id":"9104fc5f08eed3124509105b75d9b25ece1d87e9","unresolved":false,"context_lines":[{"line_number":239,"context_line":""},{"line_number":240,"context_line":"    * Any positive integer in seconds(default is 60)."},{"line_number":241,"context_line":"    * Nova will never update it\u0027s cache if this option is set to 0,"},{"line_number":242,"context_line":"      which is why it is not recommended."},{"line_number":243,"context_line":"\"\"\"),"},{"line_number":244,"context_line":"    cfg.IntOpt(\u0027reclaim_instance_interval\u0027,"},{"line_number":245,"context_line":"               default\u003d0,"}],"source_content_type":"text/x-python","patch_set":4,"id":"1aa78d24_33593536","line":242,"range":{"start_line":242,"start_character":6,"end_line":242,"end_character":41},"in_reply_to":"1aa78d24_083dffdc","updated":"2016-07-12 17:20:36.000000000","message":"Done","commit_id":"e676e674e95f7e633647ed0371d4f0ed532e797b"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"890938a53e26c2883a7d784d1873b20151b0afbb","unresolved":false,"context_lines":[{"line_number":245,"context_line":"               default\u003d0,"},{"line_number":246,"context_line":"               min\u003d0,"},{"line_number":247,"context_line":"               help\u003d\"\"\""},{"line_number":248,"context_line":"Interval in seconds for reclaiming deleted instances. It takes effect"},{"line_number":249,"context_line":"only when value is greater than 0."},{"line_number":250,"context_line":""},{"line_number":251,"context_line":"This option decides whether the server to be deleted will still be in"},{"line_number":252,"context_line":"the system. If this value is greater than 0, the deleted server will"}],"source_content_type":"text/x-python","patch_set":4,"id":"1aa78d24_53db387c","line":249,"range":{"start_line":248,"start_character":0,"end_line":249,"end_character":34},"updated":"2016-07-12 09:22:09.000000000","message":"Maybe worth saying this enabled SOFT_DELETE of instances in this text?","commit_id":"e676e674e95f7e633647ed0371d4f0ed532e797b"},{"author":{"_account_id":20217,"name":"Anusha Unnam","email":"anusha.unnam25@gmail.com","username":"aunnam"},"change_message_id":"9104fc5f08eed3124509105b75d9b25ece1d87e9","unresolved":false,"context_lines":[{"line_number":245,"context_line":"               default\u003d0,"},{"line_number":246,"context_line":"               min\u003d0,"},{"line_number":247,"context_line":"               help\u003d\"\"\""},{"line_number":248,"context_line":"Interval in seconds for reclaiming deleted instances. It takes effect"},{"line_number":249,"context_line":"only when value is greater than 0."},{"line_number":250,"context_line":""},{"line_number":251,"context_line":"This option decides whether the server to be deleted will still be in"},{"line_number":252,"context_line":"the system. If this value is greater than 0, the deleted server will"}],"source_content_type":"text/x-python","patch_set":4,"id":"1aa78d24_134b5988","line":249,"range":{"start_line":248,"start_character":0,"end_line":249,"end_character":34},"in_reply_to":"1aa78d24_53db387c","updated":"2016-07-12 17:20:36.000000000","message":"Done","commit_id":"e676e674e95f7e633647ed0371d4f0ed532e797b"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"890938a53e26c2883a7d784d1873b20151b0afbb","unresolved":false,"context_lines":[{"line_number":249,"context_line":"only when value is greater than 0."},{"line_number":250,"context_line":""},{"line_number":251,"context_line":"This option decides whether the server to be deleted will still be in"},{"line_number":252,"context_line":"the system. If this value is greater than 0, the deleted server will"},{"line_number":253,"context_line":"not be deleted immediately, instead it will be put into a queue"},{"line_number":254,"context_line":"until it\u0027s too old (deleted time greater than the value of"},{"line_number":255,"context_line":"reclaim_instance_interval). The server can be recovered from the"}],"source_content_type":"text/x-python","patch_set":4,"id":"1aa78d24_f3ffc4fe","line":252,"range":{"start_line":252,"start_character":0,"end_line":252,"end_character":10},"updated":"2016-07-12 09:22:09.000000000","message":"maybe worth noting it will be in the SOFT_DELETED state?","commit_id":"e676e674e95f7e633647ed0371d4f0ed532e797b"},{"author":{"_account_id":20217,"name":"Anusha Unnam","email":"anusha.unnam25@gmail.com","username":"aunnam"},"change_message_id":"9104fc5f08eed3124509105b75d9b25ece1d87e9","unresolved":false,"context_lines":[{"line_number":249,"context_line":"only when value is greater than 0."},{"line_number":250,"context_line":""},{"line_number":251,"context_line":"This option decides whether the server to be deleted will still be in"},{"line_number":252,"context_line":"the system. If this value is greater than 0, the deleted server will"},{"line_number":253,"context_line":"not be deleted immediately, instead it will be put into a queue"},{"line_number":254,"context_line":"until it\u0027s too old (deleted time greater than the value of"},{"line_number":255,"context_line":"reclaim_instance_interval). The server can be recovered from the"}],"source_content_type":"text/x-python","patch_set":4,"id":"1aa78d24_d37ef1ad","line":252,"range":{"start_line":252,"start_character":0,"end_line":252,"end_character":10},"in_reply_to":"1aa78d24_f3ffc4fe","updated":"2016-07-12 17:20:36.000000000","message":"Done","commit_id":"e676e674e95f7e633647ed0371d4f0ed532e797b"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"e3f273b604e96605d5143b9e411139c7ab2f2b01","unresolved":false,"context_lines":[{"line_number":223,"context_line":"\"\"\"),"},{"line_number":224,"context_line":"    cfg.IntOpt(\u0027heal_instance_info_cache_interval\u0027,"},{"line_number":225,"context_line":"               default\u003d60,"},{"line_number":226,"context_line":"               min\u003d1,"},{"line_number":227,"context_line":"               help\u003d\"\"\""},{"line_number":228,"context_line":"Number of seconds between instance network information cache updates."},{"line_number":229,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"9ad45d7e_276e8896","line":226,"range":{"start_line":226,"start_character":15,"end_line":226,"end_character":21},"updated":"2016-08-09 16:36:55.000000000","message":"Hmm, is that correct? I think we should leave this off for now.","commit_id":"14b9afd4869d48aa3363bec42f4f77b770ddecd8"},{"author":{"_account_id":20217,"name":"Anusha Unnam","email":"anusha.unnam25@gmail.com","username":"aunnam"},"change_message_id":"bc5a0c9225e2d18676ddadbf678f4ba6f9c68260","unresolved":false,"context_lines":[{"line_number":223,"context_line":"\"\"\"),"},{"line_number":224,"context_line":"    cfg.IntOpt(\u0027heal_instance_info_cache_interval\u0027,"},{"line_number":225,"context_line":"               default\u003d60,"},{"line_number":226,"context_line":"               min\u003d1,"},{"line_number":227,"context_line":"               help\u003d\"\"\""},{"line_number":228,"context_line":"Number of seconds between instance network information cache updates."},{"line_number":229,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"9ad45d7e_4bfe1938","line":226,"range":{"start_line":226,"start_character":15,"end_line":226,"end_character":21},"in_reply_to":"9ad45d7e_276e8896","updated":"2016-08-09 19:36:00.000000000","message":"you mean don\u0027t add min at all?","commit_id":"14b9afd4869d48aa3363bec42f4f77b770ddecd8"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"e3f273b604e96605d5143b9e411139c7ab2f2b01","unresolved":false,"context_lines":[{"line_number":237,"context_line":""},{"line_number":238,"context_line":"Possible values:"},{"line_number":239,"context_line":""},{"line_number":240,"context_line":"    * Any positive integer in seconds(default is 60)."},{"line_number":241,"context_line":"\"\"\"),"},{"line_number":242,"context_line":"    cfg.IntOpt(\u0027reclaim_instance_interval\u0027,"},{"line_number":243,"context_line":"               default\u003d0,"}],"source_content_type":"text/x-python","patch_set":5,"id":"9ad45d7e_6db17a8f","line":240,"updated":"2016-08-09 16:36:55.000000000","message":"Its worth saying any value \u003c\u003d0 will disable the sync, which is not recommended, but it is possible.","commit_id":"14b9afd4869d48aa3363bec42f4f77b770ddecd8"},{"author":{"_account_id":20217,"name":"Anusha Unnam","email":"anusha.unnam25@gmail.com","username":"aunnam"},"change_message_id":"bc5a0c9225e2d18676ddadbf678f4ba6f9c68260","unresolved":false,"context_lines":[{"line_number":237,"context_line":""},{"line_number":238,"context_line":"Possible values:"},{"line_number":239,"context_line":""},{"line_number":240,"context_line":"    * Any positive integer in seconds(default is 60)."},{"line_number":241,"context_line":"\"\"\"),"},{"line_number":242,"context_line":"    cfg.IntOpt(\u0027reclaim_instance_interval\u0027,"},{"line_number":243,"context_line":"               default\u003d0,"}],"source_content_type":"text/x-python","patch_set":5,"id":"9ad45d7e_8b9651ee","line":240,"in_reply_to":"9ad45d7e_6db17a8f","updated":"2016-08-09 19:36:00.000000000","message":"Done","commit_id":"14b9afd4869d48aa3363bec42f4f77b770ddecd8"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"e3f273b604e96605d5143b9e411139c7ab2f2b01","unresolved":false,"context_lines":[{"line_number":241,"context_line":"\"\"\"),"},{"line_number":242,"context_line":"    cfg.IntOpt(\u0027reclaim_instance_interval\u0027,"},{"line_number":243,"context_line":"               default\u003d0,"},{"line_number":244,"context_line":"               min\u003d0,"},{"line_number":245,"context_line":"               help\u003d\"\"\""},{"line_number":246,"context_line":"Interval in seconds for reclaiming deleted instances. A value"},{"line_number":247,"context_line":"greater than 0 will enable SOFT_DELETE of instances."}],"source_content_type":"text/x-python","patch_set":5,"id":"9ad45d7e_a72ef8f7","line":244,"range":{"start_line":244,"start_character":15,"end_line":244,"end_character":21},"updated":"2016-08-09 16:36:55.000000000","message":"We can drop this, I feel, -ve is allowed.","commit_id":"14b9afd4869d48aa3363bec42f4f77b770ddecd8"},{"author":{"_account_id":20217,"name":"Anusha Unnam","email":"anusha.unnam25@gmail.com","username":"aunnam"},"change_message_id":"bc5a0c9225e2d18676ddadbf678f4ba6f9c68260","unresolved":false,"context_lines":[{"line_number":241,"context_line":"\"\"\"),"},{"line_number":242,"context_line":"    cfg.IntOpt(\u0027reclaim_instance_interval\u0027,"},{"line_number":243,"context_line":"               default\u003d0,"},{"line_number":244,"context_line":"               min\u003d0,"},{"line_number":245,"context_line":"               help\u003d\"\"\""},{"line_number":246,"context_line":"Interval in seconds for reclaiming deleted instances. A value"},{"line_number":247,"context_line":"greater than 0 will enable SOFT_DELETE of instances."}],"source_content_type":"text/x-python","patch_set":5,"id":"9ad45d7e_ee3b9b36","line":244,"range":{"start_line":244,"start_character":15,"end_line":244,"end_character":21},"in_reply_to":"9ad45d7e_a72ef8f7","updated":"2016-08-09 19:36:00.000000000","message":"Done","commit_id":"14b9afd4869d48aa3363bec42f4f77b770ddecd8"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"e3f273b604e96605d5143b9e411139c7ab2f2b01","unresolved":false,"context_lines":[{"line_number":259,"context_line":""},{"line_number":260,"context_line":"    * Any positive integer(in seconds) greater than 0 will enable"},{"line_number":261,"context_line":"      this option."},{"line_number":262,"context_line":"    * Default value is 0 which means the option is disabled."},{"line_number":263,"context_line":"\"\"\"),"},{"line_number":264,"context_line":"    cfg.IntOpt(\u0027volume_usage_poll_interval\u0027,"},{"line_number":265,"context_line":"               default\u003d0,"}],"source_content_type":"text/x-python","patch_set":5,"id":"9ad45d7e_76078c1c","line":262,"range":{"start_line":262,"start_character":20,"end_line":262,"end_character":24},"updated":"2016-08-09 16:36:55.000000000","message":"I think it should be \u003c\u003d0","commit_id":"14b9afd4869d48aa3363bec42f4f77b770ddecd8"},{"author":{"_account_id":20217,"name":"Anusha Unnam","email":"anusha.unnam25@gmail.com","username":"aunnam"},"change_message_id":"bc5a0c9225e2d18676ddadbf678f4ba6f9c68260","unresolved":false,"context_lines":[{"line_number":259,"context_line":""},{"line_number":260,"context_line":"    * Any positive integer(in seconds) greater than 0 will enable"},{"line_number":261,"context_line":"      this option."},{"line_number":262,"context_line":"    * Default value is 0 which means the option is disabled."},{"line_number":263,"context_line":"\"\"\"),"},{"line_number":264,"context_line":"    cfg.IntOpt(\u0027volume_usage_poll_interval\u0027,"},{"line_number":265,"context_line":"               default\u003d0,"}],"source_content_type":"text/x-python","patch_set":5,"id":"9ad45d7e_4e4bc7c9","line":262,"range":{"start_line":262,"start_character":20,"end_line":262,"end_character":24},"in_reply_to":"9ad45d7e_76078c1c","updated":"2016-08-09 19:36:00.000000000","message":"Done","commit_id":"14b9afd4869d48aa3363bec42f4f77b770ddecd8"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"e3f273b604e96605d5143b9e411139c7ab2f2b01","unresolved":false,"context_lines":[{"line_number":263,"context_line":"\"\"\"),"},{"line_number":264,"context_line":"    cfg.IntOpt(\u0027volume_usage_poll_interval\u0027,"},{"line_number":265,"context_line":"               default\u003d0,"},{"line_number":266,"context_line":"               min\u003d0,"},{"line_number":267,"context_line":"               help\u003d\"\"\""},{"line_number":268,"context_line":"Interval in seconds for gathering volume usages. This option updates"},{"line_number":269,"context_line":"the volume usage cache for every volume_usage_poll_interval number"}],"source_content_type":"text/x-python","patch_set":5,"id":"9ad45d7e_cd1b467f","line":266,"updated":"2016-08-09 16:36:55.000000000","message":"Hmm, I think -1 will also disable the poll, so the min should be -1\n\nWe should add a TODO to make this consistent with the other poll values.","commit_id":"14b9afd4869d48aa3363bec42f4f77b770ddecd8"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"e3f273b604e96605d5143b9e411139c7ab2f2b01","unresolved":false,"context_lines":[{"line_number":341,"context_line":"\"\"\"),"},{"line_number":342,"context_line":"    cfg.IntOpt(\u0027block_device_allocate_retries_interval\u0027,"},{"line_number":343,"context_line":"               default\u003d3,"},{"line_number":344,"context_line":"               min\u003d1,"},{"line_number":345,"context_line":"               help\u003d\"\"\""},{"line_number":346,"context_line":"Waiting time interval (in seconds) between block device allocation"},{"line_number":347,"context_line":"retries on failures. This option allows the user to specify the"}],"source_content_type":"text/x-python","patch_set":5,"id":"9ad45d7e_e04d7173","line":344,"updated":"2016-08-09 16:36:55.000000000","message":"0 would work when passed to sleep, so I think we should have min\u003d0 here.","commit_id":"14b9afd4869d48aa3363bec42f4f77b770ddecd8"},{"author":{"_account_id":20217,"name":"Anusha Unnam","email":"anusha.unnam25@gmail.com","username":"aunnam"},"change_message_id":"bc5a0c9225e2d18676ddadbf678f4ba6f9c68260","unresolved":false,"context_lines":[{"line_number":341,"context_line":"\"\"\"),"},{"line_number":342,"context_line":"    cfg.IntOpt(\u0027block_device_allocate_retries_interval\u0027,"},{"line_number":343,"context_line":"               default\u003d3,"},{"line_number":344,"context_line":"               min\u003d1,"},{"line_number":345,"context_line":"               help\u003d\"\"\""},{"line_number":346,"context_line":"Waiting time interval (in seconds) between block device allocation"},{"line_number":347,"context_line":"retries on failures. This option allows the user to specify the"}],"source_content_type":"text/x-python","patch_set":5,"id":"9ad45d7e_ee69db26","line":344,"in_reply_to":"9ad45d7e_e04d7173","updated":"2016-08-09 19:36:00.000000000","message":"Done","commit_id":"14b9afd4869d48aa3363bec42f4f77b770ddecd8"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"e3f273b604e96605d5143b9e411139c7ab2f2b01","unresolved":false,"context_lines":[{"line_number":374,"context_line":"Likewise, if sync issues turn out to be a problem, the interval"},{"line_number":375,"context_line":"can be lowered to check more frequently."},{"line_number":376,"context_line":""},{"line_number":377,"context_line":"Possible values:"},{"line_number":378,"context_line":""},{"line_number":379,"context_line":"    * Any positive integer in seconds."},{"line_number":380,"context_line":"    * Default value is 120."},{"line_number":381,"context_line":""},{"line_number":382,"context_line":"Related options:"},{"line_number":383,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"9ad45d7e_00a9a5df","line":380,"range":{"start_line":377,"start_character":0,"end_line":380,"end_character":27},"updated":"2016-08-09 16:36:55.000000000","message":"Apart from a different default, this should be the same allowed values as instance_delete_interval, i.e. -1 would disable this.","commit_id":"14b9afd4869d48aa3363bec42f4f77b770ddecd8"},{"author":{"_account_id":20217,"name":"Anusha Unnam","email":"anusha.unnam25@gmail.com","username":"aunnam"},"change_message_id":"bc5a0c9225e2d18676ddadbf678f4ba6f9c68260","unresolved":false,"context_lines":[{"line_number":374,"context_line":"Likewise, if sync issues turn out to be a problem, the interval"},{"line_number":375,"context_line":"can be lowered to check more frequently."},{"line_number":376,"context_line":""},{"line_number":377,"context_line":"Possible values:"},{"line_number":378,"context_line":""},{"line_number":379,"context_line":"    * Any positive integer in seconds."},{"line_number":380,"context_line":"    * Default value is 120."},{"line_number":381,"context_line":""},{"line_number":382,"context_line":"Related options:"},{"line_number":383,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"9ad45d7e_ae71a3e2","line":380,"range":{"start_line":377,"start_character":0,"end_line":380,"end_character":27},"in_reply_to":"9ad45d7e_00a9a5df","updated":"2016-08-09 19:36:00.000000000","message":"Done","commit_id":"14b9afd4869d48aa3363bec42f4f77b770ddecd8"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"e3f273b604e96605d5143b9e411139c7ab2f2b01","unresolved":false,"context_lines":[{"line_number":381,"context_line":""},{"line_number":382,"context_line":"Related options:"},{"line_number":383,"context_line":""},{"line_number":384,"context_line":"    * ``scheduler_tracks_instance_changes`` should be set to True."},{"line_number":385,"context_line":"\"\"\"),"},{"line_number":386,"context_line":"    cfg.IntOpt(\u0027update_resources_interval\u0027,"},{"line_number":387,"context_line":"               default\u003d0,"}],"source_content_type":"text/x-python","patch_set":5,"id":"9ad45d7e_e0d0d155","line":384,"range":{"start_line":384,"start_character":44,"end_line":384,"end_character":66},"updated":"2016-08-09 16:36:55.000000000","message":"You mean, this option has no impact if scheduler_tracks_instance_changes\u003dFalse? I am not sure the other text is very clear.","commit_id":"14b9afd4869d48aa3363bec42f4f77b770ddecd8"},{"author":{"_account_id":20217,"name":"Anusha Unnam","email":"anusha.unnam25@gmail.com","username":"aunnam"},"change_message_id":"bc5a0c9225e2d18676ddadbf678f4ba6f9c68260","unresolved":false,"context_lines":[{"line_number":381,"context_line":""},{"line_number":382,"context_line":"Related options:"},{"line_number":383,"context_line":""},{"line_number":384,"context_line":"    * ``scheduler_tracks_instance_changes`` should be set to True."},{"line_number":385,"context_line":"\"\"\"),"},{"line_number":386,"context_line":"    cfg.IntOpt(\u0027update_resources_interval\u0027,"},{"line_number":387,"context_line":"               default\u003d0,"}],"source_content_type":"text/x-python","patch_set":5,"id":"9ad45d7e_8e193f8b","line":384,"range":{"start_line":384,"start_character":44,"end_line":384,"end_character":66},"in_reply_to":"9ad45d7e_e0d0d155","updated":"2016-08-09 19:36:00.000000000","message":"Done","commit_id":"14b9afd4869d48aa3363bec42f4f77b770ddecd8"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"e4fe596cb2267ab491dd5ecdeef02e6f82f0273b","unresolved":false,"context_lines":[{"line_number":192,"context_line":""},{"line_number":193,"context_line":"* 0: Will run at the default periodic interval."},{"line_number":194,"context_line":"* -1: Disables the option."},{"line_number":195,"context_line":"* Any positive integer in seconds(default is 600)."},{"line_number":196,"context_line":"\"\"\"),"},{"line_number":197,"context_line":"    cfg.IntOpt(\u0027sync_power_state_interval\u0027,"},{"line_number":198,"context_line":"               default\u003d600,"}],"source_content_type":"text/x-python","patch_set":6,"id":"9ad45d7e_42db3c1b","line":195,"range":{"start_line":195,"start_character":34,"end_line":195,"end_character":49},"updated":"2016-08-11 10:52:57.000000000","message":"Remove this as it\u0027s duplication (already visible on line 184)","commit_id":"946061cc319c06697ff19ac3958cb14160a4deb2"},{"author":{"_account_id":20217,"name":"Anusha Unnam","email":"anusha.unnam25@gmail.com","username":"aunnam"},"change_message_id":"0a5b669c8d77f09da27f6af3a6e630be83faa55d","unresolved":false,"context_lines":[{"line_number":192,"context_line":""},{"line_number":193,"context_line":"* 0: Will run at the default periodic interval."},{"line_number":194,"context_line":"* -1: Disables the option."},{"line_number":195,"context_line":"* Any positive integer in seconds(default is 600)."},{"line_number":196,"context_line":"\"\"\"),"},{"line_number":197,"context_line":"    cfg.IntOpt(\u0027sync_power_state_interval\u0027,"},{"line_number":198,"context_line":"               default\u003d600,"}],"source_content_type":"text/x-python","patch_set":6,"id":"9ad45d7e_ca71df0d","line":195,"range":{"start_line":195,"start_character":34,"end_line":195,"end_character":49},"in_reply_to":"9ad45d7e_42db3c1b","updated":"2016-08-11 21:13:45.000000000","message":"Done","commit_id":"946061cc319c06697ff19ac3958cb14160a4deb2"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"e4fe596cb2267ab491dd5ecdeef02e6f82f0273b","unresolved":false,"context_lines":[{"line_number":200,"context_line":"               help\u003d\"\"\""},{"line_number":201,"context_line":"Interval to sync power states between the database and the hypervisor."},{"line_number":202,"context_line":""},{"line_number":203,"context_line":"The sync_power_state_interval is the interval that Nova"},{"line_number":204,"context_line":"checks the actual virtual machine power state and the power"},{"line_number":205,"context_line":"state that Nova has in its database. If a user powers down their VM,"},{"line_number":206,"context_line":"Nova spots this and updates the API to report the VM has been"}],"source_content_type":"text/x-python","patch_set":6,"id":"9ad45d7e_a2003867","line":203,"range":{"start_line":203,"start_character":1,"end_line":203,"end_character":36},"updated":"2016-08-11 10:52:57.000000000","message":"Just say \u0027The interval that...\u0027? :)","commit_id":"946061cc319c06697ff19ac3958cb14160a4deb2"},{"author":{"_account_id":20217,"name":"Anusha Unnam","email":"anusha.unnam25@gmail.com","username":"aunnam"},"change_message_id":"0a5b669c8d77f09da27f6af3a6e630be83faa55d","unresolved":false,"context_lines":[{"line_number":200,"context_line":"               help\u003d\"\"\""},{"line_number":201,"context_line":"Interval to sync power states between the database and the hypervisor."},{"line_number":202,"context_line":""},{"line_number":203,"context_line":"The sync_power_state_interval is the interval that Nova"},{"line_number":204,"context_line":"checks the actual virtual machine power state and the power"},{"line_number":205,"context_line":"state that Nova has in its database. If a user powers down their VM,"},{"line_number":206,"context_line":"Nova spots this and updates the API to report the VM has been"}],"source_content_type":"text/x-python","patch_set":6,"id":"9ad45d7e_2a635b43","line":203,"range":{"start_line":203,"start_character":1,"end_line":203,"end_character":36},"in_reply_to":"9ad45d7e_a2003867","updated":"2016-08-11 21:13:45.000000000","message":"Done","commit_id":"946061cc319c06697ff19ac3958cb14160a4deb2"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"e4fe596cb2267ab491dd5ecdeef02e6f82f0273b","unresolved":false,"context_lines":[{"line_number":203,"context_line":"The sync_power_state_interval is the interval that Nova"},{"line_number":204,"context_line":"checks the actual virtual machine power state and the power"},{"line_number":205,"context_line":"state that Nova has in its database. If a user powers down their VM,"},{"line_number":206,"context_line":"Nova spots this and updates the API to report the VM has been"},{"line_number":207,"context_line":"powered down. Should something turn on the VM unexpectedly,"},{"line_number":208,"context_line":"Nova will turn the VM back off, to ensure the system respects what"},{"line_number":209,"context_line":"the user has requested."}],"source_content_type":"text/x-python","patch_set":6,"id":"9ad45d7e_627f60e0","line":206,"range":{"start_line":206,"start_character":5,"end_line":206,"end_character":10},"updated":"2016-08-11 10:52:57.000000000","message":"This is too colloquial. Maybe:\n\n    When a user powers down their VM, Nova updates the API...","commit_id":"946061cc319c06697ff19ac3958cb14160a4deb2"},{"author":{"_account_id":20217,"name":"Anusha Unnam","email":"anusha.unnam25@gmail.com","username":"aunnam"},"change_message_id":"0a5b669c8d77f09da27f6af3a6e630be83faa55d","unresolved":false,"context_lines":[{"line_number":203,"context_line":"The sync_power_state_interval is the interval that Nova"},{"line_number":204,"context_line":"checks the actual virtual machine power state and the power"},{"line_number":205,"context_line":"state that Nova has in its database. If a user powers down their VM,"},{"line_number":206,"context_line":"Nova spots this and updates the API to report the VM has been"},{"line_number":207,"context_line":"powered down. Should something turn on the VM unexpectedly,"},{"line_number":208,"context_line":"Nova will turn the VM back off, to ensure the system respects what"},{"line_number":209,"context_line":"the user has requested."}],"source_content_type":"text/x-python","patch_set":6,"id":"9ad45d7e_4a5ccf7c","line":206,"range":{"start_line":206,"start_character":5,"end_line":206,"end_character":10},"in_reply_to":"9ad45d7e_627f60e0","updated":"2016-08-11 21:13:45.000000000","message":"Done","commit_id":"946061cc319c06697ff19ac3958cb14160a4deb2"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"e4fe596cb2267ab491dd5ecdeef02e6f82f0273b","unresolved":false,"context_lines":[{"line_number":205,"context_line":"state that Nova has in its database. If a user powers down their VM,"},{"line_number":206,"context_line":"Nova spots this and updates the API to report the VM has been"},{"line_number":207,"context_line":"powered down. Should something turn on the VM unexpectedly,"},{"line_number":208,"context_line":"Nova will turn the VM back off, to ensure the system respects what"},{"line_number":209,"context_line":"the user has requested."},{"line_number":210,"context_line":""},{"line_number":211,"context_line":"Possible values:"}],"source_content_type":"text/x-python","patch_set":6,"id":"9ad45d7e_e26b501c","line":208,"range":{"start_line":208,"start_character":30,"end_line":208,"end_character":31},"updated":"2016-08-11 10:52:57.000000000","message":"drop this comma","commit_id":"946061cc319c06697ff19ac3958cb14160a4deb2"},{"author":{"_account_id":20217,"name":"Anusha Unnam","email":"anusha.unnam25@gmail.com","username":"aunnam"},"change_message_id":"0a5b669c8d77f09da27f6af3a6e630be83faa55d","unresolved":false,"context_lines":[{"line_number":205,"context_line":"state that Nova has in its database. If a user powers down their VM,"},{"line_number":206,"context_line":"Nova spots this and updates the API to report the VM has been"},{"line_number":207,"context_line":"powered down. Should something turn on the VM unexpectedly,"},{"line_number":208,"context_line":"Nova will turn the VM back off, to ensure the system respects what"},{"line_number":209,"context_line":"the user has requested."},{"line_number":210,"context_line":""},{"line_number":211,"context_line":"Possible values:"}],"source_content_type":"text/x-python","patch_set":6,"id":"9ad45d7e_aa574b56","line":208,"range":{"start_line":208,"start_character":30,"end_line":208,"end_character":31},"in_reply_to":"9ad45d7e_e26b501c","updated":"2016-08-11 21:13:45.000000000","message":"Done","commit_id":"946061cc319c06697ff19ac3958cb14160a4deb2"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"e4fe596cb2267ab491dd5ecdeef02e6f82f0273b","unresolved":false,"context_lines":[{"line_number":205,"context_line":"state that Nova has in its database. If a user powers down their VM,"},{"line_number":206,"context_line":"Nova spots this and updates the API to report the VM has been"},{"line_number":207,"context_line":"powered down. Should something turn on the VM unexpectedly,"},{"line_number":208,"context_line":"Nova will turn the VM back off, to ensure the system respects what"},{"line_number":209,"context_line":"the user has requested."},{"line_number":210,"context_line":""},{"line_number":211,"context_line":"Possible values:"},{"line_number":212,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"9ad45d7e_c259ec8f","line":209,"range":{"start_line":208,"start_character":35,"end_line":209,"end_character":23},"updated":"2016-08-11 10:52:57.000000000","message":"Try:\n\n    keep the system in the expected state.\n\nThis is for Nova\u0027s good, more so than the users :)","commit_id":"946061cc319c06697ff19ac3958cb14160a4deb2"},{"author":{"_account_id":20217,"name":"Anusha Unnam","email":"anusha.unnam25@gmail.com","username":"aunnam"},"change_message_id":"0a5b669c8d77f09da27f6af3a6e630be83faa55d","unresolved":false,"context_lines":[{"line_number":205,"context_line":"state that Nova has in its database. If a user powers down their VM,"},{"line_number":206,"context_line":"Nova spots this and updates the API to report the VM has been"},{"line_number":207,"context_line":"powered down. Should something turn on the VM unexpectedly,"},{"line_number":208,"context_line":"Nova will turn the VM back off, to ensure the system respects what"},{"line_number":209,"context_line":"the user has requested."},{"line_number":210,"context_line":""},{"line_number":211,"context_line":"Possible values:"},{"line_number":212,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"9ad45d7e_ca48bfb5","line":209,"range":{"start_line":208,"start_character":35,"end_line":209,"end_character":23},"in_reply_to":"9ad45d7e_c259ec8f","updated":"2016-08-11 21:13:45.000000000","message":"Done","commit_id":"946061cc319c06697ff19ac3958cb14160a4deb2"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"e4fe596cb2267ab491dd5ecdeef02e6f82f0273b","unresolved":false,"context_lines":[{"line_number":212,"context_line":""},{"line_number":213,"context_line":"* 0: Will run at the default periodic interval."},{"line_number":214,"context_line":"* -1: Disables the option."},{"line_number":215,"context_line":"* Any positive integer in seconds(default is 600)."},{"line_number":216,"context_line":""},{"line_number":217,"context_line":"Related options:"},{"line_number":218,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"9ad45d7e_a25cb87d","line":215,"range":{"start_line":215,"start_character":33,"end_line":215,"end_character":49},"updated":"2016-08-11 10:52:57.000000000","message":"drop this","commit_id":"946061cc319c06697ff19ac3958cb14160a4deb2"},{"author":{"_account_id":20217,"name":"Anusha Unnam","email":"anusha.unnam25@gmail.com","username":"aunnam"},"change_message_id":"0a5b669c8d77f09da27f6af3a6e630be83faa55d","unresolved":false,"context_lines":[{"line_number":212,"context_line":""},{"line_number":213,"context_line":"* 0: Will run at the default periodic interval."},{"line_number":214,"context_line":"* -1: Disables the option."},{"line_number":215,"context_line":"* Any positive integer in seconds(default is 600)."},{"line_number":216,"context_line":""},{"line_number":217,"context_line":"Related options:"},{"line_number":218,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"9ad45d7e_0acdb730","line":215,"range":{"start_line":215,"start_character":33,"end_line":215,"end_character":49},"in_reply_to":"9ad45d7e_a25cb87d","updated":"2016-08-11 21:13:45.000000000","message":"Done","commit_id":"946061cc319c06697ff19ac3958cb14160a4deb2"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"e4fe596cb2267ab491dd5ecdeef02e6f82f0273b","unresolved":false,"context_lines":[{"line_number":222,"context_line":"  to be synchronized manually."},{"line_number":223,"context_line":"\"\"\"),"},{"line_number":224,"context_line":"    cfg.IntOpt(\u0027heal_instance_info_cache_interval\u0027,"},{"line_number":225,"context_line":"               default\u003d60,"},{"line_number":226,"context_line":"               help\u003d\"\"\""},{"line_number":227,"context_line":"Number of seconds between instance network information cache updates."},{"line_number":228,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"9ad45d7e_42fcdc3d","line":225,"updated":"2016-08-11 10:52:57.000000000","message":"I don\u0027t know if this is possible now, but could you add a \u0027min\u003d0\u0027 so that this is consistent with the other options in this group? This could be a follow up change (it will need a reno note I guess)","commit_id":"946061cc319c06697ff19ac3958cb14160a4deb2"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"e4fe596cb2267ab491dd5ecdeef02e6f82f0273b","unresolved":false,"context_lines":[{"line_number":236,"context_line":""},{"line_number":237,"context_line":"Possible values:"},{"line_number":238,"context_line":""},{"line_number":239,"context_line":"* Any positive integer in seconds(default is 60)."},{"line_number":240,"context_line":"* Any value \u003c\u003d0 will disable the sync, which is not recommended,"},{"line_number":241,"context_line":"  but it is possible."},{"line_number":242,"context_line":"\"\"\"),"}],"source_content_type":"text/x-python","patch_set":6,"id":"9ad45d7e_02df84d9","line":239,"range":{"start_line":239,"start_character":33,"end_line":239,"end_character":48},"updated":"2016-08-11 10:52:57.000000000","message":"Drop this.","commit_id":"946061cc319c06697ff19ac3958cb14160a4deb2"},{"author":{"_account_id":20217,"name":"Anusha Unnam","email":"anusha.unnam25@gmail.com","username":"aunnam"},"change_message_id":"0a5b669c8d77f09da27f6af3a6e630be83faa55d","unresolved":false,"context_lines":[{"line_number":236,"context_line":""},{"line_number":237,"context_line":"Possible values:"},{"line_number":238,"context_line":""},{"line_number":239,"context_line":"* Any positive integer in seconds(default is 60)."},{"line_number":240,"context_line":"* Any value \u003c\u003d0 will disable the sync, which is not recommended,"},{"line_number":241,"context_line":"  but it is possible."},{"line_number":242,"context_line":"\"\"\"),"}],"source_content_type":"text/x-python","patch_set":6,"id":"9ad45d7e_8a008735","line":239,"range":{"start_line":239,"start_character":33,"end_line":239,"end_character":48},"in_reply_to":"9ad45d7e_02df84d9","updated":"2016-08-11 21:13:45.000000000","message":"Done","commit_id":"946061cc319c06697ff19ac3958cb14160a4deb2"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"e4fe596cb2267ab491dd5ecdeef02e6f82f0273b","unresolved":false,"context_lines":[{"line_number":237,"context_line":"Possible values:"},{"line_number":238,"context_line":""},{"line_number":239,"context_line":"* Any positive integer in seconds(default is 60)."},{"line_number":240,"context_line":"* Any value \u003c\u003d0 will disable the sync, which is not recommended,"},{"line_number":241,"context_line":"  but it is possible."},{"line_number":242,"context_line":"\"\"\"),"},{"line_number":243,"context_line":"    cfg.IntOpt(\u0027reclaim_instance_interval\u0027,"},{"line_number":244,"context_line":"               default\u003d0,"}],"source_content_type":"text/x-python","patch_set":6,"id":"9ad45d7e_028dc4d5","line":241,"range":{"start_line":240,"start_character":37,"end_line":241,"end_character":21},"updated":"2016-08-11 10:52:57.000000000","message":"I know it\u0027s possible :) How about simply:\n\n    ...disable the sync. This is not recommended.","commit_id":"946061cc319c06697ff19ac3958cb14160a4deb2"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"e4fe596cb2267ab491dd5ecdeef02e6f82f0273b","unresolved":false,"context_lines":[{"line_number":237,"context_line":"Possible values:"},{"line_number":238,"context_line":""},{"line_number":239,"context_line":"* Any positive integer in seconds(default is 60)."},{"line_number":240,"context_line":"* Any value \u003c\u003d0 will disable the sync, which is not recommended,"},{"line_number":241,"context_line":"  but it is possible."},{"line_number":242,"context_line":"\"\"\"),"},{"line_number":243,"context_line":"    cfg.IntOpt(\u0027reclaim_instance_interval\u0027,"},{"line_number":244,"context_line":"               default\u003d0,"}],"source_content_type":"text/x-python","patch_set":6,"id":"9ad45d7e_42aa1c1a","line":241,"range":{"start_line":240,"start_character":39,"end_line":241,"end_character":21},"updated":"2016-08-11 10:52:57.000000000","message":"If this is truly not recommended, why don\u0027t we deprecate this as a \"bad\" option? This would be a follow up patch, of course.","commit_id":"946061cc319c06697ff19ac3958cb14160a4deb2"},{"author":{"_account_id":20217,"name":"Anusha Unnam","email":"anusha.unnam25@gmail.com","username":"aunnam"},"change_message_id":"0a5b669c8d77f09da27f6af3a6e630be83faa55d","unresolved":false,"context_lines":[{"line_number":237,"context_line":"Possible values:"},{"line_number":238,"context_line":""},{"line_number":239,"context_line":"* Any positive integer in seconds(default is 60)."},{"line_number":240,"context_line":"* Any value \u003c\u003d0 will disable the sync, which is not recommended,"},{"line_number":241,"context_line":"  but it is possible."},{"line_number":242,"context_line":"\"\"\"),"},{"line_number":243,"context_line":"    cfg.IntOpt(\u0027reclaim_instance_interval\u0027,"},{"line_number":244,"context_line":"               default\u003d0,"}],"source_content_type":"text/x-python","patch_set":6,"id":"9ad45d7e_9511c854","line":241,"range":{"start_line":240,"start_character":37,"end_line":241,"end_character":21},"in_reply_to":"9ad45d7e_028dc4d5","updated":"2016-08-11 21:13:45.000000000","message":"Done","commit_id":"946061cc319c06697ff19ac3958cb14160a4deb2"},{"author":{"_account_id":20217,"name":"Anusha Unnam","email":"anusha.unnam25@gmail.com","username":"aunnam"},"change_message_id":"0a5b669c8d77f09da27f6af3a6e630be83faa55d","unresolved":false,"context_lines":[{"line_number":237,"context_line":"Possible values:"},{"line_number":238,"context_line":""},{"line_number":239,"context_line":"* Any positive integer in seconds(default is 60)."},{"line_number":240,"context_line":"* Any value \u003c\u003d0 will disable the sync, which is not recommended,"},{"line_number":241,"context_line":"  but it is possible."},{"line_number":242,"context_line":"\"\"\"),"},{"line_number":243,"context_line":"    cfg.IntOpt(\u0027reclaim_instance_interval\u0027,"},{"line_number":244,"context_line":"               default\u003d0,"}],"source_content_type":"text/x-python","patch_set":6,"id":"9ad45d7e_5543d012","line":241,"range":{"start_line":240,"start_character":39,"end_line":241,"end_character":21},"in_reply_to":"9ad45d7e_42aa1c1a","updated":"2016-08-11 21:13:45.000000000","message":"Sorry I didn\u0027t understand what you mean here.\nIs that you mean deprecate this option?\nI meant disabling this option is not recommended, but not the option itself.","commit_id":"946061cc319c06697ff19ac3958cb14160a4deb2"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"e4fe596cb2267ab491dd5ecdeef02e6f82f0273b","unresolved":false,"context_lines":[{"line_number":241,"context_line":"  but it is possible."},{"line_number":242,"context_line":"\"\"\"),"},{"line_number":243,"context_line":"    cfg.IntOpt(\u0027reclaim_instance_interval\u0027,"},{"line_number":244,"context_line":"               default\u003d0,"},{"line_number":245,"context_line":"               help\u003d\"\"\""},{"line_number":246,"context_line":"Interval in seconds for reclaiming deleted instances. A value"},{"line_number":247,"context_line":"greater than 0 will enable SOFT_DELETE of instances."}],"source_content_type":"text/x-python","patch_set":6,"id":"9ad45d7e_824d349c","line":244,"updated":"2016-08-11 10:52:57.000000000","message":"ditto: can we add \u0027min\u003d0\u0027 in a separate change? I see you did this below.","commit_id":"946061cc319c06697ff19ac3958cb14160a4deb2"},{"author":{"_account_id":20217,"name":"Anusha Unnam","email":"anusha.unnam25@gmail.com","username":"aunnam"},"change_message_id":"0a5b669c8d77f09da27f6af3a6e630be83faa55d","unresolved":false,"context_lines":[{"line_number":241,"context_line":"  but it is possible."},{"line_number":242,"context_line":"\"\"\"),"},{"line_number":243,"context_line":"    cfg.IntOpt(\u0027reclaim_instance_interval\u0027,"},{"line_number":244,"context_line":"               default\u003d0,"},{"line_number":245,"context_line":"               help\u003d\"\"\""},{"line_number":246,"context_line":"Interval in seconds for reclaiming deleted instances. A value"},{"line_number":247,"context_line":"greater than 0 will enable SOFT_DELETE of instances."}],"source_content_type":"text/x-python","patch_set":6,"id":"9ad45d7e_55df5039","line":244,"in_reply_to":"9ad45d7e_824d349c","updated":"2016-08-11 21:13:45.000000000","message":"Can you check john comments on this line.\nI added min\u003d0 and removed that according to john\u0027s comments.","commit_id":"946061cc319c06697ff19ac3958cb14160a4deb2"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"e4fe596cb2267ab491dd5ecdeef02e6f82f0273b","unresolved":false,"context_lines":[{"line_number":261,"context_line":"      this option."},{"line_number":262,"context_line":"* Any value \u003c\u003d0 will disable the option."},{"line_number":263,"context_line":"\"\"\"),"},{"line_number":264,"context_line":"    # TODO(aunnam): To be consistent with other poll options"},{"line_number":265,"context_line":"    # this option can take value -1 to disable the poll"},{"line_number":266,"context_line":"    cfg.IntOpt(\u0027volume_usage_poll_interval\u0027,"},{"line_number":267,"context_line":"               default\u003d0,"},{"line_number":268,"context_line":"               min\u003d0,"}],"source_content_type":"text/x-python","patch_set":6,"id":"9ad45d7e_a23dd8de","line":265,"range":{"start_line":264,"start_character":0,"end_line":265,"end_character":55},"updated":"2016-08-11 10:52:57.000000000","message":"Nah - if the above two are like this then we\u0027ve got some level of consistency, IMO.","commit_id":"946061cc319c06697ff19ac3958cb14160a4deb2"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"e4fe596cb2267ab491dd5ecdeef02e6f82f0273b","unresolved":false,"context_lines":[{"line_number":293,"context_line":""},{"line_number":294,"context_line":"* 0: Will run at the default periodic interval."},{"line_number":295,"context_line":"* -1: Disables the option."},{"line_number":296,"context_line":"* Any positive integer in seconds(default is 3600)."},{"line_number":297,"context_line":""},{"line_number":298,"context_line":"Related options:"},{"line_number":299,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"9ad45d7e_c508d62a","line":296,"range":{"start_line":296,"start_character":33,"end_line":296,"end_character":50},"updated":"2016-08-11 10:52:57.000000000","message":"drop this","commit_id":"946061cc319c06697ff19ac3958cb14160a4deb2"},{"author":{"_account_id":20217,"name":"Anusha Unnam","email":"anusha.unnam25@gmail.com","username":"aunnam"},"change_message_id":"0a5b669c8d77f09da27f6af3a6e630be83faa55d","unresolved":false,"context_lines":[{"line_number":293,"context_line":""},{"line_number":294,"context_line":"* 0: Will run at the default periodic interval."},{"line_number":295,"context_line":"* -1: Disables the option."},{"line_number":296,"context_line":"* Any positive integer in seconds(default is 3600)."},{"line_number":297,"context_line":""},{"line_number":298,"context_line":"Related options:"},{"line_number":299,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"9ad45d7e_b5cdec67","line":296,"range":{"start_line":296,"start_character":33,"end_line":296,"end_character":50},"in_reply_to":"9ad45d7e_c508d62a","updated":"2016-08-11 21:13:45.000000000","message":"Why? I see that this option is not deprecated. Can you be more specific on this.","commit_id":"946061cc319c06697ff19ac3958cb14160a4deb2"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"e4fe596cb2267ab491dd5ecdeef02e6f82f0273b","unresolved":false,"context_lines":[{"line_number":277,"context_line":"  this option."},{"line_number":278,"context_line":"* Default value is 0 which means the option is disabled."},{"line_number":279,"context_line":"\"\"\"),"},{"line_number":280,"context_line":"    cfg.IntOpt(\u0027shelved_poll_interval\u0027,"},{"line_number":281,"context_line":"               default\u003d3600,"},{"line_number":282,"context_line":"               min\u003d-1,"},{"line_number":283,"context_line":"               help\u003d\"\"\""},{"line_number":284,"context_line":"Interval in seconds for polling shelved instances to offload."},{"line_number":285,"context_line":""},{"line_number":286,"context_line":"The periodic task runs for every shelved_poll_interval number"},{"line_number":287,"context_line":"of seconds and checks if there are any shelved instances. If it"},{"line_number":288,"context_line":"finds a shelved instance, based on the \u0027shelved_offload_time\u0027 config"},{"line_number":289,"context_line":"value it offloads the shelved instances. Check \u0027shelved_offload_time\u0027"},{"line_number":290,"context_line":"config option description for details."},{"line_number":291,"context_line":""},{"line_number":292,"context_line":"Possible values:"},{"line_number":293,"context_line":""},{"line_number":294,"context_line":"* 0: Will run at the default periodic interval."},{"line_number":295,"context_line":"* -1: Disables the option."},{"line_number":296,"context_line":"* Any positive integer in seconds(default is 3600)."},{"line_number":297,"context_line":""},{"line_number":298,"context_line":"Related options:"},{"line_number":299,"context_line":""},{"line_number":300,"context_line":"* ``shelved_offload_time``"},{"line_number":301,"context_line":"\"\"\"),"},{"line_number":302,"context_line":"    cfg.IntOpt(\u0027shelved_offload_time\u0027,"},{"line_number":303,"context_line":"               default\u003d0,"},{"line_number":304,"context_line":"               min\u003d-1,"}],"source_content_type":"text/x-python","patch_set":6,"id":"9ad45d7e_6505aa0f","line":301,"range":{"start_line":280,"start_character":0,"end_line":301,"end_character":5},"updated":"2016-08-11 10:52:57.000000000","message":"nit: Perhaps this whole block should be moved up to group with the other \u0027-1\u0027 \u003d disable and \u00270\u0027 \u003d use default options?","commit_id":"946061cc319c06697ff19ac3958cb14160a4deb2"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"e4fe596cb2267ab491dd5ecdeef02e6f82f0273b","unresolved":false,"context_lines":[{"line_number":304,"context_line":"               min\u003d-1,"},{"line_number":305,"context_line":"               help\u003d\"\"\""},{"line_number":306,"context_line":"Time in seconds before a shelved instance is eligible for removal"},{"line_number":307,"context_line":"from a host. By default this option is set to 0 and the shelved"},{"line_number":308,"context_line":"instance will be removed from the hypervisor immediately after shelve"},{"line_number":309,"context_line":"operation. Otherwise, the instance will be kept for the value of"},{"line_number":310,"context_line":"shelved_offload_time(in seconds) so that during the time period the"}],"source_content_type":"text/x-python","patch_set":6,"id":"9ad45d7e_054f8e37","line":307,"updated":"2016-08-11 10:52:57.000000000","message":"Insert break here?","commit_id":"946061cc319c06697ff19ac3958cb14160a4deb2"},{"author":{"_account_id":20217,"name":"Anusha Unnam","email":"anusha.unnam25@gmail.com","username":"aunnam"},"change_message_id":"0a5b669c8d77f09da27f6af3a6e630be83faa55d","unresolved":false,"context_lines":[{"line_number":304,"context_line":"               min\u003d-1,"},{"line_number":305,"context_line":"               help\u003d\"\"\""},{"line_number":306,"context_line":"Time in seconds before a shelved instance is eligible for removal"},{"line_number":307,"context_line":"from a host. By default this option is set to 0 and the shelved"},{"line_number":308,"context_line":"instance will be removed from the hypervisor immediately after shelve"},{"line_number":309,"context_line":"operation. Otherwise, the instance will be kept for the value of"},{"line_number":310,"context_line":"shelved_offload_time(in seconds) so that during the time period the"}],"source_content_type":"text/x-python","patch_set":6,"id":"9ad45d7e_55e910b6","line":307,"in_reply_to":"9ad45d7e_054f8e37","updated":"2016-08-11 21:13:45.000000000","message":"Done","commit_id":"946061cc319c06697ff19ac3958cb14160a4deb2"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"e4fe596cb2267ab491dd5ecdeef02e6f82f0273b","unresolved":false,"context_lines":[{"line_number":315,"context_line":"Possible values:"},{"line_number":316,"context_line":""},{"line_number":317,"context_line":"* 0: Instance will be immediately offloaded after being"},{"line_number":318,"context_line":"     shelved(default)."},{"line_number":319,"context_line":"* -1: An instance will never offload."},{"line_number":320,"context_line":"* Any positive integer in seconds: The instance will exist for"},{"line_number":321,"context_line":"  the specified number of seconds before being offloaded."}],"source_content_type":"text/x-python","patch_set":6,"id":"9ad45d7e_451a2618","line":318,"range":{"start_line":318,"start_character":13,"end_line":318,"end_character":21},"updated":"2016-08-11 10:52:57.000000000","message":"drop this","commit_id":"946061cc319c06697ff19ac3958cb14160a4deb2"},{"author":{"_account_id":20217,"name":"Anusha Unnam","email":"anusha.unnam25@gmail.com","username":"aunnam"},"change_message_id":"0a5b669c8d77f09da27f6af3a6e630be83faa55d","unresolved":false,"context_lines":[{"line_number":315,"context_line":"Possible values:"},{"line_number":316,"context_line":""},{"line_number":317,"context_line":"* 0: Instance will be immediately offloaded after being"},{"line_number":318,"context_line":"     shelved(default)."},{"line_number":319,"context_line":"* -1: An instance will never offload."},{"line_number":320,"context_line":"* Any positive integer in seconds: The instance will exist for"},{"line_number":321,"context_line":"  the specified number of seconds before being offloaded."}],"source_content_type":"text/x-python","patch_set":6,"id":"9ad45d7e_f5dac415","line":318,"range":{"start_line":318,"start_character":13,"end_line":318,"end_character":21},"in_reply_to":"9ad45d7e_451a2618","updated":"2016-08-11 21:13:45.000000000","message":"Done","commit_id":"946061cc319c06697ff19ac3958cb14160a4deb2"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"e4fe596cb2267ab491dd5ecdeef02e6f82f0273b","unresolved":false,"context_lines":[{"line_number":334,"context_line":""},{"line_number":335,"context_line":"* 0: Will run at the default periodic interval."},{"line_number":336,"context_line":"* -1: Disables the option."},{"line_number":337,"context_line":"* Any positive integer in seconds(default is 300)."},{"line_number":338,"context_line":""},{"line_number":339,"context_line":"Related options:"},{"line_number":340,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"9ad45d7e_a5dfa238","line":337,"range":{"start_line":337,"start_character":34,"end_line":337,"end_character":49},"updated":"2016-08-11 10:52:57.000000000","message":"drop","commit_id":"946061cc319c06697ff19ac3958cb14160a4deb2"},{"author":{"_account_id":20217,"name":"Anusha Unnam","email":"anusha.unnam25@gmail.com","username":"aunnam"},"change_message_id":"0a5b669c8d77f09da27f6af3a6e630be83faa55d","unresolved":false,"context_lines":[{"line_number":334,"context_line":""},{"line_number":335,"context_line":"* 0: Will run at the default periodic interval."},{"line_number":336,"context_line":"* -1: Disables the option."},{"line_number":337,"context_line":"* Any positive integer in seconds(default is 300)."},{"line_number":338,"context_line":""},{"line_number":339,"context_line":"Related options:"},{"line_number":340,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"9ad45d7e_d5d500e5","line":337,"range":{"start_line":337,"start_character":34,"end_line":337,"end_character":49},"in_reply_to":"9ad45d7e_a5dfa238","updated":"2016-08-11 21:13:45.000000000","message":"Done","commit_id":"946061cc319c06697ff19ac3958cb14160a4deb2"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"e4fe596cb2267ab491dd5ecdeef02e6f82f0273b","unresolved":false,"context_lines":[{"line_number":386,"context_line":"               default\u003d0,"},{"line_number":387,"context_line":"               min\u003d-1,"},{"line_number":388,"context_line":"               help\u003d\"\"\""},{"line_number":389,"context_line":"Interval in seconds for updating compute resources. This option"},{"line_number":390,"context_line":"specifies how often the update_available_resources periodic task"},{"line_number":391,"context_line":"should run."},{"line_number":392,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"9ad45d7e_a5b682f6","line":389,"updated":"2016-08-11 10:52:57.000000000","message":"Insert line break here (to make it a summary line)","commit_id":"946061cc319c06697ff19ac3958cb14160a4deb2"},{"author":{"_account_id":20217,"name":"Anusha Unnam","email":"anusha.unnam25@gmail.com","username":"aunnam"},"change_message_id":"0a5b669c8d77f09da27f6af3a6e630be83faa55d","unresolved":false,"context_lines":[{"line_number":386,"context_line":"               default\u003d0,"},{"line_number":387,"context_line":"               min\u003d-1,"},{"line_number":388,"context_line":"               help\u003d\"\"\""},{"line_number":389,"context_line":"Interval in seconds for updating compute resources. This option"},{"line_number":390,"context_line":"specifies how often the update_available_resources periodic task"},{"line_number":391,"context_line":"should run."},{"line_number":392,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"9ad45d7e_35073c83","line":389,"in_reply_to":"9ad45d7e_a5b682f6","updated":"2016-08-11 21:13:45.000000000","message":"Done","commit_id":"946061cc319c06697ff19ac3958cb14160a4deb2"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"e4fe596cb2267ab491dd5ecdeef02e6f82f0273b","unresolved":false,"context_lines":[{"line_number":449,"context_line":"               default\u003d5,"},{"line_number":450,"context_line":"               min\u003d1,"},{"line_number":451,"context_line":"               help\u003d\"\"\""},{"line_number":452,"context_line":"The number of times to attempt to reap an instance\u0027s files."},{"line_number":453,"context_line":"This option specifies the maximum number of retry attempts"},{"line_number":454,"context_line":"that can be made."},{"line_number":455,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"9ad45d7e_05d2ee27","line":452,"updated":"2016-08-11 10:52:57.000000000","message":"line break","commit_id":"946061cc319c06697ff19ac3958cb14160a4deb2"},{"author":{"_account_id":20217,"name":"Anusha Unnam","email":"anusha.unnam25@gmail.com","username":"aunnam"},"change_message_id":"0a5b669c8d77f09da27f6af3a6e630be83faa55d","unresolved":false,"context_lines":[{"line_number":449,"context_line":"               default\u003d5,"},{"line_number":450,"context_line":"               min\u003d1,"},{"line_number":451,"context_line":"               help\u003d\"\"\""},{"line_number":452,"context_line":"The number of times to attempt to reap an instance\u0027s files."},{"line_number":453,"context_line":"This option specifies the maximum number of retry attempts"},{"line_number":454,"context_line":"that can be made."},{"line_number":455,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"9ad45d7e_b5fb2c78","line":452,"in_reply_to":"9ad45d7e_05d2ee27","updated":"2016-08-11 21:13:45.000000000","message":"Done","commit_id":"946061cc319c06697ff19ac3958cb14160a4deb2"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"e4fe596cb2267ab491dd5ecdeef02e6f82f0273b","unresolved":false,"context_lines":[{"line_number":455,"context_line":""},{"line_number":456,"context_line":"Possible values:"},{"line_number":457,"context_line":""},{"line_number":458,"context_line":"    * Any positive integer that specifies the number of attempts."},{"line_number":459,"context_line":"    * Default value is 5."},{"line_number":460,"context_line":""},{"line_number":461,"context_line":"Related options:"},{"line_number":462,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"9ad45d7e_c581f6fc","line":459,"range":{"start_line":458,"start_character":0,"end_line":459,"end_character":25},"updated":"2016-08-11 10:52:57.000000000","message":"remove indentation","commit_id":"946061cc319c06697ff19ac3958cb14160a4deb2"},{"author":{"_account_id":20217,"name":"Anusha Unnam","email":"anusha.unnam25@gmail.com","username":"aunnam"},"change_message_id":"0a5b669c8d77f09da27f6af3a6e630be83faa55d","unresolved":false,"context_lines":[{"line_number":455,"context_line":""},{"line_number":456,"context_line":"Possible values:"},{"line_number":457,"context_line":""},{"line_number":458,"context_line":"    * Any positive integer that specifies the number of attempts."},{"line_number":459,"context_line":"    * Default value is 5."},{"line_number":460,"context_line":""},{"line_number":461,"context_line":"Related options:"},{"line_number":462,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"9ad45d7e_f5f12496","line":459,"range":{"start_line":458,"start_character":0,"end_line":459,"end_character":25},"in_reply_to":"9ad45d7e_c581f6fc","updated":"2016-08-11 21:13:45.000000000","message":"Done","commit_id":"946061cc319c06697ff19ac3958cb14160a4deb2"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"2a1eaf4676a82ab3174a53ef5372ef58a3b1bebe","unresolved":false,"context_lines":[{"line_number":263,"context_line":"    # this option can take value -1 to disable the poll"},{"line_number":264,"context_line":"    cfg.IntOpt(\u0027volume_usage_poll_interval\u0027,"},{"line_number":265,"context_line":"               default\u003d0,"},{"line_number":266,"context_line":"               min\u003d0,"},{"line_number":267,"context_line":"               help\u003d\"\"\""},{"line_number":268,"context_line":"Interval in seconds for gathering volume usages. This option updates"},{"line_number":269,"context_line":"the volume usage cache for every volume_usage_poll_interval number"}],"source_content_type":"text/x-python","patch_set":7,"id":"9ad45d7e_17f2c09a","line":266,"updated":"2016-08-12 18:26:16.000000000","message":"I think we should drop this one too, for now. In case it breaks people.","commit_id":"724fc7bf7a1d1223de8b27a05e192df123db0f16"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"2a1eaf4676a82ab3174a53ef5372ef58a3b1bebe","unresolved":false,"context_lines":[{"line_number":446,"context_line":"instance_cleaning_opts \u003d ["},{"line_number":447,"context_line":"    cfg.IntOpt(\u0027maximum_instance_delete_attempts\u0027,"},{"line_number":448,"context_line":"               default\u003d5,"},{"line_number":449,"context_line":"               min\u003d1,"},{"line_number":450,"context_line":"               help\u003d\"\"\""},{"line_number":451,"context_line":"The number of times to attempt to reap an instance\u0027s files."},{"line_number":452,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"9ad45d7e_f773ac13","line":449,"range":{"start_line":449,"start_character":15,"end_line":449,"end_character":21},"updated":"2016-08-12 18:26:16.000000000","message":"Lets drop this for now, it might impact users.\n\nA -ve value would actually disable this feature. You shouldn\u0027t do it that way, but thats not the point.","commit_id":"724fc7bf7a1d1223de8b27a05e192df123db0f16"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"c3c56483205b85b744a17686d00c6ae8af6d9050","unresolved":false,"context_lines":[{"line_number":236,"context_line":"Possible values:"},{"line_number":237,"context_line":""},{"line_number":238,"context_line":"* Any positive integer in seconds."},{"line_number":239,"context_line":"* Any value \u003c\u003d0 will disable the sync. This is not recommended."},{"line_number":240,"context_line":"\"\"\"),"},{"line_number":241,"context_line":"    cfg.IntOpt(\u0027reclaim_instance_interval\u0027,"},{"line_number":242,"context_line":"               default\u003d0,"}],"source_content_type":"text/x-python","patch_set":8,"id":"3ac371cc_5d3ebfda","line":239,"range":{"start_line":239,"start_character":2,"end_line":239,"end_character":63},"updated":"2016-08-17 01:02:06.000000000","message":"What is the meaning/behavior of negative value here?\nAccording to the above description, should \"min\" be 0?","commit_id":"d2c00c4db6bf50d3f52a8c3baa0a67a9564b1891"},{"author":{"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},"change_message_id":"2a0bcb1e5e1eeb2d541cdce1f255e71e3170ecf1","unresolved":false,"context_lines":[{"line_number":236,"context_line":"Possible values:"},{"line_number":237,"context_line":""},{"line_number":238,"context_line":"* Any positive integer in seconds."},{"line_number":239,"context_line":"* Any value \u003c\u003d0 will disable the sync. This is not recommended."},{"line_number":240,"context_line":"\"\"\"),"},{"line_number":241,"context_line":"    cfg.IntOpt(\u0027reclaim_instance_interval\u0027,"},{"line_number":242,"context_line":"               default\u003d0,"}],"source_content_type":"text/x-python","patch_set":8,"id":"3ac371cc_8bbd0e05","line":239,"range":{"start_line":239,"start_character":2,"end_line":239,"end_character":63},"in_reply_to":"3ac371cc_5d3ebfda","updated":"2016-08-18 19:13:29.000000000","message":"So my understanding is that 0 and negative values have different meaning here. Because we use oslo_services.periodic_task here:\n0 - oslo will start the task and first thing task check is if value is 0, just return. So I think this will be a loop doing nothing. Which is wrong behavior and we should not even allow value 0 to prevent this.\nNegative -Task will be disabled in oslo and will not even be started. So to disable I think it should be negative value and not 0.\n\nI don\u0027t think we should enforce min\u003d0, maybe min\u003d-1, but we will not gain anything from it. Oslo treat all negative numbers as same.\n\nhttp://docs.openstack.org/developer/oslo.service/api/periodic_task.html","commit_id":"d2c00c4db6bf50d3f52a8c3baa0a67a9564b1891"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"c3c56483205b85b744a17686d00c6ae8af6d9050","unresolved":false,"context_lines":[{"line_number":257,"context_line":""},{"line_number":258,"context_line":"* Any positive integer(in seconds) greater than 0 will enable"},{"line_number":259,"context_line":"  this option."},{"line_number":260,"context_line":"* Any value \u003c\u003d0 will disable the option."},{"line_number":261,"context_line":"\"\"\"),"},{"line_number":262,"context_line":"    # TODO(aunnam): To be consistent with other poll options"},{"line_number":263,"context_line":"    # this option can take value -1 to disable the poll"}],"source_content_type":"text/x-python","patch_set":8,"id":"3ac371cc_3d1ae37d","line":260,"range":{"start_line":260,"start_character":3,"end_line":260,"end_character":39},"updated":"2016-08-17 01:02:06.000000000","message":"ditto","commit_id":"d2c00c4db6bf50d3f52a8c3baa0a67a9564b1891"},{"author":{"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},"change_message_id":"2a0bcb1e5e1eeb2d541cdce1f255e71e3170ecf1","unresolved":false,"context_lines":[{"line_number":257,"context_line":""},{"line_number":258,"context_line":"* Any positive integer(in seconds) greater than 0 will enable"},{"line_number":259,"context_line":"  this option."},{"line_number":260,"context_line":"* Any value \u003c\u003d0 will disable the option."},{"line_number":261,"context_line":"\"\"\"),"},{"line_number":262,"context_line":"    # TODO(aunnam): To be consistent with other poll options"},{"line_number":263,"context_line":"    # this option can take value -1 to disable the poll"}],"source_content_type":"text/x-python","patch_set":8,"id":"3ac371cc_8b54eeca","line":260,"range":{"start_line":260,"start_character":3,"end_line":260,"end_character":39},"in_reply_to":"3ac371cc_3d1ae37d","updated":"2016-08-18 19:13:29.000000000","message":"same comment as above.","commit_id":"d2c00c4db6bf50d3f52a8c3baa0a67a9564b1891"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"c3c56483205b85b744a17686d00c6ae8af6d9050","unresolved":false,"context_lines":[{"line_number":272,"context_line":""},{"line_number":273,"context_line":"* Any positive integer(in seconds) greater than 0 will enable"},{"line_number":274,"context_line":"  this option."},{"line_number":275,"context_line":"* Default value is 0 which means the option is disabled."},{"line_number":276,"context_line":"\"\"\"),"},{"line_number":277,"context_line":"    cfg.IntOpt(\u0027shelved_poll_interval\u0027,"},{"line_number":278,"context_line":"               default\u003d3600,"}],"source_content_type":"text/x-python","patch_set":8,"id":"3ac371cc_fd04cb18","line":275,"range":{"start_line":275,"start_character":2,"end_line":275,"end_character":56},"updated":"2016-08-17 01:02:06.000000000","message":"then should \"min\" be 0?","commit_id":"d2c00c4db6bf50d3f52a8c3baa0a67a9564b1891"},{"author":{"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},"change_message_id":"2a0bcb1e5e1eeb2d541cdce1f255e71e3170ecf1","unresolved":false,"context_lines":[{"line_number":272,"context_line":""},{"line_number":273,"context_line":"* Any positive integer(in seconds) greater than 0 will enable"},{"line_number":274,"context_line":"  this option."},{"line_number":275,"context_line":"* Default value is 0 which means the option is disabled."},{"line_number":276,"context_line":"\"\"\"),"},{"line_number":277,"context_line":"    cfg.IntOpt(\u0027shelved_poll_interval\u0027,"},{"line_number":278,"context_line":"               default\u003d3600,"}],"source_content_type":"text/x-python","patch_set":8,"id":"3ac371cc_6bfff2aa","line":275,"range":{"start_line":275,"start_character":2,"end_line":275,"end_character":56},"in_reply_to":"3ac371cc_fd04cb18","updated":"2016-08-18 19:13:29.000000000","message":"No, we should allow negative numbers to properly disable this.","commit_id":"d2c00c4db6bf50d3f52a8c3baa0a67a9564b1891"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"3100ae72f166731fd02b8f955cdd05430fa32865","unresolved":false,"context_lines":[{"line_number":529,"context_line":"\"\"\"),"},{"line_number":530,"context_line":"    cfg.IntOpt(\u0027instance_delete_interval\u0027,"},{"line_number":531,"context_line":"               default\u003d300,"},{"line_number":532,"context_line":"               min\u003d-1,"},{"line_number":533,"context_line":"               help\u003d\"\"\""},{"line_number":534,"context_line":"Interval in seconds for retrying failed instance file deletes."},{"line_number":535,"context_line":"This option depends on \u0027maximum_instance_delete_attempts\u0027."}],"source_content_type":"text/x-python","patch_set":11,"id":"7a8ec9b2_c9cd8d67","line":532,"updated":"2016-09-16 17:16:58.000000000","message":"So today, anything below 0 will disable things:\nhttps://github.com/openstack/oslo.service/blob/9604fc9c4379a78c0a7ee6bc18a6bda2b9baa052/oslo_service/periodic_task.py#L108\n\nI don\u0027t think we can have \"min\u003d-1\" for these options as it a backwards incompatible thing.\n\nThis may well be the reverse of my previous comments, but I have learnt more since I made those!\n\nThis applies to every conf that is used in that periodic task decorator. There are a few others in this file with min\u003d-1 in error.","commit_id":"fe9878bc9cc68a7e8092c3f2f748ad8ef1409093"},{"author":{"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},"change_message_id":"da4fa9f34404033370cec5d5356b575323816b9a","unresolved":false,"context_lines":[{"line_number":529,"context_line":"\"\"\"),"},{"line_number":530,"context_line":"    cfg.IntOpt(\u0027instance_delete_interval\u0027,"},{"line_number":531,"context_line":"               default\u003d300,"},{"line_number":532,"context_line":"               min\u003d-1,"},{"line_number":533,"context_line":"               help\u003d\"\"\""},{"line_number":534,"context_line":"Interval in seconds for retrying failed instance file deletes."},{"line_number":535,"context_line":"This option depends on \u0027maximum_instance_delete_attempts\u0027."}],"source_content_type":"text/x-python","patch_set":11,"id":"7a8ec9b2_432a3191","line":532,"in_reply_to":"7a8ec9b2_c9cd8d67","updated":"2016-09-16 21:34:52.000000000","message":"Yes that make sense. But what can we do to warn the users that -1 or 0 will be enforced in future, if we ever going to change that. I think it should be 0.","commit_id":"fe9878bc9cc68a7e8092c3f2f748ad8ef1409093"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"aa716a3a76f38e4eb0e6b18d80f6361db3fee439","unresolved":false,"context_lines":[{"line_number":549,"context_line":"time interval between consecutive retries."},{"line_number":550,"context_line":"\u0027block_device_allocate_retries\u0027 option specifies the maximum"},{"line_number":551,"context_line":"number of retries."},{"line_number":552,"context_line":""},{"line_number":553,"context_line":"Related options:"},{"line_number":554,"context_line":""},{"line_number":555,"context_line":"* ``block_device_allocate_retries\u0027\u0027 in compute_manager_opts"}],"source_content_type":"text/x-python","patch_set":12,"id":"5a8bc5a2_883a44cc","line":552,"updated":"2016-09-22 13:55:10.000000000","message":"Missing \u0027Possible values\u0027 section?","commit_id":"94384423e10e0630fafcf2c17db93575753662e7"},{"author":{"_account_id":20217,"name":"Anusha Unnam","email":"anusha.unnam25@gmail.com","username":"aunnam"},"change_message_id":"004dba26e544d6f108d5e9225d6bbd20475bf84f","unresolved":false,"context_lines":[{"line_number":549,"context_line":"time interval between consecutive retries."},{"line_number":550,"context_line":"\u0027block_device_allocate_retries\u0027 option specifies the maximum"},{"line_number":551,"context_line":"number of retries."},{"line_number":552,"context_line":""},{"line_number":553,"context_line":"Related options:"},{"line_number":554,"context_line":""},{"line_number":555,"context_line":"* ``block_device_allocate_retries\u0027\u0027 in compute_manager_opts"}],"source_content_type":"text/x-python","patch_set":12,"id":"5a8bc5a2_c73fd623","line":552,"in_reply_to":"5a8bc5a2_244cf8c6","updated":"2016-09-22 15:31:15.000000000","message":"Actually now i remember why i removed the section.\nI can add only \"Any positive integer in the possible values section\".\nSince I added min \u003d 0 so it is obvious that it is positive integer. I have seen comments to remove such obvious things.\n\nIf it looks good i can add it back.","commit_id":"94384423e10e0630fafcf2c17db93575753662e7"},{"author":{"_account_id":20217,"name":"Anusha Unnam","email":"anusha.unnam25@gmail.com","username":"aunnam"},"change_message_id":"685e3635d5c6089a2817ea205844dfb4a2391827","unresolved":false,"context_lines":[{"line_number":549,"context_line":"time interval between consecutive retries."},{"line_number":550,"context_line":"\u0027block_device_allocate_retries\u0027 option specifies the maximum"},{"line_number":551,"context_line":"number of retries."},{"line_number":552,"context_line":""},{"line_number":553,"context_line":"Related options:"},{"line_number":554,"context_line":""},{"line_number":555,"context_line":"* ``block_device_allocate_retries\u0027\u0027 in compute_manager_opts"}],"source_content_type":"text/x-python","patch_set":12,"id":"5a8bc5a2_244cf8c6","line":552,"in_reply_to":"5a8bc5a2_883a44cc","updated":"2016-09-22 15:02:12.000000000","message":"yes good catch, i don\u0027t know when i removed this section accidentally.","commit_id":"94384423e10e0630fafcf2c17db93575753662e7"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"513dc288ed548b8c2719d17d3c35cacb1185cf72","unresolved":false,"context_lines":[{"line_number":391,"context_line":"    cfg.IntOpt(\u0027bandwidth_poll_interval\u0027,"},{"line_number":392,"context_line":"               default\u003d600,"},{"line_number":393,"context_line":"               help\u003d\"\"\""},{"line_number":394,"context_line":"Interval to pull network bandwidth usage info. Not supported on all"},{"line_number":395,"context_line":"hypervisors. If a hypervisor doesn\u0027t support bandwidth usage, it"},{"line_number":396,"context_line":"will not get the info in the usage events."},{"line_number":397,"context_line":""},{"line_number":398,"context_line":"Possible values:"},{"line_number":399,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"5a8bc5a2_25103ba8","line":396,"range":{"start_line":394,"start_character":0,"end_line":396,"end_character":42},"updated":"2016-09-23 13:27:03.000000000","message":"Can you format all of these like so:\n\n    Summary line here in the imperative.\n\n    Detailed description below.\n\nlike so:\n\n    Interval to pull network bandwidth info.\n\n    Not supported on all...","commit_id":"ee5d4d7a9d1d48026f4c32e5f6c54a634a57588f"},{"author":{"_account_id":20217,"name":"Anusha Unnam","email":"anusha.unnam25@gmail.com","username":"aunnam"},"change_message_id":"75a7e36bb5a169cdd86ee4f689d2c7c823a78d63","unresolved":false,"context_lines":[{"line_number":391,"context_line":"    cfg.IntOpt(\u0027bandwidth_poll_interval\u0027,"},{"line_number":392,"context_line":"               default\u003d600,"},{"line_number":393,"context_line":"               help\u003d\"\"\""},{"line_number":394,"context_line":"Interval to pull network bandwidth usage info. Not supported on all"},{"line_number":395,"context_line":"hypervisors. If a hypervisor doesn\u0027t support bandwidth usage, it"},{"line_number":396,"context_line":"will not get the info in the usage events."},{"line_number":397,"context_line":""},{"line_number":398,"context_line":"Possible values:"},{"line_number":399,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"5a8bc5a2_5bd7d122","line":396,"range":{"start_line":394,"start_character":0,"end_line":396,"end_character":42},"in_reply_to":"5a8bc5a2_25103ba8","updated":"2016-09-23 22:32:51.000000000","message":"Done","commit_id":"ee5d4d7a9d1d48026f4c32e5f6c54a634a57588f"},{"author":{"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},"change_message_id":"929f6c1e414c7822c82ad61370f50122ededefd6","unresolved":false,"context_lines":[{"line_number":397,"context_line":""},{"line_number":398,"context_line":"Possible values:"},{"line_number":399,"context_line":""},{"line_number":400,"context_line":"* 0: Will run at the default periodic interval."},{"line_number":401,"context_line":"* Any value \u003c 0: Disables the option."},{"line_number":402,"context_line":"* Any positive integer in seconds."},{"line_number":403,"context_line":"\"\"\"),"}],"source_content_type":"text/x-python","patch_set":13,"id":"5a8bc5a2_75a85e20","line":400,"range":{"start_line":400,"start_character":5,"end_line":400,"end_character":46},"updated":"2016-09-22 19:57:29.000000000","message":"This seems wrong https://github.com/openstack/nova/blob/master/nova/compute/manager.py#L5989. 0 or any -ve value will disable it, I think.","commit_id":"ee5d4d7a9d1d48026f4c32e5f6c54a634a57588f"},{"author":{"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},"change_message_id":"c98777045bede80dedcb2e1ed1edebd62519a041","unresolved":false,"context_lines":[{"line_number":397,"context_line":""},{"line_number":398,"context_line":"Possible values:"},{"line_number":399,"context_line":""},{"line_number":400,"context_line":"* 0: Will run at the default periodic interval."},{"line_number":401,"context_line":"* Any value \u003c 0: Disables the option."},{"line_number":402,"context_line":"* Any positive integer in seconds."},{"line_number":403,"context_line":"\"\"\"),"}],"source_content_type":"text/x-python","patch_set":13,"id":"5a8bc5a2_7cde5912","line":400,"range":{"start_line":400,"start_character":5,"end_line":400,"end_character":46},"in_reply_to":"5a8bc5a2_25b83be5","updated":"2016-09-23 14:50:20.000000000","message":"ok, that make sense. Thanks for the pointer.","commit_id":"ee5d4d7a9d1d48026f4c32e5f6c54a634a57588f"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"513dc288ed548b8c2719d17d3c35cacb1185cf72","unresolved":false,"context_lines":[{"line_number":397,"context_line":""},{"line_number":398,"context_line":"Possible values:"},{"line_number":399,"context_line":""},{"line_number":400,"context_line":"* 0: Will run at the default periodic interval."},{"line_number":401,"context_line":"* Any value \u003c 0: Disables the option."},{"line_number":402,"context_line":"* Any positive integer in seconds."},{"line_number":403,"context_line":"\"\"\"),"}],"source_content_type":"text/x-python","patch_set":13,"id":"5a8bc5a2_25b83be5","line":400,"range":{"start_line":400,"start_character":5,"end_line":400,"end_character":46},"in_reply_to":"5a8bc5a2_75a85e20","updated":"2016-09-23 13:27:03.000000000","message":"No, this is correct. See the actual code in oslo.service:\n\nhttps://github.com/openstack/oslo.service/blob/ae4f6fa/oslo_service/periodic_task.py#L122\n\nIf I were to change anything, I\u0027d add what the default periodic interval is:\n\nhttps://github.com/openstack/oslo.service/blob/ae4f6fa/oslo_service/periodic_task.py#L29","commit_id":"ee5d4d7a9d1d48026f4c32e5f6c54a634a57588f"},{"author":{"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},"change_message_id":"929f6c1e414c7822c82ad61370f50122ededefd6","unresolved":false,"context_lines":[{"line_number":398,"context_line":"Possible values:"},{"line_number":399,"context_line":""},{"line_number":400,"context_line":"* 0: Will run at the default periodic interval."},{"line_number":401,"context_line":"* Any value \u003c 0: Disables the option."},{"line_number":402,"context_line":"* Any positive integer in seconds."},{"line_number":403,"context_line":"\"\"\"),"},{"line_number":404,"context_line":"    cfg.IntOpt(\u0027sync_power_state_interval\u0027,"}],"source_content_type":"text/x-python","patch_set":13,"id":"5a8bc5a2_d544d275","line":401,"range":{"start_line":401,"start_character":2,"end_line":401,"end_character":36},"updated":"2016-09-22 19:57:29.000000000","message":"We should stop advertising -ve value so people should not use it and restrict it in future by min\u003d0.","commit_id":"ee5d4d7a9d1d48026f4c32e5f6c54a634a57588f"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"513dc288ed548b8c2719d17d3c35cacb1185cf72","unresolved":false,"context_lines":[{"line_number":398,"context_line":"Possible values:"},{"line_number":399,"context_line":""},{"line_number":400,"context_line":"* 0: Will run at the default periodic interval."},{"line_number":401,"context_line":"* Any value \u003c 0: Disables the option."},{"line_number":402,"context_line":"* Any positive integer in seconds."},{"line_number":403,"context_line":"\"\"\"),"},{"line_number":404,"context_line":"    cfg.IntOpt(\u0027sync_power_state_interval\u0027,"}],"source_content_type":"text/x-python","patch_set":13,"id":"5a8bc5a2_25af5b95","line":401,"range":{"start_line":401,"start_character":2,"end_line":401,"end_character":36},"in_reply_to":"5a8bc5a2_d544d275","updated":"2016-09-23 13:27:03.000000000","message":"We can\u0027t do this, because a negative value means we can\u0027t disable this service.","commit_id":"ee5d4d7a9d1d48026f4c32e5f6c54a634a57588f"},{"author":{"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},"change_message_id":"929f6c1e414c7822c82ad61370f50122ededefd6","unresolved":false,"context_lines":[{"line_number":416,"context_line":"Possible values:"},{"line_number":417,"context_line":""},{"line_number":418,"context_line":"* 0: Will run at the default periodic interval."},{"line_number":419,"context_line":"* ANy value \u003c 0: Disables the option."},{"line_number":420,"context_line":"* Any positive integer in seconds."},{"line_number":421,"context_line":""},{"line_number":422,"context_line":"Related options:"}],"source_content_type":"text/x-python","patch_set":13,"id":"5a8bc5a2_15263ace","line":419,"range":{"start_line":419,"start_character":2,"end_line":419,"end_character":5},"updated":"2016-09-22 19:57:29.000000000","message":"Any. Same comment as above.","commit_id":"ee5d4d7a9d1d48026f4c32e5f6c54a634a57588f"},{"author":{"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},"change_message_id":"929f6c1e414c7822c82ad61370f50122ededefd6","unresolved":false,"context_lines":[{"line_number":442,"context_line":"Possible values:"},{"line_number":443,"context_line":""},{"line_number":444,"context_line":"* Any positive integer in seconds."},{"line_number":445,"context_line":"* Any value \u003c\u003d0 will disable the sync. This is not recommended."},{"line_number":446,"context_line":"\"\"\"),"},{"line_number":447,"context_line":"    cfg.IntOpt(\u0027reclaim_instance_interval\u0027,"},{"line_number":448,"context_line":"               default\u003d0,"}],"source_content_type":"text/x-python","patch_set":13,"id":"5a8bc5a2_350a5627","line":445,"range":{"start_line":445,"start_character":2,"end_line":445,"end_character":63},"updated":"2016-09-22 19:57:29.000000000","message":"same. Why not introduce min\u003d0 here?","commit_id":"ee5d4d7a9d1d48026f4c32e5f6c54a634a57588f"},{"author":{"_account_id":20217,"name":"Anusha Unnam","email":"anusha.unnam25@gmail.com","username":"aunnam"},"change_message_id":"75a7e36bb5a169cdd86ee4f689d2c7c823a78d63","unresolved":false,"context_lines":[{"line_number":442,"context_line":"Possible values:"},{"line_number":443,"context_line":""},{"line_number":444,"context_line":"* Any positive integer in seconds."},{"line_number":445,"context_line":"* Any value \u003c\u003d0 will disable the sync. This is not recommended."},{"line_number":446,"context_line":"\"\"\"),"},{"line_number":447,"context_line":"    cfg.IntOpt(\u0027reclaim_instance_interval\u0027,"},{"line_number":448,"context_line":"               default\u003d0,"}],"source_content_type":"text/x-python","patch_set":13,"id":"5a8bc5a2_76b584ec","line":445,"range":{"start_line":445,"start_character":2,"end_line":445,"end_character":63},"in_reply_to":"5a8bc5a2_350a5627","updated":"2016-09-23 22:32:51.000000000","message":"I added and removed min \u003d0, since it is also a periodic task it can take -1 to disable this option. But in the code giving value 0 it just returns doing nothing. so 0 will also disable the option.\nhttps://github.com/openstack/nova/blob/c7bf2baa266a5f69c3b8249b50bf1f43d38a3cea/nova/compute/manager.py#L5698","commit_id":"ee5d4d7a9d1d48026f4c32e5f6c54a634a57588f"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"513dc288ed548b8c2719d17d3c35cacb1185cf72","unresolved":false,"context_lines":[{"line_number":442,"context_line":"Possible values:"},{"line_number":443,"context_line":""},{"line_number":444,"context_line":"* Any positive integer in seconds."},{"line_number":445,"context_line":"* Any value \u003c\u003d0 will disable the sync. This is not recommended."},{"line_number":446,"context_line":"\"\"\"),"},{"line_number":447,"context_line":"    cfg.IntOpt(\u0027reclaim_instance_interval\u0027,"},{"line_number":448,"context_line":"               default\u003d0,"}],"source_content_type":"text/x-python","patch_set":13,"id":"5a8bc5a2_e5e013cf","line":445,"range":{"start_line":445,"start_character":2,"end_line":445,"end_character":63},"in_reply_to":"5a8bc5a2_350a5627","updated":"2016-09-23 13:27:03.000000000","message":"This could have some merit. If this is really not recommended then maybe we shouldn\u0027t allow it.\n\nIf you do this, you\u0027d need to introduce a logging warning for this cycle before adding \u0027min\u0027 in the next cycle, however, to prevent breaking on upgrades.","commit_id":"ee5d4d7a9d1d48026f4c32e5f6c54a634a57588f"},{"author":{"_account_id":20217,"name":"Anusha Unnam","email":"anusha.unnam25@gmail.com","username":"aunnam"},"change_message_id":"75a7e36bb5a169cdd86ee4f689d2c7c823a78d63","unresolved":false,"context_lines":[{"line_number":442,"context_line":"Possible values:"},{"line_number":443,"context_line":""},{"line_number":444,"context_line":"* Any positive integer in seconds."},{"line_number":445,"context_line":"* Any value \u003c\u003d0 will disable the sync. This is not recommended."},{"line_number":446,"context_line":"\"\"\"),"},{"line_number":447,"context_line":"    cfg.IntOpt(\u0027reclaim_instance_interval\u0027,"},{"line_number":448,"context_line":"               default\u003d0,"}],"source_content_type":"text/x-python","patch_set":13,"id":"5a8bc5a2_76f4a4f1","line":445,"range":{"start_line":445,"start_character":2,"end_line":445,"end_character":63},"in_reply_to":"5a8bc5a2_dc876dd5","updated":"2016-09-23 22:32:51.000000000","message":"As warning has to be added in code, I think that has to be done in a separate patch. That is not the scope of this patch.","commit_id":"ee5d4d7a9d1d48026f4c32e5f6c54a634a57588f"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"44fa6cffc24da421d90cc4ac2d463f34aa6e2099","unresolved":false,"context_lines":[{"line_number":442,"context_line":"Possible values:"},{"line_number":443,"context_line":""},{"line_number":444,"context_line":"* Any positive integer in seconds."},{"line_number":445,"context_line":"* Any value \u003c\u003d0 will disable the sync. This is not recommended."},{"line_number":446,"context_line":"\"\"\"),"},{"line_number":447,"context_line":"    cfg.IntOpt(\u0027reclaim_instance_interval\u0027,"},{"line_number":448,"context_line":"               default\u003d0,"}],"source_content_type":"text/x-python","patch_set":13,"id":"5a8bc5a2_084d0b3e","line":445,"range":{"start_line":445,"start_character":2,"end_line":445,"end_character":63},"in_reply_to":"5a8bc5a2_dc876dd5","updated":"2016-09-23 15:51:12.000000000","message":"Warning seems a way to go - we already did some bad things by introducing min\u003d0 in other places. We have to be extra careful with it.","commit_id":"ee5d4d7a9d1d48026f4c32e5f6c54a634a57588f"},{"author":{"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},"change_message_id":"c98777045bede80dedcb2e1ed1edebd62519a041","unresolved":false,"context_lines":[{"line_number":442,"context_line":"Possible values:"},{"line_number":443,"context_line":""},{"line_number":444,"context_line":"* Any positive integer in seconds."},{"line_number":445,"context_line":"* Any value \u003c\u003d0 will disable the sync. This is not recommended."},{"line_number":446,"context_line":"\"\"\"),"},{"line_number":447,"context_line":"    cfg.IntOpt(\u0027reclaim_instance_interval\u0027,"},{"line_number":448,"context_line":"               default\u003d0,"}],"source_content_type":"text/x-python","patch_set":13,"id":"5a8bc5a2_dc876dd5","line":445,"range":{"start_line":445,"start_character":2,"end_line":445,"end_character":63},"in_reply_to":"5a8bc5a2_e5e013cf","updated":"2016-09-23 14:50:20.000000000","message":"So I think we should have that warning now, so atleast next cycle we can introduce min here.","commit_id":"ee5d4d7a9d1d48026f4c32e5f6c54a634a57588f"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"513dc288ed548b8c2719d17d3c35cacb1185cf72","unresolved":false,"context_lines":[{"line_number":447,"context_line":"    cfg.IntOpt(\u0027reclaim_instance_interval\u0027,"},{"line_number":448,"context_line":"               default\u003d0,"},{"line_number":449,"context_line":"               help\u003d\"\"\""},{"line_number":450,"context_line":"Interval in seconds for reclaiming deleted instances. A value"},{"line_number":451,"context_line":"greater than 0 will enable SOFT_DELETE of instances."},{"line_number":452,"context_line":""},{"line_number":453,"context_line":"This option decides whether the server to be deleted will still be in"}],"source_content_type":"text/x-python","patch_set":13,"id":"5a8bc5a2_65696325","line":450,"range":{"start_line":450,"start_character":53,"end_line":450,"end_character":54},"updated":"2016-09-23 13:27:03.000000000","message":"Two line breaks here","commit_id":"ee5d4d7a9d1d48026f4c32e5f6c54a634a57588f"},{"author":{"_account_id":20217,"name":"Anusha Unnam","email":"anusha.unnam25@gmail.com","username":"aunnam"},"change_message_id":"75a7e36bb5a169cdd86ee4f689d2c7c823a78d63","unresolved":false,"context_lines":[{"line_number":447,"context_line":"    cfg.IntOpt(\u0027reclaim_instance_interval\u0027,"},{"line_number":448,"context_line":"               default\u003d0,"},{"line_number":449,"context_line":"               help\u003d\"\"\""},{"line_number":450,"context_line":"Interval in seconds for reclaiming deleted instances. A value"},{"line_number":451,"context_line":"greater than 0 will enable SOFT_DELETE of instances."},{"line_number":452,"context_line":""},{"line_number":453,"context_line":"This option decides whether the server to be deleted will still be in"}],"source_content_type":"text/x-python","patch_set":13,"id":"5a8bc5a2_169c4068","line":450,"range":{"start_line":450,"start_character":53,"end_line":450,"end_character":54},"in_reply_to":"5a8bc5a2_65696325","updated":"2016-09-23 22:32:51.000000000","message":"Done","commit_id":"ee5d4d7a9d1d48026f4c32e5f6c54a634a57588f"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"3b38f10cd528a65e68517c95f84ed17f3c2fa6d2","unresolved":false,"context_lines":[{"line_number":399,"context_line":"Possible values:"},{"line_number":400,"context_line":""},{"line_number":401,"context_line":"* 0: Will run at the default periodic interval."},{"line_number":402,"context_line":"* Any value \u003c 0: Disables the option."},{"line_number":403,"context_line":"* Any positive integer in seconds."},{"line_number":404,"context_line":"\"\"\"),"},{"line_number":405,"context_line":"    cfg.IntOpt(\u0027sync_power_state_interval\u0027,"}],"source_content_type":"text/x-python","patch_set":14,"id":"5a8bc5a2_2e53533a","line":402,"range":{"start_line":402,"start_character":0,"end_line":402,"end_character":37},"updated":"2016-09-26 19:34:23.000000000","message":"Actually I am not sure if this is true. Besides UT this is the only location that uses this conf: https://github.com/openstack/nova/blob/master/nova/compute/manager.py#L6001\n\nand it does not seem that there is any special handling for negative values.","commit_id":"86d93d5643581fee735a6a345fae463efcb473ac"},{"author":{"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},"change_message_id":"1da3432cd32eba4366714e016149b9f5377fad3f","unresolved":false,"context_lines":[{"line_number":399,"context_line":"Possible values:"},{"line_number":400,"context_line":""},{"line_number":401,"context_line":"* 0: Will run at the default periodic interval."},{"line_number":402,"context_line":"* Any value \u003c 0: Disables the option."},{"line_number":403,"context_line":"* Any positive integer in seconds."},{"line_number":404,"context_line":"\"\"\"),"},{"line_number":405,"context_line":"    cfg.IntOpt(\u0027sync_power_state_interval\u0027,"}],"source_content_type":"text/x-python","patch_set":14,"id":"5a8bc5a2_f43dbe2b","line":402,"range":{"start_line":402,"start_character":0,"end_line":402,"end_character":37},"in_reply_to":"5a8bc5a2_2e53533a","updated":"2016-09-26 19:49:49.000000000","message":"@Macs: This disabling is taken care by oslo_services. See this function has a decorator https://github.com/openstack/nova/blob/master/nova/compute/manager.py#L5992. oslo will only run this function if passed value is not -ve.","commit_id":"86d93d5643581fee735a6a345fae463efcb473ac"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"a5251107ef47c0cc076843b7700667a88381be16","unresolved":false,"context_lines":[{"line_number":430,"context_line":"    cfg.IntOpt(\u0027heal_instance_info_cache_interval\u0027,"},{"line_number":431,"context_line":"               default\u003d60,"},{"line_number":432,"context_line":"               help\u003d\"\"\""},{"line_number":433,"context_line":"Number of seconds between instance network information cache updates."},{"line_number":434,"context_line":""},{"line_number":435,"context_line":"Number of seconds after which each compute node runs the task of"},{"line_number":436,"context_line":"querying Neutron for all of its instances networking information,"}],"source_content_type":"text/x-python","patch_set":14,"id":"5a8bc5a2_3f42b568","line":433,"range":{"start_line":433,"start_character":0,"end_line":433,"end_character":17},"updated":"2016-09-26 15:10:25.000000000","message":"nit: Interval","commit_id":"86d93d5643581fee735a6a345fae463efcb473ac"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"a5251107ef47c0cc076843b7700667a88381be16","unresolved":false,"context_lines":[{"line_number":448,"context_line":"    cfg.IntOpt(\u0027reclaim_instance_interval\u0027,"},{"line_number":449,"context_line":"               default\u003d0,"},{"line_number":450,"context_line":"               help\u003d\"\"\""},{"line_number":451,"context_line":"Interval in seconds for reclaiming deleted instances."},{"line_number":452,"context_line":""},{"line_number":453,"context_line":"A value greater than 0 will enable SOFT_DELETE of instances."},{"line_number":454,"context_line":"This option decides whether the server to be deleted will still be in"}],"source_content_type":"text/x-python","patch_set":14,"id":"5a8bc5a2_5f15c146","line":451,"range":{"start_line":451,"start_character":9,"end_line":451,"end_character":19},"updated":"2016-09-26 15:10:25.000000000","message":"nit: you could drop this and you don\u0027t have it in the options above, and duplicate it below.","commit_id":"86d93d5643581fee735a6a345fae463efcb473ac"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"a5251107ef47c0cc076843b7700667a88381be16","unresolved":false,"context_lines":[{"line_number":469,"context_line":"    cfg.IntOpt(\u0027volume_usage_poll_interval\u0027,"},{"line_number":470,"context_line":"               default\u003d0,"},{"line_number":471,"context_line":"               help\u003d\"\"\""},{"line_number":472,"context_line":"Interval in seconds for gathering volume usages. This option updates"},{"line_number":473,"context_line":"the volume usage cache for every volume_usage_poll_interval number"},{"line_number":474,"context_line":"of seconds."},{"line_number":475,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"5a8bc5a2_bf9165f3","line":472,"range":{"start_line":472,"start_character":48,"end_line":472,"end_character":49},"updated":"2016-09-26 15:10:25.000000000","message":"Line breaks here","commit_id":"86d93d5643581fee735a6a345fae463efcb473ac"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"a5251107ef47c0cc076843b7700667a88381be16","unresolved":false,"context_lines":[{"line_number":469,"context_line":"    cfg.IntOpt(\u0027volume_usage_poll_interval\u0027,"},{"line_number":470,"context_line":"               default\u003d0,"},{"line_number":471,"context_line":"               help\u003d\"\"\""},{"line_number":472,"context_line":"Interval in seconds for gathering volume usages. This option updates"},{"line_number":473,"context_line":"the volume usage cache for every volume_usage_poll_interval number"},{"line_number":474,"context_line":"of seconds."},{"line_number":475,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"5a8bc5a2_e22fd285","line":472,"range":{"start_line":472,"start_character":9,"end_line":472,"end_character":19},"updated":"2016-09-26 15:10:25.000000000","message":"nit: drop this","commit_id":"86d93d5643581fee735a6a345fae463efcb473ac"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"a5251107ef47c0cc076843b7700667a88381be16","unresolved":false,"context_lines":[{"line_number":482,"context_line":"    cfg.IntOpt(\u0027shelved_poll_interval\u0027,"},{"line_number":483,"context_line":"               default\u003d3600,"},{"line_number":484,"context_line":"               help\u003d\"\"\""},{"line_number":485,"context_line":"Interval in seconds for polling shelved instances to offload."},{"line_number":486,"context_line":""},{"line_number":487,"context_line":"The periodic task runs for every shelved_poll_interval number"},{"line_number":488,"context_line":"of seconds and checks if there are any shelved instances. If it"}],"source_content_type":"text/x-python","patch_set":14,"id":"5a8bc5a2_a2406a35","line":485,"range":{"start_line":485,"start_character":9,"end_line":485,"end_character":19},"updated":"2016-09-26 15:10:25.000000000","message":"drop","commit_id":"86d93d5643581fee735a6a345fae463efcb473ac"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"a5251107ef47c0cc076843b7700667a88381be16","unresolved":false,"context_lines":[{"line_number":503,"context_line":"    cfg.IntOpt(\u0027shelved_offload_time\u0027,"},{"line_number":504,"context_line":"               default\u003d0,"},{"line_number":505,"context_line":"               help\u003d\"\"\""},{"line_number":506,"context_line":"Time in seconds before a shelved instance is eligible for removal"},{"line_number":507,"context_line":"from a host."},{"line_number":508,"context_line":""},{"line_number":509,"context_line":"By default this option is set to 0 and the shelved instance will be"}],"source_content_type":"text/x-python","patch_set":14,"id":"5a8bc5a2_627102a8","line":506,"range":{"start_line":506,"start_character":5,"end_line":506,"end_character":16},"updated":"2016-09-26 15:10:25.000000000","message":"drop","commit_id":"86d93d5643581fee735a6a345fae463efcb473ac"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"a5251107ef47c0cc076843b7700667a88381be16","unresolved":false,"context_lines":[{"line_number":524,"context_line":"    cfg.IntOpt(\u0027instance_delete_interval\u0027,"},{"line_number":525,"context_line":"               default\u003d300,"},{"line_number":526,"context_line":"               help\u003d\"\"\""},{"line_number":527,"context_line":"Interval in seconds for retrying failed instance file deletes."},{"line_number":528,"context_line":""},{"line_number":529,"context_line":"This option depends on \u0027maximum_instance_delete_attempts\u0027."},{"line_number":530,"context_line":"This option specifies how often to retry deletes whereas"}],"source_content_type":"text/x-python","patch_set":14,"id":"5a8bc5a2_e2b43236","line":527,"range":{"start_line":527,"start_character":9,"end_line":527,"end_character":20},"updated":"2016-09-26 15:10:25.000000000","message":"drop","commit_id":"86d93d5643581fee735a6a345fae463efcb473ac"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"a5251107ef47c0cc076843b7700667a88381be16","unresolved":false,"context_lines":[{"line_number":546,"context_line":"               default\u003d3,"},{"line_number":547,"context_line":"               min\u003d0,"},{"line_number":548,"context_line":"               help\u003d\"\"\""},{"line_number":549,"context_line":"Waiting time interval (in seconds) between block device allocation"},{"line_number":550,"context_line":"retries on failures."},{"line_number":551,"context_line":""},{"line_number":552,"context_line":"This option allows the user to specify the time interval between"}],"source_content_type":"text/x-python","patch_set":14,"id":"5a8bc5a2_0284be5b","line":549,"range":{"start_line":549,"start_character":0,"end_line":549,"end_character":34},"updated":"2016-09-26 15:10:25.000000000","message":"Interval","commit_id":"86d93d5643581fee735a6a345fae463efcb473ac"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"a5251107ef47c0cc076843b7700667a88381be16","unresolved":false,"context_lines":[{"line_number":566,"context_line":"    cfg.IntOpt(\u0027scheduler_instance_sync_interval\u0027,"},{"line_number":567,"context_line":"               default\u003d120,"},{"line_number":568,"context_line":"               help\u003d\"\"\""},{"line_number":569,"context_line":"Waiting time interval between sending the scheduler a list of current"},{"line_number":570,"context_line":"instance UUIDs to verify that its view of instances is in sync with"},{"line_number":571,"context_line":"nova."},{"line_number":572,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"5a8bc5a2_427a4678","line":569,"range":{"start_line":569,"start_character":0,"end_line":569,"end_character":21},"updated":"2016-09-26 15:10:25.000000000","message":"Interval","commit_id":"86d93d5643581fee735a6a345fae463efcb473ac"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"a5251107ef47c0cc076843b7700667a88381be16","unresolved":false,"context_lines":[{"line_number":593,"context_line":"    cfg.IntOpt(\u0027update_resources_interval\u0027,"},{"line_number":594,"context_line":"               default\u003d0,"},{"line_number":595,"context_line":"               help\u003d\"\"\""},{"line_number":596,"context_line":"Interval in seconds for updating compute resources."},{"line_number":597,"context_line":""},{"line_number":598,"context_line":"This option specifies how often the update_available_resources"},{"line_number":599,"context_line":"periodic task should run. A number less than 0 means to disable the"}],"source_content_type":"text/x-python","patch_set":14,"id":"5a8bc5a2_02ebde13","line":596,"range":{"start_line":596,"start_character":9,"end_line":596,"end_character":19},"updated":"2016-09-26 15:10:25.000000000","message":"drop","commit_id":"86d93d5643581fee735a6a345fae463efcb473ac"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"e8a08802c09ce55deffa9da03906f2cca1d13f2f","unresolved":false,"context_lines":[{"line_number":543,"context_line":"\"\"\"),"},{"line_number":544,"context_line":"    cfg.IntOpt(\u0027block_device_allocate_retries_interval\u0027,"},{"line_number":545,"context_line":"        default\u003d3,"},{"line_number":546,"context_line":"        min\u003d0,"},{"line_number":547,"context_line":"        help\u003d\"\"\""},{"line_number":548,"context_line":"Interval (in seconds) between block device allocation retries on failures."},{"line_number":549,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"1a95cdbc_946f03fb","line":546,"updated":"2016-10-10 08:58:34.000000000","message":"This is only used by passing to sleep, so that makes sense.","commit_id":"fd01428bdf94d92a974a4ba9fc4e7a16ea86ba0d"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"c243a1a56dfd967c6c67ca35ea39772ce7028e2c","unresolved":false,"context_lines":[{"line_number":545,"context_line":"        default\u003d3,"},{"line_number":546,"context_line":"        min\u003d0,"},{"line_number":547,"context_line":"        help\u003d\"\"\""},{"line_number":548,"context_line":"Interval (in seconds) between block device allocation retries on failures."},{"line_number":549,"context_line":""},{"line_number":550,"context_line":"This option allows the user to specify the time interval between"},{"line_number":551,"context_line":"consecutive retries. \u0027block_device_allocate_retries\u0027 option specifies"}],"source_content_type":"text/x-python","patch_set":16,"id":"1a95cdbc_262277a3","line":548,"range":{"start_line":548,"start_character":9,"end_line":548,"end_character":22},"updated":"2016-10-10 13:53:32.000000000","message":"This one\u0027s still here :)","commit_id":"fd01428bdf94d92a974a4ba9fc4e7a16ea86ba0d"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"6a34a3b1e7727738cd6a2193436771693e79500c","unresolved":false,"context_lines":[{"line_number":448,"context_line":"* Any value \u003c\u003d0 will disable the sync. This is not recommended."},{"line_number":449,"context_line":"\"\"\"),"},{"line_number":450,"context_line":"    cfg.IntOpt(\u0027reclaim_instance_interval\u0027,"},{"line_number":451,"context_line":"        default\u003d0,"},{"line_number":452,"context_line":"        help\u003d\"\"\""},{"line_number":453,"context_line":"Interval for reclaiming deleted instances."},{"line_number":454,"context_line":""}],"source_content_type":"text/x-python","patch_set":18,"id":"5a74a57a_0eb6e83c","line":451,"updated":"2016-11-25 11:39:30.000000000","message":"Nit: its tempting to make this default to -1 for consistency with the options where 0 means use the default interval. But thats totally another change.","commit_id":"29a8cb07a374a78504bc0343db07f3a892927965"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"6a34a3b1e7727738cd6a2193436771693e79500c","unresolved":false,"context_lines":[{"line_number":495,"context_line":""},{"line_number":496,"context_line":"Possible values:"},{"line_number":497,"context_line":""},{"line_number":498,"context_line":"* 0: Will run at the default periodic interval."},{"line_number":499,"context_line":"* Any value \u003c 0: Disables the option."},{"line_number":500,"context_line":"* Any positive integer in seconds."},{"line_number":501,"context_line":""}],"source_content_type":"text/x-python","patch_set":18,"id":"5a74a57a_8ef758f4","line":498,"updated":"2016-11-25 11:39:30.000000000","message":"Afraid this is wrong, \u003c\u003d0 disables this option as well:\nhttps://github.com/openstack/nova/blob/852baf103708ded34a8b25f2981a36fb2a8cc3fd/nova/compute/manager.py#L6019","commit_id":"29a8cb07a374a78504bc0343db07f3a892927965"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"6a34a3b1e7727738cd6a2193436771693e79500c","unresolved":false,"context_lines":[{"line_number":763,"context_line":""},{"line_number":764,"context_line":"Possible values:"},{"line_number":765,"context_line":""},{"line_number":766,"context_line":"* Any value \u003c\u003d0 disables the option."},{"line_number":767,"context_line":"* Any positive integer in seconds enables the option."},{"line_number":768,"context_line":""},{"line_number":769,"context_line":"Related options:"}],"source_content_type":"text/x-python","patch_set":18,"id":"5a74a57a_6ede7c40","line":766,"updated":"2016-11-25 11:39:30.000000000","message":"Hmm, really you need to change instance_delete_interval if you want to disable this. We should add a TODO to add warning messages to we can make the min\u003d1 eventually.","commit_id":"29a8cb07a374a78504bc0343db07f3a892927965"}]}