)]}'
{"nova/virt/libvirt/driver.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"401446043d2d9e601e7160c8436c2c474cf4a784","unresolved":false,"context_lines":[{"line_number":2483,"context_line":"        if xml:"},{"line_number":2484,"context_line":"            try:"},{"line_number":2485,"context_line":"                domain \u003d self._conn.defineXML(xml)"},{"line_number":2486,"context_line":"            except Exception as e:"},{"line_number":2487,"context_line":"                LOG.error(_(\"An error occurred while trying to define a domain\""},{"line_number":2488,"context_line":"                            \" with xml: %s\") % xml)"},{"line_number":2489,"context_line":"                raise e"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAPn%2F%2F%2Bng%3D","line":2486,"updated":"2013-06-16 07:02:26.000000000","message":"Why do lines 2495 and 2503 have with excutils.save_and_reraise_exception() and this one does not. Can you please clarify.","commit_id":"ef0ee6c28bb5a8ec9caed6d5dfd5c7a72d8cefd1"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"bd9a390208c3a77070c92ae4734fbb171bcc1ed8","unresolved":false,"context_lines":[{"line_number":2483,"context_line":"        if xml:"},{"line_number":2484,"context_line":"            try:"},{"line_number":2485,"context_line":"                domain \u003d self._conn.defineXML(xml)"},{"line_number":2486,"context_line":"            except Exception as e:"},{"line_number":2487,"context_line":"                LOG.error(_(\"An error occurred while trying to define a domain\""},{"line_number":2488,"context_line":"                            \" with xml: %s\") % xml)"},{"line_number":2489,"context_line":"                raise e"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAPn%2F%2F%2BgI%3D","line":2486,"in_reply_to":"AAAAPn%2F%2F%2Bng%3D","updated":"2013-06-16 12:35:20.000000000","message":"In this case the only thing happening in the except block is logging the xml string. In the other blocks, the domain.XMLDesc method is being called which could raise an exception, so I want to handle that case and not lose the original exception.  Basically in those other two blocks I\u0027m making a best effort at getting the xml from the domain for the error log but I don\u0027t want to lose the original exception if getting that xml fails.","commit_id":"ef0ee6c28bb5a8ec9caed6d5dfd5c7a72d8cefd1"}]}