)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"768fa9a7d6ba211f711107d7833cdc3bae0ea710","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Improve consistency in API"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Removed sections that are no longer required [1]."},{"line_number":10,"context_line":"Added default values to the description."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"[1] https://wiki.openstack.org/wiki/ConfigOptionsConsistency"},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"dada55a8_a3094833","line":10,"updated":"2016-07-27 12:21:02.000000000","message":"really? I thought we were removing the default values from being repeated.","commit_id":"3e533eb1827ce2c7c6decb4f7712b04261357177"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"cf2e7649463d028c4d9da5b6d042aba829ee319f","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Improve consistency in API"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Removed sections that are no longer required [1]."},{"line_number":10,"context_line":"Added default values to the description."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"[1] https://wiki.openstack.org/wiki/ConfigOptionsConsistency"},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"bacf61ea_0e93efa4","line":10,"in_reply_to":"dada55a8_a3094833","updated":"2016-07-27 14:27:16.000000000","message":"Forgot to update this one. Done!","commit_id":"3e533eb1827ce2c7c6decb4f7712b04261357177"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"768fa9a7d6ba211f711107d7833cdc3bae0ea710","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Removed sections that are no longer required [1]."},{"line_number":10,"context_line":"Added default values to the description."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"[1] https://wiki.openstack.org/wiki/ConfigOptionsConsistency"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Blueprint centralize-config-options-newton"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"dada55a8_1e04eb12","line":11,"updated":"2016-07-27 12:21:02.000000000","message":"Note, if you were adding the group in this change, it should be added here. But you are not, so it should not be added.","commit_id":"3e533eb1827ce2c7c6decb4f7712b04261357177"}],"nova/conf/api.py":[{"author":{"_account_id":18337,"name":"Sujitha","email":"sujitha.neti@intel.com","username":"Sujitha"},"change_message_id":"498b0139d90b3fd8e0f40b9aff8d54222b52d2c6","unresolved":false,"context_lines":[{"line_number":131,"context_line":""},{"line_number":132,"context_line":"Possible values:"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"  Any string, including an empty string (the default)."},{"line_number":135,"context_line":"\"\"\"),"},{"line_number":136,"context_line":"    cfg.StrOpt(\"osapi_glance_link_prefix\","},{"line_number":137,"context_line":"            help\u003d\"\"\""}],"source_content_type":"text/x-python","patch_set":3,"id":"dada55a8_dc65dae1","line":134,"updated":"2016-07-18 21:48:14.000000000","message":"nit: This should be a point. Add * in the beginning for consistency.","commit_id":"8addbcf16ff65fa7706a28b69a18ff6732d5f294"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"a002b10f91a755aef16ed67b124fce02d2d05010","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2015 OpenStack Foundation"},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":11,"id":"dada55a8_fe21499f","line":1,"updated":"2016-07-26 14:39:32.000000000","message":"Note - i deleted all consistency flags in this patch. It is not well visible because initial change was commited before flags were introduced. Take  flags deletion into account when reviewing!","commit_id":"3e533eb1827ce2c7c6decb4f7712b04261357177"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"dd104b36ac1682c7b90b834cfa1f7fe9e663f6f2","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2015 OpenStack Foundation"},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":11,"id":"dada55a8_be523111","line":1,"in_reply_to":"dada55a8_fe21499f","updated":"2016-07-26 14:40:31.000000000","message":"Oh, I was comparing 1st commit, not base. My bad, it is visible :)","commit_id":"3e533eb1827ce2c7c6decb4f7712b04261357177"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"768fa9a7d6ba211f711107d7833cdc3bae0ea710","unresolved":false,"context_lines":[{"line_number":265,"context_line":""},{"line_number":266,"context_line":""},{"line_number":267,"context_line":"def list_opts():"},{"line_number":268,"context_line":"    return {api_group: ALL_OPTS}"}],"source_content_type":"text/x-python","patch_set":11,"id":"dada55a8_8339a4f4","line":268,"updated":"2016-07-27 12:21:02.000000000","message":"This is wrong.\n\nWe could add an API group, but the register_opts and the list_opts need to match.\n\nWe would also have to add the deprecated group in here.\n\nLets keep adding a group as a follow on patch, feel free to add a TODO about adding that.","commit_id":"3e533eb1827ce2c7c6decb4f7712b04261357177"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"cf2e7649463d028c4d9da5b6d042aba829ee319f","unresolved":false,"context_lines":[{"line_number":265,"context_line":""},{"line_number":266,"context_line":""},{"line_number":267,"context_line":"def list_opts():"},{"line_number":268,"context_line":"    return {api_group: ALL_OPTS}"}],"source_content_type":"text/x-python","patch_set":11,"id":"bacf61ea_6e90ab96","line":268,"in_reply_to":"dada55a8_8339a4f4","updated":"2016-07-27 14:27:16.000000000","message":"Done","commit_id":"3e533eb1827ce2c7c6decb4f7712b04261357177"},{"author":{"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},"change_message_id":"7a3d71832c1edbf49b88f4ccc4ec4736a2320697","unresolved":false,"context_lines":[{"line_number":28,"context_line":"checking. \u0027noauth2\u0027 provides administrative credentials only if \u0027admin\u0027 is"},{"line_number":29,"context_line":"specified as the username."},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"Possible values:"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"* Either \u0027keystone\u0027 (default) or \u0027noauth2\u0027."},{"line_number":34,"context_line":"\"\"\"),"},{"line_number":35,"context_line":"    cfg.BoolOpt(\"use_forwarded_for\","},{"line_number":36,"context_line":"            default\u003dFalse,"}],"source_content_type":"text/x-python","patch_set":13,"id":"bacf61ea_6e3ff925","line":33,"range":{"start_line":31,"start_character":0,"end_line":33,"end_character":43},"updated":"2016-07-27 20:44:29.000000000","message":"Drop this section as when you add choices it populate the document with this. http://docs-draft.openstack.org/76/332176/13/check/gate-nova-docs-ubuntu-xenial/19ab3a6//doc/build/html/sample_config.html","commit_id":"18b9a896703ae6cd9c38dc5e3d8a0e2e93225e1a"},{"author":{"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},"change_message_id":"7a3d71832c1edbf49b88f4ccc4ec4736a2320697","unresolved":false,"context_lines":[{"line_number":51,"context_line":"is returned for all versions that don\u0027t appear in this option. As of the"},{"line_number":52,"context_line":"Liberty release, the available versions are:"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    1.0"},{"line_number":55,"context_line":"    2007-01-19"},{"line_number":56,"context_line":"    2007-03-01"},{"line_number":57,"context_line":"    2007-08-29"},{"line_number":58,"context_line":"    2007-10-10"},{"line_number":59,"context_line":"    2007-12-15"},{"line_number":60,"context_line":"    2008-02-01"},{"line_number":61,"context_line":"    2008-09-01"},{"line_number":62,"context_line":"    2009-04-04"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"The option is in the format of a single string, with each version separated by"},{"line_number":65,"context_line":"a space."}],"source_content_type":"text/x-python","patch_set":13,"id":"bacf61ea_6e541954","line":62,"range":{"start_line":54,"start_character":4,"end_line":62,"end_character":14},"updated":"2016-07-27 20:44:29.000000000","message":"If this is a list shouldn\u0027t we pre-append each of this with \u0027*\u0027.","commit_id":"18b9a896703ae6cd9c38dc5e3d8a0e2e93225e1a"}]}
