)]}'
{"nova/conf/ironic.py":[{"author":{"_account_id":7012,"name":"Brianna Poulos","email":"Brianna.Poulos@jhuapl.edu","username":"brianna-poulos"},"change_message_id":"dc26c3519e92f825074ba48c48e2e1ef5f7f8237","unresolved":false,"context_lines":[{"line_number":53,"context_line":"        help\u003d\"\"\""},{"line_number":54,"context_line":"Ironic keystone admin name"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"* Possible values:"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"* Related options:"},{"line_number":59,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3aaa91ec_a748ea5c","line":56,"updated":"2016-06-21 21:37:16.000000000","message":"It would probably be better to not include this section at all, instead of leaving it empty (which implies that there are no possible values)","commit_id":"ea45e8eb35c10199b40b7e7793c3cf544e672528"},{"author":{"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},"change_message_id":"8daa4f2700be225d17623816d7d7a3b7d4099fc4","unresolved":false,"context_lines":[{"line_number":53,"context_line":"        help\u003d\"\"\""},{"line_number":54,"context_line":"Ironic keystone admin name"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"* Possible values:"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"* Related options:"},{"line_number":59,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3aaa91ec_b8829992","line":56,"in_reply_to":"3aaa91ec_a748ea5c","updated":"2016-06-22 15:41:13.000000000","message":"Done","commit_id":"ea45e8eb35c10199b40b7e7793c3cf544e672528"},{"author":{"_account_id":7012,"name":"Brianna Poulos","email":"Brianna.Poulos@jhuapl.edu","username":"brianna-poulos"},"change_message_id":"dc26c3519e92f825074ba48c48e2e1ef5f7f8237","unresolved":false,"context_lines":[{"line_number":133,"context_line":""},{"line_number":134,"context_line":"* Related options:"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"    None"},{"line_number":137,"context_line":"\"\"\"),"},{"line_number":138,"context_line":"    cfg.IntOpt("},{"line_number":139,"context_line":"        \"api_retry_interval\","}],"source_content_type":"text/x-python","patch_set":2,"id":"3aaa91ec_a7bbca0d","line":136,"updated":"2016-06-21 21:37:16.000000000","message":"Is this related to the api_retry_interval?  The time between requests might be increased if less retries are desired.","commit_id":"ea45e8eb35c10199b40b7e7793c3cf544e672528"},{"author":{"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},"change_message_id":"8daa4f2700be225d17623816d7d7a3b7d4099fc4","unresolved":false,"context_lines":[{"line_number":133,"context_line":""},{"line_number":134,"context_line":"* Related options:"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"    None"},{"line_number":137,"context_line":"\"\"\"),"},{"line_number":138,"context_line":"    cfg.IntOpt("},{"line_number":139,"context_line":"        \"api_retry_interval\","}],"source_content_type":"text/x-python","patch_set":2,"id":"3aaa91ec_987d1db4","line":136,"in_reply_to":"3aaa91ec_a7bbca0d","updated":"2016-06-22 15:41:13.000000000","message":"Done","commit_id":"ea45e8eb35c10199b40b7e7793c3cf544e672528"},{"author":{"_account_id":18339,"name":"Sivasathurappan Radhakrishnan","email":"siva.radhakrishnan@intel.com","username":"sivakrishnan"},"change_message_id":"693cb19efe0ed5b5de2b31b3aadcf3a94b83cd95","unresolved":false,"context_lines":[{"line_number":25,"context_line":"        deprecated_for_removal\u003dTrue,"},{"line_number":26,"context_line":"        help\u003d\"\"\""},{"line_number":27,"context_line":"Version of Ironic API service endpoint."},{"line_number":28,"context_line":"This option is deprecated and setting the API version is not possible anymore."},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"* Possible values:"},{"line_number":31,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3aaa91ec_161ac017","line":28,"updated":"2016-06-27 21:54:18.000000000","message":"Can\u0027t we add this reason in \"deprecated_reason\" to maintain the consistency. Let me know your thoughts on this ?","commit_id":"996f7bf91d2b01fe3c86a362d6613c69161a3c66"},{"author":{"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},"change_message_id":"b408e2766f209154eec73ea30e5d8cdbe45f7af9","unresolved":false,"context_lines":[{"line_number":25,"context_line":"        deprecated_for_removal\u003dTrue,"},{"line_number":26,"context_line":"        help\u003d\"\"\""},{"line_number":27,"context_line":"Version of Ironic API service endpoint."},{"line_number":28,"context_line":"This option is deprecated and setting the API version is not possible anymore."},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"* Possible values:"},{"line_number":31,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3aaa91ec_315ea612","line":28,"in_reply_to":"3aaa91ec_161ac017","updated":"2016-06-28 22:06:10.000000000","message":"Well I don\u0027t know the exact reason for deprecating this. I will try to find that and upload another patch for it.","commit_id":"996f7bf91d2b01fe3c86a362d6613c69161a3c66"},{"author":{"_account_id":18337,"name":"Sujitha","email":"sujitha.neti@intel.com","username":"Sujitha"},"change_message_id":"725a8ec28dd2c1b3e0e5467b4c971be808b50eaf","unresolved":false,"context_lines":[{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    API version to be used. 1 is default"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"* Related options:"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    None"},{"line_number":37,"context_line":"\"\"\"),"}],"source_content_type":"text/x-python","patch_set":3,"id":"3aaa91ec_0ecf0b80","line":34,"updated":"2016-06-28 21:50:13.000000000","message":"This section can be removed as per https://wiki.openstack.org/wiki/ConfigOptionsConsistency.","commit_id":"996f7bf91d2b01fe3c86a362d6613c69161a3c66"},{"author":{"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},"change_message_id":"b408e2766f209154eec73ea30e5d8cdbe45f7af9","unresolved":false,"context_lines":[{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    API version to be used. 1 is default"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"* Related options:"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    None"},{"line_number":37,"context_line":"\"\"\"),"}],"source_content_type":"text/x-python","patch_set":3,"id":"3aaa91ec_51ba5224","line":34,"in_reply_to":"3aaa91ec_0ecf0b80","updated":"2016-06-28 22:06:10.000000000","message":"Done","commit_id":"996f7bf91d2b01fe3c86a362d6613c69161a3c66"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"edf50a99fe6f26d6b5acb2e06841f85a50d8d93c","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# needs:fix_opt_description"},{"line_number":2,"context_line":"# needs:check_deprecation_status"},{"line_number":3,"context_line":"# needs:check_opt_group_and_type"},{"line_number":4,"context_line":"# needs:fix_opt_description_indentation"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"# Copyright 2015 Intel Corporation"}],"source_content_type":"text/x-python","patch_set":4,"id":"3aaa91ec_b7543154","line":4,"updated":"2016-06-29 10:53:41.000000000","message":"Nit: I think we can remove some of these when we are done","commit_id":"9d80eba25026d2354c340ec2d5a6b17e16d63903"},{"author":{"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},"change_message_id":"6e574c014908c5f953f337f72971cc9ef0ec5e79","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# needs:fix_opt_description"},{"line_number":2,"context_line":"# needs:check_deprecation_status"},{"line_number":3,"context_line":"# needs:check_opt_group_and_type"},{"line_number":4,"context_line":"# needs:fix_opt_description_indentation"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"# Copyright 2015 Intel Corporation"}],"source_content_type":"text/x-python","patch_set":4,"id":"3aaa91ec_7a53ac17","line":4,"in_reply_to":"3aaa91ec_b7543154","updated":"2016-06-29 21:21:13.000000000","message":"Done","commit_id":"9d80eba25026d2354c340ec2d5a6b17e16d63903"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"edf50a99fe6f26d6b5acb2e06841f85a50d8d93c","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"ironic_group \u003d cfg.OptGroup("},{"line_number":25,"context_line":"    \"ironic\","},{"line_number":26,"context_line":"    title\u003d\"Ironic Options\")"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"ironic_options \u003d ["},{"line_number":29,"context_line":"    cfg.IntOpt(\"api_version\","}],"source_content_type":"text/x-python","patch_set":4,"id":"3aaa91ec_974f75bd","line":26,"updated":"2016-06-29 10:53:41.000000000","message":"What about the help text?\n\nI think its worth saying that some of the options below are required to be set if you are using the ironic virt driver, like the endpoint URL.","commit_id":"9d80eba25026d2354c340ec2d5a6b17e16d63903"},{"author":{"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},"change_message_id":"6e574c014908c5f953f337f72971cc9ef0ec5e79","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"ironic_group \u003d cfg.OptGroup("},{"line_number":25,"context_line":"    \"ironic\","},{"line_number":26,"context_line":"    title\u003d\"Ironic Options\")"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"ironic_options \u003d ["},{"line_number":29,"context_line":"    cfg.IntOpt(\"api_version\","}],"source_content_type":"text/x-python","patch_set":4,"id":"3aaa91ec_da5460ff","line":26,"in_reply_to":"3aaa91ec_974f75bd","updated":"2016-06-29 21:21:13.000000000","message":"Done","commit_id":"9d80eba25026d2354c340ec2d5a6b17e16d63903"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"edf50a99fe6f26d6b5acb2e06841f85a50d8d93c","unresolved":false,"context_lines":[{"line_number":32,"context_line":"        help\u003d\"\"\""},{"line_number":33,"context_line":"Version of Ironic API service endpoint."},{"line_number":34,"context_line":"This option is deprecated and setting the API version is not possible anymore."},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"* Possible values:"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    API version to be used. 1 is default"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"* Related options:"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    None"},{"line_number":43,"context_line":"\"\"\"),"},{"line_number":44,"context_line":"    cfg.StrOpt("},{"line_number":45,"context_line":"        \"api_endpoint\","}],"source_content_type":"text/x-python","patch_set":4,"id":"3aaa91ec_374a0184","line":42,"range":{"start_line":35,"start_character":0,"end_line":42,"end_character":8},"updated":"2016-06-29 10:53:41.000000000","message":"lets drop this","commit_id":"9d80eba25026d2354c340ec2d5a6b17e16d63903"},{"author":{"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},"change_message_id":"6e574c014908c5f953f337f72971cc9ef0ec5e79","unresolved":false,"context_lines":[{"line_number":32,"context_line":"        help\u003d\"\"\""},{"line_number":33,"context_line":"Version of Ironic API service endpoint."},{"line_number":34,"context_line":"This option is deprecated and setting the API version is not possible anymore."},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"* Possible values:"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    API version to be used. 1 is default"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"* Related options:"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    None"},{"line_number":43,"context_line":"\"\"\"),"},{"line_number":44,"context_line":"    cfg.StrOpt("},{"line_number":45,"context_line":"        \"api_endpoint\","}],"source_content_type":"text/x-python","patch_set":4,"id":"3aaa91ec_ba599437","line":42,"range":{"start_line":35,"start_character":0,"end_line":42,"end_character":8},"in_reply_to":"3aaa91ec_374a0184","updated":"2016-06-29 21:21:13.000000000","message":"Done","commit_id":"9d80eba25026d2354c340ec2d5a6b17e16d63903"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"edf50a99fe6f26d6b5acb2e06841f85a50d8d93c","unresolved":false,"context_lines":[{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    None"},{"line_number":43,"context_line":"\"\"\"),"},{"line_number":44,"context_line":"    cfg.StrOpt("},{"line_number":45,"context_line":"        \"api_endpoint\","},{"line_number":46,"context_line":"        help\u003d\"\"\"\""},{"line_number":47,"context_line":"URL for the Ironic API endpoint."}],"source_content_type":"text/x-python","patch_set":4,"id":"3aaa91ec_f72fd99e","line":44,"updated":"2016-06-29 10:53:41.000000000","message":"We should probably add a TODO to get this value from the keystone service catalog.","commit_id":"9d80eba25026d2354c340ec2d5a6b17e16d63903"},{"author":{"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},"change_message_id":"6e574c014908c5f953f337f72971cc9ef0ec5e79","unresolved":false,"context_lines":[{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    None"},{"line_number":43,"context_line":"\"\"\"),"},{"line_number":44,"context_line":"    cfg.StrOpt("},{"line_number":45,"context_line":"        \"api_endpoint\","},{"line_number":46,"context_line":"        help\u003d\"\"\"\""},{"line_number":47,"context_line":"URL for the Ironic API endpoint."}],"source_content_type":"text/x-python","patch_set":4,"id":"3aaa91ec_1a438843","line":44,"in_reply_to":"3aaa91ec_f72fd99e","updated":"2016-06-29 21:21:13.000000000","message":"Done","commit_id":"9d80eba25026d2354c340ec2d5a6b17e16d63903"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"edf50a99fe6f26d6b5acb2e06841f85a50d8d93c","unresolved":false,"context_lines":[{"line_number":44,"context_line":"    cfg.StrOpt("},{"line_number":45,"context_line":"        \"api_endpoint\","},{"line_number":46,"context_line":"        help\u003d\"\"\"\""},{"line_number":47,"context_line":"URL for the Ironic API endpoint."},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"* Possible values:"},{"line_number":50,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"3aaa91ec_173425f9","line":47,"updated":"2016-06-29 10:53:41.000000000","message":"Should we not give an example of what the user might set, similar to the cinder examples that reference localhost http://127.0.0.1/...\n\nI think we can do that by using the sample_default option prop. See how that looks.","commit_id":"9d80eba25026d2354c340ec2d5a6b17e16d63903"},{"author":{"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},"change_message_id":"6e574c014908c5f953f337f72971cc9ef0ec5e79","unresolved":false,"context_lines":[{"line_number":44,"context_line":"    cfg.StrOpt("},{"line_number":45,"context_line":"        \"api_endpoint\","},{"line_number":46,"context_line":"        help\u003d\"\"\"\""},{"line_number":47,"context_line":"URL for the Ironic API endpoint."},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"* Possible values:"},{"line_number":50,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"3aaa91ec_fa3f9cb1","line":47,"in_reply_to":"3aaa91ec_173425f9","updated":"2016-06-29 21:21:13.000000000","message":"Done","commit_id":"9d80eba25026d2354c340ec2d5a6b17e16d63903"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"3edd94f229d20d22578fdbc08ba47b68f7f244e8","unresolved":false,"context_lines":[{"line_number":48,"context_line":""},{"line_number":49,"context_line":"* Possible values:"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    URL"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"* Related options:"},{"line_number":54,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"3aaa91ec_b00c3743","line":51,"updated":"2016-06-29 11:40:04.000000000","message":"This one seems to be self-explanatory enough to drop it as well.","commit_id":"9d80eba25026d2354c340ec2d5a6b17e16d63903"},{"author":{"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},"change_message_id":"6e574c014908c5f953f337f72971cc9ef0ec5e79","unresolved":false,"context_lines":[{"line_number":48,"context_line":""},{"line_number":49,"context_line":"* Possible values:"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    URL"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"* Related options:"},{"line_number":54,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"3aaa91ec_3a46444f","line":51,"in_reply_to":"3aaa91ec_b00c3743","updated":"2016-06-29 21:21:13.000000000","message":"Done","commit_id":"9d80eba25026d2354c340ec2d5a6b17e16d63903"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"edf50a99fe6f26d6b5acb2e06841f85a50d8d93c","unresolved":false,"context_lines":[{"line_number":57,"context_line":"    cfg.StrOpt("},{"line_number":58,"context_line":"        \"admin_username\","},{"line_number":59,"context_line":"        help\u003d\"\"\""},{"line_number":60,"context_line":"Ironic keystone admin name"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"* Related options:"},{"line_number":63,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"3aaa91ec_1a856c58","line":60,"updated":"2016-06-29 10:53:41.000000000","message":"For these required options, it would be nice noting that this option must be set if you choose the ironic virt driver.","commit_id":"9d80eba25026d2354c340ec2d5a6b17e16d63903"},{"author":{"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},"change_message_id":"6e574c014908c5f953f337f72971cc9ef0ec5e79","unresolved":false,"context_lines":[{"line_number":57,"context_line":"    cfg.StrOpt("},{"line_number":58,"context_line":"        \"admin_username\","},{"line_number":59,"context_line":"        help\u003d\"\"\""},{"line_number":60,"context_line":"Ironic keystone admin name"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"* Related options:"},{"line_number":63,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"3aaa91ec_5a6070cf","line":60,"in_reply_to":"3aaa91ec_1a856c58","updated":"2016-06-29 21:21:13.000000000","message":"Mentioned all required options in group help text","commit_id":"9d80eba25026d2354c340ec2d5a6b17e16d63903"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"edf50a99fe6f26d6b5acb2e06841f85a50d8d93c","unresolved":false,"context_lines":[{"line_number":59,"context_line":"        help\u003d\"\"\""},{"line_number":60,"context_line":"Ironic keystone admin name"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"* Related options:"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"    None"},{"line_number":65,"context_line":"\"\"\"),"},{"line_number":66,"context_line":"    cfg.StrOpt("},{"line_number":67,"context_line":"        \"admin_password\","}],"source_content_type":"text/x-python","patch_set":4,"id":"3aaa91ec_3a9b08cb","line":64,"range":{"start_line":62,"start_character":0,"end_line":64,"end_character":8},"updated":"2016-06-29 10:53:41.000000000","message":"lets drop all these","commit_id":"9d80eba25026d2354c340ec2d5a6b17e16d63903"},{"author":{"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},"change_message_id":"6e574c014908c5f953f337f72971cc9ef0ec5e79","unresolved":false,"context_lines":[{"line_number":59,"context_line":"        help\u003d\"\"\""},{"line_number":60,"context_line":"Ironic keystone admin name"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"* Related options:"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"    None"},{"line_number":65,"context_line":"\"\"\"),"},{"line_number":66,"context_line":"    cfg.StrOpt("},{"line_number":67,"context_line":"        \"admin_password\","}],"source_content_type":"text/x-python","patch_set":4,"id":"3aaa91ec_3a5da415","line":64,"range":{"start_line":62,"start_character":0,"end_line":64,"end_character":8},"in_reply_to":"3aaa91ec_3a9b08cb","updated":"2016-06-29 21:21:13.000000000","message":"Done","commit_id":"9d80eba25026d2354c340ec2d5a6b17e16d63903"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"edf50a99fe6f26d6b5acb2e06841f85a50d8d93c","unresolved":false,"context_lines":[{"line_number":87,"context_line":"    None"},{"line_number":88,"context_line":"\"\"\"),"},{"line_number":89,"context_line":"    cfg.StrOpt("},{"line_number":90,"context_line":"        \"admin_url\","},{"line_number":91,"context_line":"        help\u003d\"\"\""},{"line_number":92,"context_line":"Keystone public API endpoint."},{"line_number":93,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"3aaa91ec_da6764b5","line":90,"range":{"start_line":90,"start_character":9,"end_line":90,"end_character":18},"updated":"2016-06-29 10:53:41.000000000","message":"I think we should rename this to auth_url?\n\nWe should check what is going on here...\n\nI was expecting something more like cinder and neutron, like this:\nhttps://github.com/openstack/nova/blob/11f8c1bc3ce07cb5ffe52f6dbd5d4892bfa9c4e3/nova/conf/neutron.py#L163\n\nand like this:\nhttps://github.com/openstack/nova/blob/11f8c1bc3ce07cb5ffe52f6dbd5d4892bfa9c4e3/nova/volume/cinder.py#L64\n\nWe should really move towards making them all consistent. Lets add a note about that. This looks like it will need lots of changes to our in tree ironic client, but we should make a note about that.","commit_id":"9d80eba25026d2354c340ec2d5a6b17e16d63903"},{"author":{"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},"change_message_id":"6e574c014908c5f953f337f72971cc9ef0ec5e79","unresolved":false,"context_lines":[{"line_number":87,"context_line":"    None"},{"line_number":88,"context_line":"\"\"\"),"},{"line_number":89,"context_line":"    cfg.StrOpt("},{"line_number":90,"context_line":"        \"admin_url\","},{"line_number":91,"context_line":"        help\u003d\"\"\""},{"line_number":92,"context_line":"Keystone public API endpoint."},{"line_number":93,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"3aaa91ec_9a9c98c1","line":90,"range":{"start_line":90,"start_character":9,"end_line":90,"end_character":18},"in_reply_to":"3aaa91ec_da6764b5","updated":"2016-06-29 21:21:13.000000000","message":"Done","commit_id":"9d80eba25026d2354c340ec2d5a6b17e16d63903"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"edf50a99fe6f26d6b5acb2e06841f85a50d8d93c","unresolved":false,"context_lines":[{"line_number":98,"context_line":"    cfg.StrOpt("},{"line_number":99,"context_line":"        \"cafile\","},{"line_number":100,"context_line":"        help\u003d\"\"\""},{"line_number":101,"context_line":"PEM encoded Certificate Authority to use when verifying HTTPs"},{"line_number":102,"context_line":"connections."},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"* Related options:"},{"line_number":105,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"3aaa91ec_5acd34b6","line":102,"range":{"start_line":101,"start_character":0,"end_line":102,"end_character":12},"updated":"2016-06-29 10:53:41.000000000","message":"I am confused, is this the CA to trust when talking to ironic. If so we should probably talk more about it in that direction.\n\nIf this is not specified, what happens? Do we use the default python keychain settings? Or is this actually required to be set?","commit_id":"9d80eba25026d2354c340ec2d5a6b17e16d63903"},{"author":{"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},"change_message_id":"6e574c014908c5f953f337f72971cc9ef0ec5e79","unresolved":false,"context_lines":[{"line_number":98,"context_line":"    cfg.StrOpt("},{"line_number":99,"context_line":"        \"cafile\","},{"line_number":100,"context_line":"        help\u003d\"\"\""},{"line_number":101,"context_line":"PEM encoded Certificate Authority to use when verifying HTTPs"},{"line_number":102,"context_line":"connections."},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"* Related options:"},{"line_number":105,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"3aaa91ec_9a83f855","line":102,"range":{"start_line":101,"start_character":0,"end_line":102,"end_character":12},"in_reply_to":"3aaa91ec_5acd34b6","updated":"2016-06-29 21:21:13.000000000","message":"By default this is not set, not sure if the connection is insecure. I will check with jroll and update another patch.","commit_id":"9d80eba25026d2354c340ec2d5a6b17e16d63903"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"edf50a99fe6f26d6b5acb2e06841f85a50d8d93c","unresolved":false,"context_lines":[{"line_number":108,"context_line":"    cfg.StrOpt("},{"line_number":109,"context_line":"        \"admin_tenant_name\","},{"line_number":110,"context_line":"        help\u003d\"\"\""},{"line_number":111,"context_line":"Ironic keystone tenant name."},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"* Related options:"},{"line_number":114,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"3aaa91ec_9a4f9cbd","line":111,"updated":"2016-06-29 10:53:41.000000000","message":"We should note this is required.","commit_id":"9d80eba25026d2354c340ec2d5a6b17e16d63903"},{"author":{"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},"change_message_id":"6e574c014908c5f953f337f72971cc9ef0ec5e79","unresolved":false,"context_lines":[{"line_number":108,"context_line":"    cfg.StrOpt("},{"line_number":109,"context_line":"        \"admin_tenant_name\","},{"line_number":110,"context_line":"        help\u003d\"\"\""},{"line_number":111,"context_line":"Ironic keystone tenant name."},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"* Related options:"},{"line_number":114,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"3aaa91ec_ba7eb467","line":111,"in_reply_to":"3aaa91ec_9a4f9cbd","updated":"2016-06-29 21:21:13.000000000","message":"Mentioned in group help","commit_id":"9d80eba25026d2354c340ec2d5a6b17e16d63903"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"edf50a99fe6f26d6b5acb2e06841f85a50d8d93c","unresolved":false,"context_lines":[{"line_number":137,"context_line":""},{"line_number":138,"context_line":"* Possible values:"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"    Any positive integer, default is 2"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"* Related options:"},{"line_number":143,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"3aaa91ec_5aa2544c","line":140,"range":{"start_line":140,"start_character":4,"end_line":140,"end_character":24},"updated":"2016-06-29 10:53:41.000000000","message":"can we just put min_value\u003d0 in the opt definition please?","commit_id":"9d80eba25026d2354c340ec2d5a6b17e16d63903"},{"author":{"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},"change_message_id":"6e574c014908c5f953f337f72971cc9ef0ec5e79","unresolved":false,"context_lines":[{"line_number":137,"context_line":""},{"line_number":138,"context_line":"* Possible values:"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"    Any positive integer, default is 2"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"* Related options:"},{"line_number":143,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"3aaa91ec_5a8eb079","line":140,"range":{"start_line":140,"start_character":4,"end_line":140,"end_character":24},"in_reply_to":"3aaa91ec_5aa2544c","updated":"2016-06-29 21:21:13.000000000","message":"Done","commit_id":"9d80eba25026d2354c340ec2d5a6b17e16d63903"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"39976cd47cd4796a15dfdd1a311353248ef52152","unresolved":false,"context_lines":[{"line_number":21,"context_line":"    help\u003d\"\"\""},{"line_number":22,"context_line":"Configuration options for Ironic driver (Bare Metal)."},{"line_number":23,"context_line":"If using the Ironic driver following options must be set:"},{"line_number":24,"context_line":"    admin_url"},{"line_number":25,"context_line":"    admin_tenant_name"},{"line_number":26,"context_line":"    admin_username"},{"line_number":27,"context_line":"    admin_password"}],"source_content_type":"text/x-python","patch_set":8,"id":"1aa78d24_5a9e6d07","line":24,"updated":"2016-07-07 12:52:34.000000000","message":"Nit: I would rather this were a comma separated list, given how this will currently get rendered in the docs. But its OK.","commit_id":"cbbcda6f49b531f5efb1397e304442032c0e6a3a"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"39976cd47cd4796a15dfdd1a311353248ef52152","unresolved":false,"context_lines":[{"line_number":46,"context_line":"    cfg.StrOpt("},{"line_number":47,"context_line":"        \u0027admin_username\u0027,"},{"line_number":48,"context_line":"        help\u003d\"\"\""},{"line_number":49,"context_line":"Ironic keystone admin name"},{"line_number":50,"context_line":"\"\"\"),"},{"line_number":51,"context_line":"    cfg.StrOpt("},{"line_number":52,"context_line":"        \u0027admin_password\u0027,"}],"source_content_type":"text/x-python","patch_set":8,"id":"1aa78d24_daa9bd25","line":49,"range":{"start_line":49,"start_character":22,"end_line":49,"end_character":26},"updated":"2016-07-07 12:52:34.000000000","message":"Nit: its a username","commit_id":"cbbcda6f49b531f5efb1397e304442032c0e6a3a"},{"author":{"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},"change_message_id":"98edbbcbc9cda2f001f5ad4407dfb99e9e5104cd","unresolved":false,"context_lines":[{"line_number":46,"context_line":"    cfg.StrOpt("},{"line_number":47,"context_line":"        \u0027admin_username\u0027,"},{"line_number":48,"context_line":"        help\u003d\"\"\""},{"line_number":49,"context_line":"Ironic keystone admin name"},{"line_number":50,"context_line":"\"\"\"),"},{"line_number":51,"context_line":"    cfg.StrOpt("},{"line_number":52,"context_line":"        \u0027admin_password\u0027,"}],"source_content_type":"text/x-python","patch_set":8,"id":"1aa78d24_e47ec5e2","line":49,"range":{"start_line":49,"start_character":22,"end_line":49,"end_character":26},"in_reply_to":"1aa78d24_daa9bd25","updated":"2016-07-12 16:56:38.000000000","message":"Done","commit_id":"cbbcda6f49b531f5efb1397e304442032c0e6a3a"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"39976cd47cd4796a15dfdd1a311353248ef52152","unresolved":false,"context_lines":[{"line_number":66,"context_line":"    cfg.StrOpt("},{"line_number":67,"context_line":"        # TODO(raj_singh): Change this option admin_url-\u003eauth_url to make it"},{"line_number":68,"context_line":"        # consistent with other clients (Neutrton, Cinder). It requires lot"},{"line_number":69,"context_line":"        # of work in Ironic client to make this happen and is out of scope of"},{"line_number":70,"context_line":"        # this patch."},{"line_number":71,"context_line":"        \u0027admin_url\u0027,"},{"line_number":72,"context_line":"        help\u003d\"\"\""},{"line_number":73,"context_line":"Keystone public API endpoint."}],"source_content_type":"text/x-python","patch_set":8,"id":"1aa78d24_1a1b4582","line":70,"range":{"start_line":69,"start_character":55,"end_line":70,"end_character":21},"updated":"2016-07-07 12:52:34.000000000","message":"Nit: this doesn\u0027t make sense once this is merged in the code, best to drop that.","commit_id":"cbbcda6f49b531f5efb1397e304442032c0e6a3a"},{"author":{"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},"change_message_id":"98edbbcbc9cda2f001f5ad4407dfb99e9e5104cd","unresolved":false,"context_lines":[{"line_number":66,"context_line":"    cfg.StrOpt("},{"line_number":67,"context_line":"        # TODO(raj_singh): Change this option admin_url-\u003eauth_url to make it"},{"line_number":68,"context_line":"        # consistent with other clients (Neutrton, Cinder). It requires lot"},{"line_number":69,"context_line":"        # of work in Ironic client to make this happen and is out of scope of"},{"line_number":70,"context_line":"        # this patch."},{"line_number":71,"context_line":"        \u0027admin_url\u0027,"},{"line_number":72,"context_line":"        help\u003d\"\"\""},{"line_number":73,"context_line":"Keystone public API endpoint."}],"source_content_type":"text/x-python","patch_set":8,"id":"1aa78d24_448079bf","line":70,"range":{"start_line":69,"start_character":55,"end_line":70,"end_character":21},"in_reply_to":"1aa78d24_1a1b4582","updated":"2016-07-12 16:56:38.000000000","message":"Done","commit_id":"cbbcda6f49b531f5efb1397e304442032c0e6a3a"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"39976cd47cd4796a15dfdd1a311353248ef52152","unresolved":false,"context_lines":[{"line_number":79,"context_line":"Path to the PEM encoded Certificate Authority file to be used when verifying"},{"line_number":80,"context_line":"HTTPs connections with the Ironic driver. By default this option is not used."},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"* Possible values:"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"    None - Default"},{"line_number":85,"context_line":"    Path to the CA file"}],"source_content_type":"text/x-python","patch_set":8,"id":"1aa78d24_7a0a4927","line":82,"updated":"2016-07-07 12:52:34.000000000","message":"This format is incorrect.\n\nThe list of options should get the bullet, and this should be flush against the side of the file.","commit_id":"cbbcda6f49b531f5efb1397e304442032c0e6a3a"},{"author":{"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},"change_message_id":"98edbbcbc9cda2f001f5ad4407dfb99e9e5104cd","unresolved":false,"context_lines":[{"line_number":79,"context_line":"Path to the PEM encoded Certificate Authority file to be used when verifying"},{"line_number":80,"context_line":"HTTPs connections with the Ironic driver. By default this option is not used."},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"* Possible values:"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"    None - Default"},{"line_number":85,"context_line":"    Path to the CA file"}],"source_content_type":"text/x-python","patch_set":8,"id":"1aa78d24_24856dce","line":82,"in_reply_to":"1aa78d24_7a0a4927","updated":"2016-07-12 16:56:38.000000000","message":"Done","commit_id":"cbbcda6f49b531f5efb1397e304442032c0e6a3a"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"39976cd47cd4796a15dfdd1a311353248ef52152","unresolved":false,"context_lines":[{"line_number":91,"context_line":"\"\"\"),"},{"line_number":92,"context_line":"    cfg.IntOpt("},{"line_number":93,"context_line":"        \u0027api_max_retries\u0027,"},{"line_number":94,"context_line":"        default\u003d60,"},{"line_number":95,"context_line":"        min\u003d0,"},{"line_number":96,"context_line":"        help\u003d\"\"\""},{"line_number":97,"context_line":"The number of times to retry when a request conflicts."}],"source_content_type":"text/x-python","patch_set":8,"id":"1aa78d24_fd2bd37f","line":94,"range":{"start_line":94,"start_character":16,"end_line":94,"end_character":18},"updated":"2016-07-07 12:52:34.000000000","message":"This is a crazy default, but thats a different patch.","commit_id":"cbbcda6f49b531f5efb1397e304442032c0e6a3a"},{"author":{"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},"change_message_id":"98edbbcbc9cda2f001f5ad4407dfb99e9e5104cd","unresolved":false,"context_lines":[{"line_number":91,"context_line":"\"\"\"),"},{"line_number":92,"context_line":"    cfg.IntOpt("},{"line_number":93,"context_line":"        \u0027api_max_retries\u0027,"},{"line_number":94,"context_line":"        default\u003d60,"},{"line_number":95,"context_line":"        min\u003d0,"},{"line_number":96,"context_line":"        help\u003d\"\"\""},{"line_number":97,"context_line":"The number of times to retry when a request conflicts."}],"source_content_type":"text/x-python","patch_set":8,"id":"1aa78d24_4457d959","line":94,"range":{"start_line":94,"start_character":16,"end_line":94,"end_character":18},"in_reply_to":"1aa78d24_fd2bd37f","updated":"2016-07-12 16:56:38.000000000","message":"I added a TODO to change this number.","commit_id":"cbbcda6f49b531f5efb1397e304442032c0e6a3a"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"39976cd47cd4796a15dfdd1a311353248ef52152","unresolved":false,"context_lines":[{"line_number":97,"context_line":"The number of times to retry when a request conflicts."},{"line_number":98,"context_line":"If \u003c\u003d 0, only try once, no retries."},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"* Possible values:"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"    Any integer value, default is 60"},{"line_number":103,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"1aa78d24_ba003103","line":100,"updated":"2016-07-07 12:52:34.000000000","message":"As above.","commit_id":"cbbcda6f49b531f5efb1397e304442032c0e6a3a"},{"author":{"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},"change_message_id":"98edbbcbc9cda2f001f5ad4407dfb99e9e5104cd","unresolved":false,"context_lines":[{"line_number":97,"context_line":"The number of times to retry when a request conflicts."},{"line_number":98,"context_line":"If \u003c\u003d 0, only try once, no retries."},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"* Possible values:"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"    Any integer value, default is 60"},{"line_number":103,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"1aa78d24_245c4d7c","line":100,"in_reply_to":"1aa78d24_ba003103","updated":"2016-07-12 16:56:38.000000000","message":"Done","commit_id":"cbbcda6f49b531f5efb1397e304442032c0e6a3a"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"39976cd47cd4796a15dfdd1a311353248ef52152","unresolved":false,"context_lines":[{"line_number":111,"context_line":"        help\u003d\"\"\""},{"line_number":112,"context_line":"The number of seconds to wait before retrying the request."},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"* Possible values:"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"    Any positive integer, default is 2"},{"line_number":117,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"1aa78d24_3d227ba3","line":114,"updated":"2016-07-07 12:52:34.000000000","message":"as above.","commit_id":"cbbcda6f49b531f5efb1397e304442032c0e6a3a"},{"author":{"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},"change_message_id":"98edbbcbc9cda2f001f5ad4407dfb99e9e5104cd","unresolved":false,"context_lines":[{"line_number":111,"context_line":"        help\u003d\"\"\""},{"line_number":112,"context_line":"The number of seconds to wait before retrying the request."},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"* Possible values:"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"    Any positive integer, default is 2"},{"line_number":117,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"1aa78d24_6452d568","line":114,"in_reply_to":"1aa78d24_3d227ba3","updated":"2016-07-12 16:56:38.000000000","message":"Done","commit_id":"cbbcda6f49b531f5efb1397e304442032c0e6a3a"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"907ceabffc85c7c2c03f887418d71775813e5ea4","unresolved":false,"context_lines":[{"line_number":21,"context_line":"    help\u003d\"\"\""},{"line_number":22,"context_line":"Configuration options for Ironic driver (Bare Metal)."},{"line_number":23,"context_line":"If using the Ironic driver following options must be set:"},{"line_number":24,"context_line":"    admin_url"},{"line_number":25,"context_line":"    admin_tenant_name"},{"line_number":26,"context_line":"    admin_username"},{"line_number":27,"context_line":"    admin_password"},{"line_number":28,"context_line":"    api_endpoint"},{"line_number":29,"context_line":"\"\"\")"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"ironic_options \u003d ["}],"source_content_type":"text/x-python","patch_set":9,"id":"dada55a8_c21eed0a","line":28,"range":{"start_line":24,"start_character":0,"end_line":28,"end_character":16},"updated":"2016-07-21 15:06:49.000000000","message":"Missing * in enumerated items.\n\nhttps://wiki.openstack.org/wiki/ConfigOptionsConsistency#fix_opt_description_indentation","commit_id":"a8bf3329808d00f99515ba991ef488574cd44530"},{"author":{"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},"change_message_id":"1241d31ae43d1fb5555bccb6b91b1fd588e03fe6","unresolved":false,"context_lines":[{"line_number":21,"context_line":"    help\u003d\"\"\""},{"line_number":22,"context_line":"Configuration options for Ironic driver (Bare Metal)."},{"line_number":23,"context_line":"If using the Ironic driver following options must be set:"},{"line_number":24,"context_line":"    admin_url"},{"line_number":25,"context_line":"    admin_tenant_name"},{"line_number":26,"context_line":"    admin_username"},{"line_number":27,"context_line":"    admin_password"},{"line_number":28,"context_line":"    api_endpoint"},{"line_number":29,"context_line":"\"\"\")"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"ironic_options \u003d ["}],"source_content_type":"text/x-python","patch_set":9,"id":"dada55a8_666c7008","line":28,"range":{"start_line":24,"start_character":0,"end_line":28,"end_character":16},"in_reply_to":"dada55a8_c21eed0a","updated":"2016-07-21 16:40:23.000000000","message":"Done","commit_id":"a8bf3329808d00f99515ba991ef488574cd44530"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"907ceabffc85c7c2c03f887418d71775813e5ea4","unresolved":false,"context_lines":[{"line_number":40,"context_line":"        # TODO(raj_singh): Get this value from keystone service catalog"},{"line_number":41,"context_line":"        \u0027api_endpoint\u0027,"},{"line_number":42,"context_line":"        sample_default\u003d\u0027http://ironic.example.org:6385/\u0027,"},{"line_number":43,"context_line":"        help\u003d\"\"\"\""},{"line_number":44,"context_line":"URL for the Ironic API endpoint."},{"line_number":45,"context_line":"\"\"\"),"},{"line_number":46,"context_line":"    cfg.StrOpt("},{"line_number":47,"context_line":"        \u0027admin_username\u0027,"},{"line_number":48,"context_line":"        help\u003d\"\"\""}],"source_content_type":"text/x-python","patch_set":9,"id":"dada55a8_62bd81d7","line":45,"range":{"start_line":43,"start_character":0,"end_line":45,"end_character":5},"updated":"2016-07-21 15:06:49.000000000","message":"Can be single line.","commit_id":"a8bf3329808d00f99515ba991ef488574cd44530"},{"author":{"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},"change_message_id":"1241d31ae43d1fb5555bccb6b91b1fd588e03fe6","unresolved":false,"context_lines":[{"line_number":40,"context_line":"        # TODO(raj_singh): Get this value from keystone service catalog"},{"line_number":41,"context_line":"        \u0027api_endpoint\u0027,"},{"line_number":42,"context_line":"        sample_default\u003d\u0027http://ironic.example.org:6385/\u0027,"},{"line_number":43,"context_line":"        help\u003d\"\"\"\""},{"line_number":44,"context_line":"URL for the Ironic API endpoint."},{"line_number":45,"context_line":"\"\"\"),"},{"line_number":46,"context_line":"    cfg.StrOpt("},{"line_number":47,"context_line":"        \u0027admin_username\u0027,"},{"line_number":48,"context_line":"        help\u003d\"\"\""}],"source_content_type":"text/x-python","patch_set":9,"id":"dada55a8_11885070","line":45,"range":{"start_line":43,"start_character":0,"end_line":45,"end_character":5},"in_reply_to":"dada55a8_62bd81d7","updated":"2016-07-21 16:40:23.000000000","message":"Done","commit_id":"a8bf3329808d00f99515ba991ef488574cd44530"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"907ceabffc85c7c2c03f887418d71775813e5ea4","unresolved":false,"context_lines":[{"line_number":45,"context_line":"\"\"\"),"},{"line_number":46,"context_line":"    cfg.StrOpt("},{"line_number":47,"context_line":"        \u0027admin_username\u0027,"},{"line_number":48,"context_line":"        help\u003d\"\"\""},{"line_number":49,"context_line":"Ironic keystone admin username"},{"line_number":50,"context_line":"\"\"\"),"},{"line_number":51,"context_line":"    cfg.StrOpt("},{"line_number":52,"context_line":"        \u0027admin_password\u0027,"},{"line_number":53,"context_line":"        secret\u003dTrue,"}],"source_content_type":"text/x-python","patch_set":9,"id":"dada55a8_a2b3f908","line":50,"range":{"start_line":48,"start_character":0,"end_line":50,"end_character":5},"updated":"2016-07-21 15:06:49.000000000","message":"Can be a single line.","commit_id":"a8bf3329808d00f99515ba991ef488574cd44530"},{"author":{"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},"change_message_id":"1241d31ae43d1fb5555bccb6b91b1fd588e03fe6","unresolved":false,"context_lines":[{"line_number":45,"context_line":"\"\"\"),"},{"line_number":46,"context_line":"    cfg.StrOpt("},{"line_number":47,"context_line":"        \u0027admin_username\u0027,"},{"line_number":48,"context_line":"        help\u003d\"\"\""},{"line_number":49,"context_line":"Ironic keystone admin username"},{"line_number":50,"context_line":"\"\"\"),"},{"line_number":51,"context_line":"    cfg.StrOpt("},{"line_number":52,"context_line":"        \u0027admin_password\u0027,"},{"line_number":53,"context_line":"        secret\u003dTrue,"}],"source_content_type":"text/x-python","patch_set":9,"id":"dada55a8_717b8c7b","line":50,"range":{"start_line":48,"start_character":0,"end_line":50,"end_character":5},"in_reply_to":"dada55a8_a2b3f908","updated":"2016-07-21 16:40:23.000000000","message":"Done","commit_id":"a8bf3329808d00f99515ba991ef488574cd44530"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"907ceabffc85c7c2c03f887418d71775813e5ea4","unresolved":false,"context_lines":[{"line_number":51,"context_line":"    cfg.StrOpt("},{"line_number":52,"context_line":"        \u0027admin_password\u0027,"},{"line_number":53,"context_line":"        secret\u003dTrue,"},{"line_number":54,"context_line":"        help\u003d\"\"\""},{"line_number":55,"context_line":"Ironic keystone admin password."},{"line_number":56,"context_line":"\"\"\"),"},{"line_number":57,"context_line":"    cfg.StrOpt("},{"line_number":58,"context_line":"        \u0027admin_auth_token\u0027,"},{"line_number":59,"context_line":"        secret\u003dTrue,"}],"source_content_type":"text/x-python","patch_set":9,"id":"dada55a8_e2d17124","line":56,"range":{"start_line":54,"start_character":0,"end_line":56,"end_character":5},"updated":"2016-07-21 15:06:49.000000000","message":"ditto","commit_id":"a8bf3329808d00f99515ba991ef488574cd44530"},{"author":{"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},"change_message_id":"1241d31ae43d1fb5555bccb6b91b1fd588e03fe6","unresolved":false,"context_lines":[{"line_number":51,"context_line":"    cfg.StrOpt("},{"line_number":52,"context_line":"        \u0027admin_password\u0027,"},{"line_number":53,"context_line":"        secret\u003dTrue,"},{"line_number":54,"context_line":"        help\u003d\"\"\""},{"line_number":55,"context_line":"Ironic keystone admin password."},{"line_number":56,"context_line":"\"\"\"),"},{"line_number":57,"context_line":"    cfg.StrOpt("},{"line_number":58,"context_line":"        \u0027admin_auth_token\u0027,"},{"line_number":59,"context_line":"        secret\u003dTrue,"}],"source_content_type":"text/x-python","patch_set":9,"id":"dada55a8_b19984c6","line":56,"range":{"start_line":54,"start_character":0,"end_line":56,"end_character":5},"in_reply_to":"dada55a8_e2d17124","updated":"2016-07-21 16:40:23.000000000","message":"Done","commit_id":"a8bf3329808d00f99515ba991ef488574cd44530"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"907ceabffc85c7c2c03f887418d71775813e5ea4","unresolved":false,"context_lines":[{"line_number":85,"context_line":"\"\"\"),"},{"line_number":86,"context_line":"    cfg.StrOpt("},{"line_number":87,"context_line":"        \u0027admin_tenant_name\u0027,"},{"line_number":88,"context_line":"        help\u003d\"\"\""},{"line_number":89,"context_line":"Ironic keystone tenant name."},{"line_number":90,"context_line":"\"\"\"),"},{"line_number":91,"context_line":"    cfg.IntOpt("},{"line_number":92,"context_line":"        \u0027api_max_retries\u0027,"},{"line_number":93,"context_line":"        # TODO(raj_singh): Change this default to some sensible number"}],"source_content_type":"text/x-python","patch_set":9,"id":"dada55a8_e298517a","line":90,"range":{"start_line":88,"start_character":0,"end_line":90,"end_character":5},"updated":"2016-07-21 15:06:49.000000000","message":"Ditto","commit_id":"a8bf3329808d00f99515ba991ef488574cd44530"},{"author":{"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},"change_message_id":"1241d31ae43d1fb5555bccb6b91b1fd588e03fe6","unresolved":false,"context_lines":[{"line_number":85,"context_line":"\"\"\"),"},{"line_number":86,"context_line":"    cfg.StrOpt("},{"line_number":87,"context_line":"        \u0027admin_tenant_name\u0027,"},{"line_number":88,"context_line":"        help\u003d\"\"\""},{"line_number":89,"context_line":"Ironic keystone tenant name."},{"line_number":90,"context_line":"\"\"\"),"},{"line_number":91,"context_line":"    cfg.IntOpt("},{"line_number":92,"context_line":"        \u0027api_max_retries\u0027,"},{"line_number":93,"context_line":"        # TODO(raj_singh): Change this default to some sensible number"}],"source_content_type":"text/x-python","patch_set":9,"id":"dada55a8_9194408b","line":90,"range":{"start_line":88,"start_character":0,"end_line":90,"end_character":5},"in_reply_to":"dada55a8_e298517a","updated":"2016-07-21 16:40:23.000000000","message":"Done","commit_id":"a8bf3329808d00f99515ba991ef488574cd44530"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"d8f1292b07bc5e373821b315132a533097c139f3","unresolved":false,"context_lines":[{"line_number":82,"context_line":"        \u0027api_max_retries\u0027,"},{"line_number":83,"context_line":"        # TODO(raj_singh): Change this default to some sensible number"},{"line_number":84,"context_line":"        default\u003d60,"},{"line_number":85,"context_line":"        min\u003d0,"},{"line_number":86,"context_line":"        help\u003d\"\"\""},{"line_number":87,"context_line":"The number of times to retry when a request conflicts."},{"line_number":88,"context_line":"If \u003c\u003d 0, only try once, no retries."}],"source_content_type":"text/x-python","patch_set":10,"id":"dada55a8_11bcd0b9","line":85,"range":{"start_line":85,"start_character":8,"end_line":85,"end_character":14},"updated":"2016-07-21 16:47:28.000000000","message":"According to help text, this is not true!","commit_id":"7d0cba38775438765e48aaafc0e2a2677efce4a2"},{"author":{"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},"change_message_id":"fc4884749327ac7097afdd67a8072d9ade9516e7","unresolved":false,"context_lines":[{"line_number":82,"context_line":"        \u0027api_max_retries\u0027,"},{"line_number":83,"context_line":"        # TODO(raj_singh): Change this default to some sensible number"},{"line_number":84,"context_line":"        default\u003d60,"},{"line_number":85,"context_line":"        min\u003d0,"},{"line_number":86,"context_line":"        help\u003d\"\"\""},{"line_number":87,"context_line":"The number of times to retry when a request conflicts."},{"line_number":88,"context_line":"If \u003c\u003d 0, only try once, no retries."}],"source_content_type":"text/x-python","patch_set":10,"id":"dada55a8_6bdb8c7c","line":85,"range":{"start_line":85,"start_character":8,"end_line":85,"end_character":14},"in_reply_to":"dada55a8_11bcd0b9","updated":"2016-07-21 20:22:39.000000000","message":"Done","commit_id":"7d0cba38775438765e48aaafc0e2a2677efce4a2"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"d8f1292b07bc5e373821b315132a533097c139f3","unresolved":false,"context_lines":[{"line_number":85,"context_line":"        min\u003d0,"},{"line_number":86,"context_line":"        help\u003d\"\"\""},{"line_number":87,"context_line":"The number of times to retry when a request conflicts."},{"line_number":88,"context_line":"If \u003c\u003d 0, only try once, no retries."},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"Possible values:"},{"line_number":91,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"dada55a8_91c8c056","line":88,"range":{"start_line":88,"start_character":0,"end_line":88,"end_character":35},"updated":"2016-07-21 16:47:28.000000000","message":"Move to possible values OR drop possible values section.","commit_id":"7d0cba38775438765e48aaafc0e2a2677efce4a2"},{"author":{"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},"change_message_id":"fc4884749327ac7097afdd67a8072d9ade9516e7","unresolved":false,"context_lines":[{"line_number":85,"context_line":"        min\u003d0,"},{"line_number":86,"context_line":"        help\u003d\"\"\""},{"line_number":87,"context_line":"The number of times to retry when a request conflicts."},{"line_number":88,"context_line":"If \u003c\u003d 0, only try once, no retries."},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"Possible values:"},{"line_number":91,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"dada55a8_8be0802a","line":88,"range":{"start_line":88,"start_character":0,"end_line":88,"end_character":35},"in_reply_to":"dada55a8_91c8c056","updated":"2016-07-21 20:22:39.000000000","message":"Done","commit_id":"7d0cba38775438765e48aaafc0e2a2677efce4a2"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"d8f1292b07bc5e373821b315132a533097c139f3","unresolved":false,"context_lines":[{"line_number":103,"context_line":""},{"line_number":104,"context_line":"Possible values:"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"* Any positive integer, default is 2"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"Related options:"},{"line_number":109,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"dada55a8_91cc408a","line":106,"range":{"start_line":106,"start_character":0,"end_line":106,"end_character":36},"updated":"2016-07-21 16:47:28.000000000","message":"Ah, sorry for not including this in previous comments.\nAdd min\u003d0 flag and drop this.","commit_id":"7d0cba38775438765e48aaafc0e2a2677efce4a2"},{"author":{"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},"change_message_id":"fc4884749327ac7097afdd67a8072d9ade9516e7","unresolved":false,"context_lines":[{"line_number":103,"context_line":""},{"line_number":104,"context_line":"Possible values:"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"* Any positive integer, default is 2"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"Related options:"},{"line_number":109,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"dada55a8_ebee5c20","line":106,"range":{"start_line":106,"start_character":0,"end_line":106,"end_character":36},"in_reply_to":"dada55a8_91cc408a","updated":"2016-07-21 20:22:39.000000000","message":"Yea, that make sense.","commit_id":"7d0cba38775438765e48aaafc0e2a2677efce4a2"},{"author":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"change_message_id":"9653439e260341bdc111e1289c991c5308a4dfca","unresolved":false,"context_lines":[{"line_number":59,"context_line":"\"\"\"),"},{"line_number":60,"context_line":"    cfg.StrOpt("},{"line_number":61,"context_line":"        # TODO(raj_singh): Change this option admin_url-\u003eauth_url to make it"},{"line_number":62,"context_line":"        # consistent with other clients (Neutrton, Cinder). It requires lot"},{"line_number":63,"context_line":"        # of work in Ironic client to make this happen."},{"line_number":64,"context_line":"        \u0027admin_url\u0027,"},{"line_number":65,"context_line":"        help\u003d\u0027Keystone public API endpoint\u0027),"}],"source_content_type":"text/x-python","patch_set":11,"id":"dada55a8_d9885fc9","line":62,"updated":"2016-07-22 17:42:44.000000000","message":"Neutron","commit_id":"b408bdf21f9e129e6f88d0549f781c5fc72261da"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"6b79202b8837c988b61f10e79b36919a5a2501cb","unresolved":false,"context_lines":[{"line_number":25,"context_line":"* admin_tenant_name"},{"line_number":26,"context_line":"* admin_username"},{"line_number":27,"context_line":"* admin_password"},{"line_number":28,"context_line":"* api_endpoint"},{"line_number":29,"context_line":"\"\"\")"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"ironic_options \u003d ["}],"source_content_type":"text/x-python","patch_set":12,"id":"dada55a8_ae5fed73","line":28,"updated":"2016-07-25 10:28:39.000000000","message":"Nit: this isn\u0027t valid RST, but then we don\u0027t use it like that yet.","commit_id":"c8c2d28679c018bbc5b2848d1473dcca15eaaaa1"}]}