)]}'
{"tox.ini":[{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"c5f444591efc6f09fcbb16a808ddc6400c7e41e9","unresolved":false,"context_lines":[{"line_number":89,"context_line":"  rm -rf doc/source/api doc/build api-guide/build api-ref/build"},{"line_number":90,"context_line":"  python setup.py build_sphinx"},{"line_number":91,"context_line":"  bash -c \u0027! find doc/ -type f -name *.json | xargs -t -n1 python -m json.tool 2\u003e\u00261 \u003e /dev/null | grep -B1 -v ^python\u0027"},{"line_number":92,"context_line":"  oslo-config-generator --config-file\u003detc/nova/nova-config-generator.conf"},{"line_number":93,"context_line":"  sphinx-build -W -b html api-guide/source api-guide/build/html"},{"line_number":94,"context_line":"  sphinx-build -W -b html api-ref/source api-ref/build/html"},{"line_number":95,"context_line":""}],"source_content_type":"text/x-properties","patch_set":1,"id":"3aaa91ec_abfa0cbb","line":92,"updated":"2016-06-23 14:07:11.000000000","message":"So we added the config generator here, in part to make sure things get checked in the gate.\n\nI think we should add oslopolicy-sample-generator here too.","commit_id":"7401a393e04bf41857f620ff11b0f570ce919837"},{"author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"change_message_id":"94665bafeec5b082b13a61fa640b74d39c6259b4","unresolved":false,"context_lines":[{"line_number":89,"context_line":"  rm -rf doc/source/api doc/build api-guide/build api-ref/build"},{"line_number":90,"context_line":"  python setup.py build_sphinx"},{"line_number":91,"context_line":"  bash -c \u0027! find doc/ -type f -name *.json | xargs -t -n1 python -m json.tool 2\u003e\u00261 \u003e /dev/null | grep -B1 -v ^python\u0027"},{"line_number":92,"context_line":"  oslo-config-generator --config-file\u003detc/nova/nova-config-generator.conf"},{"line_number":93,"context_line":"  sphinx-build -W -b html api-guide/source api-guide/build/html"},{"line_number":94,"context_line":"  sphinx-build -W -b html api-ref/source api-ref/build/html"},{"line_number":95,"context_line":""}],"source_content_type":"text/x-properties","patch_set":1,"id":"3aaa91ec_a501943a","line":92,"in_reply_to":"3aaa91ec_abfa0cbb","updated":"2016-06-23 15:24:20.000000000","message":"Ahh, wasn\u0027t aware of that. I can add it.","commit_id":"7401a393e04bf41857f620ff11b0f570ce919837"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"4ec8e5ac23c8da95be8e742bda09a5dac84bc2aa","unresolved":false,"context_lines":[{"line_number":90,"context_line":"  python setup.py build_sphinx"},{"line_number":91,"context_line":"  bash -c \u0027! find doc/ -type f -name *.json | xargs -t -n1 python -m json.tool 2\u003e\u00261 \u003e /dev/null | grep -B1 -v ^python\u0027"},{"line_number":92,"context_line":"  oslo-config-generator --config-file\u003detc/nova/nova-config-generator.conf"},{"line_number":93,"context_line":"  oslopolicy-sample-generator --config-file\u003detc/nova/nova-policy-generator.conf"},{"line_number":94,"context_line":"  sphinx-build -W -b html api-guide/source api-guide/build/html"},{"line_number":95,"context_line":"  sphinx-build -W -b html api-ref/source api-ref/build/html"},{"line_number":96,"context_line":""}],"source_content_type":"text/x-properties","patch_set":2,"id":"3aaa91ec_28babf0a","line":93,"updated":"2016-06-28 20:41:35.000000000","message":"Unless I\u0027m missing something, I don\u0027t think this is making the policy sample generation run as part of CI [1]. The nova.conf.sample is generated by the oslo.config sphinxconfiggen extension [2] during the sphinx build, which it appears to be doing without using the docs tox venv we have here.\n\n[1] http://logs.openstack.org/73/332473/2/check/gate-nova-docs/032fedb/console.html.gz\n[2] http://docs.openstack.org/developer/oslo.config/sphinxconfiggen.html","commit_id":"754323c51519a0159685da05eaf4b5afab994c67"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"e759ce314da1999d90b9a9f5b5c94d1131f201e0","unresolved":false,"context_lines":[{"line_number":90,"context_line":"  python setup.py build_sphinx"},{"line_number":91,"context_line":"  bash -c \u0027! find doc/ -type f -name *.json | xargs -t -n1 python -m json.tool 2\u003e\u00261 \u003e /dev/null | grep -B1 -v ^python\u0027"},{"line_number":92,"context_line":"  oslo-config-generator --config-file\u003detc/nova/nova-config-generator.conf"},{"line_number":93,"context_line":"  oslopolicy-sample-generator --config-file\u003detc/nova/nova-policy-generator.conf"},{"line_number":94,"context_line":"  sphinx-build -W -b html api-guide/source api-guide/build/html"},{"line_number":95,"context_line":"  sphinx-build -W -b html api-ref/source api-ref/build/html"},{"line_number":96,"context_line":""}],"source_content_type":"text/x-properties","patch_set":2,"id":"3aaa91ec_8b5589c3","line":93,"in_reply_to":"3aaa91ec_0855434f","updated":"2016-06-29 13:25:18.000000000","message":"So we run the docs target in the CI, which triggers this.\n\nBut we can add that later.","commit_id":"754323c51519a0159685da05eaf4b5afab994c67"},{"author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"change_message_id":"a3233ab687e23c146d8d16d73c248b10eeaad3ba","unresolved":false,"context_lines":[{"line_number":90,"context_line":"  python setup.py build_sphinx"},{"line_number":91,"context_line":"  bash -c \u0027! find doc/ -type f -name *.json | xargs -t -n1 python -m json.tool 2\u003e\u00261 \u003e /dev/null | grep -B1 -v ^python\u0027"},{"line_number":92,"context_line":"  oslo-config-generator --config-file\u003detc/nova/nova-config-generator.conf"},{"line_number":93,"context_line":"  oslopolicy-sample-generator --config-file\u003detc/nova/nova-policy-generator.conf"},{"line_number":94,"context_line":"  sphinx-build -W -b html api-guide/source api-guide/build/html"},{"line_number":95,"context_line":"  sphinx-build -W -b html api-ref/source api-ref/build/html"},{"line_number":96,"context_line":""}],"source_content_type":"text/x-properties","patch_set":2,"id":"3aaa91ec_0855434f","line":93,"in_reply_to":"3aaa91ec_28babf0a","updated":"2016-06-28 20:51:37.000000000","message":"Okay. I was just going by Johns statement, but yeah I don\u0027t see this tox target used at all there.\n\nI\u0027ll update the commit message to take out the bit about CI. It\u0027s probably still useful to have this here to build the sample file as part of the docs job. And CI can be dealt with later.","commit_id":"754323c51519a0159685da05eaf4b5afab994c67"},{"author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"change_message_id":"de8d58d587a2eb0fc60843d7c145c2b36d8d5daa","unresolved":false,"context_lines":[{"line_number":90,"context_line":"  python setup.py build_sphinx"},{"line_number":91,"context_line":"  bash -c \u0027! find doc/ -type f -name *.json | xargs -t -n1 python -m json.tool 2\u003e\u00261 \u003e /dev/null | grep -B1 -v ^python\u0027"},{"line_number":92,"context_line":"  oslo-config-generator --config-file\u003detc/nova/nova-config-generator.conf"},{"line_number":93,"context_line":"  oslopolicy-sample-generator --config-file\u003detc/nova/nova-policy-generator.conf"},{"line_number":94,"context_line":"  sphinx-build -W -b html api-guide/source api-guide/build/html"},{"line_number":95,"context_line":"  sphinx-build -W -b html api-ref/source api-ref/build/html"},{"line_number":96,"context_line":""}],"source_content_type":"text/x-properties","patch_set":2,"id":"3aaa91ec_03b97d15","line":93,"in_reply_to":"3aaa91ec_8b5589c3","updated":"2016-06-29 14:13:03.000000000","message":"Looking at the logs Melanie posted I don\u0027t actually see this target being used there. I would expect to see \"tox -edocs\" or something to that effect there but my searching turns up nothing. It does seem to be handled via some other means.","commit_id":"754323c51519a0159685da05eaf4b5afab994c67"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"df59975a13b97bd10a9941081bdb20c2c4f72b09","unresolved":false,"context_lines":[{"line_number":60,"context_line":"[testenv:genconfig]"},{"line_number":61,"context_line":"commands \u003d oslo-config-generator --config-file\u003detc/nova/nova-config-generator.conf"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"[testenv:genpolicy]"},{"line_number":64,"context_line":"commands \u003d oslopolicy-sample-generator --config-file\u003detc/nova/nova-policy-generator.conf"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"[testenv:cover]"}],"source_content_type":"text/x-properties","patch_set":3,"id":"3aaa91ec_f2b0998d","line":63,"range":{"start_line":63,"start_character":9,"end_line":63,"end_character":18},"updated":"2016-06-29 02:37:17.000000000","message":"-\u003e genpolicy-sample as we might want to add another env for generate the policy files using oslopolicy-policy-generator","commit_id":"5e38fa3cb5ae850dcf2bb251b4098220424a6ed6"}]}