)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"eb254c052f511f2bb9bf07ce2030b0d90a73a5c8","unresolved":false,"context_lines":[{"line_number":12,"context_line":"the boot from proceeding."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"However if there are some older nova-api services then the BuildRequest"},{"line_number":15,"context_line":"may not have ever existed so it\u0027s non-existence does not indicate a"},{"line_number":16,"context_line":"delete occurred. A service version check accounts for this and lets the"},{"line_number":17,"context_line":"build proceed as normal. In that case the delete code will also need to"},{"line_number":18,"context_line":"account for the lower service version and clean up the instance from the"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"dada55a8_e68ed277","line":15,"range":{"start_line":15,"start_character":29,"end_line":15,"end_character":33},"updated":"2016-07-20 22:44:22.000000000","message":"femtonit: its (WAAAAT? A French guy nitting some English words ?)","commit_id":"6ce01a655bd204a1e6b34dfa67290db202929b70"}],"nova/conductor/manager.py":[{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"d182205028eecc460cbfd75c5feb3514c859a719","unresolved":false,"context_lines":[{"line_number":397,"context_line":"            with excutils.save_and_reraise_exception() as exc_ctxt:"},{"line_number":398,"context_line":"                service_version \u003d objects.Service.get_minimum_version("},{"line_number":399,"context_line":"                    context, \u0027nova-api\u0027)"},{"line_number":400,"context_line":"                if service_version \u003e\u003d 12:"},{"line_number":401,"context_line":"                    # A BuildRequest was created during the boot process, the"},{"line_number":402,"context_line":"                    # NotFound exception indicates a delete happened which"},{"line_number":403,"context_line":"                    # should abort the boot."}],"source_content_type":"text/x-python","patch_set":8,"id":"1aa78d24_bc820dc6","line":400,"range":{"start_line":400,"start_character":38,"end_line":400,"end_character":40},"updated":"2016-07-06 23:47:56.000000000","message":"Just curious how we know version 12 is the marker for this? I didn\u0027t find any notes in the service version history","commit_id":"5246d8ccc450d4f9b53a15cd83ddff209b237ede"},{"author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"change_message_id":"7921025fee2814775a92efc7d4bb4e6387ddecfe","unresolved":false,"context_lines":[{"line_number":397,"context_line":"            with excutils.save_and_reraise_exception() as exc_ctxt:"},{"line_number":398,"context_line":"                service_version \u003d objects.Service.get_minimum_version("},{"line_number":399,"context_line":"                    context, \u0027nova-api\u0027)"},{"line_number":400,"context_line":"                if service_version \u003e\u003d 12:"},{"line_number":401,"context_line":"                    # A BuildRequest was created during the boot process, the"},{"line_number":402,"context_line":"                    # NotFound exception indicates a delete happened which"},{"line_number":403,"context_line":"                    # should abort the boot."}],"source_content_type":"text/x-python","patch_set":8,"id":"1aa78d24_6bb3864d","line":400,"range":{"start_line":400,"start_character":38,"end_line":400,"end_character":40},"in_reply_to":"1aa78d24_bc820dc6","updated":"2016-07-07 18:57:08.000000000","message":"Just that it was a version bump after BuildRequest objects started being created. I suppose I should add a comment there since this will be using it.","commit_id":"5246d8ccc450d4f9b53a15cd83ddff209b237ede"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"d847f837f793ea8826ac03ffc7462a186c52a0b5","unresolved":false,"context_lines":[{"line_number":391,"context_line":"                    instance.uuid)"},{"line_number":392,"context_line":"            # TODO(alaski): Sync API updates of the build_request to the"},{"line_number":393,"context_line":"            # instance before it is destroyed. Right now only locked_by can"},{"line_number":394,"context_line":"            # be updated before this is destroyed."},{"line_number":395,"context_line":"            build_request.destroy()"},{"line_number":396,"context_line":"        except exception.BuildRequestNotFound:"},{"line_number":397,"context_line":"            with excutils.save_and_reraise_exception() as exc_ctxt:"}],"source_content_type":"text/x-python","patch_set":11,"id":"dada55a8_8db785d7","line":394,"updated":"2016-07-19 14:38:05.000000000","message":"What fields would be modifiable about the build request via the API? Just curious...","commit_id":"6ce01a655bd204a1e6b34dfa67290db202929b70"},{"author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"change_message_id":"451807aa5dcb5c8f068cfefae1afc2f1286b304c","unresolved":false,"context_lines":[{"line_number":391,"context_line":"                    instance.uuid)"},{"line_number":392,"context_line":"            # TODO(alaski): Sync API updates of the build_request to the"},{"line_number":393,"context_line":"            # instance before it is destroyed. Right now only locked_by can"},{"line_number":394,"context_line":"            # be updated before this is destroyed."},{"line_number":395,"context_line":"            build_request.destroy()"},{"line_number":396,"context_line":"        except exception.BuildRequestNotFound:"},{"line_number":397,"context_line":"            with excutils.save_and_reraise_exception() as exc_ctxt:"}],"source_content_type":"text/x-python","patch_set":11,"id":"dada55a8_9cde950f","line":394,"in_reply_to":"dada55a8_8db785d7","updated":"2016-07-19 15:53:12.000000000","message":"locked_by is the only one I saw based on an audit of the code.","commit_id":"6ce01a655bd204a1e6b34dfa67290db202929b70"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"eb254c052f511f2bb9bf07ce2030b0d90a73a5c8","unresolved":false,"context_lines":[{"line_number":401,"context_line":"                    # A BuildRequest was created during the boot process, the"},{"line_number":402,"context_line":"                    # NotFound exception indicates a delete happened which"},{"line_number":403,"context_line":"                    # should abort the boot."},{"line_number":404,"context_line":"                    pass"},{"line_number":405,"context_line":"                else:"},{"line_number":406,"context_line":"                    LOG.debug(\u0027BuildRequest not found for instance %(uuid)s, \u0027"},{"line_number":407,"context_line":"                              \u0027likely due to an older nova-api service \u0027"}],"source_content_type":"text/x-python","patch_set":11,"id":"dada55a8_b22a548e","line":404,"updated":"2016-07-20 22:44:22.000000000","message":"just to be clear, since we use save_and_reraise and that the reraise flag is True (by default), we still raise the BuildRequestNotfound, even we caught it there. That\u0027s a bit confusing but I\u0027m okay with that, maybe the above comment could clarify it later but that\u0027s a nit.","commit_id":"6ce01a655bd204a1e6b34dfa67290db202929b70"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"eb254c052f511f2bb9bf07ce2030b0d90a73a5c8","unresolved":false,"context_lines":[{"line_number":404,"context_line":"                    pass"},{"line_number":405,"context_line":"                else:"},{"line_number":406,"context_line":"                    LOG.debug(\u0027BuildRequest not found for instance %(uuid)s, \u0027"},{"line_number":407,"context_line":"                              \u0027likely due to an older nova-api service \u0027"},{"line_number":408,"context_line":"                              \u0027running.\u0027, {\u0027uuid\u0027: instance.uuid})"},{"line_number":409,"context_line":"                    exc_ctxt.reraise \u003d False"},{"line_number":410,"context_line":"            return"}],"source_content_type":"text/x-python","patch_set":11,"id":"dada55a8_926f502a","line":407,"range":{"start_line":407,"start_character":31,"end_line":407,"end_character":44},"updated":"2016-07-20 22:44:22.000000000","message":"well, it\u0027s more than likely now, right? :)","commit_id":"6ce01a655bd204a1e6b34dfa67290db202929b70"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"eb254c052f511f2bb9bf07ce2030b0d90a73a5c8","unresolved":false,"context_lines":[{"line_number":406,"context_line":"                    LOG.debug(\u0027BuildRequest not found for instance %(uuid)s, \u0027"},{"line_number":407,"context_line":"                              \u0027likely due to an older nova-api service \u0027"},{"line_number":408,"context_line":"                              \u0027running.\u0027, {\u0027uuid\u0027: instance.uuid})"},{"line_number":409,"context_line":"                    exc_ctxt.reraise \u003d False"},{"line_number":410,"context_line":"            return"},{"line_number":411,"context_line":""},{"line_number":412,"context_line":"    def _populate_instance_mapping(self, context, instance, host):"}],"source_content_type":"text/x-python","patch_set":11,"id":"dada55a8_52103859","line":409,"updated":"2016-07-20 22:44:22.000000000","message":"and here, we drop the exception that we should reraise so we keep the former behaviour.","commit_id":"6ce01a655bd204a1e6b34dfa67290db202929b70"}],"nova/tests/unit/conductor/test_conductor.py":[{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"eb254c052f511f2bb9bf07ce2030b0d90a73a5c8","unresolved":false,"context_lines":[{"line_number":863,"context_line":"            self.assertTrue(inst_map_mock.destroy.called)"},{"line_number":864,"context_line":""},{"line_number":865,"context_line":"        do_test()"},{"line_number":866,"context_line":""},{"line_number":867,"context_line":"    def test_unshelve_instance_on_host(self):"},{"line_number":868,"context_line":"        instance \u003d self._create_fake_instance_obj()"},{"line_number":869,"context_line":"        instance.vm_state \u003d vm_states.SHELVED"}],"source_content_type":"text/x-python","patch_set":11,"id":"dada55a8_3d0c753a","line":866,"updated":"2016-07-20 22:44:22.000000000","message":"I would have appreciated a test verifying that we wouldn\u0027t drop the instance mapping if the minimum API version is less than 12 but okay...","commit_id":"6ce01a655bd204a1e6b34dfa67290db202929b70"}]}