)]}'
{"nova/conf/vmware.py":[{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"c0b0058cf13939a5b8f3dab5d641cedc7bdd11bb","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from oslo_config import cfg"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"vmware_group \u003d cfg.OptGroup(\u0027vmware\u0027, title\u003d\u0027VMWare Options\u0027)"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"vmwareapi_vif_opts \u003d ["},{"line_number":23,"context_line":"    cfg.StrOpt(\u0027vlan_interface\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"3aaa91ec_865c5b7e","line":20,"updated":"2016-06-29 14:57:01.000000000","message":"I think we can define some help text that includes a list of all the options that are required if you select the vmware driver. We can also describe how you select the vmware driver.\n\nThat will stop us needing to have so many related options in each of the descriptions below.","commit_id":"b498a8f513ad5b5b4988cf508fd4a23e5e515d4a"},{"author":{"_account_id":18339,"name":"Sivasathurappan Radhakrishnan","email":"siva.radhakrishnan@intel.com","username":"sivakrishnan"},"change_message_id":"9e9332aeb6e96102bdb44a69588d35a956f19129","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from oslo_config import cfg"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"vmware_group \u003d cfg.OptGroup(\u0027vmware\u0027, title\u003d\u0027VMWare Options\u0027)"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"vmwareapi_vif_opts \u003d ["},{"line_number":23,"context_line":"    cfg.StrOpt(\u0027vlan_interface\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"3aaa91ec_fb2da9a8","line":20,"in_reply_to":"3aaa91ec_865c5b7e","updated":"2016-06-30 19:56:52.000000000","message":"Done","commit_id":"b498a8f513ad5b5b4988cf508fd4a23e5e515d4a"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"7c8c5d2a0aafe3047ec1697784f26d06ea5c951e","unresolved":false,"context_lines":[{"line_number":49,"context_line":"vmwareapi_opts \u003d ["},{"line_number":50,"context_line":"    cfg.StrOpt(\u0027host_ip\u0027,"},{"line_number":51,"context_line":"               help\u003d\"\"\""},{"line_number":52,"context_line":"This options specifies hostname or IP address for connection"},{"line_number":53,"context_line":"to VMware vCenter host"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"Possible values:"}],"source_content_type":"text/x-python","patch_set":2,"id":"3aaa91ec_5f1b4273","line":52,"range":{"start_line":52,"start_character":50,"end_line":52,"end_character":60},"updated":"2016-06-29 20:59:01.000000000","message":"a connection","commit_id":"b498a8f513ad5b5b4988cf508fd4a23e5e515d4a"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"7c8c5d2a0aafe3047ec1697784f26d06ea5c951e","unresolved":false,"context_lines":[{"line_number":49,"context_line":"vmwareapi_opts \u003d ["},{"line_number":50,"context_line":"    cfg.StrOpt(\u0027host_ip\u0027,"},{"line_number":51,"context_line":"               help\u003d\"\"\""},{"line_number":52,"context_line":"This options specifies hostname or IP address for connection"},{"line_number":53,"context_line":"to VMware vCenter host"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"Possible values:"}],"source_content_type":"text/x-python","patch_set":2,"id":"3aaa91ec_7f055e0f","line":52,"range":{"start_line":52,"start_character":23,"end_line":52,"end_character":31},"updated":"2016-06-29 20:59:01.000000000","message":"the hostname","commit_id":"b498a8f513ad5b5b4988cf508fd4a23e5e515d4a"},{"author":{"_account_id":18339,"name":"Sivasathurappan Radhakrishnan","email":"siva.radhakrishnan@intel.com","username":"sivakrishnan"},"change_message_id":"9e9332aeb6e96102bdb44a69588d35a956f19129","unresolved":false,"context_lines":[{"line_number":49,"context_line":"vmwareapi_opts \u003d ["},{"line_number":50,"context_line":"    cfg.StrOpt(\u0027host_ip\u0027,"},{"line_number":51,"context_line":"               help\u003d\"\"\""},{"line_number":52,"context_line":"This options specifies hostname or IP address for connection"},{"line_number":53,"context_line":"to VMware vCenter host"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"Possible values:"}],"source_content_type":"text/x-python","patch_set":2,"id":"3aaa91ec_db28ad99","line":52,"range":{"start_line":52,"start_character":50,"end_line":52,"end_character":60},"in_reply_to":"3aaa91ec_5f1b4273","updated":"2016-06-30 19:56:52.000000000","message":"Done","commit_id":"b498a8f513ad5b5b4988cf508fd4a23e5e515d4a"},{"author":{"_account_id":18339,"name":"Sivasathurappan Radhakrishnan","email":"siva.radhakrishnan@intel.com","username":"sivakrishnan"},"change_message_id":"9e9332aeb6e96102bdb44a69588d35a956f19129","unresolved":false,"context_lines":[{"line_number":49,"context_line":"vmwareapi_opts \u003d ["},{"line_number":50,"context_line":"    cfg.StrOpt(\u0027host_ip\u0027,"},{"line_number":51,"context_line":"               help\u003d\"\"\""},{"line_number":52,"context_line":"This options specifies hostname or IP address for connection"},{"line_number":53,"context_line":"to VMware vCenter host"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"Possible values:"}],"source_content_type":"text/x-python","patch_set":2,"id":"3aaa91ec_1b1d1573","line":52,"range":{"start_line":52,"start_character":23,"end_line":52,"end_character":31},"in_reply_to":"3aaa91ec_7f055e0f","updated":"2016-06-30 19:56:52.000000000","message":"Done","commit_id":"b498a8f513ad5b5b4988cf508fd4a23e5e515d4a"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"7c8c5d2a0aafe3047ec1697784f26d06ea5c951e","unresolved":false,"context_lines":[{"line_number":50,"context_line":"    cfg.StrOpt(\u0027host_ip\u0027,"},{"line_number":51,"context_line":"               help\u003d\"\"\""},{"line_number":52,"context_line":"This options specifies hostname or IP address for connection"},{"line_number":53,"context_line":"to VMware vCenter host"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"Possible values:"},{"line_number":56,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3aaa91ec_1f3c1ac7","line":53,"range":{"start_line":53,"start_character":18,"end_line":53,"end_character":22},"updated":"2016-06-29 20:59:01.000000000","message":"host.","commit_id":"b498a8f513ad5b5b4988cf508fd4a23e5e515d4a"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"7c8c5d2a0aafe3047ec1697784f26d06ea5c951e","unresolved":false,"context_lines":[{"line_number":50,"context_line":"    cfg.StrOpt(\u0027host_ip\u0027,"},{"line_number":51,"context_line":"               help\u003d\"\"\""},{"line_number":52,"context_line":"This options specifies hostname or IP address for connection"},{"line_number":53,"context_line":"to VMware vCenter host"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"Possible values:"},{"line_number":56,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3aaa91ec_9f276ab5","line":53,"range":{"start_line":53,"start_character":0,"end_line":53,"end_character":2},"updated":"2016-06-29 20:59:01.000000000","message":"to a","commit_id":"b498a8f513ad5b5b4988cf508fd4a23e5e515d4a"},{"author":{"_account_id":18339,"name":"Sivasathurappan Radhakrishnan","email":"siva.radhakrishnan@intel.com","username":"sivakrishnan"},"change_message_id":"9e9332aeb6e96102bdb44a69588d35a956f19129","unresolved":false,"context_lines":[{"line_number":50,"context_line":"    cfg.StrOpt(\u0027host_ip\u0027,"},{"line_number":51,"context_line":"               help\u003d\"\"\""},{"line_number":52,"context_line":"This options specifies hostname or IP address for connection"},{"line_number":53,"context_line":"to VMware vCenter host"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"Possible values:"},{"line_number":56,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3aaa91ec_7b109959","line":53,"range":{"start_line":53,"start_character":18,"end_line":53,"end_character":22},"in_reply_to":"3aaa91ec_1f3c1ac7","updated":"2016-06-30 19:56:52.000000000","message":"Done","commit_id":"b498a8f513ad5b5b4988cf508fd4a23e5e515d4a"},{"author":{"_account_id":18339,"name":"Sivasathurappan Radhakrishnan","email":"siva.radhakrishnan@intel.com","username":"sivakrishnan"},"change_message_id":"9e9332aeb6e96102bdb44a69588d35a956f19129","unresolved":false,"context_lines":[{"line_number":50,"context_line":"    cfg.StrOpt(\u0027host_ip\u0027,"},{"line_number":51,"context_line":"               help\u003d\"\"\""},{"line_number":52,"context_line":"This options specifies hostname or IP address for connection"},{"line_number":53,"context_line":"to VMware vCenter host"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"Possible values:"},{"line_number":56,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3aaa91ec_5b131d65","line":53,"range":{"start_line":53,"start_character":0,"end_line":53,"end_character":2},"in_reply_to":"3aaa91ec_9f276ab5","updated":"2016-06-30 19:56:52.000000000","message":"Done","commit_id":"b498a8f513ad5b5b4988cf508fd4a23e5e515d4a"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"c0b0058cf13939a5b8f3dab5d641cedc7bdd11bb","unresolved":false,"context_lines":[{"line_number":54,"context_line":""},{"line_number":55,"context_line":"Possible values:"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"    * None (default)"},{"line_number":58,"context_line":"    * Any valid IP address"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"Related options:"}],"source_content_type":"text/x-python","patch_set":2,"id":"3aaa91ec_460a738b","line":57,"updated":"2016-06-29 14:57:01.000000000","message":"Not sure this is a valid option. I think it is required if you want to use VMware. I think we should state this is required.\n\nI think we should add a note in the vmware group about what options are required if you want to use the vmware driver.","commit_id":"b498a8f513ad5b5b4988cf508fd4a23e5e515d4a"},{"author":{"_account_id":18339,"name":"Sivasathurappan Radhakrishnan","email":"siva.radhakrishnan@intel.com","username":"sivakrishnan"},"change_message_id":"9e9332aeb6e96102bdb44a69588d35a956f19129","unresolved":false,"context_lines":[{"line_number":54,"context_line":""},{"line_number":55,"context_line":"Possible values:"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"    * None (default)"},{"line_number":58,"context_line":"    * Any valid IP address"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"Related options:"}],"source_content_type":"text/x-python","patch_set":2,"id":"3aaa91ec_0db31c4e","line":57,"in_reply_to":"3aaa91ec_460a738b","updated":"2016-06-30 19:56:52.000000000","message":"In oslo.config, all type config options have default value None if\ndon\u0027t set parameter default. Since most of the options in this file didn\u0027t have default set, it shout take default as None. But I have removed the default as none as it doesn\u0027t make sense to add them if they are not going to work without these options set.\n\nI will put a follow up patch to add \"Required\u003dTrue\" to few options and notify you once it is done or you want me to add a note saying   these options are required. Please let me know your thoughts on this.","commit_id":"b498a8f513ad5b5b4988cf508fd4a23e5e515d4a"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"c0b0058cf13939a5b8f3dab5d641cedc7bdd11bb","unresolved":false,"context_lines":[{"line_number":55,"context_line":"Possible values:"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"    * None (default)"},{"line_number":58,"context_line":"    * Any valid IP address"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"Related options:"},{"line_number":61,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3aaa91ec_39a148f9","line":58,"range":{"start_line":58,"start_character":6,"end_line":58,"end_character":26},"updated":"2016-06-29 14:57:01.000000000","message":"actually, I think it is any valid IP or hostname?","commit_id":"b498a8f513ad5b5b4988cf508fd4a23e5e515d4a"},{"author":{"_account_id":18339,"name":"Sivasathurappan Radhakrishnan","email":"siva.radhakrishnan@intel.com","username":"sivakrishnan"},"change_message_id":"9e9332aeb6e96102bdb44a69588d35a956f19129","unresolved":false,"context_lines":[{"line_number":55,"context_line":"Possible values:"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"    * None (default)"},{"line_number":58,"context_line":"    * Any valid IP address"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"Related options:"},{"line_number":61,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3aaa91ec_ad7ac874","line":58,"range":{"start_line":58,"start_character":6,"end_line":58,"end_character":26},"in_reply_to":"3aaa91ec_39a148f9","updated":"2016-06-30 19:56:52.000000000","message":"Done","commit_id":"b498a8f513ad5b5b4988cf508fd4a23e5e515d4a"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"7c8c5d2a0aafe3047ec1697784f26d06ea5c951e","unresolved":false,"context_lines":[{"line_number":55,"context_line":"Possible values:"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"    * None (default)"},{"line_number":58,"context_line":"    * Any valid IP address"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"Related options:"},{"line_number":61,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3aaa91ec_c437694b","line":58,"range":{"start_line":58,"start_character":6,"end_line":58,"end_character":26},"in_reply_to":"3aaa91ec_39a148f9","updated":"2016-06-29 20:59:01.000000000","message":"correct. it can be both","commit_id":"b498a8f513ad5b5b4988cf508fd4a23e5e515d4a"},{"author":{"_account_id":18339,"name":"Sivasathurappan Radhakrishnan","email":"siva.radhakrishnan@intel.com","username":"sivakrishnan"},"change_message_id":"9e9332aeb6e96102bdb44a69588d35a956f19129","unresolved":false,"context_lines":[{"line_number":55,"context_line":"Possible values:"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"    * None (default)"},{"line_number":58,"context_line":"    * Any valid IP address"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"Related options:"},{"line_number":61,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3aaa91ec_8d7d4c6f","line":58,"range":{"start_line":58,"start_character":6,"end_line":58,"end_character":26},"in_reply_to":"3aaa91ec_c437694b","updated":"2016-06-30 19:56:52.000000000","message":"Done","commit_id":"b498a8f513ad5b5b4988cf508fd4a23e5e515d4a"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"7c8c5d2a0aafe3047ec1697784f26d06ea5c951e","unresolved":false,"context_lines":[{"line_number":66,"context_line":"    cfg.PortOpt(\u0027host_port\u0027,"},{"line_number":67,"context_line":"                default\u003d443,"},{"line_number":68,"context_line":"                help\u003d\"\"\""},{"line_number":69,"context_line":"This option specifies port for connection to VMware vCenter host"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"Possible values:"},{"line_number":72,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3aaa91ec_1f6a5ab3","line":69,"range":{"start_line":69,"start_character":27,"end_line":69,"end_character":30},"updated":"2016-06-29 20:59:01.000000000","message":"for the","commit_id":"b498a8f513ad5b5b4988cf508fd4a23e5e515d4a"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"7c8c5d2a0aafe3047ec1697784f26d06ea5c951e","unresolved":false,"context_lines":[{"line_number":66,"context_line":"    cfg.PortOpt(\u0027host_port\u0027,"},{"line_number":67,"context_line":"                default\u003d443,"},{"line_number":68,"context_line":"                help\u003d\"\"\""},{"line_number":69,"context_line":"This option specifies port for connection to VMware vCenter host"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"Possible values:"},{"line_number":72,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3aaa91ec_5f3222f3","line":69,"range":{"start_line":69,"start_character":60,"end_line":69,"end_character":64},"updated":"2016-06-29 20:59:01.000000000","message":"host.","commit_id":"b498a8f513ad5b5b4988cf508fd4a23e5e515d4a"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"7c8c5d2a0aafe3047ec1697784f26d06ea5c951e","unresolved":false,"context_lines":[{"line_number":66,"context_line":"    cfg.PortOpt(\u0027host_port\u0027,"},{"line_number":67,"context_line":"                default\u003d443,"},{"line_number":68,"context_line":"                help\u003d\"\"\""},{"line_number":69,"context_line":"This option specifies port for connection to VMware vCenter host"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"Possible values:"},{"line_number":72,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3aaa91ec_9f75aa99","line":69,"range":{"start_line":69,"start_character":22,"end_line":69,"end_character":26},"updated":"2016-06-29 20:59:01.000000000","message":"the port","commit_id":"b498a8f513ad5b5b4988cf508fd4a23e5e515d4a"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"7c8c5d2a0aafe3047ec1697784f26d06ea5c951e","unresolved":false,"context_lines":[{"line_number":66,"context_line":"    cfg.PortOpt(\u0027host_port\u0027,"},{"line_number":67,"context_line":"                default\u003d443,"},{"line_number":68,"context_line":"                help\u003d\"\"\""},{"line_number":69,"context_line":"This option specifies port for connection to VMware vCenter host"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"Possible values:"},{"line_number":72,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3aaa91ec_3f5d9615","line":69,"range":{"start_line":69,"start_character":42,"end_line":69,"end_character":44},"updated":"2016-06-29 20:59:01.000000000","message":"to the","commit_id":"b498a8f513ad5b5b4988cf508fd4a23e5e515d4a"},{"author":{"_account_id":18339,"name":"Sivasathurappan Radhakrishnan","email":"siva.radhakrishnan@intel.com","username":"sivakrishnan"},"change_message_id":"9e9332aeb6e96102bdb44a69588d35a956f19129","unresolved":false,"context_lines":[{"line_number":66,"context_line":"    cfg.PortOpt(\u0027host_port\u0027,"},{"line_number":67,"context_line":"                default\u003d443,"},{"line_number":68,"context_line":"                help\u003d\"\"\""},{"line_number":69,"context_line":"This option specifies port for connection to VMware vCenter host"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"Possible values:"},{"line_number":72,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3aaa91ec_2d8ff875","line":69,"range":{"start_line":69,"start_character":27,"end_line":69,"end_character":30},"in_reply_to":"3aaa91ec_1f6a5ab3","updated":"2016-06-30 19:56:52.000000000","message":"Done","commit_id":"b498a8f513ad5b5b4988cf508fd4a23e5e515d4a"},{"author":{"_account_id":18339,"name":"Sivasathurappan Radhakrishnan","email":"siva.radhakrishnan@intel.com","username":"sivakrishnan"},"change_message_id":"9e9332aeb6e96102bdb44a69588d35a956f19129","unresolved":false,"context_lines":[{"line_number":66,"context_line":"    cfg.PortOpt(\u0027host_port\u0027,"},{"line_number":67,"context_line":"                default\u003d443,"},{"line_number":68,"context_line":"                help\u003d\"\"\""},{"line_number":69,"context_line":"This option specifies port for connection to VMware vCenter host"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"Possible values:"},{"line_number":72,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3aaa91ec_0d8afc63","line":69,"range":{"start_line":69,"start_character":42,"end_line":69,"end_character":44},"in_reply_to":"3aaa91ec_3f5d9615","updated":"2016-06-30 19:56:52.000000000","message":"Done","commit_id":"b498a8f513ad5b5b4988cf508fd4a23e5e515d4a"},{"author":{"_account_id":18339,"name":"Sivasathurappan Radhakrishnan","email":"siva.radhakrishnan@intel.com","username":"sivakrishnan"},"change_message_id":"9e9332aeb6e96102bdb44a69588d35a956f19129","unresolved":false,"context_lines":[{"line_number":66,"context_line":"    cfg.PortOpt(\u0027host_port\u0027,"},{"line_number":67,"context_line":"                default\u003d443,"},{"line_number":68,"context_line":"                help\u003d\"\"\""},{"line_number":69,"context_line":"This option specifies port for connection to VMware vCenter host"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"Possible values:"},{"line_number":72,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3aaa91ec_6debc013","line":69,"range":{"start_line":69,"start_character":60,"end_line":69,"end_character":64},"in_reply_to":"3aaa91ec_5f3222f3","updated":"2016-06-30 19:56:52.000000000","message":"Done","commit_id":"b498a8f513ad5b5b4988cf508fd4a23e5e515d4a"},{"author":{"_account_id":18339,"name":"Sivasathurappan Radhakrishnan","email":"siva.radhakrishnan@intel.com","username":"sivakrishnan"},"change_message_id":"9e9332aeb6e96102bdb44a69588d35a956f19129","unresolved":false,"context_lines":[{"line_number":66,"context_line":"    cfg.PortOpt(\u0027host_port\u0027,"},{"line_number":67,"context_line":"                default\u003d443,"},{"line_number":68,"context_line":"                help\u003d\"\"\""},{"line_number":69,"context_line":"This option specifies port for connection to VMware vCenter host"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"Possible values:"},{"line_number":72,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3aaa91ec_4deec422","line":69,"range":{"start_line":69,"start_character":22,"end_line":69,"end_character":26},"in_reply_to":"3aaa91ec_9f75aa99","updated":"2016-06-30 19:56:52.000000000","message":"Done","commit_id":"b498a8f513ad5b5b4988cf508fd4a23e5e515d4a"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"c0b0058cf13939a5b8f3dab5d641cedc7bdd11bb","unresolved":false,"context_lines":[{"line_number":73,"context_line":"    * 443 (default)"},{"line_number":74,"context_line":"    * Valid port number"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"Related options:"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"    * compute_driver"},{"line_number":79,"context_line":"\"\"\"),"},{"line_number":80,"context_line":"    cfg.StrOpt(\u0027host_username\u0027,"},{"line_number":81,"context_line":"               help\u003d\"\"\""}],"source_content_type":"text/x-python","patch_set":2,"id":"3aaa91ec_f94fc031","line":78,"range":{"start_line":76,"start_character":0,"end_line":78,"end_character":20},"updated":"2016-06-29 14:57:01.000000000","message":"I think we should just add a note in the above help text for this option group, rather than put this everywhere.","commit_id":"b498a8f513ad5b5b4988cf508fd4a23e5e515d4a"},{"author":{"_account_id":18339,"name":"Sivasathurappan Radhakrishnan","email":"siva.radhakrishnan@intel.com","username":"sivakrishnan"},"change_message_id":"9e9332aeb6e96102bdb44a69588d35a956f19129","unresolved":false,"context_lines":[{"line_number":73,"context_line":"    * 443 (default)"},{"line_number":74,"context_line":"    * Valid port number"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"Related options:"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"    * compute_driver"},{"line_number":79,"context_line":"\"\"\"),"},{"line_number":80,"context_line":"    cfg.StrOpt(\u0027host_username\u0027,"},{"line_number":81,"context_line":"               help\u003d\"\"\""}],"source_content_type":"text/x-python","patch_set":2,"id":"3aaa91ec_8df42cf1","line":78,"range":{"start_line":76,"start_character":0,"end_line":78,"end_character":20},"in_reply_to":"3aaa91ec_f94fc031","updated":"2016-06-30 19:56:52.000000000","message":"Done","commit_id":"b498a8f513ad5b5b4988cf508fd4a23e5e515d4a"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"7c8c5d2a0aafe3047ec1697784f26d06ea5c951e","unresolved":false,"context_lines":[{"line_number":79,"context_line":"\"\"\"),"},{"line_number":80,"context_line":"    cfg.StrOpt(\u0027host_username\u0027,"},{"line_number":81,"context_line":"               help\u003d\"\"\""},{"line_number":82,"context_line":"Username for connection to VMware vCenter host"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"Possible values:"},{"line_number":85,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3aaa91ec_9f4e4a6d","line":82,"range":{"start_line":82,"start_character":42,"end_line":82,"end_character":46},"updated":"2016-06-29 20:59:01.000000000","message":"host.","commit_id":"b498a8f513ad5b5b4988cf508fd4a23e5e515d4a"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"7c8c5d2a0aafe3047ec1697784f26d06ea5c951e","unresolved":false,"context_lines":[{"line_number":79,"context_line":"\"\"\"),"},{"line_number":80,"context_line":"    cfg.StrOpt(\u0027host_username\u0027,"},{"line_number":81,"context_line":"               help\u003d\"\"\""},{"line_number":82,"context_line":"Username for connection to VMware vCenter host"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"Possible values:"},{"line_number":85,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3aaa91ec_1f437a43","line":82,"range":{"start_line":82,"start_character":13,"end_line":82,"end_character":23},"updated":"2016-06-29 20:59:01.000000000","message":"the connection","commit_id":"b498a8f513ad5b5b4988cf508fd4a23e5e515d4a"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"7c8c5d2a0aafe3047ec1697784f26d06ea5c951e","unresolved":false,"context_lines":[{"line_number":79,"context_line":"\"\"\"),"},{"line_number":80,"context_line":"    cfg.StrOpt(\u0027host_username\u0027,"},{"line_number":81,"context_line":"               help\u003d\"\"\""},{"line_number":82,"context_line":"Username for connection to VMware vCenter host"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"Possible values:"},{"line_number":85,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3aaa91ec_5f49825f","line":82,"range":{"start_line":82,"start_character":24,"end_line":82,"end_character":26},"updated":"2016-06-29 20:59:01.000000000","message":"to the","commit_id":"b498a8f513ad5b5b4988cf508fd4a23e5e515d4a"},{"author":{"_account_id":18339,"name":"Sivasathurappan Radhakrishnan","email":"siva.radhakrishnan@intel.com","username":"sivakrishnan"},"change_message_id":"9e9332aeb6e96102bdb44a69588d35a956f19129","unresolved":false,"context_lines":[{"line_number":79,"context_line":"\"\"\"),"},{"line_number":80,"context_line":"    cfg.StrOpt(\u0027host_username\u0027,"},{"line_number":81,"context_line":"               help\u003d\"\"\""},{"line_number":82,"context_line":"Username for connection to VMware vCenter host"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"Possible values:"},{"line_number":85,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3aaa91ec_eddfb066","line":82,"range":{"start_line":82,"start_character":13,"end_line":82,"end_character":23},"in_reply_to":"3aaa91ec_1f437a43","updated":"2016-06-30 19:56:52.000000000","message":"Done","commit_id":"b498a8f513ad5b5b4988cf508fd4a23e5e515d4a"},{"author":{"_account_id":18339,"name":"Sivasathurappan Radhakrishnan","email":"siva.radhakrishnan@intel.com","username":"sivakrishnan"},"change_message_id":"9e9332aeb6e96102bdb44a69588d35a956f19129","unresolved":false,"context_lines":[{"line_number":79,"context_line":"\"\"\"),"},{"line_number":80,"context_line":"    cfg.StrOpt(\u0027host_username\u0027,"},{"line_number":81,"context_line":"               help\u003d\"\"\""},{"line_number":82,"context_line":"Username for connection to VMware vCenter host"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"Possible values:"},{"line_number":85,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3aaa91ec_cddab477","line":82,"range":{"start_line":82,"start_character":24,"end_line":82,"end_character":26},"in_reply_to":"3aaa91ec_5f49825f","updated":"2016-06-30 19:56:52.000000000","message":"Done","commit_id":"b498a8f513ad5b5b4988cf508fd4a23e5e515d4a"},{"author":{"_account_id":18339,"name":"Sivasathurappan Radhakrishnan","email":"siva.radhakrishnan@intel.com","username":"sivakrishnan"},"change_message_id":"9e9332aeb6e96102bdb44a69588d35a956f19129","unresolved":false,"context_lines":[{"line_number":79,"context_line":"\"\"\"),"},{"line_number":80,"context_line":"    cfg.StrOpt(\u0027host_username\u0027,"},{"line_number":81,"context_line":"               help\u003d\"\"\""},{"line_number":82,"context_line":"Username for connection to VMware vCenter host"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"Possible values:"},{"line_number":85,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3aaa91ec_2de6d843","line":82,"range":{"start_line":82,"start_character":42,"end_line":82,"end_character":46},"in_reply_to":"3aaa91ec_9f4e4a6d","updated":"2016-06-30 19:56:52.000000000","message":"Done","commit_id":"b498a8f513ad5b5b4988cf508fd4a23e5e515d4a"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"7c8c5d2a0aafe3047ec1697784f26d06ea5c951e","unresolved":false,"context_lines":[{"line_number":83,"context_line":""},{"line_number":84,"context_line":"Possible values:"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"    * None (default)"},{"line_number":87,"context_line":"    * Any valid host username"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"Related options:"}],"source_content_type":"text/x-python","patch_set":2,"id":"3aaa91ec_e409c585","line":86,"updated":"2016-06-29 20:59:01.000000000","message":"None is not allowed","commit_id":"b498a8f513ad5b5b4988cf508fd4a23e5e515d4a"},{"author":{"_account_id":18339,"name":"Sivasathurappan Radhakrishnan","email":"siva.radhakrishnan@intel.com","username":"sivakrishnan"},"change_message_id":"9e9332aeb6e96102bdb44a69588d35a956f19129","unresolved":false,"context_lines":[{"line_number":83,"context_line":""},{"line_number":84,"context_line":"Possible values:"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"    * None (default)"},{"line_number":87,"context_line":"    * Any valid host username"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"Related options:"}],"source_content_type":"text/x-python","patch_set":2,"id":"3aaa91ec_0de15c2a","line":86,"in_reply_to":"3aaa91ec_e409c585","updated":"2016-06-30 19:56:52.000000000","message":"Done","commit_id":"b498a8f513ad5b5b4988cf508fd4a23e5e515d4a"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"c0b0058cf13939a5b8f3dab5d641cedc7bdd11bb","unresolved":false,"context_lines":[{"line_number":81,"context_line":"               help\u003d\"\"\""},{"line_number":82,"context_line":"Username for connection to VMware vCenter host"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"Possible values:"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"    * None (default)"},{"line_number":87,"context_line":"    * Any valid host username"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"Related options:"},{"line_number":90,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3aaa91ec_390b08d8","line":87,"range":{"start_line":84,"start_character":0,"end_line":87,"end_character":29},"updated":"2016-06-29 14:57:01.000000000","message":"not sure this makes sense? None is not a valid value here, its a required option, if you choose vmware.","commit_id":"b498a8f513ad5b5b4988cf508fd4a23e5e515d4a"},{"author":{"_account_id":18339,"name":"Sivasathurappan Radhakrishnan","email":"siva.radhakrishnan@intel.com","username":"sivakrishnan"},"change_message_id":"9e9332aeb6e96102bdb44a69588d35a956f19129","unresolved":false,"context_lines":[{"line_number":81,"context_line":"               help\u003d\"\"\""},{"line_number":82,"context_line":"Username for connection to VMware vCenter host"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"Possible values:"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"    * None (default)"},{"line_number":87,"context_line":"    * Any valid host username"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"Related options:"},{"line_number":90,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3aaa91ec_ed74d068","line":87,"range":{"start_line":84,"start_character":0,"end_line":87,"end_character":29},"in_reply_to":"3aaa91ec_390b08d8","updated":"2016-06-30 19:56:52.000000000","message":"Done","commit_id":"b498a8f513ad5b5b4988cf508fd4a23e5e515d4a"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"c0b0058cf13939a5b8f3dab5d641cedc7bdd11bb","unresolved":false,"context_lines":[{"line_number":88,"context_line":""},{"line_number":89,"context_line":"Related options:"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"    * compute_driver"},{"line_number":92,"context_line":"    * host_ip"},{"line_number":93,"context_line":"    * host_password"},{"line_number":94,"context_line":"\"\"\"),"},{"line_number":95,"context_line":"    cfg.StrOpt(\u0027host_password\u0027,"},{"line_number":96,"context_line":"               secret\u003dTrue,"}],"source_content_type":"text/x-python","patch_set":2,"id":"3aaa91ec_3932e8a7","line":93,"range":{"start_line":91,"start_character":0,"end_line":93,"end_character":19},"updated":"2016-06-29 14:57:01.000000000","message":"not sure we need this here","commit_id":"b498a8f513ad5b5b4988cf508fd4a23e5e515d4a"},{"author":{"_account_id":18339,"name":"Sivasathurappan Radhakrishnan","email":"siva.radhakrishnan@intel.com","username":"sivakrishnan"},"change_message_id":"9e9332aeb6e96102bdb44a69588d35a956f19129","unresolved":false,"context_lines":[{"line_number":88,"context_line":""},{"line_number":89,"context_line":"Related options:"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"    * compute_driver"},{"line_number":92,"context_line":"    * host_ip"},{"line_number":93,"context_line":"    * host_password"},{"line_number":94,"context_line":"\"\"\"),"},{"line_number":95,"context_line":"    cfg.StrOpt(\u0027host_password\u0027,"},{"line_number":96,"context_line":"               secret\u003dTrue,"}],"source_content_type":"text/x-python","patch_set":2,"id":"3aaa91ec_cd6f5490","line":93,"range":{"start_line":91,"start_character":0,"end_line":93,"end_character":19},"in_reply_to":"3aaa91ec_3932e8a7","updated":"2016-06-30 19:56:52.000000000","message":"Done","commit_id":"b498a8f513ad5b5b4988cf508fd4a23e5e515d4a"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"c0b0058cf13939a5b8f3dab5d641cedc7bdd11bb","unresolved":false,"context_lines":[{"line_number":99,"context_line":""},{"line_number":100,"context_line":"Possible values:"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"    * None (default)"},{"line_number":103,"context_line":"    * Any valid string"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"Related options:"}],"source_content_type":"text/x-python","patch_set":2,"id":"3aaa91ec_b91ed809","line":102,"range":{"start_line":102,"start_character":5,"end_line":102,"end_character":20},"updated":"2016-06-29 14:57:01.000000000","message":"as username","commit_id":"b498a8f513ad5b5b4988cf508fd4a23e5e515d4a"},{"author":{"_account_id":18339,"name":"Sivasathurappan Radhakrishnan","email":"siva.radhakrishnan@intel.com","username":"sivakrishnan"},"change_message_id":"9e9332aeb6e96102bdb44a69588d35a956f19129","unresolved":false,"context_lines":[{"line_number":99,"context_line":""},{"line_number":100,"context_line":"Possible values:"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"    * None (default)"},{"line_number":103,"context_line":"    * Any valid string"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"Related options:"}],"source_content_type":"text/x-python","patch_set":2,"id":"3aaa91ec_2d6b7886","line":102,"range":{"start_line":102,"start_character":5,"end_line":102,"end_character":20},"in_reply_to":"3aaa91ec_b91ed809","updated":"2016-06-30 19:56:52.000000000","message":"Done","commit_id":"b498a8f513ad5b5b4988cf508fd4a23e5e515d4a"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"c0b0058cf13939a5b8f3dab5d641cedc7bdd11bb","unresolved":false,"context_lines":[{"line_number":115,"context_line":""},{"line_number":116,"context_line":"Possible values:"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"    * None (default)"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"Related options:"},{"line_number":121,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3aaa91ec_1901ecaf","line":118,"range":{"start_line":118,"start_character":0,"end_line":118,"end_character":20},"updated":"2016-06-29 14:57:01.000000000","message":"what does None mean here, is that allowed?","commit_id":"b498a8f513ad5b5b4988cf508fd4a23e5e515d4a"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"7c8c5d2a0aafe3047ec1697784f26d06ea5c951e","unresolved":false,"context_lines":[{"line_number":115,"context_line":""},{"line_number":116,"context_line":"Possible values:"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"    * None (default)"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"Related options:"},{"line_number":121,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3aaa91ec_a47a1def","line":118,"range":{"start_line":118,"start_character":0,"end_line":118,"end_character":20},"in_reply_to":"3aaa91ec_1901ecaf","updated":"2016-06-29 20:59:01.000000000","message":"None - indicates it will use the system wide trust store for the CA bundle.","commit_id":"b498a8f513ad5b5b4988cf508fd4a23e5e515d4a"},{"author":{"_account_id":18339,"name":"Sivasathurappan Radhakrishnan","email":"siva.radhakrishnan@intel.com","username":"sivakrishnan"},"change_message_id":"9e9332aeb6e96102bdb44a69588d35a956f19129","unresolved":false,"context_lines":[{"line_number":115,"context_line":""},{"line_number":116,"context_line":"Possible values:"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"    * None (default)"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"Related options:"},{"line_number":121,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3aaa91ec_0d667cba","line":118,"range":{"start_line":118,"start_character":0,"end_line":118,"end_character":20},"in_reply_to":"3aaa91ec_a47a1def","updated":"2016-06-30 19:56:52.000000000","message":"Done","commit_id":"b498a8f513ad5b5b4988cf508fd4a23e5e515d4a"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"7c8c5d2a0aafe3047ec1697784f26d06ea5c951e","unresolved":false,"context_lines":[{"line_number":140,"context_line":"\"\"\"),"},{"line_number":141,"context_line":"    cfg.StrOpt(\u0027cluster_name\u0027,"},{"line_number":142,"context_line":"               help\u003d\"\"\""},{"line_number":143,"context_line":"This option specifies name of a VMware Cluster ComputeResource."},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"Possible values:"},{"line_number":146,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3aaa91ec_df79f283","line":143,"range":{"start_line":143,"start_character":22,"end_line":143,"end_character":26},"updated":"2016-06-29 20:59:01.000000000","message":"the name","commit_id":"b498a8f513ad5b5b4988cf508fd4a23e5e515d4a"},{"author":{"_account_id":18339,"name":"Sivasathurappan Radhakrishnan","email":"siva.radhakrishnan@intel.com","username":"sivakrishnan"},"change_message_id":"9e9332aeb6e96102bdb44a69588d35a956f19129","unresolved":false,"context_lines":[{"line_number":140,"context_line":"\"\"\"),"},{"line_number":141,"context_line":"    cfg.StrOpt(\u0027cluster_name\u0027,"},{"line_number":142,"context_line":"               help\u003d\"\"\""},{"line_number":143,"context_line":"This option specifies name of a VMware Cluster ComputeResource."},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"Possible values:"},{"line_number":146,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3aaa91ec_6d0740ca","line":143,"range":{"start_line":143,"start_character":22,"end_line":143,"end_character":26},"in_reply_to":"3aaa91ec_df79f283","updated":"2016-06-30 19:56:52.000000000","message":"Done","commit_id":"b498a8f513ad5b5b4988cf508fd4a23e5e515d4a"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"c0b0058cf13939a5b8f3dab5d641cedc7bdd11bb","unresolved":false,"context_lines":[{"line_number":144,"context_line":""},{"line_number":145,"context_line":"Possible values:"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"    * None (default)"},{"line_number":148,"context_line":"    * Any valid vCenter cluster name"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"Related options:"}],"source_content_type":"text/x-python","patch_set":2,"id":"3aaa91ec_f999807a","line":147,"updated":"2016-06-29 14:57:01.000000000","message":"is that valid?","commit_id":"b498a8f513ad5b5b4988cf508fd4a23e5e515d4a"},{"author":{"_account_id":18339,"name":"Sivasathurappan Radhakrishnan","email":"siva.radhakrishnan@intel.com","username":"sivakrishnan"},"change_message_id":"9e9332aeb6e96102bdb44a69588d35a956f19129","unresolved":false,"context_lines":[{"line_number":144,"context_line":""},{"line_number":145,"context_line":"Possible values:"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"    * None (default)"},{"line_number":148,"context_line":"    * Any valid vCenter cluster name"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"Related options:"}],"source_content_type":"text/x-python","patch_set":2,"id":"3aaa91ec_8d10ac01","line":147,"in_reply_to":"3aaa91ec_a4617d3b","updated":"2016-06-30 19:56:52.000000000","message":"Done","commit_id":"b498a8f513ad5b5b4988cf508fd4a23e5e515d4a"},{"author":{"_account_id":18339,"name":"Sivasathurappan Radhakrishnan","email":"siva.radhakrishnan@intel.com","username":"sivakrishnan"},"change_message_id":"9e9332aeb6e96102bdb44a69588d35a956f19129","unresolved":false,"context_lines":[{"line_number":144,"context_line":""},{"line_number":145,"context_line":"Possible values:"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"    * None (default)"},{"line_number":148,"context_line":"    * Any valid vCenter cluster name"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"Related options:"}],"source_content_type":"text/x-python","patch_set":2,"id":"3aaa91ec_4d0a44d3","line":147,"in_reply_to":"3aaa91ec_f999807a","updated":"2016-06-30 19:56:52.000000000","message":"Done","commit_id":"b498a8f513ad5b5b4988cf508fd4a23e5e515d4a"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"7c8c5d2a0aafe3047ec1697784f26d06ea5c951e","unresolved":false,"context_lines":[{"line_number":144,"context_line":""},{"line_number":145,"context_line":"Possible values:"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"    * None (default)"},{"line_number":148,"context_line":"    * Any valid vCenter cluster name"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"Related options:"}],"source_content_type":"text/x-python","patch_set":2,"id":"3aaa91ec_a4617d3b","line":147,"in_reply_to":"3aaa91ec_f999807a","updated":"2016-06-29 20:59:01.000000000","message":"No its not. Must have a cluster_name","commit_id":"b498a8f513ad5b5b4988cf508fd4a23e5e515d4a"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"c0b0058cf13939a5b8f3dab5d641cedc7bdd11bb","unresolved":false,"context_lines":[{"line_number":158,"context_line":""},{"line_number":159,"context_line":"Possible values:"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"    * None (default)"},{"line_number":162,"context_line":"    * Any valid regular expression such as \"nas.*\""},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"Related options:"}],"source_content_type":"text/x-python","patch_set":2,"id":"3aaa91ec_f9706042","line":161,"updated":"2016-06-29 14:57:01.000000000","message":"is that a valid value? what happens in that case?","commit_id":"b498a8f513ad5b5b4988cf508fd4a23e5e515d4a"},{"author":{"_account_id":18339,"name":"Sivasathurappan Radhakrishnan","email":"siva.radhakrishnan@intel.com","username":"sivakrishnan"},"change_message_id":"9e9332aeb6e96102bdb44a69588d35a956f19129","unresolved":false,"context_lines":[{"line_number":158,"context_line":""},{"line_number":159,"context_line":"Possible values:"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"    * None (default)"},{"line_number":162,"context_line":"    * Any valid regular expression such as \"nas.*\""},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"Related options:"}],"source_content_type":"text/x-python","patch_set":2,"id":"3aaa91ec_cdf634d6","line":161,"in_reply_to":"3aaa91ec_24562d5c","updated":"2016-06-30 19:56:52.000000000","message":"Done","commit_id":"b498a8f513ad5b5b4988cf508fd4a23e5e515d4a"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"7c8c5d2a0aafe3047ec1697784f26d06ea5c951e","unresolved":false,"context_lines":[{"line_number":158,"context_line":""},{"line_number":159,"context_line":"Possible values:"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"    * None (default)"},{"line_number":162,"context_line":"    * Any valid regular expression such as \"nas.*\""},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"Related options:"}],"source_content_type":"text/x-python","patch_set":2,"id":"3aaa91ec_24562d5c","line":161,"in_reply_to":"3aaa91ec_f9706042","updated":"2016-06-29 20:59:01.000000000","message":"a matching regex to a datastore must be given","commit_id":"b498a8f513ad5b5b4988cf508fd4a23e5e515d4a"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"c0b0058cf13939a5b8f3dab5d641cedc7bdd11bb","unresolved":false,"context_lines":[{"line_number":172,"context_line":""},{"line_number":173,"context_line":"Possible values:"},{"line_number":174,"context_line":""},{"line_number":175,"context_line":"    * 0.5 (default)"},{"line_number":176,"context_line":"    * Any positive value in seconds."},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"Related options:"}],"source_content_type":"text/x-python","patch_set":2,"id":"3aaa91ec_19d9ec22","line":175,"range":{"start_line":175,"start_character":6,"end_line":175,"end_character":9},"updated":"2016-06-29 14:57:01.000000000","message":"Nit: maybe add seconds here?","commit_id":"b498a8f513ad5b5b4988cf508fd4a23e5e515d4a"},{"author":{"_account_id":18339,"name":"Sivasathurappan Radhakrishnan","email":"siva.radhakrishnan@intel.com","username":"sivakrishnan"},"change_message_id":"9e9332aeb6e96102bdb44a69588d35a956f19129","unresolved":false,"context_lines":[{"line_number":172,"context_line":""},{"line_number":173,"context_line":"Possible values:"},{"line_number":174,"context_line":""},{"line_number":175,"context_line":"    * 0.5 (default)"},{"line_number":176,"context_line":"    * Any positive value in seconds."},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"Related options:"}],"source_content_type":"text/x-python","patch_set":2,"id":"3aaa91ec_2d0258b4","line":175,"range":{"start_line":175,"start_character":6,"end_line":175,"end_character":9},"in_reply_to":"3aaa91ec_19d9ec22","updated":"2016-06-30 19:56:52.000000000","message":"Done","commit_id":"b498a8f513ad5b5b4988cf508fd4a23e5e515d4a"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"7c8c5d2a0aafe3047ec1697784f26d06ea5c951e","unresolved":false,"context_lines":[{"line_number":182,"context_line":"    cfg.IntOpt(\u0027api_retry_count\u0027,"},{"line_number":183,"context_line":"               default\u003d10,"},{"line_number":184,"context_line":"               help\u003d\"\"\""},{"line_number":185,"context_line":"This option specifies number of attempts to retry on failures,"},{"line_number":186,"context_line":"e.g. socket error, etc."},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"Possible values:"}],"source_content_type":"text/x-python","patch_set":2,"id":"3aaa91ec_ff94ae8b","line":185,"range":{"start_line":185,"start_character":22,"end_line":185,"end_character":28},"updated":"2016-06-29 20:59:01.000000000","message":"the number","commit_id":"b498a8f513ad5b5b4988cf508fd4a23e5e515d4a"},{"author":{"_account_id":18339,"name":"Sivasathurappan Radhakrishnan","email":"siva.radhakrishnan@intel.com","username":"sivakrishnan"},"change_message_id":"9e9332aeb6e96102bdb44a69588d35a956f19129","unresolved":false,"context_lines":[{"line_number":182,"context_line":"    cfg.IntOpt(\u0027api_retry_count\u0027,"},{"line_number":183,"context_line":"               default\u003d10,"},{"line_number":184,"context_line":"               help\u003d\"\"\""},{"line_number":185,"context_line":"This option specifies number of attempts to retry on failures,"},{"line_number":186,"context_line":"e.g. socket error, etc."},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"Possible values:"}],"source_content_type":"text/x-python","patch_set":2,"id":"3aaa91ec_0dfddcb0","line":185,"range":{"start_line":185,"start_character":22,"end_line":185,"end_character":28},"in_reply_to":"3aaa91ec_ff94ae8b","updated":"2016-06-30 19:56:52.000000000","message":"Done","commit_id":"b498a8f513ad5b5b4988cf508fd4a23e5e515d4a"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"7c8c5d2a0aafe3047ec1697784f26d06ea5c951e","unresolved":false,"context_lines":[{"line_number":197,"context_line":"    cfg.PortOpt(\u0027vnc_port\u0027,"},{"line_number":198,"context_line":"                default\u003d5900,"},{"line_number":199,"context_line":"                help\u003d\"\"\""},{"line_number":200,"context_line":"This option specifies VNC starting port"},{"line_number":201,"context_line":""},{"line_number":202,"context_line":"Possible values:"},{"line_number":203,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3aaa91ec_9feaca0d","line":200,"range":{"start_line":200,"start_character":35,"end_line":200,"end_character":39},"updated":"2016-06-29 20:59:01.000000000","message":"port.","commit_id":"b498a8f513ad5b5b4988cf508fd4a23e5e515d4a"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"7c8c5d2a0aafe3047ec1697784f26d06ea5c951e","unresolved":false,"context_lines":[{"line_number":197,"context_line":"    cfg.PortOpt(\u0027vnc_port\u0027,"},{"line_number":198,"context_line":"                default\u003d5900,"},{"line_number":199,"context_line":"                help\u003d\"\"\""},{"line_number":200,"context_line":"This option specifies VNC starting port"},{"line_number":201,"context_line":""},{"line_number":202,"context_line":"Possible values:"},{"line_number":203,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3aaa91ec_3f8bd669","line":200,"range":{"start_line":200,"start_character":22,"end_line":200,"end_character":25},"updated":"2016-06-29 20:59:01.000000000","message":"the VNC","commit_id":"b498a8f513ad5b5b4988cf508fd4a23e5e515d4a"},{"author":{"_account_id":18339,"name":"Sivasathurappan Radhakrishnan","email":"siva.radhakrishnan@intel.com","username":"sivakrishnan"},"change_message_id":"9e9332aeb6e96102bdb44a69588d35a956f19129","unresolved":false,"context_lines":[{"line_number":197,"context_line":"    cfg.PortOpt(\u0027vnc_port\u0027,"},{"line_number":198,"context_line":"                default\u003d5900,"},{"line_number":199,"context_line":"                help\u003d\"\"\""},{"line_number":200,"context_line":"This option specifies VNC starting port"},{"line_number":201,"context_line":""},{"line_number":202,"context_line":"Possible values:"},{"line_number":203,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3aaa91ec_4d31a4a1","line":200,"range":{"start_line":200,"start_character":22,"end_line":200,"end_character":25},"in_reply_to":"3aaa91ec_3f8bd669","updated":"2016-06-30 19:56:52.000000000","message":"Done","commit_id":"b498a8f513ad5b5b4988cf508fd4a23e5e515d4a"},{"author":{"_account_id":18339,"name":"Sivasathurappan Radhakrishnan","email":"siva.radhakrishnan@intel.com","username":"sivakrishnan"},"change_message_id":"9e9332aeb6e96102bdb44a69588d35a956f19129","unresolved":false,"context_lines":[{"line_number":197,"context_line":"    cfg.PortOpt(\u0027vnc_port\u0027,"},{"line_number":198,"context_line":"                default\u003d5900,"},{"line_number":199,"context_line":"                help\u003d\"\"\""},{"line_number":200,"context_line":"This option specifies VNC starting port"},{"line_number":201,"context_line":""},{"line_number":202,"context_line":"Possible values:"},{"line_number":203,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3aaa91ec_ed221051","line":200,"range":{"start_line":200,"start_character":35,"end_line":200,"end_character":39},"in_reply_to":"3aaa91ec_9feaca0d","updated":"2016-06-30 19:56:52.000000000","message":"Done","commit_id":"b498a8f513ad5b5b4988cf508fd4a23e5e515d4a"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"7c8c5d2a0aafe3047ec1697784f26d06ea5c951e","unresolved":false,"context_lines":[{"line_number":202,"context_line":"Possible values:"},{"line_number":203,"context_line":""},{"line_number":204,"context_line":"    * 5900 (default)"},{"line_number":205,"context_line":"    * Any valid port number"},{"line_number":206,"context_line":""},{"line_number":207,"context_line":"Related options:"},{"line_number":208,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3aaa91ec_040b312b","line":205,"range":{"start_line":205,"start_character":6,"end_line":205,"end_character":27},"updated":"2016-06-29 20:59:01.000000000","message":"Valid starting port number would be (65535 - vnc_port_total)","commit_id":"b498a8f513ad5b5b4988cf508fd4a23e5e515d4a"},{"author":{"_account_id":18339,"name":"Sivasathurappan Radhakrishnan","email":"siva.radhakrishnan@intel.com","username":"sivakrishnan"},"change_message_id":"9e9332aeb6e96102bdb44a69588d35a956f19129","unresolved":false,"context_lines":[{"line_number":202,"context_line":"Possible values:"},{"line_number":203,"context_line":""},{"line_number":204,"context_line":"    * 5900 (default)"},{"line_number":205,"context_line":"    * Any valid port number"},{"line_number":206,"context_line":""},{"line_number":207,"context_line":"Related options:"},{"line_number":208,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3aaa91ec_6dd5801a","line":205,"range":{"start_line":205,"start_character":6,"end_line":205,"end_character":27},"in_reply_to":"3aaa91ec_040b312b","updated":"2016-06-30 19:56:52.000000000","message":"Done","commit_id":"b498a8f513ad5b5b4988cf508fd4a23e5e515d4a"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"c0b0058cf13939a5b8f3dab5d641cedc7bdd11bb","unresolved":false,"context_lines":[{"line_number":204,"context_line":"    * 5900 (default)"},{"line_number":205,"context_line":"    * Any valid port number"},{"line_number":206,"context_line":""},{"line_number":207,"context_line":"Related options:"},{"line_number":208,"context_line":""},{"line_number":209,"context_line":"    * None"},{"line_number":210,"context_line":"\"\"\"),"},{"line_number":211,"context_line":"    cfg.IntOpt(\u0027vnc_port_total\u0027,"},{"line_number":212,"context_line":"               default\u003d10000,"}],"source_content_type":"text/x-python","patch_set":2,"id":"3aaa91ec_99fb1c7b","line":209,"range":{"start_line":207,"start_character":0,"end_line":209,"end_character":10},"updated":"2016-06-29 14:57:01.000000000","message":"we can drop this now?","commit_id":"b498a8f513ad5b5b4988cf508fd4a23e5e515d4a"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"7c8c5d2a0aafe3047ec1697784f26d06ea5c951e","unresolved":false,"context_lines":[{"line_number":226,"context_line":"                help\u003d\"\"\""},{"line_number":227,"context_line":"This option enables/disables use of linked clone."},{"line_number":228,"context_line":""},{"line_number":229,"context_line":"ESX hypervisor requires a copy of the VMDK file in order to boot up"},{"line_number":230,"context_line":"a virtual machine.Compute driver must download the VMDK via HTTP"},{"line_number":231,"context_line":"from the OpenStack Image service to a data store that is visible to"},{"line_number":232,"context_line":"the hypervisor and caches it. Subsequent virtual machines that need"}],"source_content_type":"text/x-python","patch_set":2,"id":"3aaa91ec_047691d6","line":229,"range":{"start_line":229,"start_character":0,"end_line":229,"end_character":3},"updated":"2016-06-29 20:59:01.000000000","message":"The ESX","commit_id":"b498a8f513ad5b5b4988cf508fd4a23e5e515d4a"},{"author":{"_account_id":18339,"name":"Sivasathurappan Radhakrishnan","email":"siva.radhakrishnan@intel.com","username":"sivakrishnan"},"change_message_id":"9e9332aeb6e96102bdb44a69588d35a956f19129","unresolved":false,"context_lines":[{"line_number":226,"context_line":"                help\u003d\"\"\""},{"line_number":227,"context_line":"This option enables/disables use of linked clone."},{"line_number":228,"context_line":""},{"line_number":229,"context_line":"ESX hypervisor requires a copy of the VMDK file in order to boot up"},{"line_number":230,"context_line":"a virtual machine.Compute driver must download the VMDK via HTTP"},{"line_number":231,"context_line":"from the OpenStack Image service to a data store that is visible to"},{"line_number":232,"context_line":"the hypervisor and caches it. Subsequent virtual machines that need"}],"source_content_type":"text/x-python","patch_set":2,"id":"3aaa91ec_4dd88453","line":229,"range":{"start_line":229,"start_character":0,"end_line":229,"end_character":3},"in_reply_to":"3aaa91ec_047691d6","updated":"2016-06-30 19:56:52.000000000","message":"Done","commit_id":"b498a8f513ad5b5b4988cf508fd4a23e5e515d4a"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"7c8c5d2a0aafe3047ec1697784f26d06ea5c951e","unresolved":false,"context_lines":[{"line_number":227,"context_line":"This option enables/disables use of linked clone."},{"line_number":228,"context_line":""},{"line_number":229,"context_line":"ESX hypervisor requires a copy of the VMDK file in order to boot up"},{"line_number":230,"context_line":"a virtual machine.Compute driver must download the VMDK via HTTP"},{"line_number":231,"context_line":"from the OpenStack Image service to a data store that is visible to"},{"line_number":232,"context_line":"the hypervisor and caches it. Subsequent virtual machines that need"},{"line_number":233,"context_line":"the VMDK use the cached versionand don\u0027t have to copy the file again"}],"source_content_type":"text/x-python","patch_set":2,"id":"3aaa91ec_a44b3d86","line":230,"range":{"start_line":230,"start_character":18,"end_line":230,"end_character":19},"updated":"2016-06-29 20:59:01.000000000","message":"Add space after period","commit_id":"b498a8f513ad5b5b4988cf508fd4a23e5e515d4a"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"7c8c5d2a0aafe3047ec1697784f26d06ea5c951e","unresolved":false,"context_lines":[{"line_number":227,"context_line":"This option enables/disables use of linked clone."},{"line_number":228,"context_line":""},{"line_number":229,"context_line":"ESX hypervisor requires a copy of the VMDK file in order to boot up"},{"line_number":230,"context_line":"a virtual machine.Compute driver must download the VMDK via HTTP"},{"line_number":231,"context_line":"from the OpenStack Image service to a data store that is visible to"},{"line_number":232,"context_line":"the hypervisor and caches it. Subsequent virtual machines that need"},{"line_number":233,"context_line":"the VMDK use the cached versionand don\u0027t have to copy the file again"}],"source_content_type":"text/x-python","patch_set":2,"id":"3aaa91ec_e441c564","line":230,"range":{"start_line":230,"start_character":18,"end_line":230,"end_character":25},"updated":"2016-06-29 20:59:01.000000000","message":"The compute driver","commit_id":"b498a8f513ad5b5b4988cf508fd4a23e5e515d4a"},{"author":{"_account_id":18339,"name":"Sivasathurappan Radhakrishnan","email":"siva.radhakrishnan@intel.com","username":"sivakrishnan"},"change_message_id":"9e9332aeb6e96102bdb44a69588d35a956f19129","unresolved":false,"context_lines":[{"line_number":227,"context_line":"This option enables/disables use of linked clone."},{"line_number":228,"context_line":""},{"line_number":229,"context_line":"ESX hypervisor requires a copy of the VMDK file in order to boot up"},{"line_number":230,"context_line":"a virtual machine.Compute driver must download the VMDK via HTTP"},{"line_number":231,"context_line":"from the OpenStack Image service to a data store that is visible to"},{"line_number":232,"context_line":"the hypervisor and caches it. Subsequent virtual machines that need"},{"line_number":233,"context_line":"the VMDK use the cached versionand don\u0027t have to copy the file again"}],"source_content_type":"text/x-python","patch_set":2,"id":"3aaa91ec_8ddeec3b","line":230,"range":{"start_line":230,"start_character":18,"end_line":230,"end_character":19},"in_reply_to":"3aaa91ec_a44b3d86","updated":"2016-06-30 19:56:52.000000000","message":"Done","commit_id":"b498a8f513ad5b5b4988cf508fd4a23e5e515d4a"},{"author":{"_account_id":18339,"name":"Sivasathurappan Radhakrishnan","email":"siva.radhakrishnan@intel.com","username":"sivakrishnan"},"change_message_id":"9e9332aeb6e96102bdb44a69588d35a956f19129","unresolved":false,"context_lines":[{"line_number":227,"context_line":"This option enables/disables use of linked clone."},{"line_number":228,"context_line":""},{"line_number":229,"context_line":"ESX hypervisor requires a copy of the VMDK file in order to boot up"},{"line_number":230,"context_line":"a virtual machine.Compute driver must download the VMDK via HTTP"},{"line_number":231,"context_line":"from the OpenStack Image service to a data store that is visible to"},{"line_number":232,"context_line":"the hypervisor and caches it. Subsequent virtual machines that need"},{"line_number":233,"context_line":"the VMDK use the cached versionand don\u0027t have to copy the file again"}],"source_content_type":"text/x-python","patch_set":2,"id":"3aaa91ec_cde4740e","line":230,"range":{"start_line":230,"start_character":18,"end_line":230,"end_character":25},"in_reply_to":"3aaa91ec_e441c564","updated":"2016-06-30 19:56:52.000000000","message":"Done","commit_id":"b498a8f513ad5b5b4988cf508fd4a23e5e515d4a"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"7c8c5d2a0aafe3047ec1697784f26d06ea5c951e","unresolved":false,"context_lines":[{"line_number":229,"context_line":"ESX hypervisor requires a copy of the VMDK file in order to boot up"},{"line_number":230,"context_line":"a virtual machine.Compute driver must download the VMDK via HTTP"},{"line_number":231,"context_line":"from the OpenStack Image service to a data store that is visible to"},{"line_number":232,"context_line":"the hypervisor and caches it. Subsequent virtual machines that need"},{"line_number":233,"context_line":"the VMDK use the cached versionand don\u0027t have to copy the file again"},{"line_number":234,"context_line":"from the OpenStack Image service."},{"line_number":235,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3aaa91ec_e438a5f0","line":232,"range":{"start_line":232,"start_character":19,"end_line":232,"end_character":25},"updated":"2016-06-29 20:59:01.000000000","message":"cache","commit_id":"b498a8f513ad5b5b4988cf508fd4a23e5e515d4a"},{"author":{"_account_id":18339,"name":"Sivasathurappan Radhakrishnan","email":"siva.radhakrishnan@intel.com","username":"sivakrishnan"},"change_message_id":"9e9332aeb6e96102bdb44a69588d35a956f19129","unresolved":false,"context_lines":[{"line_number":229,"context_line":"ESX hypervisor requires a copy of the VMDK file in order to boot up"},{"line_number":230,"context_line":"a virtual machine.Compute driver must download the VMDK via HTTP"},{"line_number":231,"context_line":"from the OpenStack Image service to a data store that is visible to"},{"line_number":232,"context_line":"the hypervisor and caches it. Subsequent virtual machines that need"},{"line_number":233,"context_line":"the VMDK use the cached versionand don\u0027t have to copy the file again"},{"line_number":234,"context_line":"from the OpenStack Image service."},{"line_number":235,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3aaa91ec_2df098c8","line":232,"range":{"start_line":232,"start_character":19,"end_line":232,"end_character":25},"in_reply_to":"3aaa91ec_e438a5f0","updated":"2016-06-30 19:56:52.000000000","message":"Done","commit_id":"b498a8f513ad5b5b4988cf508fd4a23e5e515d4a"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"7c8c5d2a0aafe3047ec1697784f26d06ea5c951e","unresolved":false,"context_lines":[{"line_number":230,"context_line":"a virtual machine.Compute driver must download the VMDK via HTTP"},{"line_number":231,"context_line":"from the OpenStack Image service to a data store that is visible to"},{"line_number":232,"context_line":"the hypervisor and caches it. Subsequent virtual machines that need"},{"line_number":233,"context_line":"the VMDK use the cached versionand don\u0027t have to copy the file again"},{"line_number":234,"context_line":"from the OpenStack Image service."},{"line_number":235,"context_line":""},{"line_number":236,"context_line":"If set to false, even with a cached VMDK, there is still a copy"}],"source_content_type":"text/x-python","patch_set":2,"id":"3aaa91ec_442a5991","line":233,"range":{"start_line":233,"start_character":49,"end_line":233,"end_character":53},"updated":"2016-06-29 20:59:01.000000000","message":"s/copy/access","commit_id":"b498a8f513ad5b5b4988cf508fd4a23e5e515d4a"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"7c8c5d2a0aafe3047ec1697784f26d06ea5c951e","unresolved":false,"context_lines":[{"line_number":230,"context_line":"a virtual machine.Compute driver must download the VMDK via HTTP"},{"line_number":231,"context_line":"from the OpenStack Image service to a data store that is visible to"},{"line_number":232,"context_line":"the hypervisor and caches it. Subsequent virtual machines that need"},{"line_number":233,"context_line":"the VMDK use the cached versionand don\u0027t have to copy the file again"},{"line_number":234,"context_line":"from the OpenStack Image service."},{"line_number":235,"context_line":""},{"line_number":236,"context_line":"If set to false, even with a cached VMDK, there is still a copy"}],"source_content_type":"text/x-python","patch_set":2,"id":"3aaa91ec_24274dcb","line":233,"range":{"start_line":233,"start_character":24,"end_line":233,"end_character":34},"updated":"2016-06-29 20:59:01.000000000","message":"version and","commit_id":"b498a8f513ad5b5b4988cf508fd4a23e5e515d4a"},{"author":{"_account_id":18339,"name":"Sivasathurappan Radhakrishnan","email":"siva.radhakrishnan@intel.com","username":"sivakrishnan"},"change_message_id":"9e9332aeb6e96102bdb44a69588d35a956f19129","unresolved":false,"context_lines":[{"line_number":230,"context_line":"a virtual machine.Compute driver must download the VMDK via HTTP"},{"line_number":231,"context_line":"from the OpenStack Image service to a data store that is visible to"},{"line_number":232,"context_line":"the hypervisor and caches it. Subsequent virtual machines that need"},{"line_number":233,"context_line":"the VMDK use the cached versionand don\u0027t have to copy the file again"},{"line_number":234,"context_line":"from the OpenStack Image service."},{"line_number":235,"context_line":""},{"line_number":236,"context_line":"If set to false, even with a cached VMDK, there is still a copy"}],"source_content_type":"text/x-python","patch_set":2,"id":"3aaa91ec_6dbc60dc","line":233,"range":{"start_line":233,"start_character":24,"end_line":233,"end_character":34},"in_reply_to":"3aaa91ec_24274dcb","updated":"2016-06-30 19:56:52.000000000","message":"Done","commit_id":"b498a8f513ad5b5b4988cf508fd4a23e5e515d4a"},{"author":{"_account_id":18339,"name":"Sivasathurappan Radhakrishnan","email":"siva.radhakrishnan@intel.com","username":"sivakrishnan"},"change_message_id":"9e9332aeb6e96102bdb44a69588d35a956f19129","unresolved":false,"context_lines":[{"line_number":230,"context_line":"a virtual machine.Compute driver must download the VMDK via HTTP"},{"line_number":231,"context_line":"from the OpenStack Image service to a data store that is visible to"},{"line_number":232,"context_line":"the hypervisor and caches it. Subsequent virtual machines that need"},{"line_number":233,"context_line":"the VMDK use the cached versionand don\u0027t have to copy the file again"},{"line_number":234,"context_line":"from the OpenStack Image service."},{"line_number":235,"context_line":""},{"line_number":236,"context_line":"If set to false, even with a cached VMDK, there is still a copy"}],"source_content_type":"text/x-python","patch_set":2,"id":"3aaa91ec_edccd06b","line":233,"range":{"start_line":233,"start_character":49,"end_line":233,"end_character":53},"in_reply_to":"3aaa91ec_442a5991","updated":"2016-06-30 19:56:52.000000000","message":"Eric, I think copy suits best as it has to copy the file to hypervisor file directory.","commit_id":"b498a8f513ad5b5b4988cf508fd4a23e5e515d4a"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"7c8c5d2a0aafe3047ec1697784f26d06ea5c951e","unresolved":false,"context_lines":[{"line_number":235,"context_line":""},{"line_number":236,"context_line":"If set to false, even with a cached VMDK, there is still a copy"},{"line_number":237,"context_line":"operation from the cache location to the hypervisor file directory"},{"line_number":238,"context_line":"in the shared data store. If set to true, above copy operation is"},{"line_number":239,"context_line":"avoided as it creates copy of virtual machine that shares virtual"},{"line_number":240,"context_line":"disks with its parent VM."},{"line_number":241,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3aaa91ec_04afb12a","line":238,"range":{"start_line":238,"start_character":42,"end_line":238,"end_character":47},"updated":"2016-06-29 20:59:01.000000000","message":"the above","commit_id":"b498a8f513ad5b5b4988cf508fd4a23e5e515d4a"},{"author":{"_account_id":18339,"name":"Sivasathurappan Radhakrishnan","email":"siva.radhakrishnan@intel.com","username":"sivakrishnan"},"change_message_id":"9e9332aeb6e96102bdb44a69588d35a956f19129","unresolved":false,"context_lines":[{"line_number":235,"context_line":""},{"line_number":236,"context_line":"If set to false, even with a cached VMDK, there is still a copy"},{"line_number":237,"context_line":"operation from the cache location to the hypervisor file directory"},{"line_number":238,"context_line":"in the shared data store. If set to true, above copy operation is"},{"line_number":239,"context_line":"avoided as it creates copy of virtual machine that shares virtual"},{"line_number":240,"context_line":"disks with its parent VM."},{"line_number":241,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3aaa91ec_6ddf400d","line":238,"range":{"start_line":238,"start_character":42,"end_line":238,"end_character":47},"in_reply_to":"3aaa91ec_04afb12a","updated":"2016-06-30 19:56:52.000000000","message":"Done","commit_id":"b498a8f513ad5b5b4988cf508fd4a23e5e515d4a"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"7c8c5d2a0aafe3047ec1697784f26d06ea5c951e","unresolved":false,"context_lines":[{"line_number":236,"context_line":"If set to false, even with a cached VMDK, there is still a copy"},{"line_number":237,"context_line":"operation from the cache location to the hypervisor file directory"},{"line_number":238,"context_line":"in the shared data store. If set to true, above copy operation is"},{"line_number":239,"context_line":"avoided as it creates copy of virtual machine that shares virtual"},{"line_number":240,"context_line":"disks with its parent VM."},{"line_number":241,"context_line":""},{"line_number":242,"context_line":"Possible values:"}],"source_content_type":"text/x-python","patch_set":2,"id":"3aaa91ec_8469e1fb","line":239,"range":{"start_line":239,"start_character":22,"end_line":239,"end_character":26},"updated":"2016-06-29 20:59:01.000000000","message":"a copy of the virtual","commit_id":"b498a8f513ad5b5b4988cf508fd4a23e5e515d4a"},{"author":{"_account_id":18339,"name":"Sivasathurappan Radhakrishnan","email":"siva.radhakrishnan@intel.com","username":"sivakrishnan"},"change_message_id":"9e9332aeb6e96102bdb44a69588d35a956f19129","unresolved":false,"context_lines":[{"line_number":236,"context_line":"If set to false, even with a cached VMDK, there is still a copy"},{"line_number":237,"context_line":"operation from the cache location to the hypervisor file directory"},{"line_number":238,"context_line":"in the shared data store. If set to true, above copy operation is"},{"line_number":239,"context_line":"avoided as it creates copy of virtual machine that shares virtual"},{"line_number":240,"context_line":"disks with its parent VM."},{"line_number":241,"context_line":""},{"line_number":242,"context_line":"Possible values:"}],"source_content_type":"text/x-python","patch_set":2,"id":"3aaa91ec_4de244d6","line":239,"range":{"start_line":239,"start_character":22,"end_line":239,"end_character":26},"in_reply_to":"3aaa91ec_8469e1fb","updated":"2016-06-30 19:56:52.000000000","message":"Done","commit_id":"b498a8f513ad5b5b4988cf508fd4a23e5e515d4a"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"7c8c5d2a0aafe3047ec1697784f26d06ea5c951e","unresolved":false,"context_lines":[{"line_number":251,"context_line":"               help\u003d\"\"\""},{"line_number":252,"context_line":"This option specifies VIM Service WSDL Location"},{"line_number":253,"context_line":""},{"line_number":254,"context_line":"If vSphere API versions 5.1 and later is being used, this section can"},{"line_number":255,"context_line":"be ignored else WSDL files must be hosted locally and their location"},{"line_number":256,"context_line":"must be specified in the above section."},{"line_number":257,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3aaa91ec_849ba117","line":254,"range":{"start_line":254,"start_character":0,"end_line":254,"end_character":51},"updated":"2016-06-29 20:59:01.000000000","message":"vsphere 5.1 is deprecated, so should this option.","commit_id":"b498a8f513ad5b5b4988cf508fd4a23e5e515d4a"},{"author":{"_account_id":18339,"name":"Sivasathurappan Radhakrishnan","email":"siva.radhakrishnan@intel.com","username":"sivakrishnan"},"change_message_id":"9e9332aeb6e96102bdb44a69588d35a956f19129","unresolved":false,"context_lines":[{"line_number":251,"context_line":"               help\u003d\"\"\""},{"line_number":252,"context_line":"This option specifies VIM Service WSDL Location"},{"line_number":253,"context_line":""},{"line_number":254,"context_line":"If vSphere API versions 5.1 and later is being used, this section can"},{"line_number":255,"context_line":"be ignored else WSDL files must be hosted locally and their location"},{"line_number":256,"context_line":"must be specified in the above section."},{"line_number":257,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3aaa91ec_edfa1074","line":254,"range":{"start_line":254,"start_character":0,"end_line":254,"end_character":51},"in_reply_to":"3aaa91ec_849ba117","updated":"2016-06-30 19:56:52.000000000","message":"Thanks for notifying me about this option. I will put a follow up patch for this option to deprecate this one.","commit_id":"b498a8f513ad5b5b4988cf508fd4a23e5e515d4a"},{"author":{"_account_id":18339,"name":"Sivasathurappan Radhakrishnan","email":"siva.radhakrishnan@intel.com","username":"sivakrishnan"},"change_message_id":"d018400dbebc11eba415cd2629156b0f2a56bdcc","unresolved":false,"context_lines":[{"line_number":255,"context_line":"be ignored else WSDL files must be hosted locally and their location"},{"line_number":256,"context_line":"must be specified in the above section."},{"line_number":257,"context_line":""},{"line_number":258,"context_line":"Optional over-ride to default location for bug work-arounds."},{"line_number":259,"context_line":""},{"line_number":260,"context_line":"Possible values:"},{"line_number":261,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3aaa91ec_3167a24e","line":258,"updated":"2016-06-23 16:04:13.000000000","message":"I am not sure what this line exactly. I would like to have others thoughts on this.","commit_id":"b498a8f513ad5b5b4988cf508fd4a23e5e515d4a"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"812bda2dec7120b05e68671e1890180bdd700b9d","unresolved":false,"context_lines":[{"line_number":101,"context_line":"Possible values:"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"    * Filename containing CA bundle file to be used for"},{"line_number":104,"context_line":"      verifying Vcenter server certificate"},{"line_number":105,"context_line":"\"\"\"),"},{"line_number":106,"context_line":"    cfg.BoolOpt(\u0027insecure\u0027,"},{"line_number":107,"context_line":"                default\u003dFalse,"}],"source_content_type":"text/x-python","patch_set":4,"id":"1aa78d24_8fdcb075","line":104,"range":{"start_line":104,"start_character":16,"end_line":104,"end_character":23},"updated":"2016-07-14 22:26:59.000000000","message":"vCenter","commit_id":"344005eecad2907b8de868bc78309573e080ef6e"},{"author":{"_account_id":18339,"name":"Sivasathurappan Radhakrishnan","email":"siva.radhakrishnan@intel.com","username":"sivakrishnan"},"change_message_id":"d3460c951fa2024c3a9ce7832ce230b959132825","unresolved":false,"context_lines":[{"line_number":101,"context_line":"Possible values:"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"    * Filename containing CA bundle file to be used for"},{"line_number":104,"context_line":"      verifying Vcenter server certificate"},{"line_number":105,"context_line":"\"\"\"),"},{"line_number":106,"context_line":"    cfg.BoolOpt(\u0027insecure\u0027,"},{"line_number":107,"context_line":"                default\u003dFalse,"}],"source_content_type":"text/x-python","patch_set":4,"id":"fad55976_7e77abd4","line":104,"range":{"start_line":104,"start_character":16,"end_line":104,"end_character":23},"in_reply_to":"1aa78d24_8fdcb075","updated":"2016-07-15 21:24:23.000000000","message":"Done","commit_id":"344005eecad2907b8de868bc78309573e080ef6e"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"812bda2dec7120b05e68671e1890180bdd700b9d","unresolved":false,"context_lines":[{"line_number":153,"context_line":"    cfg.IntOpt(\u0027api_retry_count\u0027,"},{"line_number":154,"context_line":"               default\u003d10,"},{"line_number":155,"context_line":"               help\u003d\"\"\""},{"line_number":156,"context_line":"Number of times VMware VC server API must be retried on connection"},{"line_number":157,"context_line":"failures, e.g. socket error, etc."},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"Possible values:"}],"source_content_type":"text/x-python","patch_set":4,"id":"1aa78d24_8fc3108a","line":156,"range":{"start_line":156,"start_character":23,"end_line":156,"end_character":25},"updated":"2016-07-14 22:26:59.000000000","message":"vCenter","commit_id":"344005eecad2907b8de868bc78309573e080ef6e"},{"author":{"_account_id":18339,"name":"Sivasathurappan Radhakrishnan","email":"siva.radhakrishnan@intel.com","username":"sivakrishnan"},"change_message_id":"d3460c951fa2024c3a9ce7832ce230b959132825","unresolved":false,"context_lines":[{"line_number":153,"context_line":"    cfg.IntOpt(\u0027api_retry_count\u0027,"},{"line_number":154,"context_line":"               default\u003d10,"},{"line_number":155,"context_line":"               help\u003d\"\"\""},{"line_number":156,"context_line":"Number of times VMware VC server API must be retried on connection"},{"line_number":157,"context_line":"failures, e.g. socket error, etc."},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"Possible values:"}],"source_content_type":"text/x-python","patch_set":4,"id":"fad55976_5e7467ce","line":156,"range":{"start_line":156,"start_character":23,"end_line":156,"end_character":25},"in_reply_to":"1aa78d24_8fc3108a","updated":"2016-07-15 21:24:23.000000000","message":"Done","commit_id":"344005eecad2907b8de868bc78309573e080ef6e"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"812bda2dec7120b05e68671e1890180bdd700b9d","unresolved":false,"context_lines":[{"line_number":166,"context_line":"                help\u003d\"\"\""},{"line_number":167,"context_line":"This option specifies VNC starting port."},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"Every VM created using ESX host has a option of enabling VNC client"},{"line_number":170,"context_line":"for remote connection. Above options helps you to set default starting"},{"line_number":171,"context_line":"port for VNC client."},{"line_number":172,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"1aa78d24_8ff830c6","line":169,"range":{"start_line":169,"start_character":17,"end_line":169,"end_character":22},"updated":"2016-07-14 22:26:59.000000000","message":"This sentence sounds awkward. Please rephrase. Implies the ESX host has a VNC client, which it doesn\u0027t","commit_id":"344005eecad2907b8de868bc78309573e080ef6e"},{"author":{"_account_id":18339,"name":"Sivasathurappan Radhakrishnan","email":"siva.radhakrishnan@intel.com","username":"sivakrishnan"},"change_message_id":"d3460c951fa2024c3a9ce7832ce230b959132825","unresolved":false,"context_lines":[{"line_number":166,"context_line":"                help\u003d\"\"\""},{"line_number":167,"context_line":"This option specifies VNC starting port."},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"Every VM created using ESX host has a option of enabling VNC client"},{"line_number":170,"context_line":"for remote connection. Above options helps you to set default starting"},{"line_number":171,"context_line":"port for VNC client."},{"line_number":172,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"fad55976_be812392","line":169,"range":{"start_line":169,"start_character":17,"end_line":169,"end_character":22},"in_reply_to":"1aa78d24_8ff830c6","updated":"2016-07-15 21:24:23.000000000","message":"Done","commit_id":"344005eecad2907b8de868bc78309573e080ef6e"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"812bda2dec7120b05e68671e1890180bdd700b9d","unresolved":false,"context_lines":[{"line_number":167,"context_line":"This option specifies VNC starting port."},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"Every VM created using ESX host has a option of enabling VNC client"},{"line_number":170,"context_line":"for remote connection. Above options helps you to set default starting"},{"line_number":171,"context_line":"port for VNC client."},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"Possible values:"}],"source_content_type":"text/x-python","patch_set":4,"id":"1aa78d24_0f0440c4","line":170,"range":{"start_line":170,"start_character":23,"end_line":170,"end_character":46},"updated":"2016-07-14 22:26:59.000000000","message":"Above is misleading, since there are no other VNC options above.","commit_id":"344005eecad2907b8de868bc78309573e080ef6e"},{"author":{"_account_id":18339,"name":"Sivasathurappan Radhakrishnan","email":"siva.radhakrishnan@intel.com","username":"sivakrishnan"},"change_message_id":"d3460c951fa2024c3a9ce7832ce230b959132825","unresolved":false,"context_lines":[{"line_number":167,"context_line":"This option specifies VNC starting port."},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"Every VM created using ESX host has a option of enabling VNC client"},{"line_number":170,"context_line":"for remote connection. Above options helps you to set default starting"},{"line_number":171,"context_line":"port for VNC client."},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"Possible values:"}],"source_content_type":"text/x-python","patch_set":4,"id":"fad55976_9e7edfac","line":170,"range":{"start_line":170,"start_character":23,"end_line":170,"end_character":46},"in_reply_to":"1aa78d24_0f0440c4","updated":"2016-07-15 21:24:23.000000000","message":"Done","commit_id":"344005eecad2907b8de868bc78309573e080ef6e"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"812bda2dec7120b05e68671e1890180bdd700b9d","unresolved":false,"context_lines":[{"line_number":168,"context_line":""},{"line_number":169,"context_line":"Every VM created using ESX host has a option of enabling VNC client"},{"line_number":170,"context_line":"for remote connection. Above options helps you to set default starting"},{"line_number":171,"context_line":"port for VNC client."},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"Possible values:"},{"line_number":174,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"1aa78d24_ef0614cc","line":171,"range":{"start_line":171,"start_character":5,"end_line":171,"end_character":8},"updated":"2016-07-14 22:26:59.000000000","message":"for the","commit_id":"344005eecad2907b8de868bc78309573e080ef6e"},{"author":{"_account_id":18339,"name":"Sivasathurappan Radhakrishnan","email":"siva.radhakrishnan@intel.com","username":"sivakrishnan"},"change_message_id":"d3460c951fa2024c3a9ce7832ce230b959132825","unresolved":false,"context_lines":[{"line_number":168,"context_line":""},{"line_number":169,"context_line":"Every VM created using ESX host has a option of enabling VNC client"},{"line_number":170,"context_line":"for remote connection. Above options helps you to set default starting"},{"line_number":171,"context_line":"port for VNC client."},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"Possible values:"},{"line_number":174,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"fad55976_fe49db8f","line":171,"range":{"start_line":171,"start_character":5,"end_line":171,"end_character":8},"in_reply_to":"1aa78d24_ef0614cc","updated":"2016-07-15 21:24:23.000000000","message":"Done","commit_id":"344005eecad2907b8de868bc78309573e080ef6e"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"812bda2dec7120b05e68671e1890180bdd700b9d","unresolved":false,"context_lines":[{"line_number":176,"context_line":"    * Any valid port number within 5900 - 5900 + vnc_port_total"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"Related options:"},{"line_number":179,"context_line":"Below options should be enabled/set to create VNC client."},{"line_number":180,"context_line":"    * vnc.enabled \u003d True"},{"line_number":181,"context_line":"    * vnc_port_total"},{"line_number":182,"context_line":"\"\"\"),"}],"source_content_type":"text/x-python","patch_set":4,"id":"1aa78d24_4fdc8846","line":179,"range":{"start_line":179,"start_character":39,"end_line":179,"end_character":45},"updated":"2016-07-14 22:26:59.000000000","message":"Its not creating, it enabling the VNC client","commit_id":"344005eecad2907b8de868bc78309573e080ef6e"},{"author":{"_account_id":18339,"name":"Sivasathurappan Radhakrishnan","email":"siva.radhakrishnan@intel.com","username":"sivakrishnan"},"change_message_id":"d3460c951fa2024c3a9ce7832ce230b959132825","unresolved":false,"context_lines":[{"line_number":176,"context_line":"    * Any valid port number within 5900 - 5900 + vnc_port_total"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"Related options:"},{"line_number":179,"context_line":"Below options should be enabled/set to create VNC client."},{"line_number":180,"context_line":"    * vnc.enabled \u003d True"},{"line_number":181,"context_line":"    * vnc_port_total"},{"line_number":182,"context_line":"\"\"\"),"}],"source_content_type":"text/x-python","patch_set":4,"id":"fad55976_de4e9795","line":179,"range":{"start_line":179,"start_character":39,"end_line":179,"end_character":45},"in_reply_to":"1aa78d24_4fdc8846","updated":"2016-07-15 21:24:23.000000000","message":"Done","commit_id":"344005eecad2907b8de868bc78309573e080ef6e"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"812bda2dec7120b05e68671e1890180bdd700b9d","unresolved":false,"context_lines":[{"line_number":193,"context_line":"    cfg.BoolOpt(\u0027use_linked_clone\u0027,"},{"line_number":194,"context_line":"                default\u003dTrue,"},{"line_number":195,"context_line":"                help\u003d\"\"\""},{"line_number":196,"context_line":"This option enables/disables use of linked clone."},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"The ESX hypervisor requires a copy of the VMDK file in order to boot"},{"line_number":199,"context_line":"up a virtual machine. Compute driver must download the VMDK via HTTP"}],"source_content_type":"text/x-python","patch_set":4,"id":"1aa78d24_efbbb4e2","line":196,"range":{"start_line":196,"start_character":29,"end_line":196,"end_character":32},"updated":"2016-07-14 22:26:59.000000000","message":"the use","commit_id":"344005eecad2907b8de868bc78309573e080ef6e"},{"author":{"_account_id":18339,"name":"Sivasathurappan Radhakrishnan","email":"siva.radhakrishnan@intel.com","username":"sivakrishnan"},"change_message_id":"d3460c951fa2024c3a9ce7832ce230b959132825","unresolved":false,"context_lines":[{"line_number":193,"context_line":"    cfg.BoolOpt(\u0027use_linked_clone\u0027,"},{"line_number":194,"context_line":"                default\u003dTrue,"},{"line_number":195,"context_line":"                help\u003d\"\"\""},{"line_number":196,"context_line":"This option enables/disables use of linked clone."},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"The ESX hypervisor requires a copy of the VMDK file in order to boot"},{"line_number":199,"context_line":"up a virtual machine. Compute driver must download the VMDK via HTTP"}],"source_content_type":"text/x-python","patch_set":4,"id":"fad55976_3e441373","line":196,"range":{"start_line":196,"start_character":29,"end_line":196,"end_character":32},"in_reply_to":"1aa78d24_efbbb4e2","updated":"2016-07-15 21:24:23.000000000","message":"Done","commit_id":"344005eecad2907b8de868bc78309573e080ef6e"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"812bda2dec7120b05e68671e1890180bdd700b9d","unresolved":false,"context_lines":[{"line_number":196,"context_line":"This option enables/disables use of linked clone."},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"The ESX hypervisor requires a copy of the VMDK file in order to boot"},{"line_number":199,"context_line":"up a virtual machine. Compute driver must download the VMDK via HTTP"},{"line_number":200,"context_line":"from the OpenStack Image service to a data store that is visible to"},{"line_number":201,"context_line":"the hypervisor and cache it. Subsequent virtual machines that need"},{"line_number":202,"context_line":"the VMDK use the cached version and don\u0027t have to copy the file again"}],"source_content_type":"text/x-python","patch_set":4,"id":"1aa78d24_4fb3e80a","line":199,"range":{"start_line":199,"start_character":22,"end_line":199,"end_character":29},"updated":"2016-07-14 22:26:59.000000000","message":"The compute","commit_id":"344005eecad2907b8de868bc78309573e080ef6e"},{"author":{"_account_id":18339,"name":"Sivasathurappan Radhakrishnan","email":"siva.radhakrishnan@intel.com","username":"sivakrishnan"},"change_message_id":"d3460c951fa2024c3a9ce7832ce230b959132825","unresolved":false,"context_lines":[{"line_number":196,"context_line":"This option enables/disables use of linked clone."},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"The ESX hypervisor requires a copy of the VMDK file in order to boot"},{"line_number":199,"context_line":"up a virtual machine. Compute driver must download the VMDK via HTTP"},{"line_number":200,"context_line":"from the OpenStack Image service to a data store that is visible to"},{"line_number":201,"context_line":"the hypervisor and cache it. Subsequent virtual machines that need"},{"line_number":202,"context_line":"the VMDK use the cached version and don\u0027t have to copy the file again"}],"source_content_type":"text/x-python","patch_set":4,"id":"fad55976_7e5e8b46","line":199,"range":{"start_line":199,"start_character":22,"end_line":199,"end_character":29},"in_reply_to":"1aa78d24_4fb3e80a","updated":"2016-07-15 21:24:23.000000000","message":"Done","commit_id":"344005eecad2907b8de868bc78309573e080ef6e"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"812bda2dec7120b05e68671e1890180bdd700b9d","unresolved":false,"context_lines":[{"line_number":217,"context_line":"This option specifies VIM Service WSDL Location"},{"line_number":218,"context_line":""},{"line_number":219,"context_line":"If vSphere API versions 5.1 and later is being used, this section can"},{"line_number":220,"context_line":"be ignored else WSDL files must be hosted locally and their location"},{"line_number":221,"context_line":"must be specified in the above section."},{"line_number":222,"context_line":""},{"line_number":223,"context_line":"Optional over-ride to default location for bug work-arounds."}],"source_content_type":"text/x-python","patch_set":4,"id":"1aa78d24_2f849c09","line":220,"range":{"start_line":220,"start_character":11,"end_line":220,"end_character":50},"updated":"2016-07-14 22:26:59.000000000","message":"This is a run-on sentence and the use of \"else\" is strange.","commit_id":"344005eecad2907b8de868bc78309573e080ef6e"},{"author":{"_account_id":18339,"name":"Sivasathurappan Radhakrishnan","email":"siva.radhakrishnan@intel.com","username":"sivakrishnan"},"change_message_id":"d3460c951fa2024c3a9ce7832ce230b959132825","unresolved":false,"context_lines":[{"line_number":217,"context_line":"This option specifies VIM Service WSDL Location"},{"line_number":218,"context_line":""},{"line_number":219,"context_line":"If vSphere API versions 5.1 and later is being used, this section can"},{"line_number":220,"context_line":"be ignored else WSDL files must be hosted locally and their location"},{"line_number":221,"context_line":"must be specified in the above section."},{"line_number":222,"context_line":""},{"line_number":223,"context_line":"Optional over-ride to default location for bug work-arounds."}],"source_content_type":"text/x-python","patch_set":4,"id":"fad55976_5e5bc754","line":220,"range":{"start_line":220,"start_character":11,"end_line":220,"end_character":50},"in_reply_to":"1aa78d24_2f849c09","updated":"2016-07-15 21:24:23.000000000","message":"Done","commit_id":"344005eecad2907b8de868bc78309573e080ef6e"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"812bda2dec7120b05e68671e1890180bdd700b9d","unresolved":false,"context_lines":[{"line_number":220,"context_line":"be ignored else WSDL files must be hosted locally and their location"},{"line_number":221,"context_line":"must be specified in the above section."},{"line_number":222,"context_line":""},{"line_number":223,"context_line":"Optional over-ride to default location for bug work-arounds."},{"line_number":224,"context_line":""},{"line_number":225,"context_line":"Possible values:"},{"line_number":226,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"1aa78d24_cf751833","line":223,"range":{"start_line":223,"start_character":9,"end_line":223,"end_character":21},"updated":"2016-07-14 22:26:59.000000000","message":"override of the\n\nI don\u0027t really understand this sentence.","commit_id":"344005eecad2907b8de868bc78309573e080ef6e"},{"author":{"_account_id":18339,"name":"Sivasathurappan Radhakrishnan","email":"siva.radhakrishnan@intel.com","username":"sivakrishnan"},"change_message_id":"d3460c951fa2024c3a9ce7832ce230b959132825","unresolved":false,"context_lines":[{"line_number":220,"context_line":"be ignored else WSDL files must be hosted locally and their location"},{"line_number":221,"context_line":"must be specified in the above section."},{"line_number":222,"context_line":""},{"line_number":223,"context_line":"Optional over-ride to default location for bug work-arounds."},{"line_number":224,"context_line":""},{"line_number":225,"context_line":"Possible values:"},{"line_number":226,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"fad55976_be06431e","line":223,"range":{"start_line":223,"start_character":9,"end_line":223,"end_character":21},"in_reply_to":"1aa78d24_cf751833","updated":"2016-07-15 21:24:23.000000000","message":"Not sure what it does. Since it was in the previous help text, I didn\u0027t remove it. Need someone\u0027s help who has worked in vmware to figure this out.","commit_id":"344005eecad2907b8de868bc78309573e080ef6e"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"f3e0175424c52a290095860c89c4b2ccb215da82","unresolved":false,"context_lines":[{"line_number":62,"context_line":"               help\u003d\"\"\""},{"line_number":63,"context_line":"Hostname or IP address for connection to VMware vCenter host."},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"Possible values:"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    * Any valid IP address or hostname"},{"line_number":68,"context_line":"\"\"\"),"},{"line_number":69,"context_line":"    cfg.PortOpt(\u0027host_port\u0027,"},{"line_number":70,"context_line":"                default\u003d443,"}],"source_content_type":"text/x-python","patch_set":5,"id":"dada55a8_c4011d6c","line":67,"range":{"start_line":65,"start_character":0,"end_line":67,"end_character":38},"updated":"2016-07-20 14:15:41.000000000","message":"Info is already included in text message, drop this.","commit_id":"6f7b1548ded77fd159cc56a57fe91996c83add5e"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"f3e0175424c52a290095860c89c4b2ccb215da82","unresolved":false,"context_lines":[{"line_number":80,"context_line":"               help\u003d\"\"\""},{"line_number":81,"context_line":"Username for connection to VMware vCenter host."},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"Possible values:"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"    * Any string representing valid host username"},{"line_number":86,"context_line":"\"\"\"),"},{"line_number":87,"context_line":"    cfg.StrOpt(\u0027host_password\u0027,"},{"line_number":88,"context_line":"               secret\u003dTrue,"}],"source_content_type":"text/x-python","patch_set":5,"id":"dada55a8_84e445e1","line":85,"range":{"start_line":83,"start_character":0,"end_line":85,"end_character":49},"updated":"2016-07-20 14:15:41.000000000","message":"I would drop this section, nothing new here.","commit_id":"6f7b1548ded77fd159cc56a57fe91996c83add5e"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"f3e0175424c52a290095860c89c4b2ccb215da82","unresolved":false,"context_lines":[{"line_number":89,"context_line":"               help\u003d\"\"\""},{"line_number":90,"context_line":"Password for connection to VMware vCenter host."},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"Possible values:"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"    * Any valid string"},{"line_number":95,"context_line":"\"\"\"),"},{"line_number":96,"context_line":"    cfg.StrOpt(\u0027ca_file\u0027,"},{"line_number":97,"context_line":"               help\u003d\"\"\""}],"source_content_type":"text/x-python","patch_set":5,"id":"dada55a8_04ca154e","line":94,"range":{"start_line":92,"start_character":0,"end_line":94,"end_character":22},"updated":"2016-07-20 14:15:41.000000000","message":"Drop this section. It\u0027s obvious.","commit_id":"6f7b1548ded77fd159cc56a57fe91996c83add5e"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"f3e0175424c52a290095860c89c4b2ccb215da82","unresolved":false,"context_lines":[{"line_number":100,"context_line":""},{"line_number":101,"context_line":"Possible values:"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"    * Filename containing CA bundle file to be used for"},{"line_number":104,"context_line":"      verifying vCenter server certificate"},{"line_number":105,"context_line":"\"\"\"),"},{"line_number":106,"context_line":"    cfg.BoolOpt(\u0027insecure\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"dada55a8_84d7254a","line":103,"range":{"start_line":103,"start_character":6,"end_line":103,"end_character":14},"updated":"2016-07-20 14:15:41.000000000","message":"Path to file, perhaps? I would move it to description (\"Specifies file path to CA bundle to be used...\") and drop this section.","commit_id":"6f7b1548ded77fd159cc56a57fe91996c83add5e"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"f3e0175424c52a290095860c89c4b2ccb215da82","unresolved":false,"context_lines":[{"line_number":109,"context_line":"If true, the vCenter server certificate is not verified. If false,"},{"line_number":110,"context_line":"then the default CA truststore is used for verification."},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"Possible values:"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"    * True or False (default)"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"Related options:"},{"line_number":117,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"dada55a8_c4cd9db8","line":114,"range":{"start_line":112,"start_character":0,"end_line":114,"end_character":29},"updated":"2016-07-20 14:15:41.000000000","message":"Drop this section.","commit_id":"6f7b1548ded77fd159cc56a57fe91996c83add5e"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"f3e0175424c52a290095860c89c4b2ccb215da82","unresolved":false,"context_lines":[{"line_number":145,"context_line":"Time interval in seconds to poll remote tasks invoked on"},{"line_number":146,"context_line":"VMware VC server."},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"Possible values:"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"    * 0.5 second (default)"},{"line_number":151,"context_line":"    * Any positive value in seconds"},{"line_number":152,"context_line":"\"\"\"),"},{"line_number":153,"context_line":"    cfg.IntOpt(\u0027api_retry_count\u0027,"},{"line_number":154,"context_line":"               default\u003d10,"}],"source_content_type":"text/x-python","patch_set":5,"id":"dada55a8_c49c7d5f","line":151,"range":{"start_line":148,"start_character":0,"end_line":151,"end_character":35},"updated":"2016-07-20 14:15:41.000000000","message":"Add min\u003d0.0 to FloatOpt and drop this section.","commit_id":"6f7b1548ded77fd159cc56a57fe91996c83add5e"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"f3e0175424c52a290095860c89c4b2ccb215da82","unresolved":false,"context_lines":[{"line_number":156,"context_line":"Number of times VMware vCenter server API must be retried on connection"},{"line_number":157,"context_line":"failures, e.g. socket error, etc."},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"Possible values:"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"    * 10 (default)"},{"line_number":162,"context_line":"    * Any positive integer"},{"line_number":163,"context_line":"\"\"\"),"},{"line_number":164,"context_line":"    cfg.PortOpt(\u0027vnc_port\u0027,"},{"line_number":165,"context_line":"                default\u003d5900,"}],"source_content_type":"text/x-python","patch_set":5,"id":"dada55a8_6475d130","line":162,"range":{"start_line":159,"start_character":0,"end_line":162,"end_character":26},"updated":"2016-07-20 14:15:41.000000000","message":"Add min\u003d0 to IntOpt and drop this section.","commit_id":"6f7b1548ded77fd159cc56a57fe91996c83add5e"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"f3e0175424c52a290095860c89c4b2ccb215da82","unresolved":false,"context_lines":[{"line_number":185,"context_line":"               help\u003d\"\"\""},{"line_number":186,"context_line":"Total number of VNC ports."},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"Possible values:"},{"line_number":189,"context_line":""},{"line_number":190,"context_line":"    * 10000 (default)"},{"line_number":191,"context_line":"    * Any valid positive integer"},{"line_number":192,"context_line":"\"\"\"),"},{"line_number":193,"context_line":"    cfg.BoolOpt(\u0027use_linked_clone\u0027,"},{"line_number":194,"context_line":"                default\u003dTrue,"}],"source_content_type":"text/x-python","patch_set":5,"id":"dada55a8_449b6d72","line":191,"range":{"start_line":188,"start_character":0,"end_line":191,"end_character":32},"updated":"2016-07-20 14:15:41.000000000","message":"Add min\u003d0 to IntOpt and drop this section.","commit_id":"6f7b1548ded77fd159cc56a57fe91996c83add5e"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"f3e0175424c52a290095860c89c4b2ccb215da82","unresolved":false,"context_lines":[{"line_number":208,"context_line":"is avoided as it creates copy of the virtual machine that shares"},{"line_number":209,"context_line":"virtual disks with its parent VM."},{"line_number":210,"context_line":""},{"line_number":211,"context_line":"Possible values:"},{"line_number":212,"context_line":""},{"line_number":213,"context_line":"    * True (default) or False"},{"line_number":214,"context_line":"\"\"\"),"},{"line_number":215,"context_line":"    cfg.StrOpt(\u0027wsdl_location\u0027,"},{"line_number":216,"context_line":"               help\u003d\"\"\""}],"source_content_type":"text/x-python","patch_set":5,"id":"dada55a8_44c40d5e","line":213,"range":{"start_line":211,"start_character":0,"end_line":213,"end_character":29},"updated":"2016-07-20 14:15:41.000000000","message":"Drop this section.","commit_id":"6f7b1548ded77fd159cc56a57fe91996c83add5e"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"6175bfcc7092dbc43537524d72f386dc425d19c8","unresolved":false,"context_lines":[{"line_number":59,"context_line":""},{"line_number":60,"context_line":"vmwareapi_opts \u003d ["},{"line_number":61,"context_line":"    cfg.StrOpt(\u0027host_ip\u0027,"},{"line_number":62,"context_line":"               help\u003d\"\"\""},{"line_number":63,"context_line":"Hostname or IP address for connection to VMware vCenter host."},{"line_number":64,"context_line":"\"\"\"),"},{"line_number":65,"context_line":"    cfg.PortOpt(\u0027host_port\u0027,"},{"line_number":66,"context_line":"                default\u003d443,"},{"line_number":67,"context_line":"                help\u003d\"\"\""}],"source_content_type":"text/x-python","patch_set":6,"id":"dada55a8_e77a23bc","line":64,"range":{"start_line":62,"start_character":0,"end_line":64,"end_character":5},"updated":"2016-07-21 14:57:23.000000000","message":"This can be a single line.","commit_id":"f4d26aab13ffc52b53036c51a63448872a5827ac"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"6175bfcc7092dbc43537524d72f386dc425d19c8","unresolved":false,"context_lines":[{"line_number":64,"context_line":"\"\"\"),"},{"line_number":65,"context_line":"    cfg.PortOpt(\u0027host_port\u0027,"},{"line_number":66,"context_line":"                default\u003d443,"},{"line_number":67,"context_line":"                help\u003d\"\"\""},{"line_number":68,"context_line":"Port for connection to VMware vCenter host."},{"line_number":69,"context_line":"\"\"\"),"},{"line_number":70,"context_line":"    cfg.StrOpt(\u0027host_username\u0027,"},{"line_number":71,"context_line":"               help\u003d\"\"\""},{"line_number":72,"context_line":"Username for connection to VMware vCenter host."}],"source_content_type":"text/x-python","patch_set":6,"id":"dada55a8_07a5b745","line":69,"range":{"start_line":67,"start_character":0,"end_line":69,"end_character":5},"updated":"2016-07-21 14:57:23.000000000","message":"This can be a single line.","commit_id":"f4d26aab13ffc52b53036c51a63448872a5827ac"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"6175bfcc7092dbc43537524d72f386dc425d19c8","unresolved":false,"context_lines":[{"line_number":68,"context_line":"Port for connection to VMware vCenter host."},{"line_number":69,"context_line":"\"\"\"),"},{"line_number":70,"context_line":"    cfg.StrOpt(\u0027host_username\u0027,"},{"line_number":71,"context_line":"               help\u003d\"\"\""},{"line_number":72,"context_line":"Username for connection to VMware vCenter host."},{"line_number":73,"context_line":"\"\"\"),"},{"line_number":74,"context_line":"    cfg.StrOpt(\u0027host_password\u0027,"},{"line_number":75,"context_line":"               secret\u003dTrue,"},{"line_number":76,"context_line":"               help\u003d\"\"\""}],"source_content_type":"text/x-python","patch_set":6,"id":"dada55a8_47c20fea","line":73,"range":{"start_line":71,"start_character":0,"end_line":73,"end_character":5},"updated":"2016-07-21 14:57:23.000000000","message":"This can be a single line.","commit_id":"f4d26aab13ffc52b53036c51a63448872a5827ac"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"6175bfcc7092dbc43537524d72f386dc425d19c8","unresolved":false,"context_lines":[{"line_number":73,"context_line":"\"\"\"),"},{"line_number":74,"context_line":"    cfg.StrOpt(\u0027host_password\u0027,"},{"line_number":75,"context_line":"               secret\u003dTrue,"},{"line_number":76,"context_line":"               help\u003d\"\"\""},{"line_number":77,"context_line":"Password for connection to VMware vCenter host."},{"line_number":78,"context_line":"\"\"\"),"},{"line_number":79,"context_line":"    cfg.StrOpt(\u0027ca_file\u0027,"},{"line_number":80,"context_line":"               help\u003d\"\"\""},{"line_number":81,"context_line":"Specifies the CA bundle file to be used in verifying the vCenter"}],"source_content_type":"text/x-python","patch_set":6,"id":"dada55a8_274efbc0","line":78,"range":{"start_line":76,"start_character":15,"end_line":78,"end_character":5},"updated":"2016-07-21 14:57:23.000000000","message":"This can be a single line.","commit_id":"f4d26aab13ffc52b53036c51a63448872a5827ac"},{"author":{"_account_id":18339,"name":"Sivasathurappan Radhakrishnan","email":"siva.radhakrishnan@intel.com","username":"sivakrishnan"},"change_message_id":"de52badeed61f528da4c11c12e643887b6e25f02","unresolved":false,"context_lines":[{"line_number":108,"context_line":"    * Any matching regular expression to a datastore"},{"line_number":109,"context_line":"      must be given"},{"line_number":110,"context_line":"\"\"\"),"},{"line_number":111,"context_line":"    cfg.FloatOpt(\u0027task_poll_interval\u0027,"},{"line_number":112,"context_line":"                 default\u003d0.5,"},{"line_number":113,"context_line":"                 help\u003d\"\"\""},{"line_number":114,"context_line":"Time interval in seconds to poll remote tasks invoked on"}],"source_content_type":"text/x-python","patch_set":7,"id":"dada55a8_a10c0495","line":111,"updated":"2016-07-25 19:44:27.000000000","message":"Adding min value to FloatOpt results in failure of gates as they have added \"Add min and max values to Float type and Opt\" (fbe660df29093f51e9c852ed3d2c3ec89b9bcb7d) just 4 days ago to the master. Currently we are using oslo.config (3.13) for in our test environment.","commit_id":"a104b16783bf443823679764fcf6e099974c415d"},{"author":{"_account_id":16929,"name":"Giridhar Jayavelu","email":"gjayavelu@vmware.com","username":"gjayavelu"},"change_message_id":"9d8a46d605740c7d568b6c1b587f8787ec2a4059","unresolved":false,"context_lines":[{"line_number":166,"context_line":""},{"line_number":167,"context_line":"Possible values:"},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"* Any valid port number within 5900 - 5900 + vnc_port_total"},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"Related options:"},{"line_number":172,"context_line":"Below options should be set to enable VNC client."}],"source_content_type":"text/x-python","patch_set":9,"id":"bacf61ea_842c4c03","line":169,"updated":"2016-08-04 19:26:27.000000000","message":"nit: 5900 - (5900 + vnc_port_total)","commit_id":"32cb5d7857ad8a2941ee94c39a8e3358a692bcca"},{"author":{"_account_id":16929,"name":"Giridhar Jayavelu","email":"gjayavelu@vmware.com","username":"gjayavelu"},"change_message_id":"9d8a46d605740c7d568b6c1b587f8787ec2a4059","unresolved":false,"context_lines":[{"line_number":186,"context_line":""},{"line_number":187,"context_line":"The ESX hypervisor requires a copy of the VMDK file in order to boot"},{"line_number":188,"context_line":"up a virtual machine. The compute driver must download the VMDK via"},{"line_number":189,"context_line":"HTTP from the OpenStack Image service to a data store that is visible"},{"line_number":190,"context_line":"to the hypervisor and cache it. Subsequent virtual machines that need"},{"line_number":191,"context_line":"the VMDK use the cached version and don\u0027t have to copy the file again"},{"line_number":192,"context_line":"from the OpenStack Image service."}],"source_content_type":"text/x-python","patch_set":9,"id":"bacf61ea_447534f8","line":189,"updated":"2016-08-04 19:26:27.000000000","message":"replace \"data store\" as \"datastore\" everywhere\n\nhttps://pubs.vmware.com/vsphere-4-esx-vcenter/index.jsp?topic\u003d/com.vmware.vsphere.server_configclassic.doc_40/esx_server_config/introduction_to_storage/c_datastores.html","commit_id":"32cb5d7857ad8a2941ee94c39a8e3358a692bcca"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"482334756f33dab19ae50f103732f5fca33afc82","unresolved":false,"context_lines":[{"line_number":23,"context_line":"virtual machines."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"* compute_driver"},{"line_number":26,"context_line":"* host_username"},{"line_number":27,"context_line":"* host_password"},{"line_number":28,"context_line":"* cluster_name"},{"line_number":29,"context_line":"\"\"\")"}],"source_content_type":"text/x-python","patch_set":10,"id":"9ad45d7e_d687aad5","line":26,"updated":"2016-08-08 10:37:49.000000000","message":"I assume compute_driver is in the default group, it would be good to say what value to set.\n\nI also note that host_username is in the vmware_group, thats not clear here.","commit_id":"ea4898a78aab6f409f027fdbe76799e07b79ae6d"},{"author":{"_account_id":18339,"name":"Sivasathurappan Radhakrishnan","email":"siva.radhakrishnan@intel.com","username":"sivakrishnan"},"change_message_id":"2804518a7fb5c3d54b66a60e31acd8d6aa87520f","unresolved":false,"context_lines":[{"line_number":23,"context_line":"virtual machines."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"* compute_driver"},{"line_number":26,"context_line":"* host_username"},{"line_number":27,"context_line":"* host_password"},{"line_number":28,"context_line":"* cluster_name"},{"line_number":29,"context_line":"\"\"\")"}],"source_content_type":"text/x-python","patch_set":10,"id":"9ad45d7e_e7cb031d","line":26,"in_reply_to":"9ad45d7e_d687aad5","updated":"2016-08-08 18:28:09.000000000","message":"Good catch.Thanks for pointing it out!","commit_id":"ea4898a78aab6f409f027fdbe76799e07b79ae6d"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"482334756f33dab19ae50f103732f5fca33afc82","unresolved":false,"context_lines":[{"line_number":119,"context_line":""},{"line_number":120,"context_line":"Related options:"},{"line_number":121,"context_line":"This option is ignored if \"ca_file\" is set."},{"line_number":122,"context_line":"* ca_file"},{"line_number":123,"context_line":"\"\"\"),"},{"line_number":124,"context_line":"    cfg.StrOpt(\u0027cluster_name\u0027,"},{"line_number":125,"context_line":"               help\u003d\"\"\""}],"source_content_type":"text/x-python","patch_set":10,"id":"9ad45d7e_f6e74eaa","line":122,"updated":"2016-08-08 10:37:49.000000000","message":"Nit: this seems odd formatting. I would prefer:\n\n  Related options:\n  * ca_file: this option is ignored if \"ca_file\" is set","commit_id":"ea4898a78aab6f409f027fdbe76799e07b79ae6d"},{"author":{"_account_id":18339,"name":"Sivasathurappan Radhakrishnan","email":"siva.radhakrishnan@intel.com","username":"sivakrishnan"},"change_message_id":"2804518a7fb5c3d54b66a60e31acd8d6aa87520f","unresolved":false,"context_lines":[{"line_number":119,"context_line":""},{"line_number":120,"context_line":"Related options:"},{"line_number":121,"context_line":"This option is ignored if \"ca_file\" is set."},{"line_number":122,"context_line":"* ca_file"},{"line_number":123,"context_line":"\"\"\"),"},{"line_number":124,"context_line":"    cfg.StrOpt(\u0027cluster_name\u0027,"},{"line_number":125,"context_line":"               help\u003d\"\"\""}],"source_content_type":"text/x-python","patch_set":10,"id":"9ad45d7e_27d6bbc5","line":122,"in_reply_to":"9ad45d7e_f6e74eaa","updated":"2016-08-08 18:28:09.000000000","message":"Done","commit_id":"ea4898a78aab6f409f027fdbe76799e07b79ae6d"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"482334756f33dab19ae50f103732f5fca33afc82","unresolved":false,"context_lines":[{"line_number":125,"context_line":"               help\u003d\"\"\""},{"line_number":126,"context_line":"Name of a VMware Cluster ComputeResource."},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"Possible values:"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"* Any valid vCenter cluster name"},{"line_number":131,"context_line":"\"\"\"),"},{"line_number":132,"context_line":"    cfg.StrOpt(\u0027datastore_regex\u0027,"},{"line_number":133,"context_line":"               help\u003d\"\"\""}],"source_content_type":"text/x-python","patch_set":10,"id":"9ad45d7e_56f9fa4c","line":130,"range":{"start_line":128,"start_character":0,"end_line":130,"end_character":32},"updated":"2016-08-08 10:37:49.000000000","message":"This seems confusing here, I would drop it. You can\u0027t have any valid name, you need the cluster with the compute resources we are going to manage. We should expand on the original test, but possible values isn\u0027t really needed.","commit_id":"ea4898a78aab6f409f027fdbe76799e07b79ae6d"},{"author":{"_account_id":18339,"name":"Sivasathurappan Radhakrishnan","email":"siva.radhakrishnan@intel.com","username":"sivakrishnan"},"change_message_id":"2804518a7fb5c3d54b66a60e31acd8d6aa87520f","unresolved":false,"context_lines":[{"line_number":125,"context_line":"               help\u003d\"\"\""},{"line_number":126,"context_line":"Name of a VMware Cluster ComputeResource."},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"Possible values:"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"* Any valid vCenter cluster name"},{"line_number":131,"context_line":"\"\"\"),"},{"line_number":132,"context_line":"    cfg.StrOpt(\u0027datastore_regex\u0027,"},{"line_number":133,"context_line":"               help\u003d\"\"\""}],"source_content_type":"text/x-python","patch_set":10,"id":"9ad45d7e_67d8b3f0","line":130,"range":{"start_line":128,"start_character":0,"end_line":130,"end_character":32},"in_reply_to":"9ad45d7e_56f9fa4c","updated":"2016-08-08 18:28:09.000000000","message":"Done","commit_id":"ea4898a78aab6f409f027fdbe76799e07b79ae6d"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"482334756f33dab19ae50f103732f5fca33afc82","unresolved":false,"context_lines":[{"line_number":140,"context_line":"Possible values:"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"* Any matching regular expression to a datastore"},{"line_number":143,"context_line":"  must be given"},{"line_number":144,"context_line":"\"\"\"),"},{"line_number":145,"context_line":"    cfg.FloatOpt(\u0027task_poll_interval\u0027,"},{"line_number":146,"context_line":"                 default\u003d0.5,"}],"source_content_type":"text/x-python","patch_set":10,"id":"9ad45d7e_963532f9","line":143,"range":{"start_line":143,"start_character":2,"end_line":143,"end_character":15},"updated":"2016-08-08 10:37:49.000000000","message":"It looks like this is optional. If not regex is given, it just picks the datastore with the most freespace:\nhttps://github.com/openstack/nova/blob/b7b8a5b6e1ba52e7d6fc7cc9df24f0e20598468a/nova/virt/vmwareapi/ds_util.py#L47","commit_id":"ea4898a78aab6f409f027fdbe76799e07b79ae6d"},{"author":{"_account_id":18339,"name":"Sivasathurappan Radhakrishnan","email":"siva.radhakrishnan@intel.com","username":"sivakrishnan"},"change_message_id":"2804518a7fb5c3d54b66a60e31acd8d6aa87520f","unresolved":false,"context_lines":[{"line_number":140,"context_line":"Possible values:"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"* Any matching regular expression to a datastore"},{"line_number":143,"context_line":"  must be given"},{"line_number":144,"context_line":"\"\"\"),"},{"line_number":145,"context_line":"    cfg.FloatOpt(\u0027task_poll_interval\u0027,"},{"line_number":146,"context_line":"                 default\u003d0.5,"}],"source_content_type":"text/x-python","patch_set":10,"id":"9ad45d7e_07ee178b","line":143,"range":{"start_line":143,"start_character":2,"end_line":143,"end_character":15},"in_reply_to":"9ad45d7e_963532f9","updated":"2016-08-08 18:28:09.000000000","message":"Added a note here saying so, please let me know if that looks good.","commit_id":"ea4898a78aab6f409f027fdbe76799e07b79ae6d"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"482334756f33dab19ae50f103732f5fca33afc82","unresolved":false,"context_lines":[{"line_number":146,"context_line":"                 default\u003d0.5,"},{"line_number":147,"context_line":"                 help\u003d\"\"\""},{"line_number":148,"context_line":"Time interval in seconds to poll remote tasks invoked on"},{"line_number":149,"context_line":"VMware VC server."},{"line_number":150,"context_line":"\"\"\"),"},{"line_number":151,"context_line":"    cfg.IntOpt(\u0027api_retry_count\u0027,"},{"line_number":152,"context_line":"               min\u003d0,"}],"source_content_type":"text/x-python","patch_set":10,"id":"9ad45d7e_b6179653","line":149,"updated":"2016-08-08 10:37:49.000000000","message":"I assume this is in seconds? We should be specific.","commit_id":"ea4898a78aab6f409f027fdbe76799e07b79ae6d"},{"author":{"_account_id":18339,"name":"Sivasathurappan Radhakrishnan","email":"siva.radhakrishnan@intel.com","username":"sivakrishnan"},"change_message_id":"2804518a7fb5c3d54b66a60e31acd8d6aa87520f","unresolved":false,"context_lines":[{"line_number":146,"context_line":"                 default\u003d0.5,"},{"line_number":147,"context_line":"                 help\u003d\"\"\""},{"line_number":148,"context_line":"Time interval in seconds to poll remote tasks invoked on"},{"line_number":149,"context_line":"VMware VC server."},{"line_number":150,"context_line":"\"\"\"),"},{"line_number":151,"context_line":"    cfg.IntOpt(\u0027api_retry_count\u0027,"},{"line_number":152,"context_line":"               min\u003d0,"}],"source_content_type":"text/x-python","patch_set":10,"id":"9ad45d7e_e7994321","line":149,"in_reply_to":"9ad45d7e_b6179653","updated":"2016-08-08 18:28:09.000000000","message":"Its mentioned as \"Time interval in seconds\" I am not sure what you were expecting. Please let me know if it has to be reworded.","commit_id":"ea4898a78aab6f409f027fdbe76799e07b79ae6d"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"11038ab48750d6fd3d855f1ebbaac94b46a7d173","unresolved":false,"context_lines":[{"line_number":115,"context_line":"then the default CA truststore is used for verification."},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"Related options:"},{"line_number":118,"context_line":"* ca_file: This options is ignored if \"ca_file\" is set."},{"line_number":119,"context_line":"\"\"\"),"},{"line_number":120,"context_line":"    cfg.StrOpt(\u0027cluster_name\u0027,"},{"line_number":121,"context_line":"               help\u003d\"Name of a VMware Cluster ComputeResource.\"),"}],"source_content_type":"text/x-python","patch_set":11,"id":"9ad45d7e_cd05b911","line":118,"range":{"start_line":118,"start_character":22,"end_line":118,"end_character":23},"updated":"2016-08-10 21:38:27.000000000","message":"s/options/option/","commit_id":"0ead76981cf04ea27450ddb4f3855d331c727df0"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"11038ab48750d6fd3d855f1ebbaac94b46a7d173","unresolved":false,"context_lines":[{"line_number":127,"context_line":"Compute. For example, datastore_regex\u003d\"nas.*\" selects all the data"},{"line_number":128,"context_line":"stores that have a name starting with \"nas\"."},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"NOTE:If no regex is given, it just picks the datastore with the"},{"line_number":131,"context_line":"most freespace."},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"Possible values:"}],"source_content_type":"text/x-python","patch_set":11,"id":"9ad45d7e_ad1b2572","line":130,"range":{"start_line":130,"start_character":4,"end_line":130,"end_character":5},"updated":"2016-08-10 21:38:27.000000000","message":"nit: nice to add a space after :","commit_id":"0ead76981cf04ea27450ddb4f3855d331c727df0"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"11038ab48750d6fd3d855f1ebbaac94b46a7d173","unresolved":false,"context_lines":[{"line_number":152,"context_line":"                help\u003d\"\"\""},{"line_number":153,"context_line":"This option specifies VNC starting port."},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"Every VM created by ESX host has a option of enabling VNC client"},{"line_number":156,"context_line":"for remote connection. Above option \u0027vnc_port\u0027 helps you to set"},{"line_number":157,"context_line":"default starting port for the VNC client."},{"line_number":158,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"9ad45d7e_ad496562","line":155,"range":{"start_line":155,"start_character":33,"end_line":155,"end_character":34},"updated":"2016-08-10 21:38:27.000000000","message":"s/a/an/","commit_id":"0ead76981cf04ea27450ddb4f3855d331c727df0"}]}