)]}'
{"nova/compute/manager.py":[{"author":{"_account_id":5652,"name":"David Ripton","email":"dripton@redhat.com","username":"dripton"},"change_message_id":"fead75f2b911401c3b09a8d8bb53947a0e0c306f","unresolved":false,"context_lines":[{"line_number":540,"context_line":"            try:"},{"line_number":541,"context_line":"                self._complete_partial_deletion(context, instance)"},{"line_number":542,"context_line":"            except Exception:"},{"line_number":543,"context_line":"                # we don\u0027t want that an excpetion blocks the init_host"},{"line_number":544,"context_line":"                msg \u003d _(\u0027Failed to complete a deletion\u0027)"},{"line_number":545,"context_line":"                LOG.exception(msg)"},{"line_number":546,"context_line":"            finally:"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAPn%2F%2F6Uk%3D","line":543,"updated":"2013-06-18 13:50:22.000000000","message":"s/excpetion/exception/","commit_id":"6d90e7abb9ce8b912b57d9588e4dca9d453a9de4"},{"author":{"_account_id":1865,"name":"Andrea Rosa","email":"andrea.rosa@gmail.com","username":"andrea-rosa-m"},"change_message_id":"48c008122647c4ee62441d4a987875c332ca9cef","unresolved":false,"context_lines":[{"line_number":540,"context_line":"            try:"},{"line_number":541,"context_line":"                self._complete_partial_deletion(context, instance)"},{"line_number":542,"context_line":"            except Exception:"},{"line_number":543,"context_line":"                # we don\u0027t want that an excpetion blocks the init_host"},{"line_number":544,"context_line":"                msg \u003d _(\u0027Failed to complete a deletion\u0027)"},{"line_number":545,"context_line":"                LOG.exception(msg)"},{"line_number":546,"context_line":"            finally:"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAPn%2F%2F37w%3D","line":543,"in_reply_to":"AAAAPn%2F%2F6Uk%3D","updated":"2013-06-19 10:20:57.000000000","message":"Done","commit_id":"6d90e7abb9ce8b912b57d9588e4dca9d453a9de4"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"250133149094194c1d5e8c1cc424b95ad10db319","unresolved":false,"context_lines":[{"line_number":541,"context_line":"                self._complete_partial_deletion(context, instance)"},{"line_number":542,"context_line":"            except Exception:"},{"line_number":543,"context_line":"                # we don\u0027t want that an exception blocks the init_host"},{"line_number":544,"context_line":"                msg \u003d _(\u0027Failed to complete a deletion\u0027)"},{"line_number":545,"context_line":"                LOG.exception(msg)"},{"line_number":546,"context_line":"            finally:"},{"line_number":547,"context_line":"                return"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAPn%2F%2FQAo%3D","line":544,"updated":"2013-07-06 06:11:31.000000000","message":"Is it worthwhile indicating the instance ID here?","commit_id":"a190781210f023ac25dbd583ba94cf454fb5a690"},{"author":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"change_message_id":"0646ccd18a3c9904caca20bcdd5f17b3436b2e82","unresolved":false,"context_lines":[{"line_number":541,"context_line":"                self._complete_partial_deletion(context, instance)"},{"line_number":542,"context_line":"            except Exception:"},{"line_number":543,"context_line":"                # we don\u0027t want that an exception blocks the init_host"},{"line_number":544,"context_line":"                msg \u003d _(\u0027Failed to complete a deletion\u0027)"},{"line_number":545,"context_line":"                LOG.exception(msg)"},{"line_number":546,"context_line":"            finally:"},{"line_number":547,"context_line":"                return"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAP3%2F%2F85o%3D","line":544,"in_reply_to":"AAAAPn%2F%2FQAo%3D","updated":"2013-07-08 17:23:38.000000000","message":"yes","commit_id":"a190781210f023ac25dbd583ba94cf454fb5a690"},{"author":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"change_message_id":"0646ccd18a3c9904caca20bcdd5f17b3436b2e82","unresolved":false,"context_lines":[{"line_number":542,"context_line":"            except Exception:"},{"line_number":543,"context_line":"                # we don\u0027t want that an exception blocks the init_host"},{"line_number":544,"context_line":"                msg \u003d _(\u0027Failed to complete a deletion\u0027)"},{"line_number":545,"context_line":"                LOG.exception(msg)"},{"line_number":546,"context_line":"            finally:"},{"line_number":547,"context_line":"                return"},{"line_number":548,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAP3%2F%2F85c%3D","line":545,"updated":"2013-07-08 17:23:38.000000000","message":"just add \", instance\u003dinstance) and the common logger code will handle it","commit_id":"a190781210f023ac25dbd583ba94cf454fb5a690"},{"author":{"_account_id":1865,"name":"Andrea Rosa","email":"andrea.rosa@gmail.com","username":"andrea-rosa-m"},"change_message_id":"44a0b72b5a0b77689934dc592394a3dbf27eec24","unresolved":false,"context_lines":[{"line_number":542,"context_line":"            except Exception:"},{"line_number":543,"context_line":"                # we don\u0027t want that an exception blocks the init_host"},{"line_number":544,"context_line":"                msg \u003d _(\u0027Failed to complete a deletion\u0027)"},{"line_number":545,"context_line":"                LOG.exception(msg)"},{"line_number":546,"context_line":"            finally:"},{"line_number":547,"context_line":"                return"},{"line_number":548,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAP3%2F%2F6mY%3D","line":545,"in_reply_to":"AAAAP3%2F%2F85c%3D","updated":"2013-07-09 09:11:12.000000000","message":"Done","commit_id":"a190781210f023ac25dbd583ba94cf454fb5a690"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"250133149094194c1d5e8c1cc424b95ad10db319","unresolved":false,"context_lines":[{"line_number":1427,"context_line":"                self.volume_api.delete(context, bdm[\u0027volume_id\u0027])"},{"line_number":1428,"context_line":"            # NOTE(vish): bdms will be deleted on instance destroy"},{"line_number":1429,"context_line":""},{"line_number":1430,"context_line":"    def _complete_deletion(self, context, instance, bdms,"},{"line_number":1431,"context_line":"                           reservations, prj_id, system_meta):"},{"line_number":1432,"context_line":""},{"line_number":1433,"context_line":"        self._quota_commit(context, reservations, project_id\u003dprj_id)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAPn%2F%2FQAk%3D","line":1430,"updated":"2013-07-06 06:11:31.000000000","message":"any reason why this function is not next to _complete_partial_deletion. It would have made the review a little easier :)","commit_id":"a190781210f023ac25dbd583ba94cf454fb5a690"},{"author":{"_account_id":1865,"name":"Andrea Rosa","email":"andrea.rosa@gmail.com","username":"andrea-rosa-m"},"change_message_id":"44a0b72b5a0b77689934dc592394a3dbf27eec24","unresolved":false,"context_lines":[{"line_number":1427,"context_line":"                self.volume_api.delete(context, bdm[\u0027volume_id\u0027])"},{"line_number":1428,"context_line":"            # NOTE(vish): bdms will be deleted on instance destroy"},{"line_number":1429,"context_line":""},{"line_number":1430,"context_line":"    def _complete_deletion(self, context, instance, bdms,"},{"line_number":1431,"context_line":"                           reservations, prj_id, system_meta):"},{"line_number":1432,"context_line":""},{"line_number":1433,"context_line":"        self._quota_commit(context, reservations, project_id\u003dprj_id)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAP3%2F%2F6mU%3D","line":1430,"in_reply_to":"AAAAP3%2F%2F85E%3D","updated":"2013-07-09 09:11:12.000000000","message":"sorry for that, done!","commit_id":"a190781210f023ac25dbd583ba94cf454fb5a690"},{"author":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"change_message_id":"0646ccd18a3c9904caca20bcdd5f17b3436b2e82","unresolved":false,"context_lines":[{"line_number":1427,"context_line":"                self.volume_api.delete(context, bdm[\u0027volume_id\u0027])"},{"line_number":1428,"context_line":"            # NOTE(vish): bdms will be deleted on instance destroy"},{"line_number":1429,"context_line":""},{"line_number":1430,"context_line":"    def _complete_deletion(self, context, instance, bdms,"},{"line_number":1431,"context_line":"                           reservations, prj_id, system_meta):"},{"line_number":1432,"context_line":""},{"line_number":1433,"context_line":"        self._quota_commit(context, reservations, project_id\u003dprj_id)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAP3%2F%2F85E%3D","line":1430,"in_reply_to":"AAAAPn%2F%2FQAk%3D","updated":"2013-07-08 17:23:38.000000000","message":"+1","commit_id":"a190781210f023ac25dbd583ba94cf454fb5a690"}]}