)]}'
{"nova/conf/cert.py":[{"author":{"_account_id":6735,"name":"Bob Ball","email":"bob.ball@citrix.com","username":"bob-ball"},"change_message_id":"a3188b3bb064268a7e4b1e7bfa2df4b616e26e33","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Possible values:"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"Any string. The default is cert."},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"* Related options:"},{"line_number":30,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3aaa91ec_31eff4e9","line":27,"updated":"2016-06-22 11:48:49.000000000","message":"Based on http://specs.openstack.org/openstack/nova-specs/specs/mitaka/implemented/centralize-config-options.html I don\u0027t think we need to specify a default in the help text as the generated list of options should include the default value?\n\nAlso note that the default is included earlier in this same help text.","commit_id":"efe5911b634232aa44f0adf323e3bbcf4e93d40c"},{"author":{"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},"change_message_id":"8575ec36f2516486f1db703c909ffe3a3e5837a7","unresolved":false,"context_lines":[{"line_number":19,"context_line":"cert_topic_opt \u003d cfg.StrOpt(\"cert_topic\","},{"line_number":20,"context_line":"        default\u003d\"cert\","},{"line_number":21,"context_line":"        help\u003d\"\"\""},{"line_number":22,"context_line":"Determines the RPC topic that the cert nodes listen on. The default is \u0027cert\u0027,"},{"line_number":23,"context_line":"and for most deployments there is no need to ever change it."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Possible values:"}],"source_content_type":"text/x-python","patch_set":2,"id":"3aaa91ec_aa6363db","line":22,"range":{"start_line":22,"start_character":56,"end_line":22,"end_character":77},"updated":"2016-06-22 14:58:07.000000000","message":"I think this section should go in possible values as a default. The above default variable does not show in the documentation, so you need to point that out in \"Possible value section\"","commit_id":"77c08f63d4dd22848c8709e0e3ddbbb235a9a5fd"},{"author":{"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},"change_message_id":"4981c5cdecfc120bc4088f8adc8b0937659f0465","unresolved":false,"context_lines":[{"line_number":19,"context_line":"cert_topic_opt \u003d cfg.StrOpt(\"cert_topic\","},{"line_number":20,"context_line":"        default\u003d\"cert\","},{"line_number":21,"context_line":"        help\u003d\"\"\""},{"line_number":22,"context_line":"Determines the RPC topic that the cert nodes listen on. The default is \u0027cert\u0027,"},{"line_number":23,"context_line":"and for most deployments there is no need to ever change it."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Possible values:"}],"source_content_type":"text/x-python","patch_set":2,"id":"3aaa91ec_5ed9dd82","line":22,"range":{"start_line":22,"start_character":56,"end_line":22,"end_character":77},"in_reply_to":"3aaa91ec_53227602","updated":"2016-06-22 16:01:08.000000000","message":"+1","commit_id":"77c08f63d4dd22848c8709e0e3ddbbb235a9a5fd"},{"author":{"_account_id":19845,"name":"Anush Krishnamurthy","email":"anush.krishnamurthy@intel.com","username":"akrish9"},"change_message_id":"e93241bcba40cb324f2c843d136b940e518baaa5","unresolved":false,"context_lines":[{"line_number":19,"context_line":"cert_topic_opt \u003d cfg.StrOpt(\"cert_topic\","},{"line_number":20,"context_line":"        default\u003d\"cert\","},{"line_number":21,"context_line":"        help\u003d\"\"\""},{"line_number":22,"context_line":"Determines the RPC topic that the cert nodes listen on. The default is \u0027cert\u0027,"},{"line_number":23,"context_line":"and for most deployments there is no need to ever change it."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Possible values:"}],"source_content_type":"text/x-python","patch_set":2,"id":"3aaa91ec_bee8c111","line":22,"range":{"start_line":22,"start_character":56,"end_line":22,"end_character":77},"in_reply_to":"3aaa91ec_53227602","updated":"2016-06-22 16:00:18.000000000","message":"Done","commit_id":"77c08f63d4dd22848c8709e0e3ddbbb235a9a5fd"},{"author":{"_account_id":6735,"name":"Bob Ball","email":"bob.ball@citrix.com","username":"bob-ball"},"change_message_id":"ce15ba315980991663c4688f198b663536147b92","unresolved":false,"context_lines":[{"line_number":19,"context_line":"cert_topic_opt \u003d cfg.StrOpt(\"cert_topic\","},{"line_number":20,"context_line":"        default\u003d\"cert\","},{"line_number":21,"context_line":"        help\u003d\"\"\""},{"line_number":22,"context_line":"Determines the RPC topic that the cert nodes listen on. The default is \u0027cert\u0027,"},{"line_number":23,"context_line":"and for most deployments there is no need to ever change it."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Possible values:"}],"source_content_type":"text/x-python","patch_set":2,"id":"3aaa91ec_53227602","line":22,"range":{"start_line":22,"start_character":56,"end_line":22,"end_character":77},"in_reply_to":"3aaa91ec_5347161d","updated":"2016-06-22 15:51:42.000000000","message":"I would say in this section we should have \"For most deployments, there is no need to change from the default\" and just state \"Any string, default is \u0027cert\u0027\" in the possible values?","commit_id":"77c08f63d4dd22848c8709e0e3ddbbb235a9a5fd"},{"author":{"_account_id":6735,"name":"Bob Ball","email":"bob.ball@citrix.com","username":"bob-ball"},"change_message_id":"93a45ca83acd05af7065f4ad3fa81443a76c01a7","unresolved":false,"context_lines":[{"line_number":19,"context_line":"cert_topic_opt \u003d cfg.StrOpt(\"cert_topic\","},{"line_number":20,"context_line":"        default\u003d\"cert\","},{"line_number":21,"context_line":"        help\u003d\"\"\""},{"line_number":22,"context_line":"Determines the RPC topic that the cert nodes listen on. The default is \u0027cert\u0027,"},{"line_number":23,"context_line":"and for most deployments there is no need to ever change it."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Possible values:"}],"source_content_type":"text/x-python","patch_set":2,"id":"3aaa91ec_b31e3a61","line":22,"range":{"start_line":22,"start_character":56,"end_line":22,"end_character":77},"in_reply_to":"3aaa91ec_aa6363db","updated":"2016-06-22 15:42:49.000000000","message":"Sorry; this was removed in the previous change by my suggestion.  I agree with you here; move the default being \u0027cert\u0027 to Possible values section.","commit_id":"77c08f63d4dd22848c8709e0e3ddbbb235a9a5fd"},{"author":{"_account_id":19845,"name":"Anush Krishnamurthy","email":"anush.krishnamurthy@intel.com","username":"akrish9"},"change_message_id":"35356d5c9269e2639123abcb9bc4e4069b731678","unresolved":false,"context_lines":[{"line_number":19,"context_line":"cert_topic_opt \u003d cfg.StrOpt(\"cert_topic\","},{"line_number":20,"context_line":"        default\u003d\"cert\","},{"line_number":21,"context_line":"        help\u003d\"\"\""},{"line_number":22,"context_line":"Determines the RPC topic that the cert nodes listen on. The default is \u0027cert\u0027,"},{"line_number":23,"context_line":"and for most deployments there is no need to ever change it."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Possible values:"}],"source_content_type":"text/x-python","patch_set":2,"id":"3aaa91ec_5347161d","line":22,"range":{"start_line":22,"start_character":56,"end_line":22,"end_character":77},"in_reply_to":"3aaa91ec_b31e3a61","updated":"2016-06-22 15:48:13.000000000","message":"Should the whole line go under the \"* Possible Values:\" starting from \"The default is \u0027cert\u0027, and for most deployments there is no need to ever change it\" ??","commit_id":"77c08f63d4dd22848c8709e0e3ddbbb235a9a5fd"},{"author":{"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},"change_message_id":"8575ec36f2516486f1db703c909ffe3a3e5837a7","unresolved":false,"context_lines":[{"line_number":22,"context_line":"Determines the RPC topic that the cert nodes listen on. The default is \u0027cert\u0027,"},{"line_number":23,"context_line":"and for most deployments there is no need to ever change it."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Possible values:"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"Any string. "},{"line_number":28,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3aaa91ec_e74ac482","line":25,"range":{"start_line":25,"start_character":0,"end_line":25,"end_character":8},"updated":"2016-06-22 14:58:07.000000000","message":"For consistency make it like other headers \"* Possible values:\"","commit_id":"77c08f63d4dd22848c8709e0e3ddbbb235a9a5fd"},{"author":{"_account_id":19845,"name":"Anush Krishnamurthy","email":"anush.krishnamurthy@intel.com","username":"akrish9"},"change_message_id":"e93241bcba40cb324f2c843d136b940e518baaa5","unresolved":false,"context_lines":[{"line_number":22,"context_line":"Determines the RPC topic that the cert nodes listen on. The default is \u0027cert\u0027,"},{"line_number":23,"context_line":"and for most deployments there is no need to ever change it."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Possible values:"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"Any string. "},{"line_number":28,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3aaa91ec_ded30d5e","line":25,"range":{"start_line":25,"start_character":0,"end_line":25,"end_character":8},"in_reply_to":"3aaa91ec_e74ac482","updated":"2016-06-22 16:00:18.000000000","message":"Done","commit_id":"77c08f63d4dd22848c8709e0e3ddbbb235a9a5fd"},{"author":{"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},"change_message_id":"8575ec36f2516486f1db703c909ffe3a3e5837a7","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Possible values:"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"Any string. "},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"* Related options:"},{"line_number":30,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3aaa91ec_27b7ac87","line":27,"range":{"start_line":27,"start_character":0,"end_line":27,"end_character":12},"updated":"2016-06-22 14:58:07.000000000","message":"Missing a tab (4 spaces) in the beginning.","commit_id":"77c08f63d4dd22848c8709e0e3ddbbb235a9a5fd"},{"author":{"_account_id":19845,"name":"Anush Krishnamurthy","email":"anush.krishnamurthy@intel.com","username":"akrish9"},"change_message_id":"35356d5c9269e2639123abcb9bc4e4069b731678","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Possible values:"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"Any string. "},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"* Related options:"},{"line_number":30,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3aaa91ec_b36d9a9a","line":27,"range":{"start_line":27,"start_character":0,"end_line":27,"end_character":12},"in_reply_to":"3aaa91ec_27b7ac87","updated":"2016-06-22 15:48:13.000000000","message":"Should this still be in the Possible Values section when the Default string is added.","commit_id":"77c08f63d4dd22848c8709e0e3ddbbb235a9a5fd"},{"author":{"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},"change_message_id":"4981c5cdecfc120bc4088f8adc8b0937659f0465","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Possible values:"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"Any string. "},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"* Related options:"},{"line_number":30,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3aaa91ec_9eba2509","line":27,"range":{"start_line":27,"start_character":0,"end_line":27,"end_character":12},"in_reply_to":"3aaa91ec_b36d9a9a","updated":"2016-06-22 16:01:08.000000000","message":"yes, as it is possible to be any string.","commit_id":"77c08f63d4dd22848c8709e0e3ddbbb235a9a5fd"},{"author":{"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},"change_message_id":"6813fc430dcda996f07a49016dd6b804156c86bb","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"cert_topic_opt \u003d cfg.StrOpt(\"cert_topic\","},{"line_number":20,"context_line":"        default\u003d\"cert\","},{"line_number":21,"context_line":"        help\u003d\"\"\""},{"line_number":22,"context_line":"Determines the RPC topic that the cert nodes listen on. For most deployments there is no need to ever change it."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"* Possible values:"},{"line_number":25,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3aaa91ec_5e08bd2d","line":22,"range":{"start_line":21,"start_character":2,"end_line":22,"end_character":112},"updated":"2016-06-22 16:16:08.000000000","message":"line too long, you are going to get pep8 failure. It should be \u003c\u003d79","commit_id":"a7278b8c1fda41fb13e571ad916cb6af3f7b877d"},{"author":{"_account_id":18339,"name":"Sivasathurappan Radhakrishnan","email":"siva.radhakrishnan@intel.com","username":"sivakrishnan"},"change_message_id":"081f1a9fd45988e095b8b59c3ddab69920e07acb","unresolved":false,"context_lines":[{"line_number":27,"context_line":"    Any string, the default is \u0027cert\u0027."},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"* Related options:"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    None"},{"line_number":32,"context_line":"\"\"\")"},{"line_number":33,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"3aaa91ec_733fd6d6","line":30,"updated":"2016-06-27 21:44:02.000000000","message":"Related options can be removed if it is none","commit_id":"6cfcacd1b6ccc3b1f5a4c46e384dd41433e8c7ac"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"43da56bde1983f6720b6d8b960ccd8792c276e49","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# needs:fix_opt_description"},{"line_number":2,"context_line":"# needs:check_deprecation_status"},{"line_number":3,"context_line":"# needs:check_opt_group_and_type"},{"line_number":4,"context_line":"# needs:fix_opt_description_indentation"},{"line_number":5,"context_line":"# needs:fix_opt_registration_consistency"}],"source_content_type":"text/x-python","patch_set":8,"id":"dada55a8_75c29dea","line":2,"range":{"start_line":2,"start_character":0,"end_line":2,"end_character":32},"updated":"2016-07-26 13:45:35.000000000","message":"I think you can delete all these tags, except the deprecation status one.\n\nWe should put up a follow up patch to deprecate this option. We don\u0027t need it, in addition I believe the cert service will be deprecated soon.","commit_id":"e547a2fd1bf3276947916041d249110e1bc21198"},{"author":{"_account_id":19845,"name":"Anush Krishnamurthy","email":"anush.krishnamurthy@intel.com","username":"akrish9"},"change_message_id":"c4ce5e4a71655734f1d0fdbc1ac49a1d2ac9cfe2","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# needs:fix_opt_description"},{"line_number":2,"context_line":"# needs:check_deprecation_status"},{"line_number":3,"context_line":"# needs:check_opt_group_and_type"},{"line_number":4,"context_line":"# needs:fix_opt_description_indentation"},{"line_number":5,"context_line":"# needs:fix_opt_registration_consistency"}],"source_content_type":"text/x-python","patch_set":8,"id":"dada55a8_7b144be8","line":2,"range":{"start_line":2,"start_character":0,"end_line":2,"end_character":32},"in_reply_to":"dada55a8_75c29dea","updated":"2016-07-26 14:27:02.000000000","message":"I have done this. I have marked it for \"deprecated_for_removal\u003dTrue\"","commit_id":"e547a2fd1bf3276947916041d249110e1bc21198"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"12f7d1fdad16225236b30f0edf65a6d264f84668","unresolved":false,"context_lines":[{"line_number":30,"context_line":"Determines the RPC topic that the cert nodes listen on. For most deployments"},{"line_number":31,"context_line":"there is no need to ever change it."},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"Possible values:"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"* Any string, the default is \u0027cert\u0027."},{"line_number":36,"context_line":"\"\"\"),"},{"line_number":37,"context_line":"]"},{"line_number":38,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"dada55a8_b5b255e3","line":35,"range":{"start_line":33,"start_character":0,"end_line":35,"end_character":36},"updated":"2016-07-26 13:40:33.000000000","message":"Honestly, I would drop that bit, it doesn\u0027t really say anything. Its really any valid AMPQ topic name.","commit_id":"e547a2fd1bf3276947916041d249110e1bc21198"},{"author":{"_account_id":19845,"name":"Anush Krishnamurthy","email":"anush.krishnamurthy@intel.com","username":"akrish9"},"change_message_id":"c4ce5e4a71655734f1d0fdbc1ac49a1d2ac9cfe2","unresolved":false,"context_lines":[{"line_number":30,"context_line":"Determines the RPC topic that the cert nodes listen on. For most deployments"},{"line_number":31,"context_line":"there is no need to ever change it."},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"Possible values:"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"* Any string, the default is \u0027cert\u0027."},{"line_number":36,"context_line":"\"\"\"),"},{"line_number":37,"context_line":"]"},{"line_number":38,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"dada55a8_1bda6f4b","line":35,"range":{"start_line":33,"start_character":0,"end_line":35,"end_character":36},"in_reply_to":"dada55a8_b5b255e3","updated":"2016-07-26 14:27:02.000000000","message":"Done","commit_id":"e547a2fd1bf3276947916041d249110e1bc21198"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"fc36404294cd8f1e9795617eb6a0f6dd3e7c4e07","unresolved":false,"context_lines":[{"line_number":36,"context_line":"\"\"\"),"},{"line_number":37,"context_line":"]"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"ALL_OPTS \u003d (cert_opts)"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"def register_opts(conf):"}],"source_content_type":"text/x-python","patch_set":8,"id":"dada55a8_b50ed589","line":39,"updated":"2016-07-26 13:41:50.000000000","message":"Do we need this here?","commit_id":"e547a2fd1bf3276947916041d249110e1bc21198"},{"author":{"_account_id":19845,"name":"Anush Krishnamurthy","email":"anush.krishnamurthy@intel.com","username":"akrish9"},"change_message_id":"c4ce5e4a71655734f1d0fdbc1ac49a1d2ac9cfe2","unresolved":false,"context_lines":[{"line_number":36,"context_line":"\"\"\"),"},{"line_number":37,"context_line":"]"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"ALL_OPTS \u003d (cert_opts)"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"def register_opts(conf):"}],"source_content_type":"text/x-python","patch_set":8,"id":"dada55a8_5be867e2","line":39,"in_reply_to":"dada55a8_35e02596","updated":"2016-07-26 14:27:02.000000000","message":"Done","commit_id":"e547a2fd1bf3276947916041d249110e1bc21198"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"b6b0ab923b686c428a1bd799a9d6db5580e84ef6","unresolved":false,"context_lines":[{"line_number":36,"context_line":"\"\"\"),"},{"line_number":37,"context_line":"]"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"ALL_OPTS \u003d (cert_opts)"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"def register_opts(conf):"}],"source_content_type":"text/x-python","patch_set":8,"id":"dada55a8_5597988f","line":39,"in_reply_to":"dada55a8_35e02596","updated":"2016-07-26 13:50:50.000000000","message":"I advised it. Since it is a single option list is not really required, but IMO having a list even with a single value keeps all options tip-top consistent and makes adding new options super easy.\n\nAt some point list was created, either with named single value or not, so it makes a perfect sense to me :)","commit_id":"e547a2fd1bf3276947916041d249110e1bc21198"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"43da56bde1983f6720b6d8b960ccd8792c276e49","unresolved":false,"context_lines":[{"line_number":36,"context_line":"\"\"\"),"},{"line_number":37,"context_line":"]"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"ALL_OPTS \u003d (cert_opts)"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"def register_opts(conf):"}],"source_content_type":"text/x-python","patch_set":8,"id":"dada55a8_35e02596","line":39,"in_reply_to":"dada55a8_b50ed589","updated":"2016-07-26 13:45:35.000000000","message":"Yeah, I think just drop this.","commit_id":"e547a2fd1bf3276947916041d249110e1bc21198"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"f421ff81b8e74c518a0731c6b04a8c5d7303a95b","unresolved":false,"context_lines":[{"line_number":21,"context_line":"cert_opts \u003d ["},{"line_number":22,"context_line":"    cfg.StrOpt(\"cert_topic\","},{"line_number":23,"context_line":"        default\u003d\"cert\","},{"line_number":24,"context_line":"        deprecated_for_removal\u003dTrue,"},{"line_number":25,"context_line":"        help\u003d\"\"\""},{"line_number":26,"context_line":"Determines the RPC topic that the cert nodes listen on. For most deployments"},{"line_number":27,"context_line":"there is no need to ever change it."}],"source_content_type":"text/x-python","patch_set":10,"id":"dada55a8_647dc81b","line":24,"updated":"2016-07-26 15:23:01.000000000","message":"We can\u0027t do that here, it needs a reno note adding, lets do that in a follow up patch.","commit_id":"a519cc5e99716bbad690374a74658cfdb7ebca35"},{"author":{"_account_id":20217,"name":"Anusha Unnam","email":"anusha.unnam25@gmail.com","username":"aunnam"},"change_message_id":"00be3370524ee745bd24a09b4c46428108a21617","unresolved":false,"context_lines":[{"line_number":21,"context_line":"cert_opts \u003d ["},{"line_number":22,"context_line":"    cfg.StrOpt(\"cert_topic\","},{"line_number":23,"context_line":"        default\u003d\"cert\","},{"line_number":24,"context_line":"        deprecated_for_removal\u003dTrue,"},{"line_number":25,"context_line":"        help\u003d\"\"\""},{"line_number":26,"context_line":"Determines the RPC topic that the cert nodes listen on. For most deployments"},{"line_number":27,"context_line":"there is no need to ever change it."}],"source_content_type":"text/x-python","patch_set":10,"id":"dada55a8_e69c126c","line":24,"in_reply_to":"dada55a8_24b3d09b","updated":"2016-07-26 19:06:24.000000000","message":"Anush, this is the link for reno note\nhttp://docs.openstack.org/developer/reno/usage.html","commit_id":"a519cc5e99716bbad690374a74658cfdb7ebca35"},{"author":{"_account_id":19845,"name":"Anush Krishnamurthy","email":"anush.krishnamurthy@intel.com","username":"akrish9"},"change_message_id":"aaf20d346935daebbc938196314e9ef9eef11680","unresolved":false,"context_lines":[{"line_number":21,"context_line":"cert_opts \u003d ["},{"line_number":22,"context_line":"    cfg.StrOpt(\"cert_topic\","},{"line_number":23,"context_line":"        default\u003d\"cert\","},{"line_number":24,"context_line":"        deprecated_for_removal\u003dTrue,"},{"line_number":25,"context_line":"        help\u003d\"\"\""},{"line_number":26,"context_line":"Determines the RPC topic that the cert nodes listen on. For most deployments"},{"line_number":27,"context_line":"there is no need to ever change it."}],"source_content_type":"text/x-python","patch_set":10,"id":"dada55a8_24b3d09b","line":24,"in_reply_to":"dada55a8_647dc81b","updated":"2016-07-26 15:30:29.000000000","message":"Okay. Don\u0027t know how to do a reno note.","commit_id":"a519cc5e99716bbad690374a74658cfdb7ebca35"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"f421ff81b8e74c518a0731c6b04a8c5d7303a95b","unresolved":false,"context_lines":[{"line_number":25,"context_line":"        help\u003d\"\"\""},{"line_number":26,"context_line":"Determines the RPC topic that the cert nodes listen on. For most deployments"},{"line_number":27,"context_line":"there is no need to ever change it."},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"\"\"\"),"},{"line_number":30,"context_line":"]"},{"line_number":31,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"dada55a8_8470bc41","line":28,"updated":"2016-07-26 15:23:01.000000000","message":"Nit: we shouldn\u0027t have this space here.","commit_id":"a519cc5e99716bbad690374a74658cfdb7ebca35"},{"author":{"_account_id":19845,"name":"Anush Krishnamurthy","email":"anush.krishnamurthy@intel.com","username":"akrish9"},"change_message_id":"aaf20d346935daebbc938196314e9ef9eef11680","unresolved":false,"context_lines":[{"line_number":25,"context_line":"        help\u003d\"\"\""},{"line_number":26,"context_line":"Determines the RPC topic that the cert nodes listen on. For most deployments"},{"line_number":27,"context_line":"there is no need to ever change it."},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"\"\"\"),"},{"line_number":30,"context_line":"]"},{"line_number":31,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"dada55a8_a4a7c04e","line":28,"in_reply_to":"dada55a8_8470bc41","updated":"2016-07-26 15:30:29.000000000","message":"Done","commit_id":"a519cc5e99716bbad690374a74658cfdb7ebca35"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"690dc42a79900690115a54140ad1ba55d03689b4","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# needs:check_deprecation_status"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# Copyright 2016 IBM Corp."},{"line_number":4,"context_line":"# Copyright 2016 OpenStack Foundation"}],"source_content_type":"text/x-python","patch_set":12,"id":"dada55a8_6958cf31","line":1,"updated":"2016-07-27 12:41:56.000000000","message":"yeah, we should deprecate this, but lets make that a follow on change.","commit_id":"ca360408dc340d1e0668c5632fe6aed587cb1e6c"}]}