)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"819e668dfe52b79fd10faf38b52b21e7dc9a3af9","unresolved":false,"context_lines":[{"line_number":12,"context_line":"been done."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"We need some prep work:"},{"line_number":15,"context_line":"* finish port_update unit tests in mock"},{"line_number":16,"context_line":"* add mock based allocate_for_instance tests"},{"line_number":17,"context_line":"* extract the validate and create calls into a separate method"},{"line_number":18,"context_line":"* worry about payload going over RPC, create o.vo objects to carry data"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Note: if we get all this done, it would mean we can move the port_create"},{"line_number":21,"context_line":"next cycle, because computes will know how to skip port_create, if"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3aaa91ec_39352ff7","line":18,"range":{"start_line":15,"start_character":0,"end_line":18,"end_character":71},"updated":"2016-06-27 22:32:54.000000000","message":"can we help in any of these?","commit_id":"e7a988e2fe022e96e10a13fce0d0a8f7f497e099"}],"nova/network/neutronv2/api.py":[{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"4c6b4854adfb463de6bb264f4d60f683dffe919b","unresolved":false,"context_lines":[{"line_number":597,"context_line":""},{"line_number":598,"context_line":"        return {net[\u0027id\u0027]: net for net in nets}"},{"line_number":599,"context_line":""},{"line_number":600,"context_line":"    def _create_ports_for_instance(self, context, instance, ordered_networks,"},{"line_number":601,"context_line":"            nets, neutron, security_group_ids, ports):"},{"line_number":602,"context_line":"        \"\"\"Create port for network_requests that don\u0027t have a port_id"},{"line_number":603,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3aaa91ec_b7a2c398","line":600,"range":{"start_line":600,"start_character":8,"end_line":600,"end_character":34},"updated":"2016-06-28 01:28:12.000000000","message":"I find this method name mis-leading. Granted, a lot of what the method does is create ports. But it also adds the existing ports to the raw_nw_info data structure, which I think is going to play an important role in the conductor and scheduler. _create_ports_and_process_existing_ports_for_instance maybe?","commit_id":"e7a988e2fe022e96e10a13fce0d0a8f7f497e099"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"39829062dbb69860533ab093ff564aafb7a837ad","unresolved":false,"context_lines":[{"line_number":659,"context_line":"                        self._delete_ports("},{"line_number":660,"context_line":"                            neutron, instance, created_port_ids)"},{"line_number":661,"context_line":""},{"line_number":662,"context_line":"        return raw_nw_info"},{"line_number":663,"context_line":""},{"line_number":664,"context_line":"    def allocate_for_instance(self, context, instance, **kwargs):"},{"line_number":665,"context_line":"        \"\"\"Allocate network resources for the instance."}],"source_content_type":"text/x-python","patch_set":3,"id":"3aaa91ec_99e703ac","line":662,"range":{"start_line":662,"start_character":15,"end_line":662,"end_character":26},"updated":"2016-06-27 22:30:52.000000000","message":"Is this going to be the data that we will feed the scheduler from the conductor to be used in conjunction with generic resource pools to make the placement decision?","commit_id":"e7a988e2fe022e96e10a13fce0d0a8f7f497e099"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"39829062dbb69860533ab093ff564aafb7a837ad","unresolved":false,"context_lines":[{"line_number":689,"context_line":"        # if not already done, i.e. when results passed as raw_nw_info"},{"line_number":690,"context_line":"        #"},{"line_number":691,"context_line":"        raw_nw_info \u003d kwargs.get(\u0027raw_nw_info\u0027)"},{"line_number":692,"context_line":"        if not raw_nw_info:"},{"line_number":693,"context_line":"            LOG.debug(\u0027allocate_for_instance()\u0027, instance\u003dinstance)"},{"line_number":694,"context_line":"            if not instance.project_id:"},{"line_number":695,"context_line":"                msg \u003d _(\u0027empty project id for instance %s\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3aaa91ec_f9a60752","line":692,"updated":"2016-06-27 22:30:52.000000000","message":"Is the code in this branch of the if going to be a method that will be called from the conductor prior to calling the scheduler?","commit_id":"e7a988e2fe022e96e10a13fce0d0a8f7f497e099"}]}