)]}'
{"nova/api/metadata/password.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"f14cf02dd25dc67d4a140a22418ce99d7675451a","unresolved":false,"context_lines":[{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    Password is stored with the keys \u0027password_0\u0027 -\u003e \u0027password_3\u0027."},{"line_number":44,"context_line":"    \"\"\""},{"line_number":45,"context_line":"    if not password:"},{"line_number":46,"context_line":"        password \u003d \u0027\u0027"},{"line_number":47,"context_line":"    elif six.PY3 and isinstance(password, bytes):"},{"line_number":48,"context_line":"        password \u003d password.decode(\u0027utf-8\u0027)"},{"line_number":49,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"3aaa91ec_bdb4cb81","line":46,"range":{"start_line":45,"start_character":4,"end_line":46,"end_character":21},"updated":"2016-06-30 14:06:51.000000000","message":"nit: is this not valid Python 3?","commit_id":"5f0b305e0511a4ad70f11751126321cebea2c866"},{"author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"change_message_id":"6d10ad51d736aae0b5c59a3044204bdb463a060c","unresolved":false,"context_lines":[{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    Password is stored with the keys \u0027password_0\u0027 -\u003e \u0027password_3\u0027."},{"line_number":44,"context_line":"    \"\"\""},{"line_number":45,"context_line":"    if not password:"},{"line_number":46,"context_line":"        password \u003d \u0027\u0027"},{"line_number":47,"context_line":"    elif six.PY3 and isinstance(password, bytes):"},{"line_number":48,"context_line":"        password \u003d password.decode(\u0027utf-8\u0027)"},{"line_number":49,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"3aaa91ec_5e9e7a63","line":46,"range":{"start_line":45,"start_character":4,"end_line":46,"end_character":21},"in_reply_to":"3aaa91ec_bdb4cb81","updated":"2016-06-30 15:16:08.000000000","message":"it is valid. well, i reverted the original code.","commit_id":"5f0b305e0511a4ad70f11751126321cebea2c866"},{"author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"change_message_id":"72f38e8d7e21e98daee6fd9f55600a185f638c42","unresolved":false,"context_lines":[{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    Password is stored with the keys \u0027password_0\u0027 -\u003e \u0027password_3\u0027."},{"line_number":44,"context_line":"    \"\"\""},{"line_number":45,"context_line":"    if not password:"},{"line_number":46,"context_line":"        password \u003d \u0027\u0027"},{"line_number":47,"context_line":"    elif six.PY3 and isinstance(password, bytes):"},{"line_number":48,"context_line":"        password \u003d password.decode(\u0027utf-8\u0027)"},{"line_number":49,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"3aaa91ec_bb6fb0c2","line":46,"range":{"start_line":45,"start_character":4,"end_line":46,"end_character":21},"in_reply_to":"3aaa91ec_bdb4cb81","updated":"2016-06-30 15:15:34.000000000","message":"it is valid. well, i reverted the original code.","commit_id":"5f0b305e0511a4ad70f11751126321cebea2c866"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"f14cf02dd25dc67d4a140a22418ce99d7675451a","unresolved":false,"context_lines":[{"line_number":37,"context_line":"    return result or None"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"def convert_password(context, password):"},{"line_number":41,"context_line":"    \"\"\"Stores password as system_metadata items."},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    Password is stored with the keys \u0027password_0\u0027 -\u003e \u0027password_3\u0027."},{"line_number":44,"context_line":"    \"\"\""},{"line_number":45,"context_line":"    if not password:"},{"line_number":46,"context_line":"        password \u003d \u0027\u0027"},{"line_number":47,"context_line":"    elif six.PY3 and isinstance(password, bytes):"},{"line_number":48,"context_line":"        password \u003d password.decode(\u0027utf-8\u0027)"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    meta \u003d {}"},{"line_number":51,"context_line":"    index \u003d 0"},{"line_number":52,"context_line":"    for chunk in range(CHUNKS):"},{"line_number":53,"context_line":"        meta[\u0027password_%d\u0027 % chunk] \u003d password[index:index + CHUNK_LENGTH]"},{"line_number":54,"context_line":"        index +\u003d CHUNK_LENGTH"},{"line_number":55,"context_line":"    return meta"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"def handle_password(req, meta_data):"}],"source_content_type":"text/x-python","patch_set":5,"id":"3aaa91ec_5d368703","line":55,"range":{"start_line":40,"start_character":0,"end_line":55,"end_character":15},"updated":"2016-06-30 14:06:51.000000000","message":"While an improvement, I think that this should be a separate change","commit_id":"5f0b305e0511a4ad70f11751126321cebea2c866"},{"author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"change_message_id":"6d10ad51d736aae0b5c59a3044204bdb463a060c","unresolved":false,"context_lines":[{"line_number":37,"context_line":"    return result or None"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"def convert_password(context, password):"},{"line_number":41,"context_line":"    \"\"\"Stores password as system_metadata items."},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    Password is stored with the keys \u0027password_0\u0027 -\u003e \u0027password_3\u0027."},{"line_number":44,"context_line":"    \"\"\""},{"line_number":45,"context_line":"    if not password:"},{"line_number":46,"context_line":"        password \u003d \u0027\u0027"},{"line_number":47,"context_line":"    elif six.PY3 and isinstance(password, bytes):"},{"line_number":48,"context_line":"        password \u003d password.decode(\u0027utf-8\u0027)"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    meta \u003d {}"},{"line_number":51,"context_line":"    index \u003d 0"},{"line_number":52,"context_line":"    for chunk in range(CHUNKS):"},{"line_number":53,"context_line":"        meta[\u0027password_%d\u0027 % chunk] \u003d password[index:index + CHUNK_LENGTH]"},{"line_number":54,"context_line":"        index +\u003d CHUNK_LENGTH"},{"line_number":55,"context_line":"    return meta"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"def handle_password(req, meta_data):"}],"source_content_type":"text/x-python","patch_set":5,"id":"3aaa91ec_3e99ee79","line":55,"range":{"start_line":40,"start_character":0,"end_line":55,"end_character":15},"in_reply_to":"3aaa91ec_5d368703","updated":"2016-06-30 15:16:08.000000000","message":"ok, i restored the original code.\n\nsorry, i don\u0027t think that it\u0027s worth it to write a separated change (and I don\u0027t expect that anyone will review it :-)).","commit_id":"5f0b305e0511a4ad70f11751126321cebea2c866"},{"author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"change_message_id":"72f38e8d7e21e98daee6fd9f55600a185f638c42","unresolved":false,"context_lines":[{"line_number":37,"context_line":"    return result or None"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"def convert_password(context, password):"},{"line_number":41,"context_line":"    \"\"\"Stores password as system_metadata items."},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    Password is stored with the keys \u0027password_0\u0027 -\u003e \u0027password_3\u0027."},{"line_number":44,"context_line":"    \"\"\""},{"line_number":45,"context_line":"    if not password:"},{"line_number":46,"context_line":"        password \u003d \u0027\u0027"},{"line_number":47,"context_line":"    elif six.PY3 and isinstance(password, bytes):"},{"line_number":48,"context_line":"        password \u003d password.decode(\u0027utf-8\u0027)"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    meta \u003d {}"},{"line_number":51,"context_line":"    index \u003d 0"},{"line_number":52,"context_line":"    for chunk in range(CHUNKS):"},{"line_number":53,"context_line":"        meta[\u0027password_%d\u0027 % chunk] \u003d password[index:index + CHUNK_LENGTH]"},{"line_number":54,"context_line":"        index +\u003d CHUNK_LENGTH"},{"line_number":55,"context_line":"    return meta"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"def handle_password(req, meta_data):"}],"source_content_type":"text/x-python","patch_set":5,"id":"3aaa91ec_fb65b8e0","line":55,"range":{"start_line":40,"start_character":0,"end_line":55,"end_character":15},"in_reply_to":"3aaa91ec_5d368703","updated":"2016-06-30 15:15:34.000000000","message":"ok, i restored the original code.\n\nsorry, i don\u0027t think that it\u0027s worth it to write a separated change (and I don\u0027t expect that anyone will review it :-)).","commit_id":"5f0b305e0511a4ad70f11751126321cebea2c866"}]}