)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7764,"name":"Peter Hamilton","email":"peter.hamilton@jhuapl.edu","username":"Peter"},"change_message_id":"ddde4c627808a323b18b19b702d8e42be52c377f","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Sarafraj Singh \u003cSarafraj.Singh@intel.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-06-22 12:19:30 -0500"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Improve help text of flavors"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Implements blueprint centralize-config-options-newton"},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3aaa91ec_30023570","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":7},"updated":"2016-06-22 19:03:24.000000000","message":"Can you provide more info for the commit message here?","commit_id":"98baf59558524807b3a6b932cf54cff6e39b368d"},{"author":{"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},"change_message_id":"c2c7b8db6c47d83ae264877dc3fc91afe756ee0e","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Sarafraj Singh \u003cSarafraj.Singh@intel.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-06-22 12:19:30 -0500"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Improve help text of flavors"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Implements blueprint centralize-config-options-newton"},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3aaa91ec_568ffacb","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":7},"in_reply_to":"3aaa91ec_30023570","updated":"2016-06-22 19:29:28.000000000","message":"Done","commit_id":"98baf59558524807b3a6b932cf54cff6e39b368d"}],"nova/conf/flavors.py":[{"author":{"_account_id":18335,"name":"Pushkar Umaranikar","email":"pushkar.umaranikar@intel.com","username":"pushkarumaranikar"},"change_message_id":"52a815b212a4fa6f02f1ccb7c3a4d6ff49541e16","unresolved":false,"context_lines":[{"line_number":25,"context_line":"Default flavor to use for the EC2 API only."},{"line_number":26,"context_line":"The Nova API does not support a default flavor."},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"* Possible values:"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    m1.tiny, m1.small (Default), m1.medium, m1.large, m1.nano,"},{"line_number":31,"context_line":"    m1.xlarge, m1.micro"}],"source_content_type":"text/x-python","patch_set":2,"id":"3aaa91ec_3ea40707","line":28,"range":{"start_line":28,"start_character":0,"end_line":28,"end_character":18},"updated":"2016-06-27 16:02:39.000000000","message":"It looks like micro and nano are not possible default flavors. http://docs.openstack.org/ops-guide/ops_user_facing_operations.html#flavors\nPlease correct me If I am wrong.","commit_id":"107db316bb5b22b5ddc4c167b5c1c00bf3ca3fa6"},{"author":{"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},"change_message_id":"8c9bc7c12322afafd45fb91d41ec9ca7cc1bad2d","unresolved":false,"context_lines":[{"line_number":25,"context_line":"Default flavor to use for the EC2 API only."},{"line_number":26,"context_line":"The Nova API does not support a default flavor."},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"* Possible values:"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    m1.tiny, m1.small (Default), m1.medium, m1.large, m1.nano,"},{"line_number":31,"context_line":"    m1.xlarge, m1.micro"}],"source_content_type":"text/x-python","patch_set":2,"id":"3aaa91ec_12ce5ab4","line":28,"range":{"start_line":28,"start_character":0,"end_line":28,"end_character":18},"in_reply_to":"3aaa91ec_3ea40707","updated":"2016-06-27 16:52:24.000000000","message":"Done","commit_id":"107db316bb5b22b5ddc4c167b5c1c00bf3ca3fa6"},{"author":{"_account_id":18339,"name":"Sivasathurappan Radhakrishnan","email":"siva.radhakrishnan@intel.com","username":"sivakrishnan"},"change_message_id":"500ef11e261b32808592d89c9afb568f8f897beb","unresolved":false,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":"* Related options:"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    None"},{"line_number":36,"context_line":"\"\"\"),"},{"line_number":37,"context_line":"]"},{"line_number":38,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3aaa91ec_2f13280f","line":35,"updated":"2016-06-27 20:16:02.000000000","message":"nit: related options can be removed if none.","commit_id":"107db316bb5b22b5ddc4c167b5c1c00bf3ca3fa6"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"4e217e6b50887180648da7cc74fa2b7bb482dd72","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":"* Possible values:"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    m1.tiny, m1.small (Default), m1.medium, m1.large, m1.xlarge"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"* Related options:"},{"line_number":33,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3aaa91ec_422d4645","line":30,"range":{"start_line":30,"start_character":4,"end_line":30,"end_character":63},"updated":"2016-06-29 12:33:30.000000000","message":"I think that every flavor that is available in deployment is a possibility here. The list you provided is just a default set that can be expanded by adding new flavors.\nQuestion to anyone who knows: is the set provided in this patch a default for all new deployments, or can it differ? If it can, the best option would be to just note that possible value is any flavor name.","commit_id":"ca5b74f691e9be759e5ebbbe4894e131867f8f15"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"4e217e6b50887180648da7cc74fa2b7bb482dd72","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    m1.tiny, m1.small (Default), m1.medium, m1.large, m1.xlarge"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"* Related options:"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    None"},{"line_number":35,"context_line":"\"\"\"),"},{"line_number":36,"context_line":"]"},{"line_number":37,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3aaa91ec_82060e1a","line":34,"range":{"start_line":32,"start_character":0,"end_line":34,"end_character":8},"updated":"2016-06-29 12:33:30.000000000","message":"Drop this section","commit_id":"ca5b74f691e9be759e5ebbbe4894e131867f8f15"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"6832cddedb7bb195a183f845bc510ef9753b2a96","unresolved":false,"context_lines":[{"line_number":22,"context_line":"               deprecated_for_removal\u003dTrue,"},{"line_number":23,"context_line":"               deprecated_reason\u003d\"The EC2 API is deprecated\","},{"line_number":24,"context_line":"               help\u003d\"\"\""},{"line_number":25,"context_line":"Default flavor to use for the EC2 API only."},{"line_number":26,"context_line":"The Nova API does not support a default flavor."},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"* Possible values:"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    Any flavor name"},{"line_number":31,"context_line":"    e.g. m1.tiny, m1.small (Default), m1.medium, m1.large, m1.xlarge"},{"line_number":32,"context_line":"\"\"\"),"},{"line_number":33,"context_line":"]"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"def register_opts(conf):"}],"source_content_type":"text/x-python","patch_set":4,"id":"3aaa91ec_590e693b","line":33,"range":{"start_line":25,"start_character":0,"end_line":33,"end_character":1},"updated":"2016-07-01 10:10:57.000000000","message":"I don\u0027t think we should be modifying deprecated options. Maybe ask markus_z?","commit_id":"b2c4c499c8e467882b8f7a1c8b9d1e954b98de73"},{"author":{"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},"change_message_id":"ffd0d71fba530740b16e70d04ca36cfb6559c06c","unresolved":false,"context_lines":[{"line_number":22,"context_line":"               deprecated_for_removal\u003dTrue,"},{"line_number":23,"context_line":"               deprecated_reason\u003d\"The EC2 API is deprecated\","},{"line_number":24,"context_line":"               help\u003d\"\"\""},{"line_number":25,"context_line":"Default flavor to use for the EC2 API only."},{"line_number":26,"context_line":"The Nova API does not support a default flavor."},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"* Possible values:"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    Any flavor name"},{"line_number":31,"context_line":"    e.g. m1.tiny, m1.small (Default), m1.medium, m1.large, m1.xlarge"},{"line_number":32,"context_line":"\"\"\"),"},{"line_number":33,"context_line":"]"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"def register_opts(conf):"}],"source_content_type":"text/x-python","patch_set":4,"id":"3aaa91ec_7bc22b36","line":33,"range":{"start_line":25,"start_character":0,"end_line":33,"end_character":1},"in_reply_to":"3aaa91ec_590e693b","updated":"2016-07-01 14:45:07.000000000","message":"Its just the help text, I spend little time on deprecated options to tidy them a bit. But more info will not hurt here, I think it should be fine. Lets see what others have to say.","commit_id":"b2c4c499c8e467882b8f7a1c8b9d1e954b98de73"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"ee110391594820040af23d01e0fe457c101e1664","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"flavor_opts \u003d ["},{"line_number":20,"context_line":"    cfg.StrOpt(\u0027default_flavor\u0027,"},{"line_number":21,"context_line":"               default\u003d\u0027m1.small\u0027,"},{"line_number":22,"context_line":"               deprecated_for_removal\u003dTrue,"},{"line_number":23,"context_line":"               deprecated_reason\u003d\u0027The EC2 API is deprecated\u0027,"},{"line_number":24,"context_line":"               help\u003d\"\"\""}],"source_content_type":"text/x-python","patch_set":5,"id":"fad55976_d4b5e1d0","line":21,"updated":"2016-07-15 16:56:45.000000000","message":"Nit: this default is nuts, because it probably doesn\u0027t exist in most deploys, but this is going away now.","commit_id":"ae00ce6bd1d00fec2aaf51f0792f1914477ee098"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"ee110391594820040af23d01e0fe457c101e1664","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":"Possible values:"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"* Any flavor name, e.g. m1.tiny, m1.small (Default), m1.medium, m1.large"},{"line_number":31,"context_line":"\"\"\"),"},{"line_number":32,"context_line":"]"},{"line_number":33,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"fad55976_54a3b19e","line":30,"updated":"2016-07-15 16:56:45.000000000","message":"Nit: not sure I would bother adding this in, because the values are actually deployment specific.","commit_id":"ae00ce6bd1d00fec2aaf51f0792f1914477ee098"}]}
