)]}'
{"nova/api/openstack/compute/helpers.py":[{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"b28f6f20ef057c2cd5779d0bc8473a68a491ce7a","unresolved":false,"context_lines":[{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    Not all operations support all attributes listed here. Which is"},{"line_number":57,"context_line":"    why it\u0027s important to only set operation_kwargs if there is"},{"line_number":58,"context_line":"    something to set. Input validation will ensure that we are only"},{"line_number":59,"context_line":"    operating on appropriate attributes for each operation."},{"line_number":60,"context_line":"    \"\"\""},{"line_number":61,"context_line":"    # Disk config"},{"line_number":62,"context_line":"    auto_disk_config_raw \u003d server_dict.pop(API_DISK_CONFIG, None)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3aaa91ec_16025cb4","line":59,"range":{"start_line":58,"start_character":23,"end_line":59,"end_character":59},"updated":"2016-06-23 15:45:38.000000000","message":"commented previously that jsonschema helps us on the filtering front","commit_id":"3d75b5f99e2c2d2f84dd135852899d1a1d7f682e"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"9ddb504fcd6c7cd1c3ddec22bb33998062f7f45c","unresolved":false,"context_lines":[{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    Not all operations support all attributes listed here. Which is"},{"line_number":57,"context_line":"    why it\u0027s important to only set operation_kwargs if there is"},{"line_number":58,"context_line":"    something to set. Input validation will ensure that we are only"},{"line_number":59,"context_line":"    operating on appropriate attributes for each operation."},{"line_number":60,"context_line":"    \"\"\""},{"line_number":61,"context_line":"    # Disk config"},{"line_number":62,"context_line":"    auto_disk_config_raw \u003d server_dict.pop(API_DISK_CONFIG, None)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3aaa91ec_914c6fc9","line":59,"range":{"start_line":58,"start_character":23,"end_line":59,"end_character":59},"in_reply_to":"3aaa91ec_16025cb4","updated":"2016-06-24 09:14:48.000000000","message":"Agreed this is functionally sound.\n\nIt just seems if we started again, that one would just be inline in the rebuild code. It doesn\u0027t seem very obvious this only applies to rebuild only.","commit_id":"3d75b5f99e2c2d2f84dd135852899d1a1d7f682e"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"dddf5d639ed1da9bf3128395258b55106b640de3","unresolved":false,"context_lines":[{"line_number":71,"context_line":""},{"line_number":72,"context_line":"    # This is only ever expected during rebuild operations, and only"},{"line_number":73,"context_line":"    # does anything with Ironic driver. It also demonstrates the lack"},{"line_number":74,"context_line":"    # of understanding of the word ephemeral."},{"line_number":75,"context_line":"    if \u0027preserve_ephemeral\u0027 in server_dict:"},{"line_number":76,"context_line":"        operation_kwargs[\u0027preserve_ephemeral\u0027] \u003d strutils.bool_from_string("},{"line_number":77,"context_line":"                server_dict[\u0027preserve_ephemeral\u0027], strict\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3aaa91ec_9c25d50a","line":74,"updated":"2016-06-23 14:40:00.000000000","message":"yeah, its was part of the tripple-o stuff that was \"needed\", and we couldn\u0027t find an alternative, if I remember correctly.","commit_id":"3d75b5f99e2c2d2f84dd135852899d1a1d7f682e"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"dddf5d639ed1da9bf3128395258b55106b640de3","unresolved":false,"context_lines":[{"line_number":74,"context_line":"    # of understanding of the word ephemeral."},{"line_number":75,"context_line":"    if \u0027preserve_ephemeral\u0027 in server_dict:"},{"line_number":76,"context_line":"        operation_kwargs[\u0027preserve_ephemeral\u0027] \u003d strutils.bool_from_string("},{"line_number":77,"context_line":"                server_dict[\u0027preserve_ephemeral\u0027], strict\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3aaa91ec_3c62e13e","line":77,"updated":"2016-06-23 14:40:00.000000000","message":"Honestly, shouldn\u0027t we add this directly in the code for rebuild here:\nhttps://github.com/openstack/nova/blob/master/nova/api/openstack/compute/servers.py#L1014","commit_id":"3d75b5f99e2c2d2f84dd135852899d1a1d7f682e"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"2797c91a946c482bf965f32e43b42b21e85b734e","unresolved":false,"context_lines":[{"line_number":74,"context_line":"    # of understanding of the word ephemeral."},{"line_number":75,"context_line":"    if \u0027preserve_ephemeral\u0027 in server_dict:"},{"line_number":76,"context_line":"        operation_kwargs[\u0027preserve_ephemeral\u0027] \u003d strutils.bool_from_string("},{"line_number":77,"context_line":"                server_dict[\u0027preserve_ephemeral\u0027], strict\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3aaa91ec_9f8827c7","line":77,"in_reply_to":"3aaa91ec_3c62e13e","updated":"2016-06-23 14:54:19.000000000","message":"So actually I see the following change makes this specific to rebuild, but I wonder if we should just move this one into rebuild directly.","commit_id":"3d75b5f99e2c2d2f84dd135852899d1a1d7f682e"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"b28f6f20ef057c2cd5779d0bc8473a68a491ce7a","unresolved":false,"context_lines":[{"line_number":74,"context_line":"    # of understanding of the word ephemeral."},{"line_number":75,"context_line":"    if \u0027preserve_ephemeral\u0027 in server_dict:"},{"line_number":76,"context_line":"        operation_kwargs[\u0027preserve_ephemeral\u0027] \u003d strutils.bool_from_string("},{"line_number":77,"context_line":"                server_dict[\u0027preserve_ephemeral\u0027], strict\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3aaa91ec_f6feb0ac","line":77,"in_reply_to":"3aaa91ec_9f8827c7","updated":"2016-06-23 15:45:38.000000000","message":"see L59","commit_id":"3d75b5f99e2c2d2f84dd135852899d1a1d7f682e"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"440cc1251bb8e15bffcff1f7ebf0438dea0fc751","unresolved":false,"context_lines":[{"line_number":74,"context_line":"    # of understanding of the word ephemeral."},{"line_number":75,"context_line":"    if \u0027preserve_ephemeral\u0027 in server_dict:"},{"line_number":76,"context_line":"        operation_kwargs[\u0027preserve_ephemeral\u0027] \u003d strutils.bool_from_string("},{"line_number":77,"context_line":"                server_dict[\u0027preserve_ephemeral\u0027], strict\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":4,"id":"3aaa91ec_7e3c20c8","line":77,"range":{"start_line":77,"start_character":16,"end_line":77,"end_character":49},"updated":"2016-06-24 14:46:57.000000000","message":"So here you\u0027re not popping the value out of server_dict, so we should probably be consistent...","commit_id":"ebe20ce085d01f2ad7f78bec362ca6a28b85f05c"}],"nova/api/openstack/compute/preserve_ephemeral_rebuild.py":[{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"a565d730d898fb087aa06eb8d80655a00bf8e572","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"from oslo_utils import strutils"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from nova.api.openstack.compute.schemas import preserve_ephemeral_rebuild"},{"line_number":19,"context_line":"from nova.api.openstack import extensions"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"ALIAS \u003d \"os-preserve-ephemeral-rebuild\""}],"source_content_type":"text/x-python","patch_set":2,"id":"3aaa91ec_ed534c15","side":"PARENT","line":18,"updated":"2016-06-24 13:57:57.000000000","message":"I guess we can kill this one:\nhttps://github.com/openstack/nova/blob/master/nova/api/openstack/compute/schemas/preserve_ephemeral_rebuild.py","commit_id":"3aeaa15885de315ae2ad937bf492e69edaa3c97f"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"a565d730d898fb087aa06eb8d80655a00bf8e572","unresolved":false,"context_lines":[{"line_number":41,"context_line":"                rebuild_dict[\u0027preserve_ephemeral\u0027], strict\u003dTrue)"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    def get_server_rebuild_schema(self, version):"},{"line_number":44,"context_line":"        return preserve_ephemeral_rebuild.server_rebuild"}],"source_content_type":"text/x-python","patch_set":2,"id":"3aaa91ec_4d5540f8","side":"PARENT","line":44,"updated":"2016-06-24 13:57:57.000000000","message":"I think this needs adding in the main schema?","commit_id":"3aeaa15885de315ae2ad937bf492e69edaa3c97f"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"6a8dad2bf3c9f58c0b8462a92ff9b415aa5b9044","unresolved":false,"context_lines":[{"line_number":41,"context_line":"                rebuild_dict[\u0027preserve_ephemeral\u0027], strict\u003dTrue)"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    def get_server_rebuild_schema(self, version):"},{"line_number":44,"context_line":"        return preserve_ephemeral_rebuild.server_rebuild"}],"source_content_type":"text/x-python","patch_set":4,"id":"3aaa91ec_7e226053","side":"PARENT","line":44,"updated":"2016-06-24 14:49:36.000000000","message":"This needs to be in the main server rebuild schema now.","commit_id":"322240fa0bc4f244a08a46d17678a887633ee1c7"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"d1a635a6a86dc91f58f717fac66b5440d3cf6a49","unresolved":false,"context_lines":[{"line_number":41,"context_line":"                rebuild_dict[\u0027preserve_ephemeral\u0027], strict\u003dTrue)"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    def get_server_rebuild_schema(self, version):"},{"line_number":44,"context_line":"        return preserve_ephemeral_rebuild.server_rebuild"}],"source_content_type":"text/x-python","patch_set":4,"id":"3aaa91ec_be74c835","side":"PARENT","line":44,"in_reply_to":"3aaa91ec_7e226053","updated":"2016-06-24 14:50:53.000000000","message":"Actually you got lucky because it\u0027s already there:\n\nhttps://github.com/openstack/nova/blob/master/nova/api/openstack/compute/schemas/servers.py#L102","commit_id":"322240fa0bc4f244a08a46d17678a887633ee1c7"}]}