)]}'
{"nova/virt/libvirt/blockinfo.py":[{"author":{"_account_id":5538,"name":"Rushi Agrawal","email":"rushi.openstack@gmail.com","username":"rushiagr"},"change_message_id":"cad0635360083275ab77535cd7b02f1ad601472c","unresolved":false,"context_lines":[{"line_number":476,"context_line":"def has_default_ephemeral(instance, disk_bus, block_device_info, mapping):"},{"line_number":477,"context_line":"    ephemerals \u003d driver.block_device_info_get_ephemerals(block_device_info)"},{"line_number":478,"context_line":"    if (instance.ephemeral_gb is None or instance.ephemeral_gb \u003c\u003d 0"},{"line_number":479,"context_line":"       or ephemerals):"},{"line_number":480,"context_line":"        return None"},{"line_number":481,"context_line":"    else:"},{"line_number":482,"context_line":"        info \u003d get_next_disk_info(mapping, disk_bus)"}],"source_content_type":"text/x-python","patch_set":7,"id":"dada55a8_3d3a59e8","line":479,"updated":"2016-07-22 12:48:30.000000000","message":"nit: I guess it would be more readable if we used 8 spaces here on this line.","commit_id":"556895fe9922cd0ea773cbc5cbcc643d16927338"},{"author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"change_message_id":"97c5350e5d9f5b097f4de86865d3b1e0aea721bd","unresolved":false,"context_lines":[{"line_number":476,"context_line":"def has_default_ephemeral(instance, disk_bus, block_device_info, mapping):"},{"line_number":477,"context_line":"    ephemerals \u003d driver.block_device_info_get_ephemerals(block_device_info)"},{"line_number":478,"context_line":"    if (instance.ephemeral_gb is None or instance.ephemeral_gb \u003c\u003d 0"},{"line_number":479,"context_line":"       or ephemerals):"},{"line_number":480,"context_line":"        return None"},{"line_number":481,"context_line":"    else:"},{"line_number":482,"context_line":"        info \u003d get_next_disk_info(mapping, disk_bus)"}],"source_content_type":"text/x-python","patch_set":7,"id":"bacf61ea_07a99024","line":479,"in_reply_to":"bacf61ea_2a13c2b9","updated":"2016-07-29 17:02:27.000000000","message":"I see. It\u0027s now fixed.","commit_id":"556895fe9922cd0ea773cbc5cbcc643d16927338"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"454c21f912137c3d1464f355d32dd2de99eeefb4","unresolved":false,"context_lines":[{"line_number":476,"context_line":"def has_default_ephemeral(instance, disk_bus, block_device_info, mapping):"},{"line_number":477,"context_line":"    ephemerals \u003d driver.block_device_info_get_ephemerals(block_device_info)"},{"line_number":478,"context_line":"    if (instance.ephemeral_gb is None or instance.ephemeral_gb \u003c\u003d 0"},{"line_number":479,"context_line":"       or ephemerals):"},{"line_number":480,"context_line":"        return None"},{"line_number":481,"context_line":"    else:"},{"line_number":482,"context_line":"        info \u003d get_next_disk_info(mapping, disk_bus)"}],"source_content_type":"text/x-python","patch_set":7,"id":"bacf61ea_2a13c2b9","line":479,"in_reply_to":"bacf61ea_a10a461f","updated":"2016-07-29 15:08:56.000000000","message":"Victor: The problem with that is that it\u0027s difficult to distinguish the second line of the condition from the code line that follows.  The suggestion to use 8 spaces here is meant to transform this code to:\n\n    if (instance.ephemeral_gb is None or instance.ephemeral_gb \u003c\u003d 0\n            or ephemerals):\n        return None\n\nIn this form, it\u0027s quite clear which line corresponds to the condition, and which is the code line.  This is generally the way I see that ambiguity handled, too…","commit_id":"556895fe9922cd0ea773cbc5cbcc643d16927338"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"6e0b83b8f8cf91fd56e32ab721ce473ad74f178f","unresolved":false,"context_lines":[{"line_number":476,"context_line":"def has_default_ephemeral(instance, disk_bus, block_device_info, mapping):"},{"line_number":477,"context_line":"    ephemerals \u003d driver.block_device_info_get_ephemerals(block_device_info)"},{"line_number":478,"context_line":"    if (instance.ephemeral_gb is None or instance.ephemeral_gb \u003c\u003d 0"},{"line_number":479,"context_line":"       or ephemerals):"},{"line_number":480,"context_line":"        return None"},{"line_number":481,"context_line":"    else:"},{"line_number":482,"context_line":"        info \u003d get_next_disk_info(mapping, disk_bus)"}],"source_content_type":"text/x-python","patch_set":7,"id":"bacf61ea_b682a650","line":479,"in_reply_to":"dada55a8_3d3a59e8","updated":"2016-07-28 20:17:38.000000000","message":"Agreed, but I\u0027m willing to consider it a nit for now.","commit_id":"556895fe9922cd0ea773cbc5cbcc643d16927338"},{"author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"change_message_id":"0850d142b44ed437c920593db6c15e5292480bb3","unresolved":false,"context_lines":[{"line_number":476,"context_line":"def has_default_ephemeral(instance, disk_bus, block_device_info, mapping):"},{"line_number":477,"context_line":"    ephemerals \u003d driver.block_device_info_get_ephemerals(block_device_info)"},{"line_number":478,"context_line":"    if (instance.ephemeral_gb is None or instance.ephemeral_gb \u003c\u003d 0"},{"line_number":479,"context_line":"       or ephemerals):"},{"line_number":480,"context_line":"        return None"},{"line_number":481,"context_line":"    else:"},{"line_number":482,"context_line":"        info \u003d get_next_disk_info(mapping, disk_bus)"}],"source_content_type":"text/x-python","patch_set":7,"id":"bacf61ea_a10a461f","line":479,"in_reply_to":"dada55a8_3d3a59e8","updated":"2016-07-29 10:48:56.000000000","message":"I\u0027m not sure that I understood correctly your comment. I added one space.\n\n     if (instance.ephemeral_gb is None or instance.ephemeral_gb \u003c\u003d 0\n         or ephemerals):\n         return None","commit_id":"556895fe9922cd0ea773cbc5cbcc643d16927338"}]}