)]}'
{"nova/virt/libvirt/imagebackend.py":[{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"7fd673aa39ffd67fda309ad4826a73e5c2160815","unresolved":false,"context_lines":[{"line_number":451,"context_line":"            strutils.to_slug(CONF.preallocate_images) \u003d\u003d \u0027space\u0027)"},{"line_number":452,"context_line":"        if self.preallocate:"},{"line_number":453,"context_line":"            self.driver_io \u003d \"native\""},{"line_number":454,"context_line":"        self.disk_info_path \u003d os.path.join(os.path.dirname(path), \u0027disk.info\u0027)"},{"line_number":455,"context_line":"        self.correct_format()"},{"line_number":456,"context_line":""},{"line_number":457,"context_line":"    def _get_driver_format(self):"}],"source_content_type":"text/x-python","patch_set":5,"id":"3aaa91ec_f4603003","line":454,"updated":"2016-06-30 13:21:42.000000000","message":"Why did you change that line ? You change is to make the base class defining path.","commit_id":"1d38bc6f2b831a6f2a6131724af84f155630c9df"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"622cb4dfa0b73bc47a0ddcbf987c26d114d3d96e","unresolved":false,"context_lines":[{"line_number":451,"context_line":"            strutils.to_slug(CONF.preallocate_images) \u003d\u003d \u0027space\u0027)"},{"line_number":452,"context_line":"        if self.preallocate:"},{"line_number":453,"context_line":"            self.driver_io \u003d \"native\""},{"line_number":454,"context_line":"        self.disk_info_path \u003d os.path.join(os.path.dirname(path), \u0027disk.info\u0027)"},{"line_number":455,"context_line":"        self.correct_format()"},{"line_number":456,"context_line":""},{"line_number":457,"context_line":"    def _get_driver_format(self):"}],"source_content_type":"text/x-python","patch_set":5,"id":"3aaa91ec_8384105e","line":454,"in_reply_to":"3aaa91ec_1aa7e5a7","updated":"2016-06-30 14:18:26.000000000","message":"No, you should just pass the \u0027path\u0027 parameter to the base class, then it should not be used anymore and we should just use self.path which is attribute of the class.\n\nI minus 1 because you explicitly change it which is not good.","commit_id":"1d38bc6f2b831a6f2a6131724af84f155630c9df"},{"author":{"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},"change_message_id":"1b6e57efea59c78faf9e2b3ffe8c0e0e38a7224a","unresolved":false,"context_lines":[{"line_number":451,"context_line":"            strutils.to_slug(CONF.preallocate_images) \u003d\u003d \u0027space\u0027)"},{"line_number":452,"context_line":"        if self.preallocate:"},{"line_number":453,"context_line":"            self.driver_io \u003d \"native\""},{"line_number":454,"context_line":"        self.disk_info_path \u003d os.path.join(os.path.dirname(path), \u0027disk.info\u0027)"},{"line_number":455,"context_line":"        self.correct_format()"},{"line_number":456,"context_line":""},{"line_number":457,"context_line":"    def _get_driver_format(self):"}],"source_content_type":"text/x-python","patch_set":5,"id":"3aaa91ec_8e9d57be","line":454,"in_reply_to":"3aaa91ec_8384105e","updated":"2016-06-30 14:31:20.000000000","message":"@Matthew: couldn\u0027t the call to super() have modified self.path? If so, then the two might not be equal, and it would be safer to use self.path","commit_id":"1d38bc6f2b831a6f2a6131724af84f155630c9df"},{"author":{"_account_id":9555,"name":"Matthew Booth","email":"mbooth@redhat.com","username":"MatthewBooth"},"change_message_id":"53d7ae6ab25bb315262d4a893a8acf5ce9a28204","unresolved":false,"context_lines":[{"line_number":451,"context_line":"            strutils.to_slug(CONF.preallocate_images) \u003d\u003d \u0027space\u0027)"},{"line_number":452,"context_line":"        if self.preallocate:"},{"line_number":453,"context_line":"            self.driver_io \u003d \"native\""},{"line_number":454,"context_line":"        self.disk_info_path \u003d os.path.join(os.path.dirname(path), \u0027disk.info\u0027)"},{"line_number":455,"context_line":"        self.correct_format()"},{"line_number":456,"context_line":""},{"line_number":457,"context_line":"    def _get_driver_format(self):"}],"source_content_type":"text/x-python","patch_set":5,"id":"3aaa91ec_0efcc7b6","line":454,"in_reply_to":"3aaa91ec_8384105e","updated":"2016-06-30 14:34:11.000000000","message":"This change created path as a local variable. Previously it was an instance variable. As it happens, it is now both, because the super class also makes it an instance variable. However, that is additional context for the reader to obtain, and it\u0027s just not relevant. This is clearer.","commit_id":"1d38bc6f2b831a6f2a6131724af84f155630c9df"},{"author":{"_account_id":9555,"name":"Matthew Booth","email":"mbooth@redhat.com","username":"MatthewBooth"},"change_message_id":"d69f4344416b491a14db909e933bc387c709e5a9","unresolved":false,"context_lines":[{"line_number":451,"context_line":"            strutils.to_slug(CONF.preallocate_images) \u003d\u003d \u0027space\u0027)"},{"line_number":452,"context_line":"        if self.preallocate:"},{"line_number":453,"context_line":"            self.driver_io \u003d \"native\""},{"line_number":454,"context_line":"        self.disk_info_path \u003d os.path.join(os.path.dirname(path), \u0027disk.info\u0027)"},{"line_number":455,"context_line":"        self.correct_format()"},{"line_number":456,"context_line":""},{"line_number":457,"context_line":"    def _get_driver_format(self):"}],"source_content_type":"text/x-python","patch_set":5,"id":"3aaa91ec_1aa7e5a7","line":454,"in_reply_to":"3aaa91ec_f4603003","updated":"2016-06-30 13:37:31.000000000","message":"Because after this change path is now both a local and an instance variable, and in general it\u0027s clearer to reference a local variable when it\u0027s available. Referencing the instance variable when it hasn\u0027t been created in the local scope requires the reader to make an additional jump.","commit_id":"1d38bc6f2b831a6f2a6131724af84f155630c9df"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"7fd673aa39ffd67fda309ad4826a73e5c2160815","unresolved":false,"context_lines":[{"line_number":537,"context_line":"            strutils.to_slug(CONF.preallocate_images) \u003d\u003d \u0027space\u0027)"},{"line_number":538,"context_line":"        if self.preallocate:"},{"line_number":539,"context_line":"            self.driver_io \u003d \"native\""},{"line_number":540,"context_line":"        self.disk_info_path \u003d os.path.join(os.path.dirname(path), \u0027disk.info\u0027)"},{"line_number":541,"context_line":"        self.resolve_driver_format()"},{"line_number":542,"context_line":""},{"line_number":543,"context_line":"    def create_image(self, prepare_template, base, size, *args, **kwargs):"}],"source_content_type":"text/x-python","patch_set":5,"id":"3aaa91ec_54366403","line":540,"updated":"2016-06-30 13:21:42.000000000","message":"same question here","commit_id":"1d38bc6f2b831a6f2a6131724af84f155630c9df"},{"author":{"_account_id":9555,"name":"Matthew Booth","email":"mbooth@redhat.com","username":"MatthewBooth"},"change_message_id":"d69f4344416b491a14db909e933bc387c709e5a9","unresolved":false,"context_lines":[{"line_number":537,"context_line":"            strutils.to_slug(CONF.preallocate_images) \u003d\u003d \u0027space\u0027)"},{"line_number":538,"context_line":"        if self.preallocate:"},{"line_number":539,"context_line":"            self.driver_io \u003d \"native\""},{"line_number":540,"context_line":"        self.disk_info_path \u003d os.path.join(os.path.dirname(path), \u0027disk.info\u0027)"},{"line_number":541,"context_line":"        self.resolve_driver_format()"},{"line_number":542,"context_line":""},{"line_number":543,"context_line":"    def create_image(self, prepare_template, base, size, *args, **kwargs):"}],"source_content_type":"text/x-python","patch_set":5,"id":"3aaa91ec_baae917e","line":540,"in_reply_to":"3aaa91ec_54366403","updated":"2016-06-30 13:37:31.000000000","message":"See above.","commit_id":"1d38bc6f2b831a6f2a6131724af84f155630c9df"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"7fd673aa39ffd67fda309ad4826a73e5c2160815","unresolved":false,"context_lines":[{"line_number":770,"context_line":"        self.rbd_user \u003d CONF.libvirt.rbd_user"},{"line_number":771,"context_line":"        self.ceph_conf \u003d CONF.libvirt.images_rbd_ceph_conf"},{"line_number":772,"context_line":""},{"line_number":773,"context_line":"        path \u003d \u0027rbd:%s/%s\u0027 % (self.pool, self.rbd_name)"},{"line_number":774,"context_line":"        if self.rbd_user:"},{"line_number":775,"context_line":"            path +\u003d \u0027:id\u003d\u0027 + self.rbd_user"},{"line_number":776,"context_line":"        if self.ceph_conf:"}],"source_content_type":"text/x-python","patch_set":5,"id":"3aaa91ec_d73c1631","line":773,"updated":"2016-06-30 13:21:42.000000000","message":"We can probably do something more cleaner. I guess we should to initialize the base class the most sooner.\n   def __init__(self...,path\u003dNone):\n     super(Rbd, self).__init__(path, \"block\", \"rbd\", is_block_dev\u003dFalse)\n     if self.path:\n         try:\n\t   self.rbd_name \u003d self.path.split(\u0027/\u0027)[1]\n\t except IndexError:\n\t    raise exception.InvalidDevicePath(path\u003dself.path)\n     else:\n          self.rbd_name \u003d \u0027%s_%s\u0027 % (instance.uuid, disk_name)\n          self.path \u003d \u0027rbd:%s/%s\u0027 % (self.pool, self.rbd_name)\n          if self.rbd_user:\n            self.path +\u003d \u0027:id\u003d\u0027 + self.rbd_user\n          if self.ceph_conf:\n            self.path +\u003d \u0027:conf\u003d\u0027 + self.ceph_conf\n\nThe point is also to start using attribute when base class has been called to avoid any override.","commit_id":"1d38bc6f2b831a6f2a6131724af84f155630c9df"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"622cb4dfa0b73bc47a0ddcbf987c26d114d3d96e","unresolved":false,"context_lines":[{"line_number":770,"context_line":"        self.rbd_user \u003d CONF.libvirt.rbd_user"},{"line_number":771,"context_line":"        self.ceph_conf \u003d CONF.libvirt.images_rbd_ceph_conf"},{"line_number":772,"context_line":""},{"line_number":773,"context_line":"        path \u003d \u0027rbd:%s/%s\u0027 % (self.pool, self.rbd_name)"},{"line_number":774,"context_line":"        if self.rbd_user:"},{"line_number":775,"context_line":"            path +\u003d \u0027:id\u003d\u0027 + self.rbd_user"},{"line_number":776,"context_line":"        if self.ceph_conf:"}],"source_content_type":"text/x-python","patch_set":5,"id":"3aaa91ec_c3245861","line":773,"in_reply_to":"3aaa91ec_9a8475d3","updated":"2016-06-30 14:18:26.000000000","message":"Hum it\u0027s not really, you have a block in relation with \u0027path\u0027 then a block about something else and finally a new block using the variable \u0027path\u0027 that makes things confusing. I don\u0027t say it\u0027s related to this patch but since you are updating this point, please consider comments from contributors, or feel free to arguments.","commit_id":"1d38bc6f2b831a6f2a6131724af84f155630c9df"},{"author":{"_account_id":9555,"name":"Matthew Booth","email":"mbooth@redhat.com","username":"MatthewBooth"},"change_message_id":"53d7ae6ab25bb315262d4a893a8acf5ce9a28204","unresolved":false,"context_lines":[{"line_number":770,"context_line":"        self.rbd_user \u003d CONF.libvirt.rbd_user"},{"line_number":771,"context_line":"        self.ceph_conf \u003d CONF.libvirt.images_rbd_ceph_conf"},{"line_number":772,"context_line":""},{"line_number":773,"context_line":"        path \u003d \u0027rbd:%s/%s\u0027 % (self.pool, self.rbd_name)"},{"line_number":774,"context_line":"        if self.rbd_user:"},{"line_number":775,"context_line":"            path +\u003d \u0027:id\u003d\u0027 + self.rbd_user"},{"line_number":776,"context_line":"        if self.ceph_conf:"}],"source_content_type":"text/x-python","patch_set":5,"id":"3aaa91ec_ce3f5f85","line":773,"in_reply_to":"3aaa91ec_c3245861","updated":"2016-06-30 14:34:11.000000000","message":"This is pure code motion. The \u0027block about something else\u0027 is all data required to construct the path, and it\u0027s all code which existed before. I\u0027ve just moved it up so it can be passed to the constructor. I\u0027ve also taken advantage of path being a local variable.","commit_id":"1d38bc6f2b831a6f2a6131724af84f155630c9df"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"61a1b258b45351fa7e585d586968b43763eec63f","unresolved":false,"context_lines":[{"line_number":770,"context_line":"        self.rbd_user \u003d CONF.libvirt.rbd_user"},{"line_number":771,"context_line":"        self.ceph_conf \u003d CONF.libvirt.images_rbd_ceph_conf"},{"line_number":772,"context_line":""},{"line_number":773,"context_line":"        path \u003d \u0027rbd:%s/%s\u0027 % (self.pool, self.rbd_name)"},{"line_number":774,"context_line":"        if self.rbd_user:"},{"line_number":775,"context_line":"            path +\u003d \u0027:id\u003d\u0027 + self.rbd_user"},{"line_number":776,"context_line":"        if self.ceph_conf:"}],"source_content_type":"text/x-python","patch_set":5,"id":"3aaa91ec_18ffc666","line":773,"in_reply_to":"3aaa91ec_ce3f5f85","updated":"2016-07-01 07:12:21.000000000","message":"Not really, As you can see I use path as member of the class instead of using the local variable.","commit_id":"1d38bc6f2b831a6f2a6131724af84f155630c9df"},{"author":{"_account_id":9555,"name":"Matthew Booth","email":"mbooth@redhat.com","username":"MatthewBooth"},"change_message_id":"d69f4344416b491a14db909e933bc387c709e5a9","unresolved":false,"context_lines":[{"line_number":770,"context_line":"        self.rbd_user \u003d CONF.libvirt.rbd_user"},{"line_number":771,"context_line":"        self.ceph_conf \u003d CONF.libvirt.images_rbd_ceph_conf"},{"line_number":772,"context_line":""},{"line_number":773,"context_line":"        path \u003d \u0027rbd:%s/%s\u0027 % (self.pool, self.rbd_name)"},{"line_number":774,"context_line":"        if self.rbd_user:"},{"line_number":775,"context_line":"            path +\u003d \u0027:id\u003d\u0027 + self.rbd_user"},{"line_number":776,"context_line":"        if self.ceph_conf:"}],"source_content_type":"text/x-python","patch_set":5,"id":"3aaa91ec_9a8475d3","line":773,"in_reply_to":"3aaa91ec_d73c1631","updated":"2016-06-30 13:37:31.000000000","message":"I still think this is clearer.","commit_id":"1d38bc6f2b831a6f2a6131724af84f155630c9df"},{"author":{"_account_id":16907,"name":"Diana Clarke","email":"diana.joan.clarke@gmail.com","username":"diana-clarke"},"change_message_id":"4cfe796ce2ac66704fbd674949ae880f4a462d1d","unresolved":false,"context_lines":[{"line_number":70,"context_line":"                                  \u0027only for LVM images.\u0027))"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"        self.path \u003d path"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"        self.source_type \u003d source_type"},{"line_number":75,"context_line":"        self.driver_format \u003d driver_format"},{"line_number":76,"context_line":"        self.driver_io \u003d None"}],"source_content_type":"text/x-python","patch_set":8,"id":"dada55a8_952d9100","line":73,"updated":"2016-07-20 15:07:40.000000000","message":"minor: extra newline should be removed","commit_id":"6ea7d4cd5d88bad69c9cdedabf6bc9b84ad31f58"},{"author":{"_account_id":16907,"name":"Diana Clarke","email":"diana.joan.clarke@gmail.com","username":"diana-clarke"},"change_message_id":"4cfe796ce2ac66704fbd674949ae880f4a462d1d","unresolved":false,"context_lines":[{"line_number":783,"context_line":"            ceph_conf\u003dself.ceph_conf,"},{"line_number":784,"context_line":"            rbd_user\u003dself.rbd_user)"},{"line_number":785,"context_line":""},{"line_number":786,"context_line":"        self.discard_mode \u003d CONF.libvirt.hw_disk_discard"},{"line_number":787,"context_line":""},{"line_number":788,"context_line":"    def libvirt_info(self, disk_bus, disk_dev, device_type, cache_mode,"},{"line_number":789,"context_line":"            extra_specs, hypervisor_version, boot_order\u003dNone):"}],"source_content_type":"text/x-python","patch_set":8,"id":"dada55a8_3545c5b2","line":786,"range":{"start_line":786,"start_character":8,"end_line":786,"end_character":56},"updated":"2016-07-20 15:07:40.000000000","message":"Why was this conf moved away from the others?","commit_id":"6ea7d4cd5d88bad69c9cdedabf6bc9b84ad31f58"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"642aa57a834ec33f38255b05cec11a27d92e7490","unresolved":false,"context_lines":[{"line_number":61,"context_line":"        :param path: libvirt\u0027s representation of the path of this disk."},{"line_number":62,"context_line":"        :param source_type: block or file"},{"line_number":63,"context_line":"        :param driver_format: raw or qcow2"},{"line_number":64,"context_line":"        :param is_block_dev:"},{"line_number":65,"context_line":"        \"\"\""},{"line_number":66,"context_line":"        if (CONF.ephemeral_storage_encryption.enabled and"},{"line_number":67,"context_line":"                not self._supports_encryption()):"}],"source_content_type":"text/x-python","patch_set":9,"id":"dada55a8_4df9c07f","line":64,"updated":"2016-07-26 17:39:00.000000000","message":"No description for this guy?","commit_id":"ca6dbaac21473a0527e49ca69fed20aee143b614"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"4bdf39e3325e73a38ff168af62f960f9c5db4a22","unresolved":false,"context_lines":[{"line_number":445,"context_line":"        self.disk_name \u003d disk_name"},{"line_number":446,"context_line":"        path \u003d (path or os.path.join(libvirt_utils.get_instance_path(instance),"},{"line_number":447,"context_line":"                                     disk_name))"},{"line_number":448,"context_line":"        super(Flat, self).__init__(path, \"file\", \"raw\", is_block_dev\u003dFalse)"},{"line_number":449,"context_line":""},{"line_number":450,"context_line":"        self.preallocate \u003d ("},{"line_number":451,"context_line":"            strutils.to_slug(CONF.preallocate_images) \u003d\u003d \u0027space\u0027)"}],"source_content_type":"text/x-python","patch_set":9,"id":"dada55a8_b6a66351","line":448,"updated":"2016-07-22 15:14:50.000000000","message":"FlatTestCase has very indirect testing of image.path by way of verifying that os.exists() is called with the expected thing.","commit_id":"ca6dbaac21473a0527e49ca69fed20aee143b614"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"4bdf39e3325e73a38ff168af62f960f9c5db4a22","unresolved":false,"context_lines":[{"line_number":531,"context_line":"    def __init__(self, instance\u003dNone, disk_name\u003dNone, path\u003dNone):"},{"line_number":532,"context_line":"        path \u003d (path or os.path.join(libvirt_utils.get_instance_path(instance),"},{"line_number":533,"context_line":"                                     disk_name))"},{"line_number":534,"context_line":"        super(Qcow2, self).__init__(path, \"file\", \"qcow2\", is_block_dev\u003dFalse)"},{"line_number":535,"context_line":""},{"line_number":536,"context_line":"        self.preallocate \u003d ("},{"line_number":537,"context_line":"            strutils.to_slug(CONF.preallocate_images) \u003d\u003d \u0027space\u0027)"}],"source_content_type":"text/x-python","patch_set":9,"id":"dada55a8_f64d7b9a","line":534,"updated":"2016-07-22 15:14:50.000000000","message":"Qcow2 has very indirect testing of image.path by way of verifying that os.exists() is called with the expected thing.","commit_id":"ca6dbaac21473a0527e49ca69fed20aee143b614"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"4bdf39e3325e73a38ff168af62f960f9c5db4a22","unresolved":false,"context_lines":[{"line_number":644,"context_line":"                self.lv_path \u003d os.path.join(\u0027/dev\u0027, self.vg, self.lv)"},{"line_number":645,"context_line":"                path \u003d \u0027/dev/mapper/\u0027 + dmcrypt.volume_name(self.lv)"},{"line_number":646,"context_line":""},{"line_number":647,"context_line":"        super(Lvm, self).__init__(path, \"block\", \"raw\", is_block_dev\u003dTrue)"},{"line_number":648,"context_line":""},{"line_number":649,"context_line":"        # TODO(pbrady): possibly deprecate libvirt.sparse_logical_volumes"},{"line_number":650,"context_line":"        # for the more general preallocate_images"}],"source_content_type":"text/x-python","patch_set":9,"id":"dada55a8_3616f355","line":647,"updated":"2016-07-22 15:14:50.000000000","message":"LVM does have a test via self.PATH in the base and encrypted test cases.","commit_id":"ca6dbaac21473a0527e49ca69fed20aee143b614"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"4bdf39e3325e73a38ff168af62f960f9c5db4a22","unresolved":false,"context_lines":[{"line_number":774,"context_line":"        if self.rbd_user:"},{"line_number":775,"context_line":"            path +\u003d \u0027:id\u003d\u0027 + self.rbd_user"},{"line_number":776,"context_line":"        if self.ceph_conf:"},{"line_number":777,"context_line":"            path +\u003d \u0027:conf\u003d\u0027 + self.ceph_conf"},{"line_number":778,"context_line":""},{"line_number":779,"context_line":"        super(Rbd, self).__init__(path, \"block\", \"rbd\", is_block_dev\u003dFalse)"},{"line_number":780,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"dada55a8_390d4438","line":777,"updated":"2016-07-22 15:14:50.000000000","message":"RBD does seem to have tests for .path, so we\u0027re good there.","commit_id":"ca6dbaac21473a0527e49ca69fed20aee143b614"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"4bdf39e3325e73a38ff168af62f960f9c5db4a22","unresolved":false,"context_lines":[{"line_number":783,"context_line":"            ceph_conf\u003dself.ceph_conf,"},{"line_number":784,"context_line":"            rbd_user\u003dself.rbd_user)"},{"line_number":785,"context_line":""},{"line_number":786,"context_line":"        self.discard_mode \u003d CONF.libvirt.hw_disk_discard"},{"line_number":787,"context_line":""},{"line_number":788,"context_line":"    def libvirt_info(self, disk_bus, disk_dev, device_type, cache_mode,"},{"line_number":789,"context_line":"            extra_specs, hypervisor_version, boot_order\u003dNone):"}],"source_content_type":"text/x-python","patch_set":9,"id":"dada55a8_963ebf27","line":786,"updated":"2016-07-22 15:14:50.000000000","message":"This move seems like unnecessary noise.","commit_id":"ca6dbaac21473a0527e49ca69fed20aee143b614"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"4bdf39e3325e73a38ff168af62f960f9c5db4a22","unresolved":false,"context_lines":[{"line_number":1010,"context_line":"    def __init__(self, instance\u003dNone, disk_name\u003dNone, path\u003dNone):"},{"line_number":1011,"context_line":"        path \u003d (path or os.path.join(libvirt_utils.get_instance_path(instance),"},{"line_number":1012,"context_line":"                                     disk_name))"},{"line_number":1013,"context_line":"        super(Ploop, self).__init__(path, \"file\", \"ploop\", is_block_dev\u003dFalse)"},{"line_number":1014,"context_line":""},{"line_number":1015,"context_line":"        self.resolve_driver_format()"},{"line_number":1016,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"dada55a8_799fbc50","line":1013,"updated":"2016-07-22 15:14:50.000000000","message":"Same as above, very indirect validation of this value.","commit_id":"ca6dbaac21473a0527e49ca69fed20aee143b614"}]}