)]}'
{"nova/compute/api.py":[{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"35feddc64c9479b82afcf96b5a7d68136dbea0f5","unresolved":false,"context_lines":[{"line_number":1693,"context_line":"        properties.update(extra_properties or {})"},{"line_number":1694,"context_line":""},{"line_number":1695,"context_line":"        bdms \u003d block_device.legacy_mapping("},{"line_number":1696,"context_line":"            self.get_instance_bdms(context, instance))"},{"line_number":1697,"context_line":""},{"line_number":1698,"context_line":"        mapping \u003d []"},{"line_number":1699,"context_line":"        for bdm in bdms:"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAPn%2F%2FnnQ%3D","side":"PARENT","line":1696,"updated":"2013-06-26 16:20:15.000000000","message":"if we want to go this way, could we just to legacy\u003dFalse here, or am I missing something?","commit_id":"d6ce08fd8f2b0bf7bcf16a8bea5cec864ab3779b"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"35feddc64c9479b82afcf96b5a7d68136dbea0f5","unresolved":false,"context_lines":[{"line_number":2511,"context_line":"        uuids \u003d [instance[\u0027uuid\u0027] for instance in instances]"},{"line_number":2512,"context_line":"        return self.db.instance_fault_get_by_instance_uuids(context, uuids)"},{"line_number":2513,"context_line":""},{"line_number":2514,"context_line":"    def get_instance_bdms(self, context, instance, legacy\u003dTrue):"},{"line_number":2515,"context_line":"        \"\"\"Get all bdm tables for specified instance.\"\"\""},{"line_number":2516,"context_line":"        bdms \u003d self.db.block_device_mapping_get_all_by_instance(context,"},{"line_number":2517,"context_line":"                instance[\u0027uuid\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAPn%2F%2Fnno%3D","line":2514,"updated":"2013-06-26 16:20:15.000000000","message":"Can we get a test for this? Do we use legacy\u003dFalse?","commit_id":"d0c76b0717fe0c44bcc02e4ad32295f051883aed"}],"nova/tests/api/ec2/test_cloud.py":[{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"a39738c4474ef5dbb8ac9b485f65717b304c928f","unresolved":false,"context_lines":[{"line_number":2197,"context_line":"        def fake_block_device_mapping_get_all_by_instance(context, inst_id):"},{"line_number":2198,"context_line":"            return [dict(snapshot_id\u003dsnapshots[0],"},{"line_number":2199,"context_line":"                         volume_id\u003dvolumes[0],"},{"line_number":2200,"context_line":"                         source_type\u003d\u0027snapshot\u0027,"},{"line_number":2201,"context_line":"                         destination_type\u003d\u0027volume\u0027,"},{"line_number":2202,"context_line":"                         volume_size\u003d1,"},{"line_number":2203,"context_line":"                         device_name\u003d\u0027vda\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAPn%2F%2FT10%3D","line":2200,"updated":"2013-07-04 10:24:51.000000000","message":"Is this an unrelated change, or am I missing something?","commit_id":"1cddb44658d742f724f2eb78dc028f7837111d93"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"7f76fe2ecf6fdde93485479bbff7bc2c2dceef8e","unresolved":false,"context_lines":[{"line_number":2197,"context_line":"        def fake_block_device_mapping_get_all_by_instance(context, inst_id):"},{"line_number":2198,"context_line":"            return [dict(snapshot_id\u003dsnapshots[0],"},{"line_number":2199,"context_line":"                         volume_id\u003dvolumes[0],"},{"line_number":2200,"context_line":"                         source_type\u003d\u0027snapshot\u0027,"},{"line_number":2201,"context_line":"                         destination_type\u003d\u0027volume\u0027,"},{"line_number":2202,"context_line":"                         volume_size\u003d1,"},{"line_number":2203,"context_line":"                         device_name\u003d\u0027vda\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAP3%2F%2F5KI%3D","line":2200,"in_reply_to":"AAAAPn%2F%2FSDc%3D","updated":"2013-07-09 17:02:55.000000000","message":"OK, cool.","commit_id":"1cddb44658d742f724f2eb78dc028f7837111d93"},{"author":{"_account_id":5511,"name":"Nikola Dipanov","email":"ndipanov@redhat.com","username":"ndipanov"},"change_message_id":"6e9aa2ae8ab884ce48d7f08d172dbb08b709bdf3","unresolved":false,"context_lines":[{"line_number":2197,"context_line":"        def fake_block_device_mapping_get_all_by_instance(context, inst_id):"},{"line_number":2198,"context_line":"            return [dict(snapshot_id\u003dsnapshots[0],"},{"line_number":2199,"context_line":"                         volume_id\u003dvolumes[0],"},{"line_number":2200,"context_line":"                         source_type\u003d\u0027snapshot\u0027,"},{"line_number":2201,"context_line":"                         destination_type\u003d\u0027volume\u0027,"},{"line_number":2202,"context_line":"                         volume_size\u003d1,"},{"line_number":2203,"context_line":"                         device_name\u003d\u0027vda\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAPn%2F%2FSDc%3D","line":2200,"in_reply_to":"AAAAPn%2F%2FT10%3D","updated":"2013-07-05 09:01:12.000000000","message":"No it is not an unrelated change - we need to make sure that we get the new format from the database, and this method fakes the db call.\n\nWithout this change tests fail (it was a bug that it wasn\u0027t changed in fact)","commit_id":"1cddb44658d742f724f2eb78dc028f7837111d93"}],"nova/tests/compute/test_compute.py":[{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"a39738c4474ef5dbb8ac9b485f65717b304c928f","unresolved":false,"context_lines":[{"line_number":8596,"context_line":"        # Test default behaviour"},{"line_number":8597,"context_line":"        self.mox.StubOutWithMock(block_device, \u0027legacy_mapping\u0027)"},{"line_number":8598,"context_line":"        block_device.legacy_mapping(new_bdm).AndReturn(legacy_bdm)"},{"line_number":8599,"context_line":"        self.mox.ReplayAll()"},{"line_number":8600,"context_line":""},{"line_number":8601,"context_line":"        self.assertEqual(legacy_bdm,"},{"line_number":8602,"context_line":"                         self.compute_api.get_instance_bdms({}, instance))"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAPn%2F%2FT14%3D","line":8599,"updated":"2013-07-04 10:24:51.000000000","message":"bit of an odd mix of mox and stubs, best just to chose one.","commit_id":"1cddb44658d742f724f2eb78dc028f7837111d93"},{"author":{"_account_id":5511,"name":"Nikola Dipanov","email":"ndipanov@redhat.com","username":"ndipanov"},"change_message_id":"81835eace9850499d07e2cc8bb3e0fb51d354a53","unresolved":false,"context_lines":[{"line_number":8596,"context_line":"        # Test default behaviour"},{"line_number":8597,"context_line":"        self.mox.StubOutWithMock(block_device, \u0027legacy_mapping\u0027)"},{"line_number":8598,"context_line":"        block_device.legacy_mapping(new_bdm).AndReturn(legacy_bdm)"},{"line_number":8599,"context_line":"        self.mox.ReplayAll()"},{"line_number":8600,"context_line":""},{"line_number":8601,"context_line":"        self.assertEqual(legacy_bdm,"},{"line_number":8602,"context_line":"                         self.compute_api.get_instance_bdms({}, instance))"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAP3%2F%2F3Gc%3D","line":8599,"in_reply_to":"AAAAP3%2F%2F5Jo%3D","updated":"2013-07-10 08:33:31.000000000","message":"Done","commit_id":"1cddb44658d742f724f2eb78dc028f7837111d93"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"7f76fe2ecf6fdde93485479bbff7bc2c2dceef8e","unresolved":false,"context_lines":[{"line_number":8596,"context_line":"        # Test default behaviour"},{"line_number":8597,"context_line":"        self.mox.StubOutWithMock(block_device, \u0027legacy_mapping\u0027)"},{"line_number":8598,"context_line":"        block_device.legacy_mapping(new_bdm).AndReturn(legacy_bdm)"},{"line_number":8599,"context_line":"        self.mox.ReplayAll()"},{"line_number":8600,"context_line":""},{"line_number":8601,"context_line":"        self.assertEqual(legacy_bdm,"},{"line_number":8602,"context_line":"                         self.compute_api.get_instance_bdms({}, instance))"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAP3%2F%2F5Jo%3D","line":8599,"in_reply_to":"AAAAPn%2F%2FSEU%3D","updated":"2013-07-09 17:02:55.000000000","message":"I would just do a private method. It can make it hard to know what broke in test if we have lots of reasons to fail.\n\nBut I guess its just a single responsibility thing really.","commit_id":"1cddb44658d742f724f2eb78dc028f7837111d93"},{"author":{"_account_id":5511,"name":"Nikola Dipanov","email":"ndipanov@redhat.com","username":"ndipanov"},"change_message_id":"6e9aa2ae8ab884ce48d7f08d172dbb08b709bdf3","unresolved":false,"context_lines":[{"line_number":8596,"context_line":"        # Test default behaviour"},{"line_number":8597,"context_line":"        self.mox.StubOutWithMock(block_device, \u0027legacy_mapping\u0027)"},{"line_number":8598,"context_line":"        block_device.legacy_mapping(new_bdm).AndReturn(legacy_bdm)"},{"line_number":8599,"context_line":"        self.mox.ReplayAll()"},{"line_number":8600,"context_line":""},{"line_number":8601,"context_line":"        self.assertEqual(legacy_bdm,"},{"line_number":8602,"context_line":"                         self.compute_api.get_instance_bdms({}, instance))"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAPn%2F%2FSEU%3D","line":8599,"in_reply_to":"AAAAPn%2F%2FT14%3D","updated":"2013-07-05 09:01:12.000000000","message":"It was done to avoid separate tests and useless boilerplate. I think the test is very clear and concise (and somewhat useless tbh) and I would prefer to not refactor it further.","commit_id":"1cddb44658d742f724f2eb78dc028f7837111d93"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"a39738c4474ef5dbb8ac9b485f65717b304c928f","unresolved":false,"context_lines":[{"line_number":8598,"context_line":"        block_device.legacy_mapping(new_bdm).AndReturn(legacy_bdm)"},{"line_number":8599,"context_line":"        self.mox.ReplayAll()"},{"line_number":8600,"context_line":""},{"line_number":8601,"context_line":"        self.assertEqual(legacy_bdm,"},{"line_number":8602,"context_line":"                         self.compute_api.get_instance_bdms({}, instance))"},{"line_number":8603,"context_line":""},{"line_number":8604,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAPn%2F%2FT2E%3D","line":8601,"updated":"2013-07-04 10:24:51.000000000","message":"Would like to see two separate tests here.","commit_id":"1cddb44658d742f724f2eb78dc028f7837111d93"},{"author":{"_account_id":5511,"name":"Nikola Dipanov","email":"ndipanov@redhat.com","username":"ndipanov"},"change_message_id":"6e9aa2ae8ab884ce48d7f08d172dbb08b709bdf3","unresolved":false,"context_lines":[{"line_number":8598,"context_line":"        block_device.legacy_mapping(new_bdm).AndReturn(legacy_bdm)"},{"line_number":8599,"context_line":"        self.mox.ReplayAll()"},{"line_number":8600,"context_line":""},{"line_number":8601,"context_line":"        self.assertEqual(legacy_bdm,"},{"line_number":8602,"context_line":"                         self.compute_api.get_instance_bdms({}, instance))"},{"line_number":8603,"context_line":""},{"line_number":8604,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAPn%2F%2FSEA%3D","line":8601,"in_reply_to":"AAAAPn%2F%2FT2E%3D","updated":"2013-07-05 09:01:12.000000000","message":"As per above - I believe there is very little to be gained apart from lines of code by doing it. I\u0027d prefer not to.","commit_id":"1cddb44658d742f724f2eb78dc028f7837111d93"},{"author":{"_account_id":1247,"name":"Mark McLoughlin","email":"markmc@redhat.com","username":"markmc"},"change_message_id":"a66bb53f37894617246c94851013552d1c71ce24","unresolved":false,"context_lines":[{"line_number":8039,"context_line":""},{"line_number":8040,"context_line":"    def test_get_instance_bdms_default(self):"},{"line_number":8041,"context_line":"        new_bdm \u003d self._setup_get_instance_bdm_mox()"},{"line_number":8042,"context_line":"        expected \u003d legacy_bdm \u003d object()"},{"line_number":8043,"context_line":""},{"line_number":8044,"context_line":"        self.mox.StubOutWithMock(block_device, \u0027legacy_mapping\u0027)"},{"line_number":8045,"context_line":"        block_device.legacy_mapping(new_bdm).AndReturn(legacy_bdm)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAP3%2F%2FrqU%3D","line":8042,"updated":"2013-07-13 06:37:43.000000000","message":"eh, I would have used two different objects to make this test more robust ... but not a big deal","commit_id":"1737a2cd0ad4e94706f93b6de7acf6e406e5bdb5"}]}