)]}'
{"nova/conf/vmware.py":[{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"1ae9f119d7d057c329a32a6ded93cffa11a237d2","unresolved":false,"context_lines":[{"line_number":78,"context_line":"be sent."},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"This option adds virtual serial port which sends console output to a"},{"line_number":81,"context_line":"configurable service URI. At service URI there will be virtual serial"},{"line_number":82,"context_line":"port concentrator that will collect console logs. If this is not set,"},{"line_number":83,"context_line":"no serial ports will be added to the created VMs."},{"line_number":84,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3aaa91ec_b592fbf3","line":81,"range":{"start_line":81,"start_character":26,"end_line":81,"end_character":46},"updated":"2016-06-27 00:05:08.000000000","message":"At the service URI address there...","commit_id":"fcd2337872285332ba54959bbc0ad9109ed130b2"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"1ae9f119d7d057c329a32a6ded93cffa11a237d2","unresolved":false,"context_lines":[{"line_number":85,"context_line":"Possible values:"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"    * None (default)"},{"line_number":88,"context_line":"    * Any valid uri"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"Related options:"},{"line_number":91,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3aaa91ec_d5c187e5","line":88,"range":{"start_line":88,"start_character":16,"end_line":88,"end_character":19},"updated":"2016-06-27 00:05:08.000000000","message":"URI","commit_id":"fcd2337872285332ba54959bbc0ad9109ed130b2"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"1ae9f119d7d057c329a32a6ded93cffa11a237d2","unresolved":false,"context_lines":[{"line_number":100,"context_line":"Possible values:"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"    * None (default)"},{"line_number":103,"context_line":"    * Any valid uri"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"Related options:"},{"line_number":106,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3aaa91ec_35b56b7d","line":103,"range":{"start_line":103,"start_character":16,"end_line":103,"end_character":19},"updated":"2016-06-27 00:05:08.000000000","message":"URI","commit_id":"fcd2337872285332ba54959bbc0ad9109ed130b2"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"1ae9f119d7d057c329a32a6ded93cffa11a237d2","unresolved":false,"context_lines":[{"line_number":161,"context_line":"                default\u003dFalse,"},{"line_number":162,"context_line":"                help\u003d\"\"\""},{"line_number":163,"context_line":"This option enables or disables storage policy based placement"},{"line_number":164,"context_line":"of instances"},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"Possible values:"},{"line_number":167,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3aaa91ec_15b82f74","line":164,"range":{"start_line":164,"start_character":3,"end_line":164,"end_character":12},"updated":"2016-06-27 00:05:08.000000000","message":"instances.","commit_id":"fcd2337872285332ba54959bbc0ad9109ed130b2"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"1ae9f119d7d057c329a32a6ded93cffa11a237d2","unresolved":false,"context_lines":[{"line_number":173,"context_line":"\"\"\"),"},{"line_number":174,"context_line":"    cfg.StrOpt(\u0027pbm_wsdl_location\u0027,"},{"line_number":175,"context_line":"               help\u003d\"\"\""},{"line_number":176,"context_line":"This option specifies PBM service WSDL file location URL."},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"Setting this will disable storage policy based placement"},{"line_number":179,"context_line":"of instances."}],"source_content_type":"text/x-python","patch_set":1,"id":"3aaa91ec_75b37398","line":176,"range":{"start_line":176,"start_character":12,"end_line":176,"end_character":21},"updated":"2016-06-27 00:05:08.000000000","message":"specifies the","commit_id":"fcd2337872285332ba54959bbc0ad9109ed130b2"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"1ae9f119d7d057c329a32a6ded93cffa11a237d2","unresolved":false,"context_lines":[{"line_number":210,"context_line":"    cfg.IntOpt(\u0027maximum_objects\u0027,"},{"line_number":211,"context_line":"               default\u003d100,"},{"line_number":212,"context_line":"               help\u003d\"\"\""},{"line_number":213,"context_line":"This option specifies the limit on maximum number of objects to"},{"line_number":214,"context_line":"return in single result."},{"line_number":215,"context_line":""},{"line_number":216,"context_line":"A positive value will cause the operation to suspend the retrieval"}],"source_content_type":"text/x-python","patch_set":1,"id":"3aaa91ec_b5a95b26","line":213,"range":{"start_line":213,"start_character":32,"end_line":213,"end_character":34},"updated":"2016-06-27 00:05:08.000000000","message":"on the","commit_id":"fcd2337872285332ba54959bbc0ad9109ed130b2"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"1ae9f119d7d057c329a32a6ded93cffa11a237d2","unresolved":false,"context_lines":[{"line_number":211,"context_line":"               default\u003d100,"},{"line_number":212,"context_line":"               help\u003d\"\"\""},{"line_number":213,"context_line":"This option specifies the limit on maximum number of objects to"},{"line_number":214,"context_line":"return in single result."},{"line_number":215,"context_line":""},{"line_number":216,"context_line":"A positive value will cause the operation to suspend the retrieval"},{"line_number":217,"context_line":"when the count of objects reaches the specified limit. The server may"}],"source_content_type":"text/x-python","patch_set":1,"id":"3aaa91ec_95a41f4b","line":214,"range":{"start_line":214,"start_character":7,"end_line":214,"end_character":9},"updated":"2016-06-27 00:05:08.000000000","message":"in a","commit_id":"fcd2337872285332ba54959bbc0ad9109ed130b2"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"1ae9f119d7d057c329a32a6ded93cffa11a237d2","unresolved":false,"context_lines":[{"line_number":243,"context_line":"Possible values:"},{"line_number":244,"context_line":""},{"line_number":245,"context_line":"    * None (default)"},{"line_number":246,"context_line":""},{"line_number":247,"context_line":"Related options:"},{"line_number":248,"context_line":""},{"line_number":249,"context_line":"    * None"}],"source_content_type":"text/x-python","patch_set":1,"id":"3aaa91ec_d56867f7","line":246,"updated":"2016-06-27 00:05:08.000000000","message":"Should list the other possible value here:\n\nAny string representing the cache prefix to the folder.","commit_id":"fcd2337872285332ba54959bbc0ad9109ed130b2"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"43c868808bc441ea2162ffeb418aaf19885ae154","unresolved":false,"context_lines":[{"line_number":37,"context_line":"    cfg.StrOpt(\u0027integration_bridge\u0027,"},{"line_number":38,"context_line":"               help\u003d\"\"\""},{"line_number":39,"context_line":"This option should be configured only when using the NSX-MH Neutron"},{"line_number":40,"context_line":"plugin. This is the name of the integration bridge on the ESXi. This"},{"line_number":41,"context_line":"should not be set for any other Neutron plugin. Hence the default"},{"line_number":42,"context_line":"value is not set."},{"line_number":43,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3aaa91ec_e798321e","line":40,"range":{"start_line":40,"start_character":58,"end_line":40,"end_character":62},"updated":"2016-06-27 16:52:11.000000000","message":"ESXi server or ESXi host.","commit_id":"ea79e47e978275b3c05aa149a45b2752b6c491eb"},{"author":{"_account_id":18339,"name":"Sivasathurappan Radhakrishnan","email":"siva.radhakrishnan@intel.com","username":"sivakrishnan"},"change_message_id":"481034665abb2334b07e40c253df6ab0a32f82e0","unresolved":false,"context_lines":[{"line_number":37,"context_line":"    cfg.StrOpt(\u0027integration_bridge\u0027,"},{"line_number":38,"context_line":"               help\u003d\"\"\""},{"line_number":39,"context_line":"This option should be configured only when using the NSX-MH Neutron"},{"line_number":40,"context_line":"plugin. This is the name of the integration bridge on the ESXi. This"},{"line_number":41,"context_line":"should not be set for any other Neutron plugin. Hence the default"},{"line_number":42,"context_line":"value is not set."},{"line_number":43,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3aaa91ec_39206149","line":40,"range":{"start_line":40,"start_character":58,"end_line":40,"end_character":62},"in_reply_to":"3aaa91ec_e798321e","updated":"2016-06-28 16:03:58.000000000","message":"Done","commit_id":"ea79e47e978275b3c05aa149a45b2752b6c491eb"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"43c868808bc441ea2162ffeb418aaf19885ae154","unresolved":false,"context_lines":[{"line_number":65,"context_line":"be sent."},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"This option adds virtual serial port which sends console output to a"},{"line_number":68,"context_line":"configurable service URI. At the service URI there will be virtual serial"},{"line_number":69,"context_line":"port concentrator that will collect console logs. If this is not set,"},{"line_number":70,"context_line":"no serial ports will be added to the created VMs."},{"line_number":71,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3aaa91ec_a7a62a51","line":68,"range":{"start_line":68,"start_character":26,"end_line":68,"end_character":44},"updated":"2016-06-27 16:52:11.000000000","message":"Still sounds strange for something to be \"at\" the service URI.","commit_id":"ea79e47e978275b3c05aa149a45b2752b6c491eb"},{"author":{"_account_id":18339,"name":"Sivasathurappan Radhakrishnan","email":"siva.radhakrishnan@intel.com","username":"sivakrishnan"},"change_message_id":"481034665abb2334b07e40c253df6ab0a32f82e0","unresolved":false,"context_lines":[{"line_number":65,"context_line":"be sent."},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"This option adds virtual serial port which sends console output to a"},{"line_number":68,"context_line":"configurable service URI. At the service URI there will be virtual serial"},{"line_number":69,"context_line":"port concentrator that will collect console logs. If this is not set,"},{"line_number":70,"context_line":"no serial ports will be added to the created VMs."},{"line_number":71,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3aaa91ec_99bcf5dc","line":68,"range":{"start_line":68,"start_character":26,"end_line":68,"end_character":44},"in_reply_to":"3aaa91ec_a7a62a51","updated":"2016-06-28 16:03:58.000000000","message":"Sorry for not addressing your previous comments properly. missed it.","commit_id":"ea79e47e978275b3c05aa149a45b2752b6c491eb"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"43c868808bc441ea2162ffeb418aaf19885ae154","unresolved":false,"context_lines":[{"line_number":171,"context_line":"    * Any valid file path"},{"line_number":172,"context_line":"      e.g file:///opt/SDK/spbm/wsdl/pbmService.wsdl"},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"Related options:"},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"    * None"},{"line_number":177,"context_line":"\"\"\"),"},{"line_number":178,"context_line":"    cfg.StrOpt(\u0027pbm_default_policy\u0027,"},{"line_number":179,"context_line":"               help\u003d\"\"\""},{"line_number":180,"context_line":"This option specifies the default policy to be used."}],"source_content_type":"text/x-python","patch_set":2,"id":"3aaa91ec_b2e66642","line":177,"range":{"start_line":174,"start_character":0,"end_line":177,"end_character":5},"updated":"2016-06-27 16:52:11.000000000","message":"Looks like another related none option you can remove","commit_id":"ea79e47e978275b3c05aa149a45b2752b6c491eb"},{"author":{"_account_id":18339,"name":"Sivasathurappan Radhakrishnan","email":"siva.radhakrishnan@intel.com","username":"sivakrishnan"},"change_message_id":"481034665abb2334b07e40c253df6ab0a32f82e0","unresolved":false,"context_lines":[{"line_number":171,"context_line":"    * Any valid file path"},{"line_number":172,"context_line":"      e.g file:///opt/SDK/spbm/wsdl/pbmService.wsdl"},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"Related options:"},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"    * None"},{"line_number":177,"context_line":"\"\"\"),"},{"line_number":178,"context_line":"    cfg.StrOpt(\u0027pbm_default_policy\u0027,"},{"line_number":179,"context_line":"               help\u003d\"\"\""},{"line_number":180,"context_line":"This option specifies the default policy to be used."}],"source_content_type":"text/x-python","patch_set":2,"id":"3aaa91ec_b9a0d1a6","line":177,"range":{"start_line":174,"start_character":0,"end_line":177,"end_character":5},"in_reply_to":"3aaa91ec_b2e66642","updated":"2016-06-28 16:03:58.000000000","message":"Done","commit_id":"ea79e47e978275b3c05aa149a45b2752b6c491eb"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"43c868808bc441ea2162ffeb418aaf19885ae154","unresolved":false,"context_lines":[{"line_number":180,"context_line":"This option specifies the default policy to be used."},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"If pbm_enabled is set and there is no defined storage policy for the"},{"line_number":183,"context_line":"specific request then this policy will be used."},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"Possible values:"},{"line_number":186,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3aaa91ec_f280ee4b","line":183,"range":{"start_line":183,"start_character":9,"end_line":183,"end_character":16},"updated":"2016-06-27 16:52:11.000000000","message":"request,","commit_id":"ea79e47e978275b3c05aa149a45b2752b6c491eb"},{"author":{"_account_id":18339,"name":"Sivasathurappan Radhakrishnan","email":"siva.radhakrishnan@intel.com","username":"sivakrishnan"},"change_message_id":"481034665abb2334b07e40c253df6ab0a32f82e0","unresolved":false,"context_lines":[{"line_number":180,"context_line":"This option specifies the default policy to be used."},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"If pbm_enabled is set and there is no defined storage policy for the"},{"line_number":183,"context_line":"specific request then this policy will be used."},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"Possible values:"},{"line_number":186,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3aaa91ec_f9aa5984","line":183,"range":{"start_line":183,"start_character":9,"end_line":183,"end_character":16},"in_reply_to":"3aaa91ec_f280ee4b","updated":"2016-06-28 16:03:58.000000000","message":"Done","commit_id":"ea79e47e978275b3c05aa149a45b2752b6c491eb"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"43c868808bc441ea2162ffeb418aaf19885ae154","unresolved":false,"context_lines":[{"line_number":185,"context_line":"Possible values:"},{"line_number":186,"context_line":""},{"line_number":187,"context_line":"    * None (default)"},{"line_number":188,"context_line":"    * Any valid storage policy"},{"line_number":189,"context_line":""},{"line_number":190,"context_line":"Related options:"},{"line_number":191,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3aaa91ec_c757f624","line":188,"range":{"start_line":188,"start_character":6,"end_line":188,"end_character":30},"updated":"2016-06-27 16:52:11.000000000","message":"It would be nice here to add an example.\n\nAny valid storage policy such as ...","commit_id":"ea79e47e978275b3c05aa149a45b2752b6c491eb"},{"author":{"_account_id":18339,"name":"Sivasathurappan Radhakrishnan","email":"siva.radhakrishnan@intel.com","username":"sivakrishnan"},"change_message_id":"481034665abb2334b07e40c253df6ab0a32f82e0","unresolved":false,"context_lines":[{"line_number":185,"context_line":"Possible values:"},{"line_number":186,"context_line":""},{"line_number":187,"context_line":"    * None (default)"},{"line_number":188,"context_line":"    * Any valid storage policy"},{"line_number":189,"context_line":""},{"line_number":190,"context_line":"Related options:"},{"line_number":191,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3aaa91ec_59bf2daa","line":188,"range":{"start_line":188,"start_character":6,"end_line":188,"end_character":30},"in_reply_to":"3aaa91ec_c757f624","updated":"2016-06-28 16:03:58.000000000","message":"Have added VSAN default storage policy. Let me know if that looks good.","commit_id":"ea79e47e978275b3c05aa149a45b2752b6c491eb"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"43c868808bc441ea2162ffeb418aaf19885ae154","unresolved":false,"context_lines":[{"line_number":197,"context_line":"    cfg.IntOpt(\u0027maximum_objects\u0027,"},{"line_number":198,"context_line":"               default\u003d100,"},{"line_number":199,"context_line":"               help\u003d\"\"\""},{"line_number":200,"context_line":"This option specifies the limit on maximum number of objects to"},{"line_number":201,"context_line":"return in a single result."},{"line_number":202,"context_line":""},{"line_number":203,"context_line":"A positive value will cause the operation to suspend the retrieval"}],"source_content_type":"text/x-python","patch_set":2,"id":"3aaa91ec_273fdad7","line":200,"range":{"start_line":200,"start_character":32,"end_line":200,"end_character":34},"updated":"2016-06-27 16:52:11.000000000","message":"on the","commit_id":"ea79e47e978275b3c05aa149a45b2752b6c491eb"},{"author":{"_account_id":18339,"name":"Sivasathurappan Radhakrishnan","email":"siva.radhakrishnan@intel.com","username":"sivakrishnan"},"change_message_id":"481034665abb2334b07e40c253df6ab0a32f82e0","unresolved":false,"context_lines":[{"line_number":197,"context_line":"    cfg.IntOpt(\u0027maximum_objects\u0027,"},{"line_number":198,"context_line":"               default\u003d100,"},{"line_number":199,"context_line":"               help\u003d\"\"\""},{"line_number":200,"context_line":"This option specifies the limit on maximum number of objects to"},{"line_number":201,"context_line":"return in a single result."},{"line_number":202,"context_line":""},{"line_number":203,"context_line":"A positive value will cause the operation to suspend the retrieval"}],"source_content_type":"text/x-python","patch_set":2,"id":"3aaa91ec_59e0cd96","line":200,"range":{"start_line":200,"start_character":32,"end_line":200,"end_character":34},"in_reply_to":"3aaa91ec_273fdad7","updated":"2016-06-28 16:03:58.000000000","message":"Done","commit_id":"ea79e47e978275b3c05aa149a45b2752b6c491eb"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"43c868808bc441ea2162ffeb418aaf19885ae154","unresolved":false,"context_lines":[{"line_number":215,"context_line":"vmops_opts \u003d ["},{"line_number":216,"context_line":"    cfg.StrOpt(\u0027cache_prefix\u0027,"},{"line_number":217,"context_line":"               help\u003d\"\"\""},{"line_number":218,"context_line":"This option adds prefix to the folder where cached images are stored"},{"line_number":219,"context_line":""},{"line_number":220,"context_line":"This is not the full path - just a folder prefix. This should only be"},{"line_number":221,"context_line":"used when a datastore cache should be shared between compute nodes."}],"source_content_type":"text/x-python","patch_set":2,"id":"3aaa91ec_4711465d","line":218,"range":{"start_line":218,"start_character":12,"end_line":218,"end_character":16},"updated":"2016-06-27 16:52:11.000000000","message":"adds a","commit_id":"ea79e47e978275b3c05aa149a45b2752b6c491eb"},{"author":{"_account_id":18339,"name":"Sivasathurappan Radhakrishnan","email":"siva.radhakrishnan@intel.com","username":"sivakrishnan"},"change_message_id":"481034665abb2334b07e40c253df6ab0a32f82e0","unresolved":false,"context_lines":[{"line_number":215,"context_line":"vmops_opts \u003d ["},{"line_number":216,"context_line":"    cfg.StrOpt(\u0027cache_prefix\u0027,"},{"line_number":217,"context_line":"               help\u003d\"\"\""},{"line_number":218,"context_line":"This option adds prefix to the folder where cached images are stored"},{"line_number":219,"context_line":""},{"line_number":220,"context_line":"This is not the full path - just a folder prefix. This should only be"},{"line_number":221,"context_line":"used when a datastore cache should be shared between compute nodes."}],"source_content_type":"text/x-python","patch_set":2,"id":"3aaa91ec_99f07568","line":218,"range":{"start_line":218,"start_character":12,"end_line":218,"end_character":16},"in_reply_to":"3aaa91ec_4711465d","updated":"2016-06-28 16:03:58.000000000","message":"Done","commit_id":"ea79e47e978275b3c05aa149a45b2752b6c491eb"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"43c868808bc441ea2162ffeb418aaf19885ae154","unresolved":false,"context_lines":[{"line_number":218,"context_line":"This option adds prefix to the folder where cached images are stored"},{"line_number":219,"context_line":""},{"line_number":220,"context_line":"This is not the full path - just a folder prefix. This should only be"},{"line_number":221,"context_line":"used when a datastore cache should be shared between compute nodes."},{"line_number":222,"context_line":""},{"line_number":223,"context_line":"Note: This should only be used when the compute nodes are running on same"},{"line_number":224,"context_line":"host or they have a shared file system."}],"source_content_type":"text/x-python","patch_set":2,"id":"3aaa91ec_523622e8","line":221,"range":{"start_line":221,"start_character":28,"end_line":221,"end_character":37},"updated":"2016-06-27 16:52:11.000000000","message":"s/should be/is","commit_id":"ea79e47e978275b3c05aa149a45b2752b6c491eb"},{"author":{"_account_id":18339,"name":"Sivasathurappan Radhakrishnan","email":"siva.radhakrishnan@intel.com","username":"sivakrishnan"},"change_message_id":"481034665abb2334b07e40c253df6ab0a32f82e0","unresolved":false,"context_lines":[{"line_number":218,"context_line":"This option adds prefix to the folder where cached images are stored"},{"line_number":219,"context_line":""},{"line_number":220,"context_line":"This is not the full path - just a folder prefix. This should only be"},{"line_number":221,"context_line":"used when a datastore cache should be shared between compute nodes."},{"line_number":222,"context_line":""},{"line_number":223,"context_line":"Note: This should only be used when the compute nodes are running on same"},{"line_number":224,"context_line":"host or they have a shared file system."}],"source_content_type":"text/x-python","patch_set":2,"id":"3aaa91ec_3902213f","line":221,"range":{"start_line":221,"start_character":28,"end_line":221,"end_character":37},"in_reply_to":"3aaa91ec_523622e8","updated":"2016-06-28 16:03:58.000000000","message":"Done","commit_id":"ea79e47e978275b3c05aa149a45b2752b6c491eb"},{"author":{"_account_id":16929,"name":"Giridhar Jayavelu","email":"gjayavelu@vmware.com","username":"gjayavelu"},"change_message_id":"37c1ae1020fa73f6764034dc7c87be11a68214c8","unresolved":false,"context_lines":[{"line_number":64,"context_line":"Identifies the remote system where serial port traffic will be sent."},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"This option adds virtual serial port which sends console output to a"},{"line_number":67,"context_line":"configurable service URI. At the service URI address there will be"},{"line_number":68,"context_line":"virtual serial port concentrator that will collect console logs."},{"line_number":69,"context_line":"If this is not set, no serial ports will be added to the created VMs."},{"line_number":70,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3aaa91ec_dc22eba2","line":67,"updated":"2016-06-28 16:08:16.000000000","message":"\u003e\u003eAt the service URI address there will be\n\u003e\u003evirtual serial port concentrator..\nThe service URI should represent virtual serial port concentrator address which will collect serial logs.","commit_id":"436d3d97c4df513ef42784bc79d8be5d0d70f29f"},{"author":{"_account_id":16929,"name":"Giridhar Jayavelu","email":"gjayavelu@vmware.com","username":"gjayavelu"},"change_message_id":"37c1ae1020fa73f6764034dc7c87be11a68214c8","unresolved":false,"context_lines":[{"line_number":172,"context_line":"\"\"\"),"},{"line_number":173,"context_line":"    cfg.StrOpt(\u0027pbm_default_policy\u0027,"},{"line_number":174,"context_line":"               help\u003d\"\"\""},{"line_number":175,"context_line":"This option specifies the default policy to be used."},{"line_number":176,"context_line":""},{"line_number":177,"context_line":"If pbm_enabled is set and there is no defined storage policy for the"},{"line_number":178,"context_line":"specific request, then this policy will be used."}],"source_content_type":"text/x-python","patch_set":3,"id":"3aaa91ec_f934194b","line":175,"updated":"2016-06-28 16:08:16.000000000","message":"s/default policy/default storage policy","commit_id":"436d3d97c4df513ef42784bc79d8be5d0d70f29f"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"d48dd6bb79539e8240330f217e38fab18e5ebcac","unresolved":false,"context_lines":[{"line_number":23,"context_line":"    cfg.StrOpt(\u0027vlan_interface\u0027,"},{"line_number":24,"context_line":"               default\u003d\u0027vmnic0\u0027,"},{"line_number":25,"context_line":"               help\u003d\"\"\""},{"line_number":26,"context_line":"This option specifies physical ethernet adapter name for VLAN"},{"line_number":27,"context_line":"networking."},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"Set the vlan_interface configuration option to match the ESX host"}],"source_content_type":"text/x-python","patch_set":5,"id":"dada55a8_75729c12","line":26,"range":{"start_line":26,"start_character":12,"end_line":26,"end_character":21},"updated":"2016-07-20 15:25:35.000000000","message":"specifies the","commit_id":"d0d3d6776d7d1d9ef4bd4c58088d93e0d1c3963c"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"e4a395595ff1e530135601ef3cfb615e4fdc52e3","unresolved":false,"context_lines":[{"line_number":53,"context_line":"Set this value if affected by an increased network latency causing"},{"line_number":54,"context_line":"repeated characters when typing in a remote console."},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"Possible values:"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    * Any positive integer value"},{"line_number":59,"context_line":"\"\"\"),"},{"line_number":60,"context_line":"    cfg.StrOpt(\u0027serial_port_service_uri\u0027,"},{"line_number":61,"context_line":"               help\u003d\"\"\""}],"source_content_type":"text/x-python","patch_set":5,"id":"dada55a8_9ad2de5a","line":58,"range":{"start_line":56,"start_character":0,"end_line":58,"end_character":32},"updated":"2016-07-20 14:43:40.000000000","message":"Add min\u003d0 to IntOpt and drop this section.","commit_id":"d0d3d6776d7d1d9ef4bd4c58088d93e0d1c3963c"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"d48dd6bb79539e8240330f217e38fab18e5ebcac","unresolved":false,"context_lines":[{"line_number":59,"context_line":"\"\"\"),"},{"line_number":60,"context_line":"    cfg.StrOpt(\u0027serial_port_service_uri\u0027,"},{"line_number":61,"context_line":"               help\u003d\"\"\""},{"line_number":62,"context_line":"Identifies the remote system where serial port traffic will be sent."},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"This option adds virtual serial port which sends console output to a"},{"line_number":65,"context_line":"configurable service URI. At the service URI address there will be"}],"source_content_type":"text/x-python","patch_set":5,"id":"dada55a8_b5cd3433","line":62,"range":{"start_line":62,"start_character":29,"end_line":62,"end_character":34},"updated":"2016-07-20 15:25:35.000000000","message":"where the","commit_id":"d0d3d6776d7d1d9ef4bd4c58088d93e0d1c3963c"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"d48dd6bb79539e8240330f217e38fab18e5ebcac","unresolved":false,"context_lines":[{"line_number":61,"context_line":"               help\u003d\"\"\""},{"line_number":62,"context_line":"Identifies the remote system where serial port traffic will be sent."},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"This option adds virtual serial port which sends console output to a"},{"line_number":65,"context_line":"configurable service URI. At the service URI address there will be"},{"line_number":66,"context_line":"virtual serial port concentrator that will collect console logs."},{"line_number":67,"context_line":"If this is not set, no serial ports will be added to the created VMs."}],"source_content_type":"text/x-python","patch_set":5,"id":"dada55a8_15cfe029","line":64,"range":{"start_line":64,"start_character":12,"end_line":64,"end_character":16},"updated":"2016-07-20 15:25:35.000000000","message":"adds a","commit_id":"d0d3d6776d7d1d9ef4bd4c58088d93e0d1c3963c"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"e4a395595ff1e530135601ef3cfb615e4fdc52e3","unresolved":false,"context_lines":[{"line_number":143,"context_line":"This option enables or disables storage policy based placement"},{"line_number":144,"context_line":"of instances."},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"Possible values:"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"    * True or False (default)"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"Related options:"},{"line_number":151,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"dada55a8_da3f3685","line":148,"range":{"start_line":146,"start_character":0,"end_line":148,"end_character":29},"updated":"2016-07-20 14:43:40.000000000","message":"Drop this section.","commit_id":"d0d3d6776d7d1d9ef4bd4c58088d93e0d1c3963c"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"e4a395595ff1e530135601ef3cfb615e4fdc52e3","unresolved":false,"context_lines":[{"line_number":194,"context_line":"still limit the count to something less than the configured value."},{"line_number":195,"context_line":"Any remaining objects may be retrieved with additional requests."},{"line_number":196,"context_line":""},{"line_number":197,"context_line":"Possible values:"},{"line_number":198,"context_line":""},{"line_number":199,"context_line":"    * 100 (default)"},{"line_number":200,"context_line":"    * Any positive integer value"},{"line_number":201,"context_line":"\"\"\")"},{"line_number":202,"context_line":"]"},{"line_number":203,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"dada55a8_9ad5be1d","line":200,"range":{"start_line":197,"start_character":0,"end_line":200,"end_character":32},"updated":"2016-07-20 14:43:40.000000000","message":"Add min\u003d0 to IntOpt and drop this section.","commit_id":"d0d3d6776d7d1d9ef4bd4c58088d93e0d1c3963c"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"14b42658cac6d1cd6e403d64b041d9d7aa3e38de","unresolved":false,"context_lines":[{"line_number":58,"context_line":"Set this value if affected by an increased network latency causing"},{"line_number":59,"context_line":"repeated characters when typing in a remote console."},{"line_number":60,"context_line":"\"\"\"),"},{"line_number":61,"context_line":"    cfg.StrOpt(\u0027serial_port_service_uri\u0027,"},{"line_number":62,"context_line":"               help\u003d\"\"\""},{"line_number":63,"context_line":"Identifies the remote system where the serial port traffic will"},{"line_number":64,"context_line":"be sent."}],"source_content_type":"text/x-python","patch_set":8,"id":"9ad45d7e_01a57e03","line":61,"updated":"2016-08-08 10:43:35.000000000","message":"Nit: we now have a URIOpt","commit_id":"cb4bb82e04940ddcee5cd37985669b2b83c460a0"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"14b42658cac6d1cd6e403d64b041d9d7aa3e38de","unresolved":false,"context_lines":[{"line_number":72,"context_line":""},{"line_number":73,"context_line":"* Any valid URI"},{"line_number":74,"context_line":"\"\"\"),"},{"line_number":75,"context_line":"    cfg.StrOpt(\u0027serial_port_proxy_uri\u0027,"},{"line_number":76,"context_line":"               help\u003d\"\"\""},{"line_number":77,"context_line":"Identifies a proxy service that provides network access to the"},{"line_number":78,"context_line":"serial_port_service_uri."}],"source_content_type":"text/x-python","patch_set":8,"id":"9ad45d7e_41af76e3","line":75,"updated":"2016-08-08 10:43:35.000000000","message":"As above.","commit_id":"cb4bb82e04940ddcee5cd37985669b2b83c460a0"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"14b42658cac6d1cd6e403d64b041d9d7aa3e38de","unresolved":false,"context_lines":[{"line_number":146,"context_line":""},{"line_number":147,"context_line":"* pbm_default_policy"},{"line_number":148,"context_line":"\"\"\"),"},{"line_number":149,"context_line":"    cfg.StrOpt(\u0027pbm_wsdl_location\u0027,"},{"line_number":150,"context_line":"               help\u003d\"\"\""},{"line_number":151,"context_line":"This option specifies the PBM service WSDL file location URL."},{"line_number":152,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"9ad45d7e_c1e88619","line":149,"updated":"2016-08-08 10:43:35.000000000","message":"Nit: URIOpt would be good.","commit_id":"cb4bb82e04940ddcee5cd37985669b2b83c460a0"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"14b42658cac6d1cd6e403d64b041d9d7aa3e38de","unresolved":false,"context_lines":[{"line_number":151,"context_line":"This option specifies the PBM service WSDL file location URL."},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"Setting this will disable storage policy based placement"},{"line_number":154,"context_line":"of instances."},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"Possible values:"},{"line_number":157,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"9ad45d7e_01ca9ea1","line":154,"updated":"2016-08-08 10:43:35.000000000","message":"Nit: it would be nice to note this is not usually required.","commit_id":"cb4bb82e04940ddcee5cd37985669b2b83c460a0"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"14b42658cac6d1cd6e403d64b041d9d7aa3e38de","unresolved":false,"context_lines":[{"line_number":163,"context_line":"This option specifies the default policy to be used."},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"If pbm_enabled is set and there is no defined storage policy for the"},{"line_number":166,"context_line":"specific request, then this policy will be used."},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"Possible values:"},{"line_number":169,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"9ad45d7e_c136c6b3","line":166,"updated":"2016-08-08 10:43:35.000000000","message":"Nit: not totally clear on the default behaviour here.","commit_id":"cb4bb82e04940ddcee5cd37985669b2b83c460a0"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"14b42658cac6d1cd6e403d64b041d9d7aa3e38de","unresolved":false,"context_lines":[{"line_number":186,"context_line":"A positive value will cause the operation to suspend the retrieval"},{"line_number":187,"context_line":"when the count of objects reaches the specified limit. The server may"},{"line_number":188,"context_line":"still limit the count to something less than the configured value."},{"line_number":189,"context_line":"Any remaining objects may be retrieved with additional requests."},{"line_number":190,"context_line":"\"\"\"),"},{"line_number":191,"context_line":"    cfg.StrOpt(\u0027cache_prefix\u0027,"},{"line_number":192,"context_line":"               help\u003d\"\"\""}],"source_content_type":"text/x-python","patch_set":8,"id":"9ad45d7e_0158def9","line":189,"updated":"2016-08-08 10:43:35.000000000","message":"Nit: I assume this is about communicating with VCenter, its not totally clear thats what this is about.","commit_id":"cb4bb82e04940ddcee5cd37985669b2b83c460a0"}]}