)]}'
{"nova/policies/base.py":[{"author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"change_message_id":"6868e4701c2628138748bf0b6bded843443847dd","unresolved":false,"context_lines":[{"line_number":23,"context_line":"    policy.RuleDefault(\u0027context_is_admin\u0027, \u0027role:admin\u0027),"},{"line_number":24,"context_line":"    policy.RuleDefault(\u0027admin_or_owner\u0027,"},{"line_number":25,"context_line":"                       \u0027is_admin:True or project_id:%(project_id)s\u0027),"},{"line_number":26,"context_line":"    policy.RuleDefault(\u0027default\u0027, RULE_ADMIN_OR_OWNER),"},{"line_number":27,"context_line":"    policy.RuleDefault(\u0027admin_api\u0027, \u0027is_admin:True\u0027),"},{"line_number":28,"context_line":"    policy.RuleDefault(\u0027cells_scheduler_filter:TargetCellFilter\u0027,"},{"line_number":29,"context_line":"                       \u0027is_admin:True\u0027),"}],"source_content_type":"text/x-python","patch_set":2,"id":"3aaa91ec_963369f6","line":26,"updated":"2016-06-27 14:15:43.000000000","message":"I would actually like this rule to not be defined. Since all rules are registered nothing should fall through to the default.","commit_id":"f583b67995f72f326d8a7ffb9d02f8ee7dde4d17"}],"nova/policies/shelve.py":[{"author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"change_message_id":"58788f51f298ab170d7cfc7f2513a953e75876ea","unresolved":false,"context_lines":[{"line_number":32,"context_line":"        name\u003dPOLICY_ROOT % \u0027shelve_offload\u0027,"},{"line_number":33,"context_line":"        check_str\u003dbase.RULE_ADMIN_API),"},{"line_number":34,"context_line":"    policy.RuleDefault("},{"line_number":35,"context_line":"        name\u003dPOLICY_ROOT % \u0027discoverable\u0027,"},{"line_number":36,"context_line":"        check_str\u003dbase.RULE_ANY),"},{"line_number":37,"context_line":"]"},{"line_number":38,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"3aaa91ec_46cce134","line":35,"updated":"2016-06-30 21:21:55.000000000","message":"woops","commit_id":"7d01bceaa03d73fd4af1887ab8c49281666b9e11"},{"author":{"_account_id":8213,"name":"Claudiu Belu","email":"cbelu@cloudbasesolutions.com","username":"claudiub"},"change_message_id":"f449f4f9145facfd3c1fe35b3133b692d7c56f94","unresolved":false,"context_lines":[{"line_number":32,"context_line":"        name\u003dPOLICY_ROOT % \u0027shelve_offload\u0027,"},{"line_number":33,"context_line":"        check_str\u003dbase.RULE_ADMIN_API),"},{"line_number":34,"context_line":"    policy.RuleDefault("},{"line_number":35,"context_line":"        name\u003dPOLICY_ROOT % \u0027discoverable\u0027,"},{"line_number":36,"context_line":"        check_str\u003dbase.RULE_ANY),"},{"line_number":37,"context_line":"]"},{"line_number":38,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"3aaa91ec_810d1391","line":35,"in_reply_to":"3aaa91ec_46cce134","updated":"2016-06-30 21:43:54.000000000","message":"\u0027os_compute_api:os-shelve:shelve:discoverable\u0027 is what was registered in policy.json before. :)\n\nhttps://github.com/openstack/nova/blob/stable/mitaka/etc/nova/policy.json#L457","commit_id":"7d01bceaa03d73fd4af1887ab8c49281666b9e11"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"7adf60d88ebe21d481cf1d456ddf2025949a18cb","unresolved":false,"context_lines":[{"line_number":32,"context_line":"        name\u003dPOLICY_ROOT % \u0027shelve_offload\u0027,"},{"line_number":33,"context_line":"        check_str\u003dbase.RULE_ADMIN_API),"},{"line_number":34,"context_line":"    policy.RuleDefault("},{"line_number":35,"context_line":"        name\u003dPOLICY_ROOT % \u0027discoverable\u0027,"},{"line_number":36,"context_line":"        check_str\u003dbase.RULE_ANY),"},{"line_number":37,"context_line":"]"},{"line_number":38,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"3aaa91ec_ec802bc2","line":35,"in_reply_to":"3aaa91ec_810d1391","updated":"2016-07-01 13:12:23.000000000","message":"I think that means we shouldn\u0027t change it. Otherwise the user existed configure file will be broken. But looks like we didn\u0027t have upgrade support in Oslo.policy yet. I prefer leave it as before, the extension deprecation works will remove those rule finally.","commit_id":"7d01bceaa03d73fd4af1887ab8c49281666b9e11"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"7e31c7fba375f4d902572e59ed0c2ae5b92b4835","unresolved":false,"context_lines":[{"line_number":32,"context_line":"        name\u003dPOLICY_ROOT % \u0027shelve_offload\u0027,"},{"line_number":33,"context_line":"        check_str\u003dbase.RULE_ADMIN_API),"},{"line_number":34,"context_line":"    policy.RuleDefault("},{"line_number":35,"context_line":"        name\u003dPOLICY_ROOT % \u0027discoverable\u0027,"},{"line_number":36,"context_line":"        check_str\u003dbase.RULE_ANY),"},{"line_number":37,"context_line":"]"},{"line_number":38,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"3aaa91ec_92841c5e","line":35,"in_reply_to":"3aaa91ec_ec802bc2","updated":"2016-07-01 13:36:28.000000000","message":"please ignore this comment, there isn\u0027t a problem. We just write wrong default rule in the policy.json before.","commit_id":"7d01bceaa03d73fd4af1887ab8c49281666b9e11"}],"nova/tests/unit/api/openstack/compute/test_extension_info.py":[{"author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"change_message_id":"6868e4701c2628138748bf0b6bded843443847dd","unresolved":false,"context_lines":[{"line_number":58,"context_line":"}"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"def fake_policy_authorize_selective(context, action, target, do_raise\u003dTrue):"},{"line_number":62,"context_line":"    return action !\u003d \u0027os_compute_api:ext1-alias:discoverable\u0027"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3aaa91ec_b63ae596","line":61,"updated":"2016-06-27 14:15:43.000000000","message":"Should probably change the do_raise default to False here since no exception is raised.","commit_id":"f583b67995f72f326d8a7ffb9d02f8ee7dde4d17"},{"author":{"_account_id":8213,"name":"Claudiu Belu","email":"cbelu@cloudbasesolutions.com","username":"claudiub"},"change_message_id":"ec83190adb8e7c09ede705331983018ce81de984","unresolved":false,"context_lines":[{"line_number":58,"context_line":"}"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"def fake_policy_authorize_selective(context, action, target, do_raise\u003dTrue):"},{"line_number":62,"context_line":"    return action !\u003d \u0027os_compute_api:ext1-alias:discoverable\u0027"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3aaa91ec_b047741c","line":61,"in_reply_to":"3aaa91ec_8a24cac6","updated":"2016-06-27 20:57:45.000000000","message":"eh, nevermind.\n\nanyways, I\u0027ll remove do_raise arg, no need for it, context.can doesn\u0027t call with do_raise argument.","commit_id":"f583b67995f72f326d8a7ffb9d02f8ee7dde4d17"},{"author":{"_account_id":8213,"name":"Claudiu Belu","email":"cbelu@cloudbasesolutions.com","username":"claudiub"},"change_message_id":"2ee27987836cc7f256a011f74ef954d3a4ba251a","unresolved":false,"context_lines":[{"line_number":58,"context_line":"}"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"def fake_policy_authorize_selective(context, action, target, do_raise\u003dTrue):"},{"line_number":62,"context_line":"    return action !\u003d \u0027os_compute_api:ext1-alias:discoverable\u0027"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3aaa91ec_8a24cac6","line":61,"in_reply_to":"3aaa91ec_b63ae596","updated":"2016-06-27 20:51:09.000000000","message":"I can simply remove the arguments anyways, since they aren\u0027t necessary for mock.","commit_id":"f583b67995f72f326d8a7ffb9d02f8ee7dde4d17"}]}