)]}'
{"nova/tests/unit/virt/libvirt/test_driver.py":[{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"a304758de42fbaee346ac89aaf381d70560484a0","unresolved":false,"context_lines":[{"line_number":8686,"context_line":"        # NOTE(mdbooth): I\u0027m not entirely sure what this test was ever"},{"line_number":8687,"context_line":"        # supposed to be testing. The test that nothing is fetched is"},{"line_number":8688,"context_line":"        # implicit: we haven\u0027t mocked anything, so if we tried to get"},{"line_number":8689,"context_line":"        # anything from glance or another compute, it would raise an exception."},{"line_number":8690,"context_line":""},{"line_number":8691,"context_line":"    def _generate_target_ret(self, target_connect_addr\u003dNone):"},{"line_number":8692,"context_line":"        target_ret \u003d {"}],"source_content_type":"text/x-python","patch_set":1,"id":"3aaa91ec_df5af64f","line":8689,"updated":"2016-06-28 10:20:16.000000000","message":"The \u0027_fetch_instance_kernel_ramdisk\u0027 method should be mocked.\nThen check whether it is called or not.\n\nmock_fetch_instance_kernel_ramdisk.assert_called_once_with(\n    self.context, instance, fallback_from_host\u003dNone)","commit_id":"617def142f914a1927509f05e9619098c617c537"},{"author":{"_account_id":9555,"name":"Matthew Booth","email":"mbooth@redhat.com","username":"MatthewBooth"},"change_message_id":"f152bc743d9878966b97b3836998e80b3c42b454","unresolved":false,"context_lines":[{"line_number":8686,"context_line":"        # NOTE(mdbooth): I\u0027m not entirely sure what this test was ever"},{"line_number":8687,"context_line":"        # supposed to be testing. The test that nothing is fetched is"},{"line_number":8688,"context_line":"        # implicit: we haven\u0027t mocked anything, so if we tried to get"},{"line_number":8689,"context_line":"        # anything from glance or another compute, it would raise an exception."},{"line_number":8690,"context_line":""},{"line_number":8691,"context_line":"    def _generate_target_ret(self, target_connect_addr\u003dNone):"},{"line_number":8692,"context_line":"        target_ret \u003d {"}],"source_content_type":"text/x-python","patch_set":1,"id":"3aaa91ec_aac88375","line":8689,"in_reply_to":"3aaa91ec_6216c9a8","updated":"2016-06-28 12:19:05.000000000","message":"I disagree, because _fetch_instance_kernel_ramdisk isn\u0027t an interesting unit boundary. In general, cache() is the interesting boundary in these tests, or fetch_image.","commit_id":"617def142f914a1927509f05e9619098c617c537"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"f8782c1d1b8f9f5598afd66a4c84aa766c88f0c8","unresolved":false,"context_lines":[{"line_number":8686,"context_line":"        # NOTE(mdbooth): I\u0027m not entirely sure what this test was ever"},{"line_number":8687,"context_line":"        # supposed to be testing. The test that nothing is fetched is"},{"line_number":8688,"context_line":"        # implicit: we haven\u0027t mocked anything, so if we tried to get"},{"line_number":8689,"context_line":"        # anything from glance or another compute, it would raise an exception."},{"line_number":8690,"context_line":""},{"line_number":8691,"context_line":"    def _generate_target_ret(self, target_connect_addr\u003dNone):"},{"line_number":8692,"context_line":"        target_ret \u003d {"}],"source_content_type":"text/x-python","patch_set":1,"id":"3aaa91ec_6216c9a8","line":8689,"in_reply_to":"3aaa91ec_df5af64f","updated":"2016-06-28 10:28:32.000000000","message":"IMO, this test case is necessary for test coverage (C1 coverage).\nThere is the following \u0027if\u0027 statement.\n\n        if not disk_info:\n            disk_info \u003d []\n\n        for info in disk_info:\n        ....\n\nAnd check whether \u0027for\u0027 statement is skipped or not,\nand check whether \u0027_fetch_instance_kernel_ramdisk\u0027 is called finally or not.","commit_id":"617def142f914a1927509f05e9619098c617c537"},{"author":{"_account_id":16907,"name":"Diana Clarke","email":"diana.joan.clarke@gmail.com","username":"diana-clarke"},"change_message_id":"bae187de5484f0a676b5f0f49ae3c8bf12b5a0ea","unresolved":false,"context_lines":[{"line_number":10079,"context_line":"        instance_ref \u003d self.test_instance"},{"line_number":10080,"context_line":"        instance_ref[\u0027image_ref\u0027] \u003d 123456  # we send an int to test sha1 call"},{"line_number":10081,"context_line":"        instance \u003d objects.Instance(**instance_ref)"},{"line_number":10082,"context_line":"        instance.config_drive \u003d None"},{"line_number":10083,"context_line":"        image_meta \u003d objects.ImageMeta.from_dict(self.test_image_meta)"},{"line_number":10084,"context_line":""},{"line_number":10085,"context_line":"        self.mox.StubOutWithMock(libvirt_driver.LibvirtDriver,"}],"source_content_type":"text/x-python","patch_set":10,"id":"dada55a8_b719af8a","line":10082,"range":{"start_line":10082,"start_character":8,"end_line":10082,"end_character":36},"updated":"2016-07-20 18:29:54.000000000","message":"How come this was added? This test passes without it, but perhaps I\u0027m missing the bigger picture.","commit_id":"c4e463feafba630b51c3a1ed26309f71e81be7fa"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"27d83b57df8f9e5b0ca6905b5d7e6b854ca41d1a","unresolved":false,"context_lines":[{"line_number":10159,"context_line":"        instance_ref \u003d self.test_instance"},{"line_number":10160,"context_line":"        instance_ref[\u0027image_ref\u0027] \u003d 123456  # we send an int to test sha1 call"},{"line_number":10161,"context_line":"        instance \u003d objects.Instance(**instance_ref)"},{"line_number":10162,"context_line":"        instance.config_drive \u003d None"},{"line_number":10163,"context_line":"        image_meta \u003d objects.ImageMeta.from_dict(self.test_image_meta)"},{"line_number":10164,"context_line":""},{"line_number":10165,"context_line":"        self.mox.StubOutWithMock(libvirt_driver.LibvirtDriver,"}],"source_content_type":"text/x-python","patch_set":14,"id":"bacf61ea_273d628f","line":10162,"updated":"2016-08-01 17:23:26.000000000","message":"It looks to me like False is represented by config_drive\u003d\u0027\u0027. When is it ever valid for it to be None?","commit_id":"c68d60de4e78fb778b8325bea506783e08825bb5"},{"author":{"_account_id":9555,"name":"Matthew Booth","email":"mbooth@redhat.com","username":"MatthewBooth"},"change_message_id":"1b86acdf754671a6d0329d01e24af8544b84a39d","unresolved":false,"context_lines":[{"line_number":10159,"context_line":"        instance_ref \u003d self.test_instance"},{"line_number":10160,"context_line":"        instance_ref[\u0027image_ref\u0027] \u003d 123456  # we send an int to test sha1 call"},{"line_number":10161,"context_line":"        instance \u003d objects.Instance(**instance_ref)"},{"line_number":10162,"context_line":"        instance.config_drive \u003d None"},{"line_number":10163,"context_line":"        image_meta \u003d objects.ImageMeta.from_dict(self.test_image_meta)"},{"line_number":10164,"context_line":""},{"line_number":10165,"context_line":"        self.mox.StubOutWithMock(libvirt_driver.LibvirtDriver,"}],"source_content_type":"text/x-python","patch_set":14,"id":"bacf61ea_f29c755f","line":10162,"in_reply_to":"bacf61ea_273d628f","updated":"2016-08-02 14:16:13.000000000","message":"From instance.py:\n  \u0027config_drive\u0027: fields.StringField(nullable\u003dTrue)\n\nFrom configdrive.required_by:\n      return (instance.config_drive or\n            CONF.force_config_drive or\n            image_prop \u003d\u003d fields.ConfigDrivePolicy.MANDATORY\n            )\n\nSo, None is the most obvious value to set this to, and I hate falsey values. However, I do note that compute.API sets it to \u0027\u0027 in _check_config_drive(). Sigh... The test should probably follow this, so I\u0027ll change it.","commit_id":"c68d60de4e78fb778b8325bea506783e08825bb5"}]}