)]}'
{"plugins/xenserver/xenapi/etc/xapi.d/plugins/glance":[{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"e5efca791789635c5a4b1319990d4d5a7472b551","unresolved":false,"context_lines":[{"line_number":36,"context_line":"    import simplejson as json"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"import md5  # noqa"},{"line_number":39,"context_line":"import six"},{"line_number":40,"context_line":"import socket"},{"line_number":41,"context_line":"import urllib2"},{"line_number":42,"context_line":"from urlparse import urlparse"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"3aaa91ec_2c50685e","line":39,"updated":"2016-06-27 14:52:20.000000000","message":"The \"six\" package is generally not available in the xenserver.  For that matter, the Python package on the xenserver is still generally Python 2.4.","commit_id":"711011a563783a6409b82f0eb6475c07ab8489ba"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"e5efca791789635c5a4b1319990d4d5a7472b551","unresolved":false,"context_lines":[{"line_number":321,"context_line":"    headers \u003d {\u0027Content-Type\u0027: \u0027application/openstack-images-v2.1-json-patch\u0027}"},{"line_number":322,"context_line":"    headers.update(**extra_headers)"},{"line_number":323,"context_line":""},{"line_number":324,"context_line":"    for key, value in six.iteritems(properties):"},{"line_number":325,"context_line":"        prop \u003d {\"path\": \"/%s\" % key.replace(\u0027_\u0027, \u0027-\u0027),"},{"line_number":326,"context_line":"                \"value\": key,"},{"line_number":327,"context_line":"                \"op\": \"add\"}"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"3aaa91ec_cc2f24a6","line":324,"updated":"2016-06-27 14:52:20.000000000","message":"There\u0027s no reason to use iteritems() at all, whether the old dict.iteritems() method or the newer six.iteritems() function.  While there\u0027s no real reason to make any changes here, I would be amenable to accepting a change that replaced this with the dict.items() method; that would also eliminate the need to use the six package—which, as stated above, will not be available in the environment plugins operate in—and happens to be the guidance given for all of nova (\"Don\u0027t use \u0027iteritems()\u0027 without very good reason.\")","commit_id":"711011a563783a6409b82f0eb6475c07ab8489ba"}]}