)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"4c7b2804055b932c24152875bec0ecbb4d18b8c5","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Don\u0027t check for file type in _find_base_file"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Firstly, _find_base_file was differentiating between 2 different types"},{"line_number":10,"context_line":"of \u0027non-original\u0027, but the caller was then treating them identically."},{"line_number":11,"context_line":"This differentiation was obviously redundant."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"However, the caller was using them to populate originals. Note that"},{"line_number":14,"context_line":"_scan_base_files has been called previously, and therefore originals"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5ff73747_41c9e423","line":11,"range":{"start_line":9,"start_character":0,"end_line":11,"end_character":45},"updated":"2017-04-27 11:01:18.000000000","message":"Having read through the code, I was going to comment on this not being true...","commit_id":"35eaa27a04612d85c20f067ab5bf1425b4a4f78e"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"4c7b2804055b932c24152875bec0ecbb4d18b8c5","unresolved":false,"context_lines":[{"line_number":10,"context_line":"of \u0027non-original\u0027, but the caller was then treating them identically."},{"line_number":11,"context_line":"This differentiation was obviously redundant."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"However, the caller was using them to populate originals. Note that"},{"line_number":14,"context_line":"_scan_base_files has been called previously, and therefore originals"},{"line_number":15,"context_line":"is already correctly populated. This means that _find_base_file does"},{"line_number":16,"context_line":"not need to identify \u0027originals\u0027 at all."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Additionally, originals is only tracked at all so that \u0027originals\u0027 and"},{"line_number":19,"context_line":"\u0027non-originals\u0027 can be aged with different frequencies. This doesn\u0027t"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5ff73747_c1dcd4e5","line":16,"range":{"start_line":13,"start_character":0,"end_line":16,"end_character":40},"updated":"2017-04-27 11:01:18.000000000","message":"Until I read this :) Great commit message, as always","commit_id":"35eaa27a04612d85c20f067ab5bf1425b4a4f78e"}],"nova/virt/libvirt/imagecache.py":[{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"010c75cdad4ba4f2ef7d88bad47e0e7d04fd06b7","unresolved":false,"context_lines":[{"line_number":212,"context_line":"        if os.path.exists(base_file):"},{"line_number":213,"context_line":"            yield base_file"},{"line_number":214,"context_line":""},{"line_number":215,"context_line":"        # An older naming style which can be removed sometime after Folsom"},{"line_number":216,"context_line":"        base_file \u003d os.path.join(base_dir, fingerprint + \u0027_sm\u0027)"},{"line_number":217,"context_line":"        if os.path.exists(base_file):"},{"line_number":218,"context_line":"            yield base_file"},{"line_number":219,"context_line":""},{"line_number":220,"context_line":"        # Resized images (also legacy)"},{"line_number":221,"context_line":"        resize_re \u003d re.compile(\u0027.*/%s_[0-9]+$\u0027 % fingerprint)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3aaa91ec_0e21cb4d","line":218,"range":{"start_line":215,"start_character":0,"end_line":218,"end_character":27},"updated":"2016-06-28 21:50:15.000000000","message":"Should we be looking to remove this and other _sm handling code in future cleanups given the comment or does that also need updating?","commit_id":"957afd3bcc8e774f634938d5558fcbbbbc19b037"},{"author":{"_account_id":9555,"name":"Matthew Booth","email":"mbooth@redhat.com","username":"MatthewBooth"},"change_message_id":"8657665ee6577c5c8fb49855c01eb7a64319133b","unresolved":false,"context_lines":[{"line_number":212,"context_line":"        if os.path.exists(base_file):"},{"line_number":213,"context_line":"            yield base_file"},{"line_number":214,"context_line":""},{"line_number":215,"context_line":"        # An older naming style which can be removed sometime after Folsom"},{"line_number":216,"context_line":"        base_file \u003d os.path.join(base_dir, fingerprint + \u0027_sm\u0027)"},{"line_number":217,"context_line":"        if os.path.exists(base_file):"},{"line_number":218,"context_line":"            yield base_file"},{"line_number":219,"context_line":""},{"line_number":220,"context_line":"        # Resized images (also legacy)"},{"line_number":221,"context_line":"        resize_re \u003d re.compile(\u0027.*/%s_[0-9]+$\u0027 % fingerprint)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3aaa91ec_34d32261","line":218,"range":{"start_line":215,"start_character":0,"end_line":218,"end_character":27},"in_reply_to":"3aaa91ec_0e21cb4d","updated":"2016-06-29 09:16:34.000000000","message":"We should probably handle them across the board until we implement a migration scheme for them. However, I\u0027m reasonably confident this will have been broken for a really long time. If anybody has a pet this old, they\u0027ve already worked round it.\n\nFor the moment I\u0027m happy to leave it under the carpet :)","commit_id":"957afd3bcc8e774f634938d5558fcbbbbc19b037"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"42f500161939519f1d7bbfdff1a40c4ecbe0d339","unresolved":false,"context_lines":[{"line_number":220,"context_line":"        if os.path.exists(base_file):"},{"line_number":221,"context_line":"            yield base_file"},{"line_number":222,"context_line":""},{"line_number":223,"context_line":"        # An older naming style which can be removed sometime after Folsom"},{"line_number":224,"context_line":"        base_file \u003d os.path.join(base_dir, fingerprint + \u0027_sm\u0027)"},{"line_number":225,"context_line":"        if os.path.exists(base_file):"},{"line_number":226,"context_line":"            yield base_file"}],"source_content_type":"text/x-python","patch_set":2,"id":"5ff73747_300740cd","line":223,"updated":"2017-04-27 12:58:07.000000000","message":"yeah, I think we\u0027re \"some time after Folsom\" at this point ;)","commit_id":"35eaa27a04612d85c20f067ab5bf1425b4a4f78e"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"4c7b2804055b932c24152875bec0ecbb4d18b8c5","unresolved":false,"context_lines":[{"line_number":220,"context_line":"        if os.path.exists(base_file):"},{"line_number":221,"context_line":"            yield base_file"},{"line_number":222,"context_line":""},{"line_number":223,"context_line":"        # An older naming style which can be removed sometime after Folsom"},{"line_number":224,"context_line":"        base_file \u003d os.path.join(base_dir, fingerprint + \u0027_sm\u0027)"},{"line_number":225,"context_line":"        if os.path.exists(base_file):"},{"line_number":226,"context_line":"            yield base_file"},{"line_number":227,"context_line":""},{"line_number":228,"context_line":"        # Resized images (also legacy)"},{"line_number":229,"context_line":"        resize_re \u003d re.compile(\u0027.*/%s_[0-9]+$\u0027 % fingerprint)"}],"source_content_type":"text/x-python","patch_set":2,"id":"5ff73747_21325860","line":226,"range":{"start_line":223,"start_character":0,"end_line":226,"end_character":27},"updated":"2017-04-27 11:01:18.000000000","message":"sidenote: I wonder if there\u0027s a deprecation path for this?","commit_id":"35eaa27a04612d85c20f067ab5bf1425b4a4f78e"},{"author":{"_account_id":9555,"name":"Matthew Booth","email":"mbooth@redhat.com","username":"MatthewBooth"},"change_message_id":"ff4e83ede0de1e2b4b57da2fe0e1f6ba6824d8e6","unresolved":false,"context_lines":[{"line_number":220,"context_line":"        if os.path.exists(base_file):"},{"line_number":221,"context_line":"            yield base_file"},{"line_number":222,"context_line":""},{"line_number":223,"context_line":"        # An older naming style which can be removed sometime after Folsom"},{"line_number":224,"context_line":"        base_file \u003d os.path.join(base_dir, fingerprint + \u0027_sm\u0027)"},{"line_number":225,"context_line":"        if os.path.exists(base_file):"},{"line_number":226,"context_line":"            yield base_file"},{"line_number":227,"context_line":""},{"line_number":228,"context_line":"        # Resized images (also legacy)"},{"line_number":229,"context_line":"        resize_re \u003d re.compile(\u0027.*/%s_[0-9]+$\u0027 % fingerprint)"}],"source_content_type":"text/x-python","patch_set":2,"id":"5ff73747_047c0a70","line":226,"range":{"start_line":223,"start_character":0,"end_line":226,"end_character":27},"in_reply_to":"5ff73747_21325860","updated":"2017-04-27 11:08:39.000000000","message":"lyarwood asked the same question in an earlier version. I very much doubt it.\n\nThe problem is that unless we actively migrate instance layouts we can\u0027t really ever deprecate this stuff. This is one of the main reasons I want to store on-disk layout explicitly with the instance, btw.","commit_id":"35eaa27a04612d85c20f067ab5bf1425b4a4f78e"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"4c7b2804055b932c24152875bec0ecbb4d18b8c5","unresolved":false,"context_lines":[{"line_number":312,"context_line":""},{"line_number":313,"context_line":"    def _remove_base_file(self, base_file):"},{"line_number":314,"context_line":"        \"\"\"Remove a single base file if it is old enough.\"\"\""},{"line_number":315,"context_line":"        maxage \u003d CONF.libvirt.remove_unused_resized_minimum_age_seconds"},{"line_number":316,"context_line":"        if base_file in self.originals:"},{"line_number":317,"context_line":"            maxage \u003d CONF.remove_unused_original_minimum_age_seconds"},{"line_number":318,"context_line":""},{"line_number":319,"context_line":"        self._remove_old_enough_file(base_file, maxage)"},{"line_number":320,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5ff73747_216a58ed","line":317,"range":{"start_line":315,"start_character":0,"end_line":317,"end_character":68},"updated":"2017-04-27 11:01:18.000000000","message":"So it\u0027s this part that doesn\u0027t make sense, in your opinion. I assume one will go by the wayside so (likely the \u0027libvirt\u0027 one, given the generic one is used elsewhere)","commit_id":"35eaa27a04612d85c20f067ab5bf1425b4a4f78e"}]}