)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"81a3edb7260631ea6b793315ed6ed43a64486a42","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2016-09-28 11:31:59 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"migration.source_compute should be unchanged after finish_revert_resize."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: Ie616045c40ea4a18977c18df9f5624efa4ba7e6a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"5a8bc5a2_56e8d616","line":8,"updated":"2016-09-28 10:32:43.000000000","message":"Could you add more description at here? and register a bug","commit_id":"8dacbb1b4e56a54c4a3bb5d0bce70347498f5bd8"},{"author":{"_account_id":12813,"name":"Rong Han","email":"han.rong3@zte.com.cn","username":"hanrong-zte"},"change_message_id":"e6087838050d6a1a3de60537f7e72b8e92fac104","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2016-09-28 11:31:59 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"migration.source_compute should be unchanged after finish_revert_resize."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: Ie616045c40ea4a18977c18df9f5624efa4ba7e6a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"da6895a0_0a7d27e7","line":8,"in_reply_to":"5a8bc5a2_56e8d616","updated":"2016-10-25 07:37:21.000000000","message":"Done","commit_id":"8dacbb1b4e56a54c4a3bb5d0bce70347498f5bd8"}],"nova/compute/manager.py":[{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"81a3edb7260631ea6b793315ed6ed43a64486a42","unresolved":false,"context_lines":[{"line_number":3576,"context_line":""},{"line_number":3577,"context_line":"            self.network_api.setup_networks_on_host(context, instance,"},{"line_number":3578,"context_line":"                                                    migration.source_compute)"},{"line_number":3579,"context_line":"            migration_p \u003d obj_base.obj_to_primitive(migration)"},{"line_number":3580,"context_line":"            self.network_api.migrate_instance_finish(context,"},{"line_number":3581,"context_line":"                                                     instance,"},{"line_number":3582,"context_line":"                                                     migration_p)"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a8bc5a2_f66482e6","side":"PARENT","line":3579,"range":{"start_line":3579,"start_character":12,"end_line":3579,"end_character":62},"updated":"2016-09-28 10:32:43.000000000","message":"you should change the dest_compute at here, to help \u0027self.network_api.migrate_instance_finish\u0027 works correctly","commit_id":"de82d983333ddfd5033e962badd2b931336560b6"},{"author":{"_account_id":12813,"name":"Rong Han","email":"han.rong3@zte.com.cn","username":"hanrong-zte"},"change_message_id":"e6087838050d6a1a3de60537f7e72b8e92fac104","unresolved":false,"context_lines":[{"line_number":3576,"context_line":""},{"line_number":3577,"context_line":"            self.network_api.setup_networks_on_host(context, instance,"},{"line_number":3578,"context_line":"                                                    migration.source_compute)"},{"line_number":3579,"context_line":"            migration_p \u003d obj_base.obj_to_primitive(migration)"},{"line_number":3580,"context_line":"            self.network_api.migrate_instance_finish(context,"},{"line_number":3581,"context_line":"                                                     instance,"},{"line_number":3582,"context_line":"                                                     migration_p)"}],"source_content_type":"text/x-python","patch_set":5,"id":"da6895a0_fd126461","side":"PARENT","line":3579,"range":{"start_line":3579,"start_character":12,"end_line":3579,"end_character":62},"in_reply_to":"5a8bc5a2_7630729f","updated":"2016-10-25 07:37:21.000000000","message":"I will add comment.","commit_id":"de82d983333ddfd5033e962badd2b931336560b6"},{"author":{"_account_id":12813,"name":"Rong Han","email":"han.rong3@zte.com.cn","username":"hanrong-zte"},"change_message_id":"e6087838050d6a1a3de60537f7e72b8e92fac104","unresolved":false,"context_lines":[{"line_number":3576,"context_line":""},{"line_number":3577,"context_line":"            self.network_api.setup_networks_on_host(context, instance,"},{"line_number":3578,"context_line":"                                                    migration.source_compute)"},{"line_number":3579,"context_line":"            migration_p \u003d obj_base.obj_to_primitive(migration)"},{"line_number":3580,"context_line":"            self.network_api.migrate_instance_finish(context,"},{"line_number":3581,"context_line":"                                                     instance,"},{"line_number":3582,"context_line":"                                                     migration_p)"}],"source_content_type":"text/x-python","patch_set":5,"id":"da6895a0_7d82d495","side":"PARENT","line":3579,"range":{"start_line":3579,"start_character":12,"end_line":3579,"end_character":62},"in_reply_to":"5a8bc5a2_f66482e6","updated":"2016-10-25 07:37:21.000000000","message":"I see, thanks.","commit_id":"de82d983333ddfd5033e962badd2b931336560b6"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"9704fea4a9db8b938b88f2584f3faa0b2e049d28","unresolved":false,"context_lines":[{"line_number":3576,"context_line":""},{"line_number":3577,"context_line":"            self.network_api.setup_networks_on_host(context, instance,"},{"line_number":3578,"context_line":"                                                    migration.source_compute)"},{"line_number":3579,"context_line":"            migration_p \u003d obj_base.obj_to_primitive(migration)"},{"line_number":3580,"context_line":"            self.network_api.migrate_instance_finish(context,"},{"line_number":3581,"context_line":"                                                     instance,"},{"line_number":3582,"context_line":"                                                     migration_p)"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a8bc5a2_7630729f","side":"PARENT","line":3579,"range":{"start_line":3579,"start_character":12,"end_line":3579,"end_character":62},"in_reply_to":"5a8bc5a2_f66482e6","updated":"2016-09-28 10:35:37.000000000","message":"It\u0027s also worth a comment at here to explain why we doing that.","commit_id":"de82d983333ddfd5033e962badd2b931336560b6"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"8bd0222676fc89e4c902566c1665ec3121374a21","unresolved":false,"context_lines":[{"line_number":3574,"context_line":"                                                    migration.source_compute)"},{"line_number":3575,"context_line":"            migration_p \u003d obj_base.obj_to_primitive(migration)"},{"line_number":3576,"context_line":"            # NOTE(hanrong): we need to change migration_p[\u0027dest_compute\u0027] to"},{"line_number":3577,"context_line":"            # source host temporarily. Migration_p as"},{"line_number":3578,"context_line":"            # migrate_instance_finish\u0027s parameter, migrate_instance_finish"},{"line_number":3579,"context_line":"            # need migration\u0027s final destination host."},{"line_number":3580,"context_line":"            migration_p[\u0027dest_compute\u0027] \u003d migration.source_compute"},{"line_number":3581,"context_line":"            self.network_api.migrate_instance_finish(context,"},{"line_number":3582,"context_line":"                                                     instance,"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba5da102_af6a4ab1","line":3579,"range":{"start_line":3577,"start_character":39,"end_line":3579,"end_character":54},"updated":"2016-11-01 14:30:23.000000000","message":"Maybe we should say: \"network_api.migrate_instance_finish\" will setup the network for the instance on the destination host. For revert resize, the instance will back to the source host, the setup of the network for instance should be on the source host. So set the migration_p[\u0027dest_compute\u0027] to source host at here.","commit_id":"386aa044c7af61c35a4b268f66e25d4f0e2cd23e"},{"author":{"_account_id":12813,"name":"Rong Han","email":"han.rong3@zte.com.cn","username":"hanrong-zte"},"change_message_id":"72e783a67350f26c6a1443176997730694431496","unresolved":false,"context_lines":[{"line_number":3574,"context_line":"                                                    migration.source_compute)"},{"line_number":3575,"context_line":"            migration_p \u003d obj_base.obj_to_primitive(migration)"},{"line_number":3576,"context_line":"            # NOTE(hanrong): we need to change migration_p[\u0027dest_compute\u0027] to"},{"line_number":3577,"context_line":"            # source host temporarily. Migration_p as"},{"line_number":3578,"context_line":"            # migrate_instance_finish\u0027s parameter, migrate_instance_finish"},{"line_number":3579,"context_line":"            # need migration\u0027s final destination host."},{"line_number":3580,"context_line":"            migration_p[\u0027dest_compute\u0027] \u003d migration.source_compute"},{"line_number":3581,"context_line":"            self.network_api.migrate_instance_finish(context,"},{"line_number":3582,"context_line":"                                                     instance,"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba5da102_02b4a432","line":3579,"range":{"start_line":3577,"start_character":39,"end_line":3579,"end_character":54},"in_reply_to":"ba5da102_af6a4ab1","updated":"2016-11-03 06:08:55.000000000","message":"Done","commit_id":"386aa044c7af61c35a4b268f66e25d4f0e2cd23e"}],"nova/tests/unit/compute/test_compute.py":[{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"8bd0222676fc89e4c902566c1665ec3121374a21","unresolved":false,"context_lines":[{"line_number":5495,"context_line":"        self.assertNotEqual(migration.dest_compute, migration.source_compute)"},{"line_number":5496,"context_line":"        self.assertNotEqual(migration.dest_node, migration.source_node)"},{"line_number":5497,"context_line":"        self.assertEqual(NODENAME2, migration.dest_compute)"},{"line_number":5498,"context_line":"        self.assertEqual(NODENAME2, migration.dest_node)"},{"line_number":5499,"context_line":"        self.assertIsInstance(instance.numa_topology, numa_topology.__class__)"},{"line_number":5500,"context_line":""},{"line_number":5501,"context_line":"        if remove_old_vm_state:"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba5da102_5d6b27f1","line":5498,"updated":"2016-11-01 14:30:23.000000000","message":"Can we ensure that we pass the right value to the \"self.network_api.migrate_instance_finish\"?","commit_id":"386aa044c7af61c35a4b268f66e25d4f0e2cd23e"},{"author":{"_account_id":12813,"name":"Rong Han","email":"han.rong3@zte.com.cn","username":"hanrong-zte"},"change_message_id":"72e783a67350f26c6a1443176997730694431496","unresolved":false,"context_lines":[{"line_number":5495,"context_line":"        self.assertNotEqual(migration.dest_compute, migration.source_compute)"},{"line_number":5496,"context_line":"        self.assertNotEqual(migration.dest_node, migration.source_node)"},{"line_number":5497,"context_line":"        self.assertEqual(NODENAME2, migration.dest_compute)"},{"line_number":5498,"context_line":"        self.assertEqual(NODENAME2, migration.dest_node)"},{"line_number":5499,"context_line":"        self.assertIsInstance(instance.numa_topology, numa_topology.__class__)"},{"line_number":5500,"context_line":""},{"line_number":5501,"context_line":"        if remove_old_vm_state:"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba5da102_22ec4829","line":5498,"in_reply_to":"ba5da102_5d6b27f1","updated":"2016-11-03 06:08:55.000000000","message":"I will add test for the parameter of self.network_api.migrate_instance_finish.","commit_id":"386aa044c7af61c35a4b268f66e25d4f0e2cd23e"}]}