)]}'
{"nova/virt/libvirt/guest.py":[{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"1d5e637e7fc355499a6ec1d084f212c1155b568d","unresolved":false,"context_lines":[{"line_number":218,"context_line":"        try:"},{"line_number":219,"context_line":"            self._domain.undefineFlags("},{"line_number":220,"context_line":"                libvirt.VIR_DOMAIN_UNDEFINE_MANAGED_SAVE |"},{"line_number":221,"context_line":"                libvirt.VIR_DOMAIN_UNDEFINE_NVRAM)"},{"line_number":222,"context_line":"        except libvirt.libvirtError:"},{"line_number":223,"context_line":"            LOG.debug(\"Error from libvirt during undefineFlags. %d\""},{"line_number":224,"context_line":"                      \"Retrying with undefine\", self.id)"}],"source_content_type":"text/x-python","patch_set":4,"id":"dada55a8_184a4355","line":221,"updated":"2016-07-27 11:45:52.000000000","message":"MIn libvirt is 1.2.1, but UNDEFINE_NVRAM was only added in 1.2.8. Further, even if the ibvirt-python API has the constant defined, we might run against a libvirt demon version which does not support it.\n\nSo you need to a) check if UNDEFINE_NVRAM actually exists before using it, and b) catch an error and retry without UNDEFINE_NVRAM","commit_id":"0ac51c4e57b47cc9f51dd231360af26ad663d6cb"},{"author":{"_account_id":20854,"name":"Ching Kuo","email":"gene@openstack.org","username":"gene-kuo"},"change_message_id":"a719514db3b0348a69597bd0f0f07f34fade3cbc","unresolved":false,"context_lines":[{"line_number":218,"context_line":"        try:"},{"line_number":219,"context_line":"            self._domain.undefineFlags("},{"line_number":220,"context_line":"                libvirt.VIR_DOMAIN_UNDEFINE_MANAGED_SAVE |"},{"line_number":221,"context_line":"                libvirt.VIR_DOMAIN_UNDEFINE_NVRAM)"},{"line_number":222,"context_line":"        except libvirt.libvirtError:"},{"line_number":223,"context_line":"            LOG.debug(\"Error from libvirt during undefineFlags. %d\""},{"line_number":224,"context_line":"                      \"Retrying with undefine\", self.id)"}],"source_content_type":"text/x-python","patch_set":4,"id":"bacf61ea_9ac6ce47","line":221,"in_reply_to":"dada55a8_184a4355","updated":"2016-08-05 17:59:26.000000000","message":"Thanks, going to work on it now","commit_id":"0ac51c4e57b47cc9f51dd231360af26ad663d6cb"}]}