)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9555,"name":"Matthew Booth","email":"mbooth@redhat.com","username":"MatthewBooth"},"change_message_id":"7c65d29d3db871d50423d86d7885bebbfc58765d","unresolved":false,"context_lines":[{"line_number":12,"context_line":"The first check is performed by _is_shared_block_storage method, the"},{"line_number":13,"context_line":"second one is performed inside check_can_live_migrate_source."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"The second check was added in https://review.openstack.org/#/c/195885"},{"line_number":16,"context_line":"There were no sufficient details why that change helps in both commit"},{"line_number":17,"context_line":"message and related bug. Also that change does not set"},{"line_number":18,"context_line":"dest_check_data.is_shared_block_storage flag, which looks inconsistent."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9ad45d7e_b9193d25","line":15,"updated":"2016-08-12 13:13:29.000000000","message":"So, now you\u0027ve said on IRC I can see that this change is essentially a revert of the above patch. It\u0027s not massively important, but if you update could you please reword the commit message to explicitly use the word \u0027revert\u0027?","commit_id":"12149fd830af1815548bb39daee2132fd1a42011"}],"nova/tests/unit/virt/libvirt/test_driver.py":[{"author":{"_account_id":9555,"name":"Matthew Booth","email":"mbooth@redhat.com","username":"MatthewBooth"},"change_message_id":"7c65d29d3db871d50423d86d7885bebbfc58765d","unresolved":false,"context_lines":[{"line_number":7282,"context_line":"                          drvr.check_can_live_migrate_source,"},{"line_number":7283,"context_line":"                          self.context, instance, dest_check_data)"},{"line_number":7284,"context_line":""},{"line_number":7285,"context_line":"    def test_check_can_live_migrate_source_booted_from_volume(self):"},{"line_number":7286,"context_line":"        block_device_info \u003d {\u0027block_device_mapping\u0027: [{\u0027boot_index\u0027: 0}]}"},{"line_number":7287,"context_line":"        instance, dest_check_data, drvr \u003d self._mock_can_live_migrate_source("},{"line_number":7288,"context_line":"                block_device_info\u003dblock_device_info)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9ad45d7e_39a42d07","side":"PARENT","line":7285,"updated":"2016-08-12 13:13:29.000000000","message":"For reviewer reference: deleting these tests is fine because the correct operation of _is_shared_block_storage_volume, which we assume in this test, is tested separately in test_is_shared_block_storage_volume_backed and test_is_shared_block_storage_volume_backed_with_disk.","commit_id":"dab2e1fe1fe7ee51a09c145bd756f6aca693da50"}],"nova/virt/libvirt/driver.py":[{"author":{"_account_id":12299,"name":"Paweł Koniszewski","email":"pawel.koniszewski@gmail.com","username":"pawel.koniszewski"},"change_message_id":"0fac8e7212d6893e42f71a7ffd33a1501cc6ce25","unresolved":false,"context_lines":[{"line_number":5425,"context_line":"            # place block device files under the instance path"},{"line_number":5426,"context_line":"            return True"},{"line_number":5427,"context_line":""},{"line_number":5428,"context_line":"        # Here we assume that _get_instance_disk_info returns all instance\u0027s"},{"line_number":5429,"context_line":"        # disks (not volumes). But this is wrong for rbd. The function returns"},{"line_number":5430,"context_line":"        # an empty list always due to rbd trait. However it does not matter,"},{"line_number":5431,"context_line":"        # because rbd case is checked above, but different image types on"}],"source_content_type":"text/x-python","patch_set":1,"id":"1aa78d24_e4b65289","line":5428,"updated":"2016-07-04 12:43:40.000000000","message":"It would be better to add a NOTE(your_nickname) at the beginning of this comment","commit_id":"7539de60056fb2cda332e969c8fd6df220506cec"},{"author":{"_account_id":10224,"name":"Feodor Tersin","email":"ftersin@hotmail.com","username":"ftersin"},"change_message_id":"5379516a6829940f645ca4f8badd13da64ebe5a4","unresolved":false,"context_lines":[{"line_number":5425,"context_line":"            # place block device files under the instance path"},{"line_number":5426,"context_line":"            return True"},{"line_number":5427,"context_line":""},{"line_number":5428,"context_line":"        # Here we assume that _get_instance_disk_info returns all instance\u0027s"},{"line_number":5429,"context_line":"        # disks (not volumes). But this is wrong for rbd. The function returns"},{"line_number":5430,"context_line":"        # an empty list always due to rbd trait. However it does not matter,"},{"line_number":5431,"context_line":"        # because rbd case is checked above, but different image types on"}],"source_content_type":"text/x-python","patch_set":1,"id":"1aa78d24_905ea4e7","line":5428,"in_reply_to":"1aa78d24_e4b65289","updated":"2016-07-04 13:48:30.000000000","message":"sahid does not like named comments. In other reviews he asked me to remove such signatures.","commit_id":"7539de60056fb2cda332e969c8fd6df220506cec"}]}