)]}'
{"nova/conf/network.py":[{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"f9114fa342ee79f3c068164ecd8d375d46f5b3c7","unresolved":false,"context_lines":[{"line_number":172,"context_line":"\"\"\"),"},{"line_number":173,"context_line":"    cfg.IntOpt(\"vpn_start\","},{"line_number":174,"context_line":"            default\u003d1000,"},{"line_number":175,"context_line":"            min\u003d1,"},{"line_number":176,"context_line":"            max\u003d65535,"},{"line_number":177,"context_line":"            help\u003d\"\"\""},{"line_number":178,"context_line":"This is the port number to use as the first VPN port for private networks."}],"source_content_type":"text/x-python","patch_set":1,"id":"3aaa91ec_d126f7b8","line":175,"updated":"2016-06-30 07:20:41.000000000","message":"Just use PortOpt instead","commit_id":"097e67c439ca36821d22de2f7127d87ab36095ad"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"9b19af7dc72d87a0ba8986ea740553308081e86e","unresolved":false,"context_lines":[{"line_number":172,"context_line":"\"\"\"),"},{"line_number":173,"context_line":"    cfg.IntOpt(\"vpn_start\","},{"line_number":174,"context_line":"            default\u003d1000,"},{"line_number":175,"context_line":"            min\u003d1,"},{"line_number":176,"context_line":"            max\u003d65535,"},{"line_number":177,"context_line":"            help\u003d\"\"\""},{"line_number":178,"context_line":"This is the port number to use as the first VPN port for private networks."}],"source_content_type":"text/x-python","patch_set":1,"id":"1aa78d24_adecfd8f","line":175,"in_reply_to":"3aaa91ec_d126f7b8","updated":"2016-07-05 13:06:02.000000000","message":"+1","commit_id":"097e67c439ca36821d22de2f7127d87ab36095ad"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"a914bee72d7dcd7109eea44a91c7929442761f4a","unresolved":false,"context_lines":[{"line_number":627,"context_line":"\"\"\"),"},{"line_number":628,"context_line":"    cfg.IntOpt(\"send_arp_for_ha_count\","},{"line_number":629,"context_line":"            default\u003d3,"},{"line_number":630,"context_line":"            min\u003d0,"},{"line_number":631,"context_line":"            help\u003d\"\"\""},{"line_number":632,"context_line":"When arp messages are configured to be sent, they will be sent with the count"},{"line_number":633,"context_line":"set to the value of this option. Of course, if this is set to zero, no arp"}],"source_content_type":"text/x-python","patch_set":1,"id":"3aaa91ec_31f77bd4","line":630,"updated":"2016-06-30 07:36:12.000000000","message":"No longer in linux_net.py:bind_floating_ip() do you have to check for send_arp_for_ha_count \u003e 0","commit_id":"097e67c439ca36821d22de2f7127d87ab36095ad"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"a914bee72d7dcd7109eea44a91c7929442761f4a","unresolved":false,"context_lines":[{"line_number":693,"context_line":"    cfg.BoolOpt(\u0027fake_network\u0027,"},{"line_number":694,"context_line":"                default\u003dFalse,"},{"line_number":695,"context_line":"                help\u003d\u0027If passed, use fake network devices and addresses\u0027),"},{"line_number":696,"context_line":"    cfg.IntOpt(\u0027ebtables_exec_attempts\u0027,"},{"line_number":697,"context_line":"               default\u003d3,"},{"line_number":698,"context_line":"               min\u003d0,"},{"line_number":699,"context_line":"               help\u003d\u0027Number of times to retry ebtables commands on failure.\u0027),"}],"source_content_type":"text/x-python","patch_set":1,"id":"3aaa91ec_31249b0b","line":696,"updated":"2016-06-30 07:36:12.000000000","message":"No longer need to check if ebtables_exec_attempts is \u003e 0 in linux_net.py:_exec_ebtables()","commit_id":"097e67c439ca36821d22de2f7127d87ab36095ad"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"a914bee72d7dcd7109eea44a91c7929442761f4a","unresolved":false,"context_lines":[{"line_number":695,"context_line":"                help\u003d\u0027If passed, use fake network devices and addresses\u0027),"},{"line_number":696,"context_line":"    cfg.IntOpt(\u0027ebtables_exec_attempts\u0027,"},{"line_number":697,"context_line":"               default\u003d3,"},{"line_number":698,"context_line":"               min\u003d0,"},{"line_number":699,"context_line":"               help\u003d\u0027Number of times to retry ebtables commands on failure.\u0027),"},{"line_number":700,"context_line":"    cfg.FloatOpt(\u0027ebtables_retry_interval\u0027,"},{"line_number":701,"context_line":"                 default\u003d1.0,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3aaa91ec_d160b737","line":698,"range":{"start_line":698,"start_character":19,"end_line":698,"end_character":20},"updated":"2016-06-30 07:36:12.000000000","message":"Should be 1 according to linux_net.py:\n\n    attempts \u003d CONF.ebtables_exec_attempts\n    if attempts \u003c\u003d 0:\n        attempts \u003d 1","commit_id":"097e67c439ca36821d22de2f7127d87ab36095ad"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"9b19af7dc72d87a0ba8986ea740553308081e86e","unresolved":false,"context_lines":[{"line_number":695,"context_line":"                help\u003d\u0027If passed, use fake network devices and addresses\u0027),"},{"line_number":696,"context_line":"    cfg.IntOpt(\u0027ebtables_exec_attempts\u0027,"},{"line_number":697,"context_line":"               default\u003d3,"},{"line_number":698,"context_line":"               min\u003d0,"},{"line_number":699,"context_line":"               help\u003d\u0027Number of times to retry ebtables commands on failure.\u0027),"},{"line_number":700,"context_line":"    cfg.FloatOpt(\u0027ebtables_retry_interval\u0027,"},{"line_number":701,"context_line":"                 default\u003d1.0,"}],"source_content_type":"text/x-python","patch_set":1,"id":"1aa78d24_0db27194","line":698,"range":{"start_line":698,"start_character":19,"end_line":698,"end_character":20},"in_reply_to":"3aaa91ec_d160b737","updated":"2016-07-05 13:06:02.000000000","message":"+1","commit_id":"097e67c439ca36821d22de2f7127d87ab36095ad"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"561adbdab70a76b12d35c0f78ddea059f275a841","unresolved":false,"context_lines":[{"line_number":630,"context_line":"                help\u003d\u0027If passed, use fake network devices and addresses\u0027),"},{"line_number":631,"context_line":"    cfg.IntOpt(\u0027ebtables_exec_attempts\u0027,"},{"line_number":632,"context_line":"               default\u003d3,"},{"line_number":633,"context_line":"               min\u003d1,"},{"line_number":634,"context_line":"               help\u003d\u0027Number of times to retry ebtables commands on failure.\u0027),"},{"line_number":635,"context_line":"    cfg.FloatOpt(\u0027ebtables_retry_interval\u0027,"},{"line_number":636,"context_line":"                 default\u003d1.0,"}],"source_content_type":"text/x-python","patch_set":2,"id":"dada55a8_54c31157","line":633,"updated":"2016-07-20 17:59:58.000000000","message":"Due to this change, you no longer need to check for values \u003c\u003d 0 in linux_net.py\n\nhttps://github.com/openstack/nova/blob/master/nova/network/linux_net.py#L1663","commit_id":"cd2e8d00f3a08f980bff26e2ebbeeb2564520185"},{"author":{"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},"change_message_id":"4c671f4ec67f1e67f2b3d4aca69e146119a58fc5","unresolved":false,"context_lines":[{"line_number":630,"context_line":"                help\u003d\u0027If passed, use fake network devices and addresses\u0027),"},{"line_number":631,"context_line":"    cfg.IntOpt(\u0027ebtables_exec_attempts\u0027,"},{"line_number":632,"context_line":"               default\u003d3,"},{"line_number":633,"context_line":"               min\u003d1,"},{"line_number":634,"context_line":"               help\u003d\u0027Number of times to retry ebtables commands on failure.\u0027),"},{"line_number":635,"context_line":"    cfg.FloatOpt(\u0027ebtables_retry_interval\u0027,"},{"line_number":636,"context_line":"                 default\u003d1.0,"}],"source_content_type":"text/x-python","patch_set":2,"id":"dada55a8_638e55d1","line":633,"in_reply_to":"dada55a8_54c31157","updated":"2016-07-20 20:07:44.000000000","message":"OK, now I\u0027m confused. In the previous patch you said that this should be 1, and John agreed. Now you are -1ing this for making the exact change you asked for. Just look at: https://review.openstack.org/#/c/335585/1..2/nova/conf/network.py@633\n\nFunctionally, 1 is the minimum, so why not include this here?","commit_id":"cd2e8d00f3a08f980bff26e2ebbeeb2564520185"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"a8090fd2f552880d616b9da2bcede29de4c45929","unresolved":false,"context_lines":[{"line_number":630,"context_line":"                help\u003d\u0027If passed, use fake network devices and addresses\u0027),"},{"line_number":631,"context_line":"    cfg.IntOpt(\u0027ebtables_exec_attempts\u0027,"},{"line_number":632,"context_line":"               default\u003d3,"},{"line_number":633,"context_line":"               min\u003d1,"},{"line_number":634,"context_line":"               help\u003d\u0027Number of times to retry ebtables commands on failure.\u0027),"},{"line_number":635,"context_line":"    cfg.FloatOpt(\u0027ebtables_retry_interval\u0027,"},{"line_number":636,"context_line":"                 default\u003d1.0,"}],"source_content_type":"text/x-python","patch_set":2,"id":"dada55a8_acc67997","line":633,"in_reply_to":"dada55a8_638e55d1","updated":"2016-07-20 21:26:15.000000000","message":"Agreed it should be 1. I\u0027m just saying that you no longer need the code in linux_net.py because it\u0027ll never be lower than 1. It\u0027ll raise a config exception before ever reaching that.","commit_id":"cd2e8d00f3a08f980bff26e2ebbeeb2564520185"},{"author":{"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},"change_message_id":"c86fbc90007db2c16d848eb268ee3d0a8d2113f5","unresolved":false,"context_lines":[{"line_number":630,"context_line":"                help\u003d\u0027If passed, use fake network devices and addresses\u0027),"},{"line_number":631,"context_line":"    cfg.IntOpt(\u0027ebtables_exec_attempts\u0027,"},{"line_number":632,"context_line":"               default\u003d3,"},{"line_number":633,"context_line":"               min\u003d1,"},{"line_number":634,"context_line":"               help\u003d\u0027Number of times to retry ebtables commands on failure.\u0027),"},{"line_number":635,"context_line":"    cfg.FloatOpt(\u0027ebtables_retry_interval\u0027,"},{"line_number":636,"context_line":"                 default\u003d1.0,"}],"source_content_type":"text/x-python","patch_set":2,"id":"dada55a8_126080a4","line":633,"in_reply_to":"dada55a8_acc67997","updated":"2016-07-20 22:22:56.000000000","message":"So is that a reason to block this patch from merging?","commit_id":"cd2e8d00f3a08f980bff26e2ebbeeb2564520185"},{"author":{"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},"change_message_id":"0917e2117b2d7aeb152b13dfd15e830bc093d428","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# needs:fix_opt_description"},{"line_number":2,"context_line":"# needs:check_deprecation_status"},{"line_number":3,"context_line":"# needs:check_opt_group_and_type"},{"line_number":4,"context_line":"# needs:fix_opt_description_indentation"},{"line_number":5,"context_line":"# needs:fix_opt_registration_consistency"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"# Copyright 2016 OpenStack Foundation"}],"source_content_type":"text/x-python","patch_set":3,"id":"bacf61ea_49230f06","line":5,"range":{"start_line":1,"start_character":2,"end_line":5,"end_character":40},"updated":"2016-07-27 20:48:31.000000000","message":"Seems like some of these tags can go away now?","commit_id":"ada42985dd788101663d9fe50868e1ea80318b10"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"e78cb8d5dfc66c0f17bf5ec3a72273bbd7c7723b","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# needs:fix_opt_description"},{"line_number":2,"context_line":"# needs:check_deprecation_status"},{"line_number":3,"context_line":"# needs:check_opt_group_and_type"},{"line_number":4,"context_line":"# needs:fix_opt_description_indentation"},{"line_number":5,"context_line":"# needs:fix_opt_registration_consistency"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"# Copyright 2016 OpenStack Foundation"}],"source_content_type":"text/x-python","patch_set":3,"id":"bacf61ea_32763b3e","line":5,"range":{"start_line":1,"start_character":2,"end_line":5,"end_character":40},"in_reply_to":"bacf61ea_49230f06","updated":"2016-08-01 18:59:57.000000000","message":"I guess not yet to remove tags because some works remain like line 334 which should be removed..","commit_id":"ada42985dd788101663d9fe50868e1ea80318b10"}]}