)]}'
{"nova/conductor/manager.py":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"7f2c923755193da4dc8b6512ce22ffc95c1f5d33","unresolved":false,"context_lines":[{"line_number":100,"context_line":"        # NOTE(hanlind): Only when backporting things, see bug #1596119."},{"line_number":101,"context_line":"        do_backport \u003d (isinstance(result, nova_object.NovaObject) and"},{"line_number":102,"context_line":"                       versionutils.is_compatible(object_versions[objname],"},{"line_number":103,"context_line":"                                                  result.VERSION))"},{"line_number":104,"context_line":"        return (result.obj_to_primitive("},{"line_number":105,"context_line":"            target_version\u003dobject_versions[objname],"},{"line_number":106,"context_line":"            version_manifest\u003dobject_versions)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3aaa91ec_6c01d006","line":103,"updated":"2016-07-01 16:41:30.000000000","message":"This is a tad confusing to a casual reader I think. Couldn\u0027t we make this just be:\n\n do_backport \u003d requested_version \u003c actual_version\n\n?\n\nProbably still need a major version check to make sure we don\u0027t allow sending back a 1.x version when 2.x was requested.","commit_id":"9648cf408e1853177ca26f6b4e1f43e31feaffc6"},{"author":{"_account_id":6450,"name":"Hans Lindgren","email":"hanlind@kth.se","username":"hanlind"},"change_message_id":"8a9bf3e2e7333e46092e34d41fa81db2237def11","unresolved":false,"context_lines":[{"line_number":100,"context_line":"        # NOTE(hanlind): Only when backporting things, see bug #1596119."},{"line_number":101,"context_line":"        do_backport \u003d (isinstance(result, nova_object.NovaObject) and"},{"line_number":102,"context_line":"                       versionutils.is_compatible(object_versions[objname],"},{"line_number":103,"context_line":"                                                  result.VERSION))"},{"line_number":104,"context_line":"        return (result.obj_to_primitive("},{"line_number":105,"context_line":"            target_version\u003dobject_versions[objname],"},{"line_number":106,"context_line":"            version_manifest\u003dobject_versions)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1aa78d24_eaf762f3","line":103,"in_reply_to":"3aaa91ec_6c01d006","updated":"2016-07-02 10:48:56.000000000","message":"Yeah, I hesitated a bit when I wrote this for that same reason. I\u0027ll rewrite to try to make it clearer.","commit_id":"9648cf408e1853177ca26f6b4e1f43e31feaffc6"}]}