)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"add45f28939c1d30be8d629cf14e3a349cd4c6e3","unresolved":false,"context_lines":[{"line_number":21,"context_line":"in policy."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Change-Id: I08dc33367401ec1f98e1795a52d4e981f09a07de"},{"line_number":24,"context_line":"Partially-Implements: bp policy-in-code"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3aaa91ec_c6e4510e","line":24,"updated":"2016-06-30 21:10:40.000000000","message":"Does this also cover this blueprint?\n\nhttps://blueprints.launchpad.net/nova/+spec/discoverable-policy-cli","commit_id":"6acddd68fbcb28f791b461d16a5419b9daa964a6"}],"nova/cmd/manage.py":[{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"9f300c01d165af93899ff1b29f65a05d438ab783","unresolved":false,"context_lines":[{"line_number":234,"context_line":"        \"\"\""},{"line_number":235,"context_line":"        # namespace is the entry_point namespace under oslo.policy.enforcer"},{"line_number":236,"context_line":"        # in setup.cfg."},{"line_number":237,"context_line":"        policy_generator._generate_policy(namespace\u003d\u0027nova\u0027,"},{"line_number":238,"context_line":"                                          output_file\u003doutput_file)"},{"line_number":239,"context_line":""},{"line_number":240,"context_line":"    def redundant(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"1aa78d24_e76710e7","line":237,"updated":"2016-07-06 09:58:26.000000000","message":"if feels bad calling the method, but I see why you are doing that... hmm.","commit_id":"a2e1076c0220f2a197cd446ef43b7850bd8b2230"},{"author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"change_message_id":"bb92877ac1c1835c2a0e0f9b87de33c2a20ee86e","unresolved":false,"context_lines":[{"line_number":234,"context_line":"        \"\"\""},{"line_number":235,"context_line":"        # namespace is the entry_point namespace under oslo.policy.enforcer"},{"line_number":236,"context_line":"        # in setup.cfg."},{"line_number":237,"context_line":"        policy_generator._generate_policy(namespace\u003d\u0027nova\u0027,"},{"line_number":238,"context_line":"                                          output_file\u003doutput_file)"},{"line_number":239,"context_line":""},{"line_number":240,"context_line":"    def redundant(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"1aa78d24_05204f47","line":237,"in_reply_to":"1aa78d24_e76710e7","updated":"2016-07-06 11:49:09.000000000","message":"This is just to get the commands to be in nova-manage. The other way to go about this is to just use the olso policy scripts that are installed now. So rather than \u0027nova-manage policy merged\u0027 we would have \u0027oslopolicy-policy-generator\u0027 and below would be \u0027oslopolicy-list-redundant\u0027.","commit_id":"a2e1076c0220f2a197cd446ef43b7850bd8b2230"}],"nova/conf/policy.py":[{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"f8f95fc95c0e3172ba8de1e8d249efc7be3043e7","unresolved":false,"context_lines":[{"line_number":23,"context_line":"                   \u0027which to look for a policy.Enforcer.\u0027),"},{"line_number":24,"context_line":"        cfg.StrOpt(\u0027output-file\u0027,"},{"line_number":25,"context_line":"                   help\u003d\u0027Path of the file to write to. Defaults to stdout.\u0027),"},{"line_number":26,"context_line":"]"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"def get_enforcer():"}],"source_content_type":"text/x-python","patch_set":5,"id":"dada55a8_b858528b","line":26,"updated":"2016-08-15 10:11:20.000000000","message":"I think we have been putting these in a central location, but in this case, I think here is better, as its local CLI opts.","commit_id":"127e90b38e64fee91ff27ba3d750d0e87c9afba7"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"55ca673ae15225548a8ab4183e4d14f7d2f71922","unresolved":false,"context_lines":[{"line_number":23,"context_line":"                   \u0027which to look for a policy.Enforcer.\u0027),"},{"line_number":24,"context_line":"        cfg.StrOpt(\u0027output-file\u0027,"},{"line_number":25,"context_line":"                   help\u003d\u0027Path of the file to write to. Defaults to stdout.\u0027),"},{"line_number":26,"context_line":"]"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"def get_enforcer():"}],"source_content_type":"text/x-python","patch_set":5,"id":"1ac06dbe_e5e02dfd","line":26,"in_reply_to":"1ac06dbe_253d25bc","updated":"2016-08-24 14:22:30.000000000","message":"we have some CLI opts, but I think most of them were going to stay next to the CMD that used them, I thought.\n\nI can\u0027t think how else to do this though, you are right.","commit_id":"127e90b38e64fee91ff27ba3d750d0e87c9afba7"},{"author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"change_message_id":"2dcebc30d87dcf759b161f76db18ee8018f5de56","unresolved":false,"context_lines":[{"line_number":23,"context_line":"                   \u0027which to look for a policy.Enforcer.\u0027),"},{"line_number":24,"context_line":"        cfg.StrOpt(\u0027output-file\u0027,"},{"line_number":25,"context_line":"                   help\u003d\u0027Path of the file to write to. Defaults to stdout.\u0027),"},{"line_number":26,"context_line":"]"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"def get_enforcer():"}],"source_content_type":"text/x-python","patch_set":5,"id":"1ac06dbe_253d25bc","line":26,"in_reply_to":"dada55a8_b858528b","updated":"2016-08-24 14:17:00.000000000","message":"I thought nova/conf/* was the central location? Where else would these go?","commit_id":"127e90b38e64fee91ff27ba3d750d0e87c9afba7"}],"setup.cfg":[{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"cc0b97d24674d88524cc4ca733a9f1c825d71a41","unresolved":false,"context_lines":[{"line_number":32,"context_line":"    nova.api \u003d nova.common.config:set_middleware_defaults"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"oslo.policy.enforcer \u003d"},{"line_number":35,"context_line":"    nova \u003d nova.conf.policy:get_enforcer"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"oslo.policy.policies \u003d"},{"line_number":38,"context_line":"    # The sample policies will be ordered by entry point and then by list"}],"source_content_type":"text/x-ttcn-cfg","patch_set":6,"id":"1ac06dbe_c2e7e744","line":35,"range":{"start_line":35,"start_character":11,"end_line":35,"end_character":40},"updated":"2016-08-24 14:04:19.000000000","message":"I didn\u0027t find this path in the nova code. When I run the cmd, I got error \"ImportError: No module named policy\"","commit_id":"ffbd608a07d072539a724203d41fedb8304153e9"}],"tox.ini":[{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"f8f95fc95c0e3172ba8de1e8d249efc7be3043e7","unresolved":false,"context_lines":[{"line_number":17,"context_line":"deps \u003d -r{toxinidir}/test-requirements.txt"},{"line_number":18,"context_line":"commands \u003d"},{"line_number":19,"context_line":"  find . -type f -name \"*.pyc\" -delete"},{"line_number":20,"context_line":"  oslopolicy-list-redundant --namespace nova"},{"line_number":21,"context_line":"  bash tools/pretty_tox.sh \u0027{posargs}\u0027"},{"line_number":22,"context_line":"passenv \u003d http_proxy HTTP_PROXY https_proxy HTTPS_PROXY no_proxy NO_PROXY OS_DEBUG"},{"line_number":23,"context_line":"# there is also secret magic in pretty_tox.sh which lets you run in a fail only"}],"source_content_type":"text/x-properties","patch_set":5,"id":"3ac371cc_96f99fcb","line":20,"updated":"2016-08-15 10:11:20.000000000","message":"It feels a better fit for pep8 maybe?\n\nprobably worth a comment about why its here.\n\nSeems to be failing as it can\u0027t find the policy.json file:\n\n  \"oslo_config.cfg.ConfigFilesNotFoundError: Failed to find some config files: policy.json\"","commit_id":"127e90b38e64fee91ff27ba3d750d0e87c9afba7"}]}
