)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"e18d4fbfdc75973761fcf2d1702bba69d2957319","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"If an instance is booted from a volume, shelved, and goes into an error"},{"line_number":10,"context_line":"state due to some reason, the volume from which instance is booted"},{"line_number":11,"context_line":"remains even the instance is deleted because instance has no host"},{"line_number":12,"context_line":"associated with it."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Called _local_delete() to detach volume and destroy bdm if instance is"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1aa78d24_d610c85b","line":11,"range":{"start_line":11,"start_character":8,"end_line":11,"end_character":16},"updated":"2016-07-06 09:17:19.000000000","message":"Nit: even when the","commit_id":"5ce74fa06c0e7a70fdc927b2c1f364af83f7de1d"}],"nova/compute/api.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"f5b2515d313577fd494eafa0b88c5e9ec6f4e53c","unresolved":false,"context_lines":[{"line_number":1672,"context_line":"                    quotas.rollback()"},{"line_number":1673,"context_line":""},{"line_number":1674,"context_line":"    def _expect_no_host(self, instance):"},{"line_number":1675,"context_line":"        # NOTE(melwitt): Instances in ERROR state have their host and node"},{"line_number":1676,"context_line":"        # set to None as part of exception handling."},{"line_number":1677,"context_line":"        if instance.vm_state in (vm_states.SHELVED_OFFLOADED, vm_states.ERROR):"},{"line_number":1678,"context_line":"            return True"}],"source_content_type":"text/x-python","patch_set":2,"id":"1aa78d24_5a2be994","line":1675,"updated":"2016-07-07 23:16:07.000000000","message":"Not for this test:\n\nhttp://git.openstack.org/cgit/openstack/tempest/tree/tempest/api/compute/servers/test_delete_server.py#n141\n\nSo this is a bad assumption.","commit_id":"5ce74fa06c0e7a70fdc927b2c1f364af83f7de1d"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"6bfeeacb448806b102d2e5fc7c35dbf802224a68","unresolved":false,"context_lines":[{"line_number":1672,"context_line":"                    quotas.rollback()"},{"line_number":1673,"context_line":""},{"line_number":1674,"context_line":"    def _expect_no_host(self, instance):"},{"line_number":1675,"context_line":"        # NOTE(melwitt): Instances in ERROR state have their host and node"},{"line_number":1676,"context_line":"        # set to None as part of exception handling."},{"line_number":1677,"context_line":"        if instance.vm_state in (vm_states.SHELVED_OFFLOADED, vm_states.ERROR):"},{"line_number":1678,"context_line":"            return True"}],"source_content_type":"text/x-python","patch_set":2,"id":"1aa78d24_65c44a5f","line":1675,"in_reply_to":"1aa78d24_5a2be994","updated":"2016-07-07 23:35:01.000000000","message":"Yep ... sigh","commit_id":"5ce74fa06c0e7a70fdc927b2c1f364af83f7de1d"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"e18d4fbfdc75973761fcf2d1702bba69d2957319","unresolved":false,"context_lines":[{"line_number":1790,"context_line":"                    if bdm.delete_on_termination:"},{"line_number":1791,"context_line":"                        self.volume_api.delete(context, bdm.volume_id)"},{"line_number":1792,"context_line":"                except Exception as exc:"},{"line_number":1793,"context_line":"                    err_str \u003d _LW(\"Ignoring volume cleanup failure due to %s\")"},{"line_number":1794,"context_line":"                    LOG.warn(err_str % exc, instance\u003dinstance)"},{"line_number":1795,"context_line":"            bdm.destroy()"},{"line_number":1796,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1aa78d24_c10da4e9","line":1793,"range":{"start_line":1793,"start_character":44,"end_line":1793,"end_character":50},"updated":"2016-07-06 09:17:19.000000000","message":"Nit: maybe BDM clean up?","commit_id":"5ce74fa06c0e7a70fdc927b2c1f364af83f7de1d"}]}