)]}'
{"nova/tests/unit/virt/libvirt/test_imagebackend.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"8a99e11e9ee888cf52a0fba639ba212704db682f","unresolved":false,"context_lines":[{"line_number":690,"context_line":""},{"line_number":691,"context_line":"    def _create_image(self, sparse):"},{"line_number":692,"context_line":"        with test.nested("},{"line_number":693,"context_line":"            mock.patch.object(self.disk, \u0027resize2fs\u0027),"},{"line_number":694,"context_line":"            mock.patch.object(self.lvm, \u0027create_volume\u0027),"},{"line_number":695,"context_line":"            mock.patch.object(self.disk, \u0027get_disk_size\u0027),"},{"line_number":696,"context_line":"            mock.patch.object(self.utils, \u0027execute\u0027)"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a77a97e_2f358ef6","line":693,"range":{"start_line":693,"start_character":42,"end_line":693,"end_character":51},"updated":"2016-11-16 08:23:59.000000000","message":"do we need this to mock here ?","commit_id":"b3eda27883df0bf42f48738abc173f22297549d0"},{"author":{"_account_id":19741,"name":"Hieu LE","email":"hieulq2@viettel.com.vn","username":"hieulq"},"change_message_id":"ee1811f6f70586f59e2588614956ac6f89fa4ae9","unresolved":false,"context_lines":[{"line_number":690,"context_line":""},{"line_number":691,"context_line":"    def _create_image(self, sparse):"},{"line_number":692,"context_line":"        with test.nested("},{"line_number":693,"context_line":"            mock.patch.object(self.disk, \u0027resize2fs\u0027),"},{"line_number":694,"context_line":"            mock.patch.object(self.lvm, \u0027create_volume\u0027),"},{"line_number":695,"context_line":"            mock.patch.object(self.disk, \u0027get_disk_size\u0027),"},{"line_number":696,"context_line":"            mock.patch.object(self.utils, \u0027execute\u0027)"}],"source_content_type":"text/x-python","patch_set":6,"id":"5a74a57a_c3cf707d","line":693,"range":{"start_line":693,"start_character":42,"end_line":693,"end_character":51},"in_reply_to":"5a74a57a_2efaedbd","updated":"2016-11-25 09:43:21.000000000","message":"Done, sorry for the copy-paste-monkey.","commit_id":"b3eda27883df0bf42f48738abc173f22297549d0"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"d31dcbd16cc4b0650b0be1a3c5ce3e6f6bc89093","unresolved":false,"context_lines":[{"line_number":690,"context_line":""},{"line_number":691,"context_line":"    def _create_image(self, sparse):"},{"line_number":692,"context_line":"        with test.nested("},{"line_number":693,"context_line":"            mock.patch.object(self.disk, \u0027resize2fs\u0027),"},{"line_number":694,"context_line":"            mock.patch.object(self.lvm, \u0027create_volume\u0027),"},{"line_number":695,"context_line":"            mock.patch.object(self.disk, \u0027get_disk_size\u0027),"},{"line_number":696,"context_line":"            mock.patch.object(self.utils, \u0027execute\u0027)"}],"source_content_type":"text/x-python","patch_set":6,"id":"5a74a57a_2efaedbd","line":693,"range":{"start_line":693,"start_character":42,"end_line":693,"end_character":51},"in_reply_to":"7a77a97e_2f358ef6","updated":"2016-11-24 11:18:20.000000000","message":"This directly mirrors prepare mocks, I am not against that, but if we can trim the list, thats no bad thing.","commit_id":"b3eda27883df0bf42f48738abc173f22297549d0"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"d31dcbd16cc4b0650b0be1a3c5ce3e6f6bc89093","unresolved":false,"context_lines":[{"line_number":697,"context_line":"        ) as (mock_resize, mock_create, mock_get, mock_execute):"},{"line_number":698,"context_line":"            mock_get.return_value \u003d self.TEMPLATE_SIZE"},{"line_number":699,"context_line":"            fn \u003d mock.MagicMock()"},{"line_number":700,"context_line":"            fn(target\u003dself.TEMPLATE_PATH)"},{"line_number":701,"context_line":"            cmd \u003d (\u0027qemu-img\u0027, \u0027convert\u0027, \u0027-O\u0027, \u0027raw\u0027, self.TEMPLATE_PATH,"},{"line_number":702,"context_line":"                   self.PATH)"},{"line_number":703,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"5a74a57a_4e1c8913","line":700,"updated":"2016-11-24 11:18:20.000000000","message":"As per previous patch I don\u0027t believe this is doing what it used to do, validate what is called on fn. you need an fn.assert_called_once_with(...) adding instead.","commit_id":"b3eda27883df0bf42f48738abc173f22297549d0"},{"author":{"_account_id":19741,"name":"Hieu LE","email":"hieulq2@viettel.com.vn","username":"hieulq"},"change_message_id":"ee1811f6f70586f59e2588614956ac6f89fa4ae9","unresolved":false,"context_lines":[{"line_number":697,"context_line":"        ) as (mock_resize, mock_create, mock_get, mock_execute):"},{"line_number":698,"context_line":"            mock_get.return_value \u003d self.TEMPLATE_SIZE"},{"line_number":699,"context_line":"            fn \u003d mock.MagicMock()"},{"line_number":700,"context_line":"            fn(target\u003dself.TEMPLATE_PATH)"},{"line_number":701,"context_line":"            cmd \u003d (\u0027qemu-img\u0027, \u0027convert\u0027, \u0027-O\u0027, \u0027raw\u0027, self.TEMPLATE_PATH,"},{"line_number":702,"context_line":"                   self.PATH)"},{"line_number":703,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"5a74a57a_63a5bcb3","line":700,"in_reply_to":"5a74a57a_4e1c8913","updated":"2016-11-25 09:43:21.000000000","message":"Done","commit_id":"b3eda27883df0bf42f48738abc173f22297549d0"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"8a99e11e9ee888cf52a0fba639ba212704db682f","unresolved":false,"context_lines":[{"line_number":713,"context_line":""},{"line_number":714,"context_line":"    def _create_image_generated(self, sparse):"},{"line_number":715,"context_line":"        with test.nested("},{"line_number":716,"context_line":"                mock.patch.object(self.disk, \u0027resize2fs\u0027),"},{"line_number":717,"context_line":"                mock.patch.object(self.lvm, \u0027create_volume\u0027),"},{"line_number":718,"context_line":"                mock.patch.object(self.disk, \u0027get_disk_size\u0027),"},{"line_number":719,"context_line":"                mock.patch.object(self.utils, \u0027execute\u0027)"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a77a97e_6f3f86d6","line":716,"range":{"start_line":716,"start_character":46,"end_line":716,"end_character":55},"updated":"2016-11-16 08:23:59.000000000","message":"here too","commit_id":"b3eda27883df0bf42f48738abc173f22297549d0"},{"author":{"_account_id":19741,"name":"Hieu LE","email":"hieulq2@viettel.com.vn","username":"hieulq"},"change_message_id":"ee1811f6f70586f59e2588614956ac6f89fa4ae9","unresolved":false,"context_lines":[{"line_number":713,"context_line":""},{"line_number":714,"context_line":"    def _create_image_generated(self, sparse):"},{"line_number":715,"context_line":"        with test.nested("},{"line_number":716,"context_line":"                mock.patch.object(self.disk, \u0027resize2fs\u0027),"},{"line_number":717,"context_line":"                mock.patch.object(self.lvm, \u0027create_volume\u0027),"},{"line_number":718,"context_line":"                mock.patch.object(self.disk, \u0027get_disk_size\u0027),"},{"line_number":719,"context_line":"                mock.patch.object(self.utils, \u0027execute\u0027)"}],"source_content_type":"text/x-python","patch_set":6,"id":"5a74a57a_c37db01d","line":716,"range":{"start_line":716,"start_character":46,"end_line":716,"end_character":55},"in_reply_to":"7a77a97e_6f3f86d6","updated":"2016-11-25 09:43:21.000000000","message":"Done","commit_id":"b3eda27883df0bf42f48738abc173f22297549d0"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"8a99e11e9ee888cf52a0fba639ba212704db682f","unresolved":false,"context_lines":[{"line_number":715,"context_line":"        with test.nested("},{"line_number":716,"context_line":"                mock.patch.object(self.disk, \u0027resize2fs\u0027),"},{"line_number":717,"context_line":"                mock.patch.object(self.lvm, \u0027create_volume\u0027),"},{"line_number":718,"context_line":"                mock.patch.object(self.disk, \u0027get_disk_size\u0027),"},{"line_number":719,"context_line":"                mock.patch.object(self.utils, \u0027execute\u0027)"},{"line_number":720,"context_line":"        ) as (mock_resize, mock_create, mock_get, mock_execute):"},{"line_number":721,"context_line":"            fn \u003d mock.MagicMock()"},{"line_number":722,"context_line":"            fn(target\u003dself.PATH, ephemeral_size\u003dNone)"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a77a97e_6f486688","line":719,"range":{"start_line":718,"start_character":45,"end_line":719,"end_character":56},"updated":"2016-11-16 08:23:59.000000000","message":"dito","commit_id":"b3eda27883df0bf42f48738abc173f22297549d0"},{"author":{"_account_id":19741,"name":"Hieu LE","email":"hieulq2@viettel.com.vn","username":"hieulq"},"change_message_id":"ee1811f6f70586f59e2588614956ac6f89fa4ae9","unresolved":false,"context_lines":[{"line_number":715,"context_line":"        with test.nested("},{"line_number":716,"context_line":"                mock.patch.object(self.disk, \u0027resize2fs\u0027),"},{"line_number":717,"context_line":"                mock.patch.object(self.lvm, \u0027create_volume\u0027),"},{"line_number":718,"context_line":"                mock.patch.object(self.disk, \u0027get_disk_size\u0027),"},{"line_number":719,"context_line":"                mock.patch.object(self.utils, \u0027execute\u0027)"},{"line_number":720,"context_line":"        ) as (mock_resize, mock_create, mock_get, mock_execute):"},{"line_number":721,"context_line":"            fn \u003d mock.MagicMock()"},{"line_number":722,"context_line":"            fn(target\u003dself.PATH, ephemeral_size\u003dNone)"}],"source_content_type":"text/x-python","patch_set":6,"id":"5a74a57a_e378ec2d","line":719,"range":{"start_line":718,"start_character":45,"end_line":719,"end_character":56},"in_reply_to":"7a77a97e_6f486688","updated":"2016-11-25 09:43:21.000000000","message":"Done","commit_id":"b3eda27883df0bf42f48738abc173f22297549d0"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"d31dcbd16cc4b0650b0be1a3c5ce3e6f6bc89093","unresolved":false,"context_lines":[{"line_number":719,"context_line":"                mock.patch.object(self.utils, \u0027execute\u0027)"},{"line_number":720,"context_line":"        ) as (mock_resize, mock_create, mock_get, mock_execute):"},{"line_number":721,"context_line":"            fn \u003d mock.MagicMock()"},{"line_number":722,"context_line":"            fn(target\u003dself.PATH, ephemeral_size\u003dNone)"},{"line_number":723,"context_line":"            image \u003d self.image_class(self.INSTANCE, self.NAME)"},{"line_number":724,"context_line":""},{"line_number":725,"context_line":"            image.create_image(fn, self.TEMPLATE_PATH,"}],"source_content_type":"text/x-python","patch_set":6,"id":"5a74a57a_ced6d926","line":722,"updated":"2016-11-24 11:18:20.000000000","message":"as above, etc...","commit_id":"b3eda27883df0bf42f48738abc173f22297549d0"},{"author":{"_account_id":19741,"name":"Hieu LE","email":"hieulq2@viettel.com.vn","username":"hieulq"},"change_message_id":"ee1811f6f70586f59e2588614956ac6f89fa4ae9","unresolved":false,"context_lines":[{"line_number":719,"context_line":"                mock.patch.object(self.utils, \u0027execute\u0027)"},{"line_number":720,"context_line":"        ) as (mock_resize, mock_create, mock_get, mock_execute):"},{"line_number":721,"context_line":"            fn \u003d mock.MagicMock()"},{"line_number":722,"context_line":"            fn(target\u003dself.PATH, ephemeral_size\u003dNone)"},{"line_number":723,"context_line":"            image \u003d self.image_class(self.INSTANCE, self.NAME)"},{"line_number":724,"context_line":""},{"line_number":725,"context_line":"            image.create_image(fn, self.TEMPLATE_PATH,"}],"source_content_type":"text/x-python","patch_set":6,"id":"5a74a57a_03788829","line":722,"in_reply_to":"5a74a57a_ced6d926","updated":"2016-11-25 09:43:21.000000000","message":"Done","commit_id":"b3eda27883df0bf42f48738abc173f22297549d0"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"8a99e11e9ee888cf52a0fba639ba212704db682f","unresolved":false,"context_lines":[{"line_number":818,"context_line":""},{"line_number":819,"context_line":"    def test_create_image_negative(self):"},{"line_number":820,"context_line":"        with test.nested("},{"line_number":821,"context_line":"                mock.patch.object(self.disk, \u0027resize2fs\u0027),"},{"line_number":822,"context_line":"                mock.patch.object(self.lvm, \u0027create_volume\u0027),"},{"line_number":823,"context_line":"                mock.patch.object(self.disk, \u0027get_disk_size\u0027),"},{"line_number":824,"context_line":"                mock.patch.object(self.utils, \u0027execute\u0027),"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a77a97e_caba4823","line":821,"range":{"start_line":821,"start_character":46,"end_line":821,"end_character":55},"updated":"2016-11-16 08:23:59.000000000","message":"we do not need to mock this.","commit_id":"b3eda27883df0bf42f48738abc173f22297549d0"},{"author":{"_account_id":19741,"name":"Hieu LE","email":"hieulq2@viettel.com.vn","username":"hieulq"},"change_message_id":"ee1811f6f70586f59e2588614956ac6f89fa4ae9","unresolved":false,"context_lines":[{"line_number":818,"context_line":""},{"line_number":819,"context_line":"    def test_create_image_negative(self):"},{"line_number":820,"context_line":"        with test.nested("},{"line_number":821,"context_line":"                mock.patch.object(self.disk, \u0027resize2fs\u0027),"},{"line_number":822,"context_line":"                mock.patch.object(self.lvm, \u0027create_volume\u0027),"},{"line_number":823,"context_line":"                mock.patch.object(self.disk, \u0027get_disk_size\u0027),"},{"line_number":824,"context_line":"                mock.patch.object(self.utils, \u0027execute\u0027),"}],"source_content_type":"text/x-python","patch_set":6,"id":"5a74a57a_4390c043","line":821,"range":{"start_line":821,"start_character":46,"end_line":821,"end_character":55},"in_reply_to":"7a77a97e_caba4823","updated":"2016-11-25 09:43:21.000000000","message":"Done","commit_id":"b3eda27883df0bf42f48738abc173f22297549d0"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"8a99e11e9ee888cf52a0fba639ba212704db682f","unresolved":false,"context_lines":[{"line_number":821,"context_line":"                mock.patch.object(self.disk, \u0027resize2fs\u0027),"},{"line_number":822,"context_line":"                mock.patch.object(self.lvm, \u0027create_volume\u0027),"},{"line_number":823,"context_line":"                mock.patch.object(self.disk, \u0027get_disk_size\u0027),"},{"line_number":824,"context_line":"                mock.patch.object(self.utils, \u0027execute\u0027),"},{"line_number":825,"context_line":"                mock.patch.object(self.lvm, \u0027remove_volumes\u0027),"},{"line_number":826,"context_line":"        ) as (mock_resize, mock_create, mock_get, mock_execute, mock_remove):"},{"line_number":827,"context_line":"            mock_create.side_effect \u003d RuntimeError"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a77a97e_eab54431","line":824,"range":{"start_line":824,"start_character":47,"end_line":824,"end_character":54},"updated":"2016-11-16 08:23:59.000000000","message":"this too","commit_id":"b3eda27883df0bf42f48738abc173f22297549d0"},{"author":{"_account_id":19741,"name":"Hieu LE","email":"hieulq2@viettel.com.vn","username":"hieulq"},"change_message_id":"ee1811f6f70586f59e2588614956ac6f89fa4ae9","unresolved":false,"context_lines":[{"line_number":821,"context_line":"                mock.patch.object(self.disk, \u0027resize2fs\u0027),"},{"line_number":822,"context_line":"                mock.patch.object(self.lvm, \u0027create_volume\u0027),"},{"line_number":823,"context_line":"                mock.patch.object(self.disk, \u0027get_disk_size\u0027),"},{"line_number":824,"context_line":"                mock.patch.object(self.utils, \u0027execute\u0027),"},{"line_number":825,"context_line":"                mock.patch.object(self.lvm, \u0027remove_volumes\u0027),"},{"line_number":826,"context_line":"        ) as (mock_resize, mock_create, mock_get, mock_execute, mock_remove):"},{"line_number":827,"context_line":"            mock_create.side_effect \u003d RuntimeError"}],"source_content_type":"text/x-python","patch_set":6,"id":"5a74a57a_6393fc4f","line":824,"range":{"start_line":824,"start_character":47,"end_line":824,"end_character":54},"in_reply_to":"7a77a97e_eab54431","updated":"2016-11-25 09:43:21.000000000","message":"Done","commit_id":"b3eda27883df0bf42f48738abc173f22297549d0"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"d31dcbd16cc4b0650b0be1a3c5ce3e6f6bc89093","unresolved":false,"context_lines":[{"line_number":827,"context_line":"            mock_create.side_effect \u003d RuntimeError"},{"line_number":828,"context_line":"            mock_get.return_value \u003d self.TEMPLATE_SIZE"},{"line_number":829,"context_line":"            fn \u003d mock.MagicMock()"},{"line_number":830,"context_line":"            fn(target\u003dself.TEMPLATE_PATH)"},{"line_number":831,"context_line":"            image \u003d self.image_class(self.INSTANCE, self.NAME)"},{"line_number":832,"context_line":""},{"line_number":833,"context_line":"            self.assertRaises(RuntimeError, image.create_image, fn,"}],"source_content_type":"text/x-python","patch_set":6,"id":"5a74a57a_aeb6fdd9","line":830,"updated":"2016-11-24 11:18:20.000000000","message":"as above.","commit_id":"b3eda27883df0bf42f48738abc173f22297549d0"},{"author":{"_account_id":19741,"name":"Hieu LE","email":"hieulq2@viettel.com.vn","username":"hieulq"},"change_message_id":"ee1811f6f70586f59e2588614956ac6f89fa4ae9","unresolved":false,"context_lines":[{"line_number":827,"context_line":"            mock_create.side_effect \u003d RuntimeError"},{"line_number":828,"context_line":"            mock_get.return_value \u003d self.TEMPLATE_SIZE"},{"line_number":829,"context_line":"            fn \u003d mock.MagicMock()"},{"line_number":830,"context_line":"            fn(target\u003dself.TEMPLATE_PATH)"},{"line_number":831,"context_line":"            image \u003d self.image_class(self.INSTANCE, self.NAME)"},{"line_number":832,"context_line":""},{"line_number":833,"context_line":"            self.assertRaises(RuntimeError, image.create_image, fn,"}],"source_content_type":"text/x-python","patch_set":6,"id":"5a74a57a_a39d145b","line":830,"in_reply_to":"5a74a57a_aeb6fdd9","updated":"2016-11-25 09:43:21.000000000","message":"Done","commit_id":"b3eda27883df0bf42f48738abc173f22297549d0"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"8a99e11e9ee888cf52a0fba639ba212704db682f","unresolved":false,"context_lines":[{"line_number":839,"context_line":""},{"line_number":840,"context_line":"    def test_create_image_generated_negative(self):"},{"line_number":841,"context_line":"        with test.nested("},{"line_number":842,"context_line":"                mock.patch.object(self.disk, \u0027resize2fs\u0027),"},{"line_number":843,"context_line":"                mock.patch.object(self.lvm, \u0027create_volume\u0027),"},{"line_number":844,"context_line":"                mock.patch.object(self.disk, \u0027get_disk_size\u0027),"},{"line_number":845,"context_line":"                mock.patch.object(self.utils, \u0027execute\u0027),"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a77a97e_4a7d586d","line":842,"range":{"start_line":842,"start_character":46,"end_line":842,"end_character":55},"updated":"2016-11-16 08:23:59.000000000","message":"ditto","commit_id":"b3eda27883df0bf42f48738abc173f22297549d0"},{"author":{"_account_id":19741,"name":"Hieu LE","email":"hieulq2@viettel.com.vn","username":"hieulq"},"change_message_id":"ee1811f6f70586f59e2588614956ac6f89fa4ae9","unresolved":false,"context_lines":[{"line_number":839,"context_line":""},{"line_number":840,"context_line":"    def test_create_image_generated_negative(self):"},{"line_number":841,"context_line":"        with test.nested("},{"line_number":842,"context_line":"                mock.patch.object(self.disk, \u0027resize2fs\u0027),"},{"line_number":843,"context_line":"                mock.patch.object(self.lvm, \u0027create_volume\u0027),"},{"line_number":844,"context_line":"                mock.patch.object(self.disk, \u0027get_disk_size\u0027),"},{"line_number":845,"context_line":"                mock.patch.object(self.utils, \u0027execute\u0027),"}],"source_content_type":"text/x-python","patch_set":6,"id":"5a74a57a_c3cbf051","line":842,"range":{"start_line":842,"start_character":46,"end_line":842,"end_character":55},"in_reply_to":"7a77a97e_4a7d586d","updated":"2016-11-25 09:43:21.000000000","message":"Done","commit_id":"b3eda27883df0bf42f48738abc173f22297549d0"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"8a99e11e9ee888cf52a0fba639ba212704db682f","unresolved":false,"context_lines":[{"line_number":841,"context_line":"        with test.nested("},{"line_number":842,"context_line":"                mock.patch.object(self.disk, \u0027resize2fs\u0027),"},{"line_number":843,"context_line":"                mock.patch.object(self.lvm, \u0027create_volume\u0027),"},{"line_number":844,"context_line":"                mock.patch.object(self.disk, \u0027get_disk_size\u0027),"},{"line_number":845,"context_line":"                mock.patch.object(self.utils, \u0027execute\u0027),"},{"line_number":846,"context_line":"                mock.patch.object(self.lvm, \u0027remove_volumes\u0027),"},{"line_number":847,"context_line":"        ) as (mock_resize, mock_create, mock_get, mock_execute, mock_remove):"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a77a97e_8a97708f","line":844,"range":{"start_line":844,"start_character":46,"end_line":844,"end_character":59},"updated":"2016-11-16 08:23:59.000000000","message":"ditto","commit_id":"b3eda27883df0bf42f48738abc173f22297549d0"},{"author":{"_account_id":19741,"name":"Hieu LE","email":"hieulq2@viettel.com.vn","username":"hieulq"},"change_message_id":"ee1811f6f70586f59e2588614956ac6f89fa4ae9","unresolved":false,"context_lines":[{"line_number":841,"context_line":"        with test.nested("},{"line_number":842,"context_line":"                mock.patch.object(self.disk, \u0027resize2fs\u0027),"},{"line_number":843,"context_line":"                mock.patch.object(self.lvm, \u0027create_volume\u0027),"},{"line_number":844,"context_line":"                mock.patch.object(self.disk, \u0027get_disk_size\u0027),"},{"line_number":845,"context_line":"                mock.patch.object(self.utils, \u0027execute\u0027),"},{"line_number":846,"context_line":"                mock.patch.object(self.lvm, \u0027remove_volumes\u0027),"},{"line_number":847,"context_line":"        ) as (mock_resize, mock_create, mock_get, mock_execute, mock_remove):"}],"source_content_type":"text/x-python","patch_set":6,"id":"5a74a57a_e3c62c48","line":844,"range":{"start_line":844,"start_character":46,"end_line":844,"end_character":59},"in_reply_to":"7a77a97e_8a97708f","updated":"2016-11-25 09:43:21.000000000","message":"Done","commit_id":"b3eda27883df0bf42f48738abc173f22297549d0"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"8a99e11e9ee888cf52a0fba639ba212704db682f","unresolved":false,"context_lines":[{"line_number":842,"context_line":"                mock.patch.object(self.disk, \u0027resize2fs\u0027),"},{"line_number":843,"context_line":"                mock.patch.object(self.lvm, \u0027create_volume\u0027),"},{"line_number":844,"context_line":"                mock.patch.object(self.disk, \u0027get_disk_size\u0027),"},{"line_number":845,"context_line":"                mock.patch.object(self.utils, \u0027execute\u0027),"},{"line_number":846,"context_line":"                mock.patch.object(self.lvm, \u0027remove_volumes\u0027),"},{"line_number":847,"context_line":"        ) as (mock_resize, mock_create, mock_get, mock_execute, mock_remove):"},{"line_number":848,"context_line":"            fn \u003d mock.MagicMock()"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a77a97e_aa926c9d","line":845,"range":{"start_line":845,"start_character":47,"end_line":845,"end_character":54},"updated":"2016-11-16 08:23:59.000000000","message":"ditto","commit_id":"b3eda27883df0bf42f48738abc173f22297549d0"},{"author":{"_account_id":19741,"name":"Hieu LE","email":"hieulq2@viettel.com.vn","username":"hieulq"},"change_message_id":"ee1811f6f70586f59e2588614956ac6f89fa4ae9","unresolved":false,"context_lines":[{"line_number":842,"context_line":"                mock.patch.object(self.disk, \u0027resize2fs\u0027),"},{"line_number":843,"context_line":"                mock.patch.object(self.lvm, \u0027create_volume\u0027),"},{"line_number":844,"context_line":"                mock.patch.object(self.disk, \u0027get_disk_size\u0027),"},{"line_number":845,"context_line":"                mock.patch.object(self.utils, \u0027execute\u0027),"},{"line_number":846,"context_line":"                mock.patch.object(self.lvm, \u0027remove_volumes\u0027),"},{"line_number":847,"context_line":"        ) as (mock_resize, mock_create, mock_get, mock_execute, mock_remove):"},{"line_number":848,"context_line":"            fn \u003d mock.MagicMock()"}],"source_content_type":"text/x-python","patch_set":6,"id":"5a74a57a_03c6c847","line":845,"range":{"start_line":845,"start_character":47,"end_line":845,"end_character":54},"in_reply_to":"7a77a97e_aa926c9d","updated":"2016-11-25 09:43:21.000000000","message":"Done","commit_id":"b3eda27883df0bf42f48738abc173f22297549d0"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"d31dcbd16cc4b0650b0be1a3c5ce3e6f6bc89093","unresolved":false,"context_lines":[{"line_number":847,"context_line":"        ) as (mock_resize, mock_create, mock_get, mock_execute, mock_remove):"},{"line_number":848,"context_line":"            fn \u003d mock.MagicMock()"},{"line_number":849,"context_line":"            fn(target\u003dself.PATH, ephemeral_size\u003dNone)"},{"line_number":850,"context_line":"            fn.side_effect \u003d RuntimeError"},{"line_number":851,"context_line":"            image \u003d self.image_class(self.INSTANCE, self.NAME)"},{"line_number":852,"context_line":""},{"line_number":853,"context_line":"            self.assertRaises(RuntimeError, image.create_image, fn,"}],"source_content_type":"text/x-python","patch_set":6,"id":"5a74a57a_2ea4ada4","line":850,"updated":"2016-11-24 11:18:20.000000000","message":"This one seems just fine, but its a shame we are not asserting what is called any more.","commit_id":"b3eda27883df0bf42f48738abc173f22297549d0"},{"author":{"_account_id":19741,"name":"Hieu LE","email":"hieulq2@viettel.com.vn","username":"hieulq"},"change_message_id":"ee1811f6f70586f59e2588614956ac6f89fa4ae9","unresolved":false,"context_lines":[{"line_number":847,"context_line":"        ) as (mock_resize, mock_create, mock_get, mock_execute, mock_remove):"},{"line_number":848,"context_line":"            fn \u003d mock.MagicMock()"},{"line_number":849,"context_line":"            fn(target\u003dself.PATH, ephemeral_size\u003dNone)"},{"line_number":850,"context_line":"            fn.side_effect \u003d RuntimeError"},{"line_number":851,"context_line":"            image \u003d self.image_class(self.INSTANCE, self.NAME)"},{"line_number":852,"context_line":""},{"line_number":853,"context_line":"            self.assertRaises(RuntimeError, image.create_image, fn,"}],"source_content_type":"text/x-python","patch_set":6,"id":"5a74a57a_e3f46c88","line":850,"in_reply_to":"5a74a57a_2ea4ada4","updated":"2016-11-25 09:43:21.000000000","message":"Done","commit_id":"b3eda27883df0bf42f48738abc173f22297549d0"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"7466e3794ba3b32c4523fe0476c530274576a014","unresolved":false,"context_lines":[{"line_number":112,"context_line":"        def fake_fetch(target, *args, **kwargs):"},{"line_number":113,"context_line":"            return"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"        with mock.patch.object(image, \u0027get_disk_size\u0027, lambda _: self.SIZE):"},{"line_number":116,"context_line":"            self.stub_out(\u0027os.path.exists\u0027, lambda _: True)"},{"line_number":117,"context_line":"            self.stub_out(\u0027os.access\u0027, lambda p, w: True)"},{"line_number":118,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"ba5201f7_adb0cfde","line":115,"range":{"start_line":115,"start_character":55,"end_line":115,"end_character":74},"updated":"2017-01-02 20:58:01.000000000","message":"Could we use return_value\u003dself.SIZE instead here?","commit_id":"6ba487edf6b6f53b3b443adae3c04e4fd4da7726"},{"author":{"_account_id":19741,"name":"Hieu LE","email":"hieulq2@viettel.com.vn","username":"hieulq"},"change_message_id":"a33e6945f0b96dd138cfa4ea0e762ea85d9950a8","unresolved":false,"context_lines":[{"line_number":112,"context_line":"        def fake_fetch(target, *args, **kwargs):"},{"line_number":113,"context_line":"            return"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"        with mock.patch.object(image, \u0027get_disk_size\u0027, lambda _: self.SIZE):"},{"line_number":116,"context_line":"            self.stub_out(\u0027os.path.exists\u0027, lambda _: True)"},{"line_number":117,"context_line":"            self.stub_out(\u0027os.access\u0027, lambda p, w: True)"},{"line_number":118,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"ba5201f7_13ad78e9","line":115,"range":{"start_line":115,"start_character":55,"end_line":115,"end_character":74},"in_reply_to":"ba5201f7_adb0cfde","updated":"2017-01-03 01:36:56.000000000","message":"Done","commit_id":"6ba487edf6b6f53b3b443adae3c04e4fd4da7726"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"7466e3794ba3b32c4523fe0476c530274576a014","unresolved":false,"context_lines":[{"line_number":113,"context_line":"            return"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"        with mock.patch.object(image, \u0027get_disk_size\u0027, lambda _: self.SIZE):"},{"line_number":116,"context_line":"            self.stub_out(\u0027os.path.exists\u0027, lambda _: True)"},{"line_number":117,"context_line":"            self.stub_out(\u0027os.access\u0027, lambda p, w: True)"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"            # Call twice to verify testing fallocate is only called once."},{"line_number":120,"context_line":"            image.cache(fake_fetch, self.TEMPLATE_PATH, self.SIZE)"}],"source_content_type":"text/x-python","patch_set":8,"id":"ba5201f7_cdb513ce","line":117,"range":{"start_line":116,"start_character":0,"end_line":117,"end_character":57},"updated":"2017-01-02 20:58:01.000000000","message":"Can we move this outside of the context manager?","commit_id":"6ba487edf6b6f53b3b443adae3c04e4fd4da7726"},{"author":{"_account_id":19741,"name":"Hieu LE","email":"hieulq2@viettel.com.vn","username":"hieulq"},"change_message_id":"a33e6945f0b96dd138cfa4ea0e762ea85d9950a8","unresolved":false,"context_lines":[{"line_number":113,"context_line":"            return"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"        with mock.patch.object(image, \u0027get_disk_size\u0027, lambda _: self.SIZE):"},{"line_number":116,"context_line":"            self.stub_out(\u0027os.path.exists\u0027, lambda _: True)"},{"line_number":117,"context_line":"            self.stub_out(\u0027os.access\u0027, lambda p, w: True)"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"            # Call twice to verify testing fallocate is only called once."},{"line_number":120,"context_line":"            image.cache(fake_fetch, self.TEMPLATE_PATH, self.SIZE)"}],"source_content_type":"text/x-python","patch_set":8,"id":"ba5201f7_33ba7c24","line":117,"range":{"start_line":116,"start_character":0,"end_line":117,"end_character":57},"in_reply_to":"ba5201f7_cdb513ce","updated":"2017-01-03 01:36:56.000000000","message":"Done","commit_id":"6ba487edf6b6f53b3b443adae3c04e4fd4da7726"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"7466e3794ba3b32c4523fe0476c530274576a014","unresolved":false,"context_lines":[{"line_number":653,"context_line":"        self.INSTANCE[\u0027ephemeral_key_uuid\u0027] \u003d None"},{"line_number":654,"context_line":"        self.LV \u003d \u0027%s_%s\u0027 % (self.INSTANCE[\u0027uuid\u0027], self.NAME)"},{"line_number":655,"context_line":"        self.PATH \u003d os.path.join(\u0027/dev\u0027, self.VG, self.LV)"},{"line_number":656,"context_line":"        self.disk \u003d imagebackend.disk"},{"line_number":657,"context_line":"        self.utils \u003d imagebackend.utils"},{"line_number":658,"context_line":"        self.lvm \u003d imagebackend.lvm"},{"line_number":659,"context_line":""},{"line_number":660,"context_line":"    def _create_image(self, sparse):"},{"line_number":661,"context_line":"        with test.nested("}],"source_content_type":"text/x-python","patch_set":8,"id":"ba5201f7_0df63b8f","line":658,"range":{"start_line":656,"start_character":0,"end_line":658,"end_character":35},"updated":"2017-01-02 20:58:01.000000000","message":"There doesn\u0027t appear to be any reason to keep these around when we\u0027re using mock - they made sense when we had a prepare_mock function (we needed somewhere to store the mocked functions) but not now. You can drop this and use the import directly as below","commit_id":"6ba487edf6b6f53b3b443adae3c04e4fd4da7726"},{"author":{"_account_id":19741,"name":"Hieu LE","email":"hieulq2@viettel.com.vn","username":"hieulq"},"change_message_id":"a33e6945f0b96dd138cfa4ea0e762ea85d9950a8","unresolved":false,"context_lines":[{"line_number":653,"context_line":"        self.INSTANCE[\u0027ephemeral_key_uuid\u0027] \u003d None"},{"line_number":654,"context_line":"        self.LV \u003d \u0027%s_%s\u0027 % (self.INSTANCE[\u0027uuid\u0027], self.NAME)"},{"line_number":655,"context_line":"        self.PATH \u003d os.path.join(\u0027/dev\u0027, self.VG, self.LV)"},{"line_number":656,"context_line":"        self.disk \u003d imagebackend.disk"},{"line_number":657,"context_line":"        self.utils \u003d imagebackend.utils"},{"line_number":658,"context_line":"        self.lvm \u003d imagebackend.lvm"},{"line_number":659,"context_line":""},{"line_number":660,"context_line":"    def _create_image(self, sparse):"},{"line_number":661,"context_line":"        with test.nested("}],"source_content_type":"text/x-python","patch_set":8,"id":"ba5201f7_f372b47b","line":658,"range":{"start_line":656,"start_character":0,"end_line":658,"end_character":35},"in_reply_to":"ba5201f7_0df63b8f","updated":"2017-01-03 01:36:56.000000000","message":"Done","commit_id":"6ba487edf6b6f53b3b443adae3c04e4fd4da7726"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"7466e3794ba3b32c4523fe0476c530274576a014","unresolved":false,"context_lines":[{"line_number":659,"context_line":""},{"line_number":660,"context_line":"    def _create_image(self, sparse):"},{"line_number":661,"context_line":"        with test.nested("},{"line_number":662,"context_line":"            mock.patch.object(self.lvm, \u0027create_volume\u0027),"},{"line_number":663,"context_line":"            mock.patch.object(self.disk, \u0027get_disk_size\u0027),"},{"line_number":664,"context_line":"            mock.patch.object(self.utils, \u0027execute\u0027)"},{"line_number":665,"context_line":"        ) as (mock_create, mock_get, mock_execute):"},{"line_number":666,"context_line":"            mock_get.return_value \u003d self.TEMPLATE_SIZE"},{"line_number":667,"context_line":"            fn \u003d mock.MagicMock()"}],"source_content_type":"text/x-python","patch_set":8,"id":"ba5201f7_0dc8fb54","line":664,"range":{"start_line":662,"start_character":0,"end_line":664,"end_character":52},"updated":"2017-01-02 20:58:01.000000000","message":"These could be decorators, right?\n\n  @mock.patch.object(\u0027nova.virt.libvirt.imagebackend.lvm.create_volume)\n  ...","commit_id":"6ba487edf6b6f53b3b443adae3c04e4fd4da7726"},{"author":{"_account_id":19741,"name":"Hieu LE","email":"hieulq2@viettel.com.vn","username":"hieulq"},"change_message_id":"a33e6945f0b96dd138cfa4ea0e762ea85d9950a8","unresolved":false,"context_lines":[{"line_number":659,"context_line":""},{"line_number":660,"context_line":"    def _create_image(self, sparse):"},{"line_number":661,"context_line":"        with test.nested("},{"line_number":662,"context_line":"            mock.patch.object(self.lvm, \u0027create_volume\u0027),"},{"line_number":663,"context_line":"            mock.patch.object(self.disk, \u0027get_disk_size\u0027),"},{"line_number":664,"context_line":"            mock.patch.object(self.utils, \u0027execute\u0027)"},{"line_number":665,"context_line":"        ) as (mock_create, mock_get, mock_execute):"},{"line_number":666,"context_line":"            mock_get.return_value \u003d self.TEMPLATE_SIZE"},{"line_number":667,"context_line":"            fn \u003d mock.MagicMock()"}],"source_content_type":"text/x-python","patch_set":8,"id":"ba5201f7_13701872","line":664,"range":{"start_line":662,"start_character":0,"end_line":664,"end_character":52},"in_reply_to":"ba5201f7_0dc8fb54","updated":"2017-01-03 01:36:56.000000000","message":"Done for the rest of this patch, too","commit_id":"6ba487edf6b6f53b3b443adae3c04e4fd4da7726"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"b8a104f3f5b0e988881bad3cc4b34020792bf00a","unresolved":false,"context_lines":[{"line_number":657,"context_line":"    @mock.patch.object(imagebackend.disk, \u0027get_disk_size\u0027)"},{"line_number":658,"context_line":"    @mock.patch.object(imagebackend.utils, \u0027execute\u0027)"},{"line_number":659,"context_line":"    def _create_image(self, sparse, mock_execute, mock_get, mock_create):"},{"line_number":660,"context_line":"        mock_get.return_value \u003d self.TEMPLATE_SIZE"},{"line_number":661,"context_line":"        fn \u003d mock.MagicMock()"},{"line_number":662,"context_line":"        cmd \u003d (\u0027qemu-img\u0027, \u0027convert\u0027, \u0027-O\u0027, \u0027raw\u0027, self.TEMPLATE_PATH,"},{"line_number":663,"context_line":"               self.PATH)"}],"source_content_type":"text/x-python","patch_set":10,"id":"ba5201f7_48e827e3","line":660,"range":{"start_line":660,"start_character":8,"end_line":660,"end_character":50},"updated":"2017-01-03 10:37:17.000000000","message":"nit: this could be a argument to the decorator:\n\n    @mock.path.object(imagebackend.disk, \u0027get_disk_size\u0027,\n                      return_value\u003dTEMPLATE_SIZE)","commit_id":"a02644a8f95c0c04bfd39256637cc6ad967db69b"},{"author":{"_account_id":19741,"name":"Hieu LE","email":"hieulq2@viettel.com.vn","username":"hieulq"},"change_message_id":"b68fbceb789fabedefce8bae653a1dc6bcc72153","unresolved":false,"context_lines":[{"line_number":657,"context_line":"    @mock.patch.object(imagebackend.disk, \u0027get_disk_size\u0027)"},{"line_number":658,"context_line":"    @mock.patch.object(imagebackend.utils, \u0027execute\u0027)"},{"line_number":659,"context_line":"    def _create_image(self, sparse, mock_execute, mock_get, mock_create):"},{"line_number":660,"context_line":"        mock_get.return_value \u003d self.TEMPLATE_SIZE"},{"line_number":661,"context_line":"        fn \u003d mock.MagicMock()"},{"line_number":662,"context_line":"        cmd \u003d (\u0027qemu-img\u0027, \u0027convert\u0027, \u0027-O\u0027, \u0027raw\u0027, self.TEMPLATE_PATH,"},{"line_number":663,"context_line":"               self.PATH)"}],"source_content_type":"text/x-python","patch_set":10,"id":"ba5201f7_5078af2b","line":660,"range":{"start_line":660,"start_character":8,"end_line":660,"end_character":50},"in_reply_to":"ba5201f7_48e827e3","updated":"2017-01-04 01:04:53.000000000","message":"Done","commit_id":"a02644a8f95c0c04bfd39256637cc6ad967db69b"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"b8a104f3f5b0e988881bad3cc4b34020792bf00a","unresolved":false,"context_lines":[{"line_number":692,"context_line":"    @mock.patch.object(imagebackend.utils, \u0027execute\u0027)"},{"line_number":693,"context_line":"    def _create_image_resize(self, sparse, mock_execute, mock_get,"},{"line_number":694,"context_line":"                             mock_create, mock_resize):"},{"line_number":695,"context_line":"        mock_get.return_value \u003d self.TEMPLATE_SIZE"},{"line_number":696,"context_line":"        fn \u003d mock.MagicMock()"},{"line_number":697,"context_line":"        fn(target\u003dself.TEMPLATE_PATH)"},{"line_number":698,"context_line":"        cmd \u003d (\u0027qemu-img\u0027, \u0027convert\u0027, \u0027-O\u0027, \u0027raw\u0027, self.TEMPLATE_PATH,"}],"source_content_type":"text/x-python","patch_set":10,"id":"ba5201f7_88f20fd1","line":695,"range":{"start_line":695,"start_character":8,"end_line":695,"end_character":50},"updated":"2017-01-03 10:37:17.000000000","message":"ditto (and for other cases below)","commit_id":"a02644a8f95c0c04bfd39256637cc6ad967db69b"},{"author":{"_account_id":19741,"name":"Hieu LE","email":"hieulq2@viettel.com.vn","username":"hieulq"},"change_message_id":"b68fbceb789fabedefce8bae653a1dc6bcc72153","unresolved":false,"context_lines":[{"line_number":692,"context_line":"    @mock.patch.object(imagebackend.utils, \u0027execute\u0027)"},{"line_number":693,"context_line":"    def _create_image_resize(self, sparse, mock_execute, mock_get,"},{"line_number":694,"context_line":"                             mock_create, mock_resize):"},{"line_number":695,"context_line":"        mock_get.return_value \u003d self.TEMPLATE_SIZE"},{"line_number":696,"context_line":"        fn \u003d mock.MagicMock()"},{"line_number":697,"context_line":"        fn(target\u003dself.TEMPLATE_PATH)"},{"line_number":698,"context_line":"        cmd \u003d (\u0027qemu-img\u0027, \u0027convert\u0027, \u0027-O\u0027, \u0027raw\u0027, self.TEMPLATE_PATH,"}],"source_content_type":"text/x-python","patch_set":10,"id":"ba5201f7_30a40ba5","line":695,"range":{"start_line":695,"start_character":8,"end_line":695,"end_character":50},"in_reply_to":"ba5201f7_88f20fd1","updated":"2017-01-04 01:04:53.000000000","message":"Done","commit_id":"a02644a8f95c0c04bfd39256637cc6ad967db69b"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"0f5f2a41754ce0be0024cd0dc580eac73b05eecc","unresolved":false,"context_lines":[{"line_number":663,"context_line":"               self.PATH)"},{"line_number":664,"context_line":""},{"line_number":665,"context_line":"        image \u003d self.image_class(self.INSTANCE, self.NAME)"},{"line_number":666,"context_line":""},{"line_number":667,"context_line":"        image.create_image(fn, self.TEMPLATE_PATH, None)"},{"line_number":668,"context_line":""},{"line_number":669,"context_line":"        mock_create.assert_called_once_with(self.VG, self.LV,"}],"source_content_type":"text/x-python","patch_set":11,"id":"ba5201f7_70d76123","line":666,"updated":"2017-01-04 11:24:13.000000000","message":"nit: unrelated whitespace change","commit_id":"29a5a89e1b1caad42a2fafcf41d6c5d84f5d836b"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"8569440097914d0e7bc37bb5d47fabc6fe0418a4","unresolved":false,"context_lines":[{"line_number":670,"context_line":"        mock_create.assert_called_once_with(self.VG, self.LV,"},{"line_number":671,"context_line":"                                            self.TEMPLATE_SIZE,"},{"line_number":672,"context_line":"                                            sparse\u003dsparse)"},{"line_number":673,"context_line":""},{"line_number":674,"context_line":"        fn.assert_called_once_with(target\u003dself.TEMPLATE_PATH)"},{"line_number":675,"context_line":"        mock_get.assert_called_once_with(self.TEMPLATE_PATH)"},{"line_number":676,"context_line":"        mock_execute.assert_called_once_with(*cmd, run_as_root\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":12,"id":"3a461143_9acbfc52","line":673,"updated":"2017-01-27 18:47:12.000000000","message":"Nit: don\u0027t need this gap here I feel.","commit_id":"cf6ac7a6aa66216232f01a1aca8d4a398b77275a"}]}