)]}'
{"id":"openstack%2Fnova~336021","triplet_id":"openstack%2Fnova~master~I069b888de9ab681ae5c8cf4515e67e3c7c514443","project":"openstack/nova","branch":"master","topic":"bp/libvirt-virtlogd","hashtags":[],"change_id":"I069b888de9ab681ae5c8cf4515e67e3c7c514443","subject":"libvirt: remove dead code path in \"_get_console_output_pty\"","status":"ABANDONED","created":"2016-06-30 13:39:32.000000000","updated":"2016-06-30 16:23:26.000000000","total_comment_count":4,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"39b0144137ac6141d67f9ae88694b16cb048eeb3","_number":336021,"virtual_id_number":336021,"owner":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"actions":{},"labels":{"Verified":{"all":[{"date":"2016-06-30 16:23:26.000000000","_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},{"value":0,"date":"2016-06-30 14:58:35.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":9578,"name":"DB Datasets CI","email":"turbo-hipster@lists.rcbops.com","username":"turbo-hipster","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":9578,"name":"DB Datasets CI","email":"turbo-hipster@lists.rcbops.com","username":"turbo-hipster","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},{"value":0,"permitted_voting_range":{"min":-1,"max":0},"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},{"_account_id":9578,"name":"DB Datasets CI","email":"turbo-hipster@lists.rcbops.com","username":"turbo-hipster","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":9578,"name":"DB Datasets CI","email":"turbo-hipster@lists.rcbops.com","username":"turbo-hipster","tags":["SERVICE_USER"]}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},{"_account_id":9578,"name":"DB Datasets CI","email":"turbo-hipster@lists.rcbops.com","username":"turbo-hipster","tags":["SERVICE_USER"]},{"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2016-06-30 13:50:57.000000000","updated_by":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"reviewer":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"state":"REVIEWER"},{"updated":"2016-06-30 14:58:35.000000000","updated_by":{"_account_id":9578,"name":"DB Datasets CI","email":"turbo-hipster@lists.rcbops.com","username":"turbo-hipster","tags":["SERVICE_USER"]},"reviewer":{"_account_id":9578,"name":"DB Datasets CI","email":"turbo-hipster@lists.rcbops.com","username":"turbo-hipster","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2016-06-30 16:23:26.000000000","updated_by":{"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},"reviewer":{"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"75b2b86cb6328f11d009c8e97fb7c0eb6c30218c","author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"date":"2016-06-30 13:39:32.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"0598fcd1e7df75ca73dfe7c28e648a632c1423d0","author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"date":"2016-06-30 13:50:57.000000000","message":"Patch Set 1: Code-Review-1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"f71687297ea1c32ff1361c25191acecd557ce3ec","author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"date":"2016-06-30 14:06:51.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"cb4bdb8fc94c13477e2b3ea7c5ce7031f537f287","author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"date":"2016-06-30 14:07:29.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"1421a470302b93394049c25a6715aff023578777","author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"date":"2016-06-30 14:45:38.000000000","message":"Abandoned\n\nI have to respin the change series. I\u0027m squashing this into https://review.openstack.org/#/c/334480/7","accounts_in_message":[],"_revision_number":2},{"id":"1166287b6d5ecd96d000c85aa36b891dfc4c65e5","author":{"_account_id":9578,"name":"DB Datasets CI","email":"turbo-hipster@lists.rcbops.com","username":"turbo-hipster","tags":["SERVICE_USER"]},"date":"2016-06-30 14:58:35.000000000","message":"Patch Set 2:\n\nDatabase migration testing successful.\n\n- real-db-upgrade_nova_mysql_devstack_131007:th-mysql http://www.rcbops.com/turbo_hipster/results/21/336021/2/check/real-db-upgrade_nova_mysql_devstack_131007:th-mysql/e0bb8738a7d04b07a19247fd3cb4a98e/index.html : SUCCESS in 21m 56s\n- real-db-upgrade_nova_percona_devstack_131007:th-percona http://www.rcbops.com/turbo_hipster/results/21/336021/2/check/real-db-upgrade_nova_percona_devstack_131007:th-percona/b9bdc3610ab04b8594054096ca03aa98/index.html : SUCCESS in 21m 53s\n- real-db-upgrade_nova_mysql_user_001:th-mysql http://www.rcbops.com/turbo_hipster/results/21/336021/2/check/real-db-upgrade_nova_mysql_user_001:th-mysql/affc5b0f2d2c4aaf8cbfc9dbcc3ee4d8/index.html : SUCCESS in 16m 30s\n- real-db-upgrade_nova_percona_user_001:th-percona http://www.rcbops.com/turbo_hipster/results/21/336021/2/check/real-db-upgrade_nova_percona_user_001:th-percona/5df3c11d3b6445ae91b1ee02f94ba0c4/index.html : SUCCESS in 21m 48s\n\nTo recheck, leave \u0027recheck migrations\u0027 as a comment. More information: https://wiki.openstack.org/wiki/ThirdPartySystems/DB_Datasets_CI","accounts_in_message":[],"_revision_number":2},{"id":"2aef546482c2cbaab1cb684c09d25db354635284","author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"date":"2016-06-30 15:13:52.000000000","message":"Patch Set 1:\n\n(2 comments)","accounts_in_message":[],"_revision_number":1},{"id":"cbc912560bb173ef62f269a73e1082adeb7902d4","author":{"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},"date":"2016-06-30 16:23:26.000000000","message":"Patch Set 2:\n\nTesting completed on Citrix Xenserver. For rechecking only on the Citrix Xenserver CI,add a review comment with \"xenserver: recheck\". Contact info: openstack@citrix.com.\nFor debugging suggestions, see https://wiki.openstack.org/wiki/Debugging_XenServer_CI_failures\n\n- check-citrix-xenserver http://dd6b71949550285df7dc-dda4e480e005aaa13ec303551d2d8155.r49.cf1.rackcdn.com/21/336021/2/22641/index.html : SUCCESS in 01 h 14 m 19 s","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"389201399224c2a131272c3e170a45dcbf9ccd19","revisions":{"b0665f10763fe90594c0a6991fd44cc6c202f424":{"kind":"REWORK","_number":1,"created":"2016-06-30 13:39:32.000000000","uploader":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"ref":"refs/changes/21/336021/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/21/336021/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/21/336021/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/21/336021/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/21/336021/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/21/336021/1"}}},"commit":{"parents":[{"commit":"65a9a553a628354341de6d5023642d0d1d358b56","subject":"libvirt: virtlogd: use virtlogd for char devices","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/65a9a553a628354341de6d5023642d0d1d358b56"}]}],"author":{"name":"Markus Zoeller","email":"mzoeller@de.ibm.com","date":"2016-06-30 13:37:04.000000000","tz":120},"committer":{"name":"Markus Zoeller","email":"mzoeller@de.ibm.com","date":"2016-06-30 13:37:04.000000000","tz":120},"subject":"libvirt: remove dead code path in \"_get_console_output_pty\"","message":"libvirt: remove dead code path in \"_get_console_output_pty\"\n\nIf I get [1] right, the execution of the processutils will always return\nat least an empty string and never None. Which makes the latter part of\nthe ``data or \u0027\u0027`` code path a dead path. This change removes that.\n\nReferences:\n[1] https://github.com/openstack/oslo.concurrency/blob/\n    c876fabd0726b33a34f72a1af7588da0360ae37f/oslo_concurrency/\n    processutils.py#L394\n\nChange-Id: I069b888de9ab681ae5c8cf4515e67e3c7c514443\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/b0665f10763fe90594c0a6991fd44cc6c202f424"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/b0665f10763fe90594c0a6991fd44cc6c202f424"}]},"branch":"refs/heads/master"},"389201399224c2a131272c3e170a45dcbf9ccd19":{"kind":"TRIVIAL_REBASE_WITH_MESSAGE_UPDATE","_number":2,"created":"2016-06-30 14:07:29.000000000","uploader":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"ref":"refs/changes/21/336021/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/21/336021/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/21/336021/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/21/336021/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/21/336021/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/21/336021/2"}}},"commit":{"parents":[{"commit":"f9f16c832e4665e9a3ae92fe22a2315c92f1253b","subject":"libvirt: virtlogd: use virtlogd for char devices","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/f9f16c832e4665e9a3ae92fe22a2315c92f1253b"}]}],"author":{"name":"Markus Zoeller","email":"mzoeller@de.ibm.com","date":"2016-06-30 13:37:04.000000000","tz":120},"committer":{"name":"Markus Zoeller","email":"mzoeller@de.ibm.com","date":"2016-06-30 14:05:35.000000000","tz":120},"subject":"libvirt: remove dead code path in \"_get_console_output_pty\"","message":"libvirt: remove dead code path in \"_get_console_output_pty\"\n\nThe execution of the processutils will always return at least an empty\nstring and never None. Which makes the latter part of the ``data or \u0027\u0027``\ncode path a dead path. This change removes that.\n\nReferences:\n[1] https://github.com/openstack/oslo.concurrency/blob/\n    c876fabd0726b33a34f72a1af7588da0360ae37f/oslo_concurrency/\n    processutils.py#L394\n\nChange-Id: I069b888de9ab681ae5c8cf4515e67e3c7c514443\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/389201399224c2a131272c3e170a45dcbf9ccd19"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/389201399224c2a131272c3e170a45dcbf9ccd19"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}
