)]}'
{"nova/db/sqlalchemy/migrate_repo/versions/190_add_sqlite_indexes.py":[{"author":{"_account_id":5652,"name":"David Ripton","email":"dripton@redhat.com","username":"dripton"},"change_message_id":"70bb084392925f9768ed61c4b46bb81c5d648e28","unresolved":false,"context_lines":[{"line_number":221,"context_line":"    for index in indexes:"},{"line_number":222,"context_line":"        index.create(migrate_engine) if upgrade else index.drop(migrate_engine)"},{"line_number":223,"context_line":""},{"line_number":224,"context_line":"    # if upgrade:"},{"line_number":225,"context_line":"    #     import pdb"},{"line_number":226,"context_line":"    #     pdb.set_trace()"},{"line_number":227,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAPn%2F%2F0cY%3D","line":224,"updated":"2013-06-20 14:03:14.000000000","message":"This commented-out debug code should be removed.","commit_id":"7a6869e0a4fc4d99f367bf9c6a2bc4bdf6674f0e"},{"author":{"_account_id":7491,"name":"Viktor Serhieiev","email":"viktor.sergeyev@gmail.com","username":"vsergeyev"},"change_message_id":"f285add47adf9df72d3fd5e401c6c08d0e9455a2","unresolved":false,"context_lines":[{"line_number":221,"context_line":"    for index in indexes:"},{"line_number":222,"context_line":"        index.create(migrate_engine) if upgrade else index.drop(migrate_engine)"},{"line_number":223,"context_line":""},{"line_number":224,"context_line":"    # if upgrade:"},{"line_number":225,"context_line":"    #     import pdb"},{"line_number":226,"context_line":"    #     pdb.set_trace()"},{"line_number":227,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAPn%2F%2F0Tk%3D","line":224,"in_reply_to":"AAAAPn%2F%2F0cY%3D","updated":"2013-06-20 15:00:32.000000000","message":"Done","commit_id":"7a6869e0a4fc4d99f367bf9c6a2bc4bdf6674f0e"},{"author":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"change_message_id":"9116bc4be361ef32d88991a7508c78c36dd91ae0","unresolved":false,"context_lines":[{"line_number":59,"context_line":"    virtual_interfaces \u003d Table(\u0027virtual_interfaces\u0027, meta, autoload\u003dTrue)"},{"line_number":60,"context_line":"    instance_system_metadata \u003d Table("},{"line_number":61,"context_line":"        \u0027instance_system_metadata\u0027, meta, autoload\u003dTrue)"},{"line_number":62,"context_line":"    volume_metadata \u003d Table(\u0027volume_metadata\u0027, meta, autoload\u003dTrue)"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"    indexes \u003d ("},{"line_number":65,"context_line":"        # agent_builds"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAPn%2F%2Fl30%3D","line":62,"updated":"2013-06-27 06:50:38.000000000","message":"I\u0027d prefer to see these broken up a bit more. I wonder if this could be expressed as a list of sets or something and be shorter?","commit_id":"9876d4c275a01421bf3386cfaf4be5706955f650"},{"author":{"_account_id":7491,"name":"Viktor Serhieiev","email":"viktor.sergeyev@gmail.com","username":"vsergeyev"},"change_message_id":"a167a14bf13e7638c1c3c661053a9b4772ce5a5e","unresolved":false,"context_lines":[{"line_number":59,"context_line":"    virtual_interfaces \u003d Table(\u0027virtual_interfaces\u0027, meta, autoload\u003dTrue)"},{"line_number":60,"context_line":"    instance_system_metadata \u003d Table("},{"line_number":61,"context_line":"        \u0027instance_system_metadata\u0027, meta, autoload\u003dTrue)"},{"line_number":62,"context_line":"    volume_metadata \u003d Table(\u0027volume_metadata\u0027, meta, autoload\u003dTrue)"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"    indexes \u003d ("},{"line_number":65,"context_line":"        # agent_builds"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAPn%2F%2FliY%3D","line":62,"in_reply_to":"AAAAPn%2F%2Fl30%3D","updated":"2013-06-27 08:59:57.000000000","message":"Done. It\u0027s become shorter, but only a little.","commit_id":"9876d4c275a01421bf3386cfaf4be5706955f650"}],"nova/db/sqlalchemy/migrate_repo/versions/201_add_sqlite_indexes.py":[{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"4083ebd45bb20d24f27f7f4144ff83953b8a7d44","unresolved":false,"context_lines":[{"line_number":174,"context_line":""},{"line_number":175,"context_line":"def downgrade(migrate_engine):"},{"line_number":176,"context_line":"    if migrate_engine.name \u003d\u003d \"sqlite\":"},{"line_number":177,"context_line":"        _add_sqlite_indexes(migrate_engine, False)"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAQn%2F%2F7tI%3D","line":177,"updated":"2013-07-18 21:32:54.000000000","message":"ok, this is just confusing. _add_sqlite_indexes(... False) really is weird logic.\n\nPlease make a second utility function name here, move the data out of the function, and have this be _drop_sqlite_indexes.","commit_id":"84b95c8e0f3d0c5fb246d117ea9ce6ddca4ceae8"},{"author":{"_account_id":7491,"name":"Viktor Serhieiev","email":"viktor.sergeyev@gmail.com","username":"vsergeyev"},"change_message_id":"adfc910e67499cc5050955d3f1a6c93caf03fc47","unresolved":false,"context_lines":[{"line_number":174,"context_line":""},{"line_number":175,"context_line":"def downgrade(migrate_engine):"},{"line_number":176,"context_line":"    if migrate_engine.name \u003d\u003d \"sqlite\":"},{"line_number":177,"context_line":"        _add_sqlite_indexes(migrate_engine, False)"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAQn%2F%2F6K0%3D","line":177,"in_reply_to":"AAAAQn%2F%2F7tI%3D","updated":"2013-07-19 12:08:51.000000000","message":"Done","commit_id":"84b95c8e0f3d0c5fb246d117ea9ce6ddca4ceae8"}]}