)]}'
{"id":"openstack%2Fnova~336105","triplet_id":"openstack%2Fnova~master~Ief45617eb0776a8e64c5253eb97f99e3e714213e","project":"openstack/nova","branch":"master","topic":"device-tag-ut-mock-cleanup","hashtags":[],"change_id":"Ief45617eb0776a8e64c5253eb97f99e3e714213e","subject":"trivial: remove unnecessary mock from servers API test","status":"MERGED","created":"2016-06-30 16:19:36.000000000","updated":"2016-07-04 14:50:09.000000000","submitted":"2016-07-04 14:50:08.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"e41d2b57765ca14ca8e51bd43a460d5bc3afec6c","_number":336105,"virtual_id_number":336105,"owner":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"recommended":{"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},{"value":1,"date":"2016-06-30 17:21:50.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":9578,"name":"DB Datasets CI","email":"turbo-hipster@lists.rcbops.com","username":"turbo-hipster","tags":["SERVICE_USER"]},{"value":0,"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},{"value":1,"date":"2016-06-30 19:12:16.000000000","_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},{"value":0,"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},{"value":2,"date":"2016-07-04 14:50:08.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"all":[{"value":2,"date":"2016-07-04 13:48:41.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},{"value":0,"_account_id":9578,"name":"DB Datasets CI","email":"turbo-hipster@lists.rcbops.com","username":"turbo-hipster","tags":["SERVICE_USER"]},{"value":2,"date":"2016-07-03 09:10:39.000000000","_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},{"value":0,"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},{"value":1,"date":"2016-07-04 00:46:27.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"all":[{"value":1,"date":"2016-07-04 13:48:41.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},{"value":0,"_account_id":9578,"name":"DB Datasets CI","email":"turbo-hipster@lists.rcbops.com","username":"turbo-hipster","tags":["SERVICE_USER"]},{"value":0,"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},{"value":0,"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},{"value":0,"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},{"value":0,"_account_id":9578,"name":"DB Datasets CI","email":"turbo-hipster@lists.rcbops.com","username":"turbo-hipster","tags":["SERVICE_USER"]},{"value":0,"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},{"value":0,"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},{"value":0,"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},{"_account_id":9578,"name":"DB Datasets CI","email":"turbo-hipster@lists.rcbops.com","username":"turbo-hipster","tags":["SERVICE_USER"]},{"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2016-06-30 17:21:50.000000000","updated_by":{"_account_id":9578,"name":"DB Datasets CI","email":"turbo-hipster@lists.rcbops.com","username":"turbo-hipster","tags":["SERVICE_USER"]},"reviewer":{"_account_id":9578,"name":"DB Datasets CI","email":"turbo-hipster@lists.rcbops.com","username":"turbo-hipster","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2016-06-30 19:12:16.000000000","updated_by":{"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},"reviewer":{"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2016-07-03 09:10:39.000000000","updated_by":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"reviewer":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"state":"REVIEWER"},{"updated":"2016-07-04 00:46:27.000000000","updated_by":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"reviewer":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"state":"REVIEWER"},{"updated":"2016-07-04 13:48:41.000000000","updated_by":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"reviewer":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"state":"REVIEWER"},{"updated":"2016-07-04 14:50:08.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"276ebb7629692bcaade7ac1fa387385f94ce6a45","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2016-06-30 16:19:36.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"dbb219812eaf6e35636c749dfdded1d59c1ddadc","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-06-30 16:43:25.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-nova-docs http://docs-draft.openstack.org/05/336105/1/check/gate-nova-docs/5d312c3//doc/build/html/ : SUCCESS in 4m 02s\n- gate-nova-pep8 http://logs.openstack.org/05/336105/1/check/gate-nova-pep8/fd83736/ : SUCCESS in 8m 18s\n- gate-nova-python27-db http://logs.openstack.org/05/336105/1/check/gate-nova-python27-db/62f000c/ : SUCCESS in 13m 35s\n- gate-nova-python34-db http://logs.openstack.org/05/336105/1/check/gate-nova-python34-db/69926f7/ : SUCCESS in 11m 17s\n- gate-nova-tox-db-functional http://logs.openstack.org/05/336105/1/check/gate-nova-tox-db-functional/3f9680a/ : SUCCESS in 15m 03s","accounts_in_message":[],"_revision_number":1},{"id":"7a2f8e0add26241c0740540ef6185e4e83091607","author":{"_account_id":9578,"name":"DB Datasets CI","email":"turbo-hipster@lists.rcbops.com","username":"turbo-hipster","tags":["SERVICE_USER"]},"date":"2016-06-30 17:21:50.000000000","message":"Patch Set 1: Verified+1\n\nDatabase migration testing successful.\n\n- real-db-upgrade_nova_mysql_devstack_131007:th-mysql http://www.rcbops.com/turbo_hipster/results/05/336105/1/check/real-db-upgrade_nova_mysql_devstack_131007:th-mysql/a9735f09b7e9478bbfe40573698df73b/index.html : SUCCESS in 24m 10s\n- real-db-upgrade_nova_percona_devstack_131007:th-percona http://www.rcbops.com/turbo_hipster/results/05/336105/1/check/real-db-upgrade_nova_percona_devstack_131007:th-percona/dd82ce2e8ac64d9cb5cee7a470e4f13a/index.html : SUCCESS in 22m 00s\n- real-db-upgrade_nova_mysql_user_001:th-mysql http://www.rcbops.com/turbo_hipster/results/05/336105/1/check/real-db-upgrade_nova_mysql_user_001:th-mysql/fcc0a6fee50146e69f7e0b14860201a6/index.html : SUCCESS in 24m 19s\n- real-db-upgrade_nova_percona_user_001:th-percona http://www.rcbops.com/turbo_hipster/results/05/336105/1/check/real-db-upgrade_nova_percona_user_001:th-percona/2cb142faaf3347adaf937a04520bd0e3/index.html : SUCCESS in 21m 21s\n\nTo recheck, leave \u0027recheck migrations\u0027 as a comment. More information: https://wiki.openstack.org/wiki/ThirdPartySystems/DB_Datasets_CI","accounts_in_message":[],"_revision_number":1},{"id":"cbbd9fc241dabf6ca2b780067bed8fd74559a655","author":{"_account_id":5170,"name":"Microsoft Hyper-V CI","email":"hyper-v_ci@microsoft.com","username":"hyper-v-ci","tags":["SERVICE_USER"]},"date":"2016-06-30 17:50:04.000000000","message":"Patch Set 1:\n\nFor rechecking only on the Microsoft Hyper-V CI, add a review comment with check hyper-v\n\n- nova-dvsm-full-tempest http://64.119.130.115/nova/336105/1/ : FAILURE in 38m 28s","accounts_in_message":[],"_revision_number":1},{"id":"7530fc27753d7678dfa53eba99b5dfee04e59ad7","author":{"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},"date":"2016-06-30 19:12:16.000000000","message":"Patch Set 1: Verified+1\n\nTesting completed on Citrix Xenserver. For rechecking only on the Citrix Xenserver CI,add a review comment with \"xenserver: recheck\". Contact info: openstack@citrix.com.\nFor debugging suggestions, see https://wiki.openstack.org/wiki/Debugging_XenServer_CI_failures\n\n- check-citrix-xenserver http://dd6b71949550285df7dc-dda4e480e005aaa13ec303551d2d8155.r49.cf1.rackcdn.com/05/336105/1/22694/index.html : SUCCESS in 01 h 09 m 07 s","accounts_in_message":[],"_revision_number":1},{"id":"0f297fb0c69c4a7e032eefca2a58dc555cf9abdd","author":{"_account_id":16376,"name":"Intel NFV CI","email":"openstack-nfv-ci@intel.com","username":"intel-nfv-ci","tags":["SERVICE_USER"]},"date":"2016-06-30 23:23:10.000000000","message":"Patch Set 1:\n\nBuild succeeded (check pipeline).\n\n- tempest-dsvm-full-nfv http://intel-openstack-ci-logs.ovh/05/336105/1/check/tempest-dsvm-full-nfv/0b2a62b : SUCCESS in 1h 53m 37s\n- tempest-dsvm-intel-nfv http://intel-openstack-ci-logs.ovh/05/336105/1/check/tempest-dsvm-intel-nfv/ed22107 : SUCCESS in 45m 42s\n- tempest-dsvm-ovsdpdk-nfv-networking http://intel-openstack-ci-logs.ovh/05/336105/1/check/tempest-dsvm-ovsdpdk-nfv-networking/a1357ac : SUCCESS in 1h 04m 35s","accounts_in_message":[],"_revision_number":1},{"id":"55301c8f94a1864151d942be346b1d9035d7ffbd","author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"date":"2016-07-03 09:10:39.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"7fda81d6eb1bf754c7c5de550b4d42d531c23468","author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"date":"2016-07-03 22:08:21.000000000","message":"Patch Set 1:\n\nThere were a few other nits to address in the tagging series, no? In that case, wouldn\u0027t it be better to have a single patch fixing all the nits in one shot?","accounts_in_message":[],"_revision_number":1},{"id":"1a6f6bb8a001a747e5f1fbd7b62d85c8abe5d936","author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"date":"2016-07-04 00:46:27.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"675fa5b12c47cd36a2206df20cdd39c4d81a1aee","author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"date":"2016-07-04 13:48:41.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"f9e7d9d800287889772e8992ff8f56f856e9d57b","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-07-04 13:48:53.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"eb69e8bfdbdf9b2a86da93c30cf434da512f6fe9","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-07-04 14:50:08.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-nova-docs http://docs-draft.openstack.org/05/336105/1/gate/gate-nova-docs/bb1c554//doc/build/html/ : SUCCESS in 5m 17s\n- gate-nova-pep8 http://logs.openstack.org/05/336105/1/gate/gate-nova-pep8/690a6c6/ : SUCCESS in 6m 42s\n- gate-nova-python27-db http://logs.openstack.org/05/336105/1/gate/gate-nova-python27-db/a82f718/ : SUCCESS in 11m 57s\n- gate-nova-python34-db http://logs.openstack.org/05/336105/1/gate/gate-nova-python34-db/6228f4c/ : SUCCESS in 9m 37s\n- gate-nova-tox-db-functional http://logs.openstack.org/05/336105/1/gate/gate-nova-tox-db-functional/aa69e75/ : SUCCESS in 14m 49s","accounts_in_message":[],"_revision_number":1},{"id":"15ceb11a0905e4213a04b5c0b74007d0b03ca13c","date":"2016-07-04 14:50:09.000000000","message":"Change has been successfully merged into the git repository by Jenkins","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"cdc938fa0211fcbc7117092d15059f324335313d","revisions":{"cdc938fa0211fcbc7117092d15059f324335313d":{"kind":"REWORK","_number":1,"created":"2016-06-30 16:19:36.000000000","uploader":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"ref":"refs/changes/05/336105/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/05/336105/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/05/336105/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/05/336105/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/05/336105/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/05/336105/1"}}},"commit":{"parents":[{"commit":"222a88a54ceda741e0409f86aeb632b38a1792be","subject":"Merge \"Always call port_update in allocate_for_instance\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/222a88a54ceda741e0409f86aeb632b38a1792be"}]}],"author":{"name":"Matt Riedemann","email":"mriedem@us.ibm.com","date":"2016-06-30 16:17:56.000000000","tz":-240},"committer":{"name":"Matt Riedemann","email":"mriedem@us.ibm.com","date":"2016-06-30 16:17:56.000000000","tz":-240},"subject":"trivial: remove unnecessary mock from servers API test","message":"trivial: remove unnecessary mock from servers API test\n\nThis came up while reviewing I89247200f4cf1f644daf476727b4a6acb22b0cf6\nbut we didn\u0027t want to hold the change for it, so the cleanup is\naddressed here.\n\nChange-Id: Ief45617eb0776a8e64c5253eb97f99e3e714213e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/cdc938fa0211fcbc7117092d15059f324335313d"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/cdc938fa0211fcbc7117092d15059f324335313d"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"222a88a54ceda741e0409f86aeb632b38a1792be","is_merged_in_target_branch":true}],"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}