)]}'
{"nova/utils.py":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"2d742905aac76db91b11f062c93a0fcc6c6deac6","unresolved":false,"context_lines":[{"line_number":975,"context_line":""},{"line_number":976,"context_line":"def instance_meta(instance):"},{"line_number":977,"context_line":"    if \u0027metadata\u0027 not in instance:"},{"line_number":978,"context_line":"        return dict()"},{"line_number":979,"context_line":"    elif isinstance(instance[\u0027metadata\u0027], dict):"},{"line_number":980,"context_line":"        return instance[\u0027metadata\u0027]"},{"line_number":981,"context_line":"    else:"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAPn%2F%2Fs2c%3D","line":978,"updated":"2013-06-24 23:05:31.000000000","message":"Why do this? I think that this method should mirror the instance_sys_meta() below.","commit_id":"2b84672c9383abfe8f2c2dd1814561023ea48832"},{"author":{"_account_id":642,"name":"Matt Dietz","email":"matthew.dietz@gmail.com","username":"cerberus"},"change_message_id":"2fcb99533cb35faf4af588004186fb37b14cfbb2","unresolved":false,"context_lines":[{"line_number":975,"context_line":""},{"line_number":976,"context_line":"def instance_meta(instance):"},{"line_number":977,"context_line":"    if \u0027metadata\u0027 not in instance:"},{"line_number":978,"context_line":"        return dict()"},{"line_number":979,"context_line":"    elif isinstance(instance[\u0027metadata\u0027], dict):"},{"line_number":980,"context_line":"        return instance[\u0027metadata\u0027]"},{"line_number":981,"context_line":"    else:"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAPn%2F%2Fkqw%3D","line":978,"in_reply_to":"AAAAPn%2F%2Fkvg%3D","updated":"2013-06-27 15:08:13.000000000","message":"I agree with Dan here; the first if statement shouldn\u0027t be necessary. Would you mind either fixing it or explaining why we need it for sure?","commit_id":"2b84672c9383abfe8f2c2dd1814561023ea48832"},{"author":{"_account_id":7763,"name":"Alexei Kornienko","email":"akornienko@mirantis.com","username":"akornienko"},"change_message_id":"b42b321c78ff2def00da470a81bb1d7e1da1bf38","unresolved":false,"context_lines":[{"line_number":975,"context_line":""},{"line_number":976,"context_line":"def instance_meta(instance):"},{"line_number":977,"context_line":"    if \u0027metadata\u0027 not in instance:"},{"line_number":978,"context_line":"        return dict()"},{"line_number":979,"context_line":"    elif isinstance(instance[\u0027metadata\u0027], dict):"},{"line_number":980,"context_line":"        return instance[\u0027metadata\u0027]"},{"line_number":981,"context_line":"    else:"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAPn%2F%2FsDY%3D","line":978,"in_reply_to":"AAAAPn%2F%2Fs2c%3D","updated":"2013-06-26 07:25:54.000000000","message":"From the usage pattern instance[\u0027metadata\u0027] is allowed to be empty (see https://review.openstack.org/#/c/33623/1/nova/api/metadata/base.py line 130 for example) cause of this it\u0027s simpler to return an empty dict by default. Otherwise checks on the client side would be required to make sure \u0027metadata\u0027 key exists.","commit_id":"2b84672c9383abfe8f2c2dd1814561023ea48832"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"45166b688e826f46a12d479d020bbd214c17530a","unresolved":false,"context_lines":[{"line_number":975,"context_line":""},{"line_number":976,"context_line":"def instance_meta(instance):"},{"line_number":977,"context_line":"    if \u0027metadata\u0027 not in instance:"},{"line_number":978,"context_line":"        return dict()"},{"line_number":979,"context_line":"    elif isinstance(instance[\u0027metadata\u0027], dict):"},{"line_number":980,"context_line":"        return instance[\u0027metadata\u0027]"},{"line_number":981,"context_line":"    else:"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAPn%2F%2Fkvg%3D","line":978,"in_reply_to":"AAAAPn%2F%2FsDY%3D","updated":"2013-06-27 14:52:50.000000000","message":"I think you confused what I was asking. I don\u0027t think doing \"if metadata not in instance\" is the right thing here. In SQLA \u003c\u003d0.7, this will return an empty dict if metadata is not yet loaded into the instance, which would return an empty dict when it shouldn\u0027t. If it is present, but empty, the two lines below should still result in an empty dict.","commit_id":"2b84672c9383abfe8f2c2dd1814561023ea48832"}]}