)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"647b75c7c3cd0419452b0921eadc164c19a3a7bb","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Body Verification of api-ref os-volume-attachments.inc"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Verified the request and response body of the api-ref"},{"line_number":10,"context_line":"os-volume-attachments.inc."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"part of bp:api-ref-in-rst"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"dada55a8_933a1fcc","line":9,"range":{"start_line":9,"start_character":9,"end_line":9,"end_character":38},"updated":"2016-07-25 04:38:10.000000000","message":"Body verification is not for request body and response body.\nSee https://wiki.openstack.org/wiki/NovaAPIRef#Body_Verification","commit_id":"d2e521c469501972c64826f04b7a14412467d3d8"},{"author":{"_account_id":6802,"name":"Joel Coffman","email":"jmc7tp@gmail.com","username":"joel-coffman"},"change_message_id":"30ae656831338be56e188163ed123eda7b7d69c2","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Body Verification of api-ref os-volume-attachments.inc"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch verifies the body of os-volume-attachments.inc."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"part of bp:api-ref-in-rst"},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"9ad45d7e_25ac858b","line":9,"updated":"2016-08-10 14:09:44.000000000","message":"Perhaps I\u0027m simply ignorant about the API Ref, but this statement still doesn\u0027t explain *why* the change is being made.\n- Why is body verification important?\n- What specifically has been changed?\n\nIn this case, it seems like the tag `needs:body_verification` has been removed -- perhaps the commit message should state that the content of the request and response bodies has been manually verified and thus the tag is no longer needed?","commit_id":"260ce0a15434055ba47c807ad92db80c3bb25066"}],"api-ref/source/os-volume-attachments.inc":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"cb45e990d823261423c687d80d13333b21c610e1","unresolved":false,"context_lines":[{"line_number":33,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"  - volumeAttachments: volumeAttachments"},{"line_number":36,"context_line":"  - device: device_resp"},{"line_number":37,"context_line":"  - id: attachment_id_resp"},{"line_number":38,"context_line":"  - serverId: server_id"},{"line_number":39,"context_line":"  - volumeId: volumeId_resp"}],"source_content_type":"text/x-c++src","patch_set":1,"id":"3aaa91ec_69cb9e72","line":36,"range":{"start_line":36,"start_character":12,"end_line":36,"end_character":23},"updated":"2016-07-01 08:39:01.000000000","message":"this is optional in response but mentioned as required in parameter.yaml","commit_id":"3d4536e27e30b511a68ef253758bda824474ea6d"},{"author":{"_account_id":21111,"name":"STEW TY","email":"punsoca@gmail.com","username":"stewie925"},"change_message_id":"ab205f76579523ddebc27884bad42201babc3bd8","unresolved":false,"context_lines":[{"line_number":33,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"  - volumeAttachments: volumeAttachments"},{"line_number":36,"context_line":"  - device: device_resp"},{"line_number":37,"context_line":"  - id: attachment_id_resp"},{"line_number":38,"context_line":"  - serverId: server_id"},{"line_number":39,"context_line":"  - volumeId: volumeId_resp"}],"source_content_type":"text/x-c++src","patch_set":1,"id":"3aaa91ec_f600ed68","line":36,"range":{"start_line":36,"start_character":12,"end_line":36,"end_character":23},"in_reply_to":"3aaa91ec_69cb9e72","updated":"2016-07-01 15:52:45.000000000","message":"Would like some clarification on this - I ran the REST API test and I see the device listed each time in the response body?\n\n{\n  \"volumeAttachments\": [\n    {\n      \"device\": \"/dev/vdb\",\n      \"serverId\": \"3084d50e-97e9-40ba-b7c3-0c6c6d246aba\",\n      \"id\": \"6e3bc14b-d763-42d9-8e26-4ed34a4501e4\",\n      \"volumeId\": \"6e3bc14b-d763-42d9-8e26-4ed34a4501e4\"\n    }\n  ]\n}","commit_id":"3d4536e27e30b511a68ef253758bda824474ea6d"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"cb45e990d823261423c687d80d13333b21c610e1","unresolved":false,"context_lines":[{"line_number":112,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"  - volumeAttachment: volumeAttachment"},{"line_number":115,"context_line":"  - device: device_resp"},{"line_number":116,"context_line":"  - id: attachment_id_resp"},{"line_number":117,"context_line":"  - serverId: server_id"},{"line_number":118,"context_line":"  - volumeId: volumeId_resp"}],"source_content_type":"text/x-c++src","patch_set":1,"id":"3aaa91ec_0460ffa3","line":115,"range":{"start_line":115,"start_character":12,"end_line":115,"end_character":23},"updated":"2016-07-01 08:39:01.000000000","message":"ditto","commit_id":"3d4536e27e30b511a68ef253758bda824474ea6d"},{"author":{"_account_id":21111,"name":"STEW TY","email":"punsoca@gmail.com","username":"stewie925"},"change_message_id":"5b8a59fb66ce8b8f91503367101b1f21b83ac4b4","unresolved":false,"context_lines":[{"line_number":33,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"  - volumeAttachments: volumeAttachments"},{"line_number":36,"context_line":"  - device: device_resp_optional"},{"line_number":37,"context_line":"  - id: attachment_id_resp"},{"line_number":38,"context_line":"  - serverId: server_id"},{"line_number":39,"context_line":"  - volumeId: volumeId_resp"}],"source_content_type":"text/x-c++src","patch_set":2,"id":"1aa78d24_227da5e7","line":36,"range":{"start_line":36,"start_character":12,"end_line":36,"end_character":32},"updated":"2016-07-05 19:24:50.000000000","message":"added \u0027device_rep_optional\u0027 parameter per Ghanshyam Mann review.","commit_id":"edbf99f985dc2bc98a27c6b786c32c1879b566b6"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"c71b8d3ba3b1d7c80502d409778ae3aa6df14157","unresolved":false,"context_lines":[{"line_number":33,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"  - volumeAttachments: volumeAttachments"},{"line_number":36,"context_line":"  - device: device_resp_optional"},{"line_number":37,"context_line":"  - id: attachment_id_resp"},{"line_number":38,"context_line":"  - serverId: server_id"},{"line_number":39,"context_line":"  - volumeId: volumeId_resp"}],"source_content_type":"text/x-c++src","patch_set":2,"id":"1aa78d24_d952a712","line":36,"range":{"start_line":36,"start_character":12,"end_line":36,"end_character":32},"in_reply_to":"1aa78d24_227da5e7","updated":"2016-07-12 09:53:24.000000000","message":"ditto","commit_id":"edbf99f985dc2bc98a27c6b786c32c1879b566b6"},{"author":{"_account_id":21111,"name":"STEW TY","email":"punsoca@gmail.com","username":"stewie925"},"change_message_id":"5b8a59fb66ce8b8f91503367101b1f21b83ac4b4","unresolved":false,"context_lines":[{"line_number":112,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"  - volumeAttachment: volumeAttachment"},{"line_number":115,"context_line":"  - device: device_resp_optional"},{"line_number":116,"context_line":"  - id: attachment_id_resp"},{"line_number":117,"context_line":"  - serverId: server_id"},{"line_number":118,"context_line":"  - volumeId: volumeId_resp"}],"source_content_type":"text/x-c++src","patch_set":2,"id":"1aa78d24_825bb986","line":115,"range":{"start_line":115,"start_character":12,"end_line":115,"end_character":31},"updated":"2016-07-05 19:24:50.000000000","message":"same as above comment.","commit_id":"edbf99f985dc2bc98a27c6b786c32c1879b566b6"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"c71b8d3ba3b1d7c80502d409778ae3aa6df14157","unresolved":false,"context_lines":[{"line_number":112,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"  - volumeAttachment: volumeAttachment"},{"line_number":115,"context_line":"  - device: device_resp_optional"},{"line_number":116,"context_line":"  - id: attachment_id_resp"},{"line_number":117,"context_line":"  - serverId: server_id"},{"line_number":118,"context_line":"  - volumeId: volumeId_resp"}],"source_content_type":"text/x-c++src","patch_set":2,"id":"1aa78d24_793bb3d1","line":115,"range":{"start_line":115,"start_character":12,"end_line":115,"end_character":31},"in_reply_to":"1aa78d24_825bb986","updated":"2016-07-12 09:53:24.000000000","message":"It is not optional in the response.\nIf device_name (assigned_mountpoint) is not found, an exception is raised.\nSo the response always includes \u0027device\u0027.\n\nhttps://github.com/openstack/nova/blob/294c85787b5273b21df97a273969e4294212b1d3/nova/api/openstack/compute/volumes.py#L287","commit_id":"edbf99f985dc2bc98a27c6b786c32c1879b566b6"},{"author":{"_account_id":21111,"name":"STEW TY","email":"punsoca@gmail.com","username":"stewie925"},"change_message_id":"744d58e6cf8a1acfcc67aeff0157291e02654e78","unresolved":false,"context_lines":[{"line_number":34,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"  - volumeAttachments: volumeAttachments"},{"line_number":37,"context_line":"  - device: device_resp"},{"line_number":38,"context_line":"  - id: attachment_id_resp"},{"line_number":39,"context_line":"  - serverId: server_id"},{"line_number":40,"context_line":"  - volumeId: volumeId_resp"}],"source_content_type":"text/x-c++src","patch_set":4,"id":"1aa78d24_f5cb0370","line":37,"range":{"start_line":37,"start_character":12,"end_line":37,"end_character":23},"updated":"2016-07-12 21:21:52.000000000","message":"Takashi Natsume has confirmed that the device in the response body is required.  I have made the change accordingly.","commit_id":"0e4e448bcf89004f0241e568a591b60315af1791"},{"author":{"_account_id":21111,"name":"STEW TY","email":"punsoca@gmail.com","username":"stewie925"},"change_message_id":"744d58e6cf8a1acfcc67aeff0157291e02654e78","unresolved":false,"context_lines":[{"line_number":78,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"  - volumeAttachment: volumeAttachment"},{"line_number":81,"context_line":"  - device: device_resp"},{"line_number":82,"context_line":"  - id: attachment_id_resp"},{"line_number":83,"context_line":"  - serverId: server_id"},{"line_number":84,"context_line":"  - volumeId: volumeId_resp"}],"source_content_type":"text/x-c++src","patch_set":4,"id":"1aa78d24_35990b7a","line":81,"range":{"start_line":81,"start_character":12,"end_line":81,"end_character":23},"updated":"2016-07-12 21:21:52.000000000","message":"Ditto","commit_id":"0e4e448bcf89004f0241e568a591b60315af1791"},{"author":{"_account_id":21111,"name":"STEW TY","email":"punsoca@gmail.com","username":"stewie925"},"change_message_id":"adc43458a201c0dce3e4428b5328a0b76d8e4dfc","unresolved":false,"context_lines":[{"line_number":78,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"  - volumeAttachment: volumeAttachment"},{"line_number":81,"context_line":"  - device: device_resp"},{"line_number":82,"context_line":"  - id: attachment_id_resp"},{"line_number":83,"context_line":"  - serverId: server_id"},{"line_number":84,"context_line":"  - volumeId: volumeId_resp"}],"source_content_type":"text/x-c++src","patch_set":4,"id":"1aa78d24_d5fc0774","line":81,"range":{"start_line":81,"start_character":12,"end_line":81,"end_character":23},"in_reply_to":"1aa78d24_35990b7a","updated":"2016-07-12 21:27:27.000000000","message":"Oops this is never changed.  Please ignore.","commit_id":"0e4e448bcf89004f0241e568a591b60315af1791"},{"author":{"_account_id":21111,"name":"STEW TY","email":"punsoca@gmail.com","username":"stewie925"},"change_message_id":"adc43458a201c0dce3e4428b5328a0b76d8e4dfc","unresolved":false,"context_lines":[{"line_number":114,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"  - volumeAttachment: volumeAttachment"},{"line_number":117,"context_line":"  - device: device_resp"},{"line_number":118,"context_line":"  - id: attachment_id_resp"},{"line_number":119,"context_line":"  - serverId: server_id"},{"line_number":120,"context_line":"  - volumeId: volumeId_resp"}],"source_content_type":"text/x-c++src","patch_set":4,"id":"1aa78d24_15d4cfe9","line":117,"range":{"start_line":117,"start_character":12,"end_line":117,"end_character":23},"updated":"2016-07-12 21:27:27.000000000","message":"Same change as in line 37 as the field is required.","commit_id":"0e4e448bcf89004f0241e568a591b60315af1791"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"647b75c7c3cd0419452b0921eadc164c19a3a7bb","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"  - server_id: server_id_path"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"Response"},{"line_number":32,"context_line":"--------"}],"source_content_type":"text/x-c++src","patch_set":5,"id":"dada55a8_b3180377","line":29,"updated":"2016-07-25 04:38:10.000000000","message":"It is an unnecessary change.","commit_id":"d2e521c469501972c64826f04b7a14412467d3d8"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"647b75c7c3cd0419452b0921eadc164c19a3a7bb","unresolved":false,"context_lines":[{"line_number":71,"context_line":".. literalinclude:: ../../doc/api_samples/os-volumes/attach-volume-to-server-req.json"},{"line_number":72,"context_line":"   :language: javascript"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"Response"},{"line_number":76,"context_line":"--------"},{"line_number":77,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":5,"id":"dada55a8_13262fba","line":74,"updated":"2016-07-25 04:38:10.000000000","message":"ditto.","commit_id":"d2e521c469501972c64826f04b7a14412467d3d8"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"29b0ede80c452dfa031534c1f86b0f3f38a1bf21","unresolved":false,"context_lines":[{"line_number":23,"context_line":"-------"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"  - server_id: server_id_path"},{"line_number":29,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":7,"id":"9a89bdaa_ed5c427f","line":26,"updated":"2016-09-12 23:08:56.000000000","message":"Why do we need 2 blank lines here..","commit_id":"a74f69f506b37d39a4de61f40c3bd860a5c119b5"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"29b0ede80c452dfa031534c1f86b0f3f38a1bf21","unresolved":false,"context_lines":[{"line_number":33,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"  - volumeAttachments: volumeAttachments"},{"line_number":36,"context_line":"  - device: device_resp"},{"line_number":37,"context_line":"  - id: attachment_id_resp"},{"line_number":38,"context_line":"  - serverId: server_id"},{"line_number":39,"context_line":"  - volumeId: volumeId_resp"}],"source_content_type":"text/x-c++src","patch_set":7,"id":"9a89bdaa_e02289a2","line":36,"range":{"start_line":36,"start_character":4,"end_line":36,"end_character":23},"updated":"2016-09-12 23:08:56.000000000","message":"LGTM based on https://github.com/openstack/tempest/blob/master/tempest/lib/api_schema/response/compute/v2_1/servers.py#L288","commit_id":"a74f69f506b37d39a4de61f40c3bd860a5c119b5"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"29b0ede80c452dfa031534c1f86b0f3f38a1bf21","unresolved":false,"context_lines":[{"line_number":59,"context_line":""},{"line_number":60,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"  - server_id: server_id_path"},{"line_number":64,"context_line":"  - volumeAttachment: volumeAttachment"},{"line_number":65,"context_line":"  - volumeId: volumeId"}],"source_content_type":"text/x-c++src","patch_set":7,"id":"9a89bdaa_edb8c277","line":62,"updated":"2016-09-12 23:08:56.000000000","message":"ditto","commit_id":"a74f69f506b37d39a4de61f40c3bd860a5c119b5"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"29b0ede80c452dfa031534c1f86b0f3f38a1bf21","unresolved":false,"context_lines":[{"line_number":102,"context_line":""},{"line_number":103,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"  - server_id: server_id_path"},{"line_number":107,"context_line":"  - attachment_id: attachment_id"},{"line_number":108,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":7,"id":"9a89bdaa_403255f3","line":105,"updated":"2016-09-12 23:08:56.000000000","message":"ditto","commit_id":"a74f69f506b37d39a4de61f40c3bd860a5c119b5"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"29b0ede80c452dfa031534c1f86b0f3f38a1bf21","unresolved":false,"context_lines":[{"line_number":138,"context_line":""},{"line_number":139,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"  - server_id: server_id_path"},{"line_number":143,"context_line":"  - attachment_id: attachment_id"},{"line_number":144,"context_line":"  - volumeAttachment: volumeAttachment"}],"source_content_type":"text/x-c++src","patch_set":7,"id":"9a89bdaa_804e1d6d","line":141,"updated":"2016-09-12 23:08:56.000000000","message":"ditto","commit_id":"a74f69f506b37d39a4de61f40c3bd860a5c119b5"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"29b0ede80c452dfa031534c1f86b0f3f38a1bf21","unresolved":false,"context_lines":[{"line_number":170,"context_line":""},{"line_number":171,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"  - server_id: server_id_path"},{"line_number":175,"context_line":"  - attachment_id: attachment_id"},{"line_number":176,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":7,"id":"9a89bdaa_c054a5ff","line":173,"updated":"2016-09-12 23:08:56.000000000","message":"ditto","commit_id":"a74f69f506b37d39a4de61f40c3bd860a5c119b5"}]}