)]}'
{"nova/scheduler/driver.py":[{"author":{"_account_id":7740,"name":"Andrew Forrest","email":"forrest@research.att.com","username":"forrest"},"change_message_id":"0e164880340052b010d7ab72d79565cb95c91763","unresolved":false,"context_lines":[{"line_number":61,"context_line":"        LOG.exception(_(\"Exception during scheduler.run_instance\"))"},{"line_number":62,"context_line":"    state \u003d vm_states.ERROR.upper()"},{"line_number":63,"context_line":"    LOG.warning(_(\u0027Setting instance to %(state)s state.\u0027),"},{"line_number":64,"context_line":"                {\u0027state\u0027: state}, instance_uuid\u003dinstance_uuid)"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    # update instance state and notify on the transition"},{"line_number":67,"context_line":"    (old_ref, new_ref) \u003d db.instance_update_and_get_original(context,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAPn%2F%2F3Aw%3D","line":64,"updated":"2013-06-19 16:38:39.000000000","message":"Please see inline comments about single arg format strings elsewhere in this review.","commit_id":"73a18173c5946ad5a6847e22bad282b49aaf33bc"}],"nova/scheduler/filters/aggregate_multitenancy_isolation.py":[{"author":{"_account_id":7740,"name":"Andrew Forrest","email":"forrest@research.att.com","username":"forrest"},"change_message_id":"0e164880340052b010d7ab72d79565cb95c91763","unresolved":false,"context_lines":[{"line_number":42,"context_line":"        if metadata !\u003d {}:"},{"line_number":43,"context_line":"            if tenant_id not in metadata[\"filter_tenant_id\"]:"},{"line_number":44,"context_line":"                LOG.debug(_(\"%(host_state)s fails tenant id on \""},{"line_number":45,"context_line":"                    \"aggregate\"), {\u0027host_state\u0027: host_state})"},{"line_number":46,"context_line":"                return False"},{"line_number":47,"context_line":"        return True"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAPn%2F%2F3Bg%3D","line":45,"updated":"2013-06-19 16:38:39.000000000","message":"For a single argument I prefer %s and arg.\nSee http://docs.openstack.org/developer/nova/devref/il8n.html for an example.","commit_id":"73a18173c5946ad5a6847e22bad282b49aaf33bc"}],"nova/scheduler/scheduler_options.py":[{"author":{"_account_id":7740,"name":"Andrew Forrest","email":"forrest@research.att.com","username":"forrest"},"change_message_id":"0e164880340052b010d7ab72d79565cb95c91763","unresolved":false,"context_lines":[{"line_number":78,"context_line":"            return json.load(handle)"},{"line_number":79,"context_line":"        except ValueError as e:"},{"line_number":80,"context_line":"            LOG.exception(_(\"Could not decode scheduler options: \u0027%(e)s\u0027\"),"},{"line_number":81,"context_line":"                          {\u0027e\u0027: e})"},{"line_number":82,"context_line":"            return {}"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"    def _get_time_now(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAPn%2F%2F3CE%3D","line":81,"updated":"2013-06-19 16:38:39.000000000","message":"Unless you anticipate additional arguments to the format string a simple %s and e would seem preferable.","commit_id":"73a18173c5946ad5a6847e22bad282b49aaf33bc"}]}