)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":17288,"name":"liuxiuli","email":"liu.lixiu@zte.com.cn","username":"liu-lixiu"},"change_message_id":"8048b1dab4f269bcc0d3caffe672c391278482c2","unresolved":false,"context_lines":[{"line_number":9,"context_line":"After block live-migration, instance\u0027s cleaned was set True. It"},{"line_number":10,"context_line":"was not consistent with instance\u0027s deleted value that was False."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"This patch modify this problem, after delete instace\u0027s files on"},{"line_number":13,"context_line":"source or destination compute node while instance live-migration,"},{"line_number":14,"context_line":"the value of instance\u0027s cleaned is False."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Closes-Bug:#1598353"},{"line_number":17,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1aa78d24_381f80b8","line":14,"range":{"start_line":12,"start_character":0,"end_line":14,"end_character":41},"updated":"2016-07-06 06:39:35.000000000","message":"Problem is cleaned value is error or we should delete files according to the flag?","commit_id":"2fcb2a79d18e2d735415b031f80e432e225482d7"},{"author":{"_account_id":12813,"name":"Rong Han","email":"han.rong3@zte.com.cn","username":"hanrong-zte"},"change_message_id":"e2d07e3e86f0bd34062d112a5c43006cacdec737","unresolved":false,"context_lines":[{"line_number":9,"context_line":"After block live-migration, instance\u0027s cleaned was set True. It"},{"line_number":10,"context_line":"was not consistent with instance\u0027s deleted value that was False."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"This patch modify this problem, after delete instace\u0027s files on"},{"line_number":13,"context_line":"source or destination compute node while instance live-migration,"},{"line_number":14,"context_line":"the value of instance\u0027s cleaned is False."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Closes-Bug:#1598353"},{"line_number":17,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1aa78d24_69f01c68","line":14,"range":{"start_line":12,"start_character":0,"end_line":14,"end_character":41},"in_reply_to":"1aa78d24_381f80b8","updated":"2016-07-06 07:45:33.000000000","message":"yes, the periodic_task of _run_pending_deletes will search instances which are \"deleted\" value is True and \"cleaned\" value is False to clean their files.\nin nova/compute/manager\n@periodic_task.periodic_task(spacing\u003dCONF.instance_delete_interval)\ndef _run_pending_deletes(self, context):\n    filters \u003d {\u0027deleted\u0027: True,\n                   \u0027soft_deleted\u0027: False,\n                   \u0027host\u0027: CONF.host,\n                   \u0027cleaned\u0027: False}","commit_id":"2fcb2a79d18e2d735415b031f80e432e225482d7"}],"nova/tests/unit/virt/libvirt/test_driver.py":[{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"c9d62feeb8b68d02274e6b786c6c7c9b2a12c5a2","unresolved":false,"context_lines":[{"line_number":13721,"context_line":"            self.context, instance, network_info\u003d{}, destroy_disks\u003dFalse,"},{"line_number":13722,"context_line":"            migrate_data\u003dmigrate_data, destroy_vifs\u003dFalse)"},{"line_number":13723,"context_line":"        delete_instance_files.assert_called_once_with(instance)"},{"line_number":13724,"context_line":"        self.assertEqual(0, int(instance.system_metadata[\u0027clean_attempts\u0027]))"},{"line_number":13725,"context_line":"        self.assertFalse(instance.cleaned)"},{"line_number":13726,"context_line":"        save.assert_not_called()"},{"line_number":13727,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1aa78d24_2e61fad3","line":13724,"updated":"2016-07-06 07:12:40.000000000","message":"We should reflect this behavior for rollback_live_migation_at_destination too","commit_id":"2fcb2a79d18e2d735415b031f80e432e225482d7"}],"nova/virt/libvirt/driver.py":[{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"ceb1af58dcbd822f1700b06bde1e036a34695b16","unresolved":false,"context_lines":[{"line_number":963,"context_line":"        is_shared_block_storage \u003d False"},{"line_number":964,"context_line":"        if migrate_data and \u0027is_shared_block_storage\u0027 in migrate_data:"},{"line_number":965,"context_line":"            is_shared_block_storage \u003d migrate_data.is_shared_block_storage"},{"line_number":966,"context_line":"        if destroy_disks or is_shared_block_storage:"},{"line_number":967,"context_line":"            attempts \u003d int(instance.system_metadata.get(\u0027clean_attempts\u0027,"},{"line_number":968,"context_line":"                                                        \u00270\u0027))"},{"line_number":969,"context_line":"            success \u003d self.delete_instance_files(instance)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1aa78d24_6e914247","side":"PARENT","line":966,"updated":"2016-07-06 07:21:29.000000000","message":"I\u0027m just not sure about why do we have to pass here in case of migrate...","commit_id":"99b6b0531ee1b7b3e8b0085454dc8863bd122bc6"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"ba2d90fc4ff0b035ab3a4b0b42c9aed3e82362be","unresolved":false,"context_lines":[{"line_number":967,"context_line":"            attempts \u003d int(instance.system_metadata.get(\u0027clean_attempts\u0027,"},{"line_number":968,"context_line":"                                                        \u00270\u0027))"},{"line_number":969,"context_line":"            success \u003d self.delete_instance_files(instance)"},{"line_number":970,"context_line":"            # NOTE(mriedem): This is used in the _run_pending_deletes periodic"},{"line_number":971,"context_line":"            # task in the compute manager. The tight coupling is not great..."},{"line_number":972,"context_line":"            instance.system_metadata[\u0027clean_attempts\u0027] \u003d str(attempts + 1)"},{"line_number":973,"context_line":"            if success:"}],"source_content_type":"text/x-python","patch_set":2,"id":"1aa78d24_0ec4fe5c","side":"PARENT","line":970,"updated":"2016-07-06 07:20:37.000000000","message":"This periodic task is filtering on instances deleted so we are good","commit_id":"99b6b0531ee1b7b3e8b0085454dc8863bd122bc6"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"c9d62feeb8b68d02274e6b786c6c7c9b2a12c5a2","unresolved":false,"context_lines":[{"line_number":965,"context_line":"            is_shared_block_storage \u003d migrate_data.is_shared_block_storage"},{"line_number":966,"context_line":"        if destroy_disks or is_shared_block_storage:"},{"line_number":967,"context_line":"            success \u003d self.delete_instance_files(instance)"},{"line_number":968,"context_line":"            if not migrate_data:"},{"line_number":969,"context_line":"                self._set_instance_clean_flags(instance, success)"},{"line_number":970,"context_line":""},{"line_number":971,"context_line":"        self._undefine_domain(instance)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1aa78d24_2e1c5a69","line":968,"updated":"2016-07-06 07:12:40.000000000","message":"That method is called with migrate_data for post_live_migration and rollback_at_destination and for both of this case we don\u0027t want cleaned to be set. Sounds good for me.\n\nCan you add comment under this condition to avoid any interrogations?","commit_id":"2fcb2a79d18e2d735415b031f80e432e225482d7"}]}