)]}'
{"nova/compute/manager.py":[{"author":{"_account_id":1678,"name":"Tiantian Gao","email":"gtt116@gmail.com","username":"gtt116"},"change_message_id":"af749a49e575be40c0bdf2b6f03f97ebee5d7591","unresolved":false,"context_lines":[{"line_number":4185,"context_line":"                        self._shutdown_instance(context, instance, bdms)"},{"line_number":4186,"context_line":"                        self._cleanup_volumes(context, instance[\u0027uuid\u0027], bdms)"},{"line_number":4187,"context_line":"                    except Exception:"},{"line_number":4188,"context_line":"                        pass"},{"line_number":4189,"context_line":"                else:"},{"line_number":4190,"context_line":"                    raise Exception(_(\"Unrecognized value \u0027%s\u0027\""},{"line_number":4191,"context_line":"                                      \" for CONF.running_deleted_\""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAPn%2F%2FrUk%3D","line":4188,"updated":"2013-06-25 13:48:31.000000000","message":"How about logging the traceback, then we can exactly know what was going wrong.","commit_id":"05092a418778388b776cd09fd8df11584cd11754"},{"author":{"_account_id":6450,"name":"Hans Lindgren","email":"hanlind@kth.se","username":"hanlind"},"change_message_id":"3fd73d0a7e6b61841118795b8f3a5ec77737aa12","unresolved":false,"context_lines":[{"line_number":4185,"context_line":"                        self._shutdown_instance(context, instance, bdms)"},{"line_number":4186,"context_line":"                        self._cleanup_volumes(context, instance[\u0027uuid\u0027], bdms)"},{"line_number":4187,"context_line":"                    except Exception:"},{"line_number":4188,"context_line":"                        pass"},{"line_number":4189,"context_line":"                else:"},{"line_number":4190,"context_line":"                    raise Exception(_(\"Unrecognized value \u0027%s\u0027\""},{"line_number":4191,"context_line":"                                      \" for CONF.running_deleted_\""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAPn%2F%2FoGQ%3D","line":4188,"in_reply_to":"AAAAPn%2F%2FrUk%3D","updated":"2013-06-26 13:50:49.000000000","message":"Done","commit_id":"05092a418778388b776cd09fd8df11584cd11754"},{"author":{"_account_id":7494,"name":"Guangya Liu","email":"gyliu513@gmail.com","username":"JayLau"},"change_message_id":"d966006148dd50922aff8c85a9226ae18c5a078e","unresolved":false,"context_lines":[{"line_number":4187,"context_line":"                    except Exception as e:"},{"line_number":4188,"context_line":"                        LOG.warning(_(\"Periodic cleanup failed to delete \""},{"line_number":4189,"context_line":"                                      \"instance: %s\"),"},{"line_number":4190,"context_line":"                                    unicode(e), instance\u003dinstance)"},{"line_number":4191,"context_line":"                else:"},{"line_number":4192,"context_line":"                    raise Exception(_(\"Unrecognized value \u0027%s\u0027\""},{"line_number":4193,"context_line":"                                      \" for CONF.running_deleted_\""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAPn%2F%2FmWw%3D","line":4190,"updated":"2013-06-26 23:49:39.000000000","message":"How about improve log to add instance name here?","commit_id":"941984e6aba8e8169bbce82bfa40bf2c827a114a"},{"author":{"_account_id":7494,"name":"Guangya Liu","email":"gyliu513@gmail.com","username":"JayLau"},"change_message_id":"34b1b88673de40767eaf87d8b47e0f7a6cb98140","unresolved":false,"context_lines":[{"line_number":4187,"context_line":"                    except Exception as e:"},{"line_number":4188,"context_line":"                        LOG.warning(_(\"Periodic cleanup failed to delete \""},{"line_number":4189,"context_line":"                                      \"instance: %s\"),"},{"line_number":4190,"context_line":"                                    unicode(e), instance\u003dinstance)"},{"line_number":4191,"context_line":"                else:"},{"line_number":4192,"context_line":"                    raise Exception(_(\"Unrecognized value \u0027%s\u0027\""},{"line_number":4193,"context_line":"                                      \" for CONF.running_deleted_\""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAPn%2F%2Flwg%3D","line":4190,"in_reply_to":"AAAAPn%2F%2Fl1k%3D","updated":"2013-06-27 07:39:41.000000000","message":"Yes, but i was curious for the syntax.\nLOG.warning(_(\"Periodic cleanup failed to delete \"\n                                \"instance: %s\"),\n                                 unicode(e), instance\u003dinstance)\n\nI want to know the %s in \" instance: %s\"),\" would print out the exception or instance uuid? Thanks.","commit_id":"941984e6aba8e8169bbce82bfa40bf2c827a114a"},{"author":{"_account_id":7494,"name":"Guangya Liu","email":"gyliu513@gmail.com","username":"JayLau"},"change_message_id":"aebdd8c41c93ea086f4e75fc335b3fa5d56fba7b","unresolved":false,"context_lines":[{"line_number":4187,"context_line":"                    except Exception as e:"},{"line_number":4188,"context_line":"                        LOG.warning(_(\"Periodic cleanup failed to delete \""},{"line_number":4189,"context_line":"                                      \"instance: %s\"),"},{"line_number":4190,"context_line":"                                    unicode(e), instance\u003dinstance)"},{"line_number":4191,"context_line":"                else:"},{"line_number":4192,"context_line":"                    raise Exception(_(\"Unrecognized value \u0027%s\u0027\""},{"line_number":4193,"context_line":"                                      \" for CONF.running_deleted_\""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAPn%2F%2FlIE%3D","line":4190,"in_reply_to":"AAAAPn%2F%2FlMk%3D","updated":"2013-06-27 12:36:01.000000000","message":"Got it. Thanks.","commit_id":"941984e6aba8e8169bbce82bfa40bf2c827a114a"},{"author":{"_account_id":6450,"name":"Hans Lindgren","email":"hanlind@kth.se","username":"hanlind"},"change_message_id":"78f6e1c4af027cfb3512aece28cff52bc68c844d","unresolved":false,"context_lines":[{"line_number":4187,"context_line":"                    except Exception as e:"},{"line_number":4188,"context_line":"                        LOG.warning(_(\"Periodic cleanup failed to delete \""},{"line_number":4189,"context_line":"                                      \"instance: %s\"),"},{"line_number":4190,"context_line":"                                    unicode(e), instance\u003dinstance)"},{"line_number":4191,"context_line":"                else:"},{"line_number":4192,"context_line":"                    raise Exception(_(\"Unrecognized value \u0027%s\u0027\""},{"line_number":4193,"context_line":"                                      \" for CONF.running_deleted_\""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAPn%2F%2FlMk%3D","line":4190,"in_reply_to":"AAAAPn%2F%2Flwg%3D","updated":"2013-06-27 12:07:28.000000000","message":"So, the %s is for the exception message, but since instance is passed as a kwarg, the instance uuid will be logged together with the message.","commit_id":"941984e6aba8e8169bbce82bfa40bf2c827a114a"},{"author":{"_account_id":6450,"name":"Hans Lindgren","email":"hanlind@kth.se","username":"hanlind"},"change_message_id":"039152b7db35c8e7416cae89415fa31e2f3b47a0","unresolved":false,"context_lines":[{"line_number":4187,"context_line":"                    except Exception as e:"},{"line_number":4188,"context_line":"                        LOG.warning(_(\"Periodic cleanup failed to delete \""},{"line_number":4189,"context_line":"                                      \"instance: %s\"),"},{"line_number":4190,"context_line":"                                    unicode(e), instance\u003dinstance)"},{"line_number":4191,"context_line":"                else:"},{"line_number":4192,"context_line":"                    raise Exception(_(\"Unrecognized value \u0027%s\u0027\""},{"line_number":4193,"context_line":"                                      \" for CONF.running_deleted_\""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAPn%2F%2Fl1k%3D","line":4190,"in_reply_to":"AAAAPn%2F%2FmWw%3D","updated":"2013-06-27 07:06:57.000000000","message":"This is not anything the end user will ever see. Logging the instance uuid should be enough, right?","commit_id":"941984e6aba8e8169bbce82bfa40bf2c827a114a"}]}