)]}'
{"nova/tests/unit/virt/libvirt/test_driver.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"d51b1deb085e816ebdad0228ffdf56cd6a2d79ce","unresolved":false,"context_lines":[{"line_number":15657,"context_line":"            root_disk.resize.assert_called_once_with("},{"line_number":15658,"context_line":"                instance.root_gb * units.Gi)"},{"line_number":15659,"context_line":""},{"line_number":15660,"context_line":"            # NOTE(mdbooth): Resize of ephemeral disks doesn\u0027t work, and this"},{"line_number":15661,"context_line":"            # test doesn\u0027t highlight this. This test is asserting that"},{"line_number":15662,"context_line":"            # \u0027disk.local\u0027, which is an implicit ephemeral disk with no BDM, is"},{"line_number":15663,"context_line":"            # correctly resized. However, this disk is never created in"},{"line_number":15664,"context_line":"            # practise because ephemeral disks always have a BDM created for"},{"line_number":15665,"context_line":"            # them. Resize of ephemeral disks from BDMs is not working, because"},{"line_number":15666,"context_line":"            # BDMs aren\u0027t resized in ComputeManager._finish_resize with the"},{"line_number":15667,"context_line":"            # instance properties. Consequently we resize, but explicitly to"},{"line_number":15668,"context_line":"            # the original size. This is neither a regression nor a test"},{"line_number":15669,"context_line":"            # regression because this has never worked and has never been"},{"line_number":15670,"context_line":"            # tested.  We should update this test to explicitly pass in BDMs"},{"line_number":15671,"context_line":"            # when we fix the BDM resize issue, and explicitly test it."},{"line_number":15672,"context_line":"            #"},{"line_number":15673,"context_line":"            # See https://bugs.launchpad.net/nova/+bug/1594377"},{"line_number":15674,"context_line":"            ephemeral.resize.assert_called_once_with(instance.ephemeral_gb *"},{"line_number":15675,"context_line":"                                                     units.Gi)"},{"line_number":15676,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":4,"id":"1aa78d24_4fc0fb2a","line":15673,"range":{"start_line":15660,"start_character":0,"end_line":15673,"end_character":62},"updated":"2016-07-05 09:14:24.000000000","message":"Might be helpful to link to this test in said bug report, so that it can be fixed in the future","commit_id":"35e97c0a14a7ee6a99ab44f53c55791497830e9b"},{"author":{"_account_id":8768,"name":"Chris Friesen","email":"chris.friesen@windriver.com","username":"cbf123"},"change_message_id":"b4021028adb810aa8fd4d9cfa777bbe524194f88","unresolved":false,"context_lines":[{"line_number":15780,"context_line":"            # test doesn\u0027t highlight this. This test is asserting that"},{"line_number":15781,"context_line":"            # \u0027disk.local\u0027, which is an implicit ephemeral disk with no BDM, is"},{"line_number":15782,"context_line":"            # correctly resized. However, this disk is never created in"},{"line_number":15783,"context_line":"            # practise because ephemeral disks always have a BDM created for"},{"line_number":15784,"context_line":"            # them. Resize of ephemeral disks from BDMs is not working, because"},{"line_number":15785,"context_line":"            # BDMs aren\u0027t resized in ComputeManager._finish_resize with the"},{"line_number":15786,"context_line":"            # instance properties. Consequently we resize, but explicitly to"}],"source_content_type":"text/x-python","patch_set":10,"id":"dada55a8_a2ca8b6c","line":15783,"updated":"2016-07-22 20:48:00.000000000","message":"Nit: should be \"in practice\", I think.  (Even in British English.)","commit_id":"4a051cfe3ce5ca58c5912387e9aca2266118abb7"}],"nova/virt/libvirt/driver.py":[{"author":{"_account_id":8768,"name":"Chris Friesen","email":"chris.friesen@windriver.com","username":"cbf123"},"change_message_id":"5dabd694a434372bf5bb3848f3968a586ad656c7","unresolved":false,"context_lines":[{"line_number":7155,"context_line":"            root_disk.ensure_backing()"},{"line_number":7156,"context_line":""},{"line_number":7157,"context_line":"            # We snapshot the root disk before modifying it"},{"line_number":7158,"context_line":"            root_disk.create_snap(libvirt_utils.RESIZE_SNAPSHOT_NAME)"},{"line_number":7159,"context_line":""},{"line_number":7160,"context_line":"            if resize_instance:"},{"line_number":7161,"context_line":"                root_disk.resize(instance.flavor.root_gb * units.Gi)"}],"source_content_type":"text/x-python","patch_set":17,"id":"9a57fde8_2a878062","line":7158,"range":{"start_line":7158,"start_character":34,"end_line":7158,"end_character":47},"updated":"2017-01-12 16:16:05.000000000","message":"This question is not specific to these changes, but why do we need to snapshot the disk for the case where we are migrating/resizing to a different host?  Is it just simpler to do it unconditionally even if not necessary?","commit_id":"d26a86ed872550f081b254b39a173c65213de3e7"},{"author":{"_account_id":8768,"name":"Chris Friesen","email":"chris.friesen@windriver.com","username":"cbf123"},"change_message_id":"a45c6b6b55a0946ca3e95d108c1aa83857a3956d","unresolved":false,"context_lines":[{"line_number":7155,"context_line":"            root_disk.ensure_backing()"},{"line_number":7156,"context_line":""},{"line_number":7157,"context_line":"            # We snapshot the root disk before modifying it"},{"line_number":7158,"context_line":"            root_disk.create_snap(libvirt_utils.RESIZE_SNAPSHOT_NAME)"},{"line_number":7159,"context_line":""},{"line_number":7160,"context_line":"            if resize_instance:"},{"line_number":7161,"context_line":"                root_disk.resize(instance.flavor.root_gb * units.Gi)"}],"source_content_type":"text/x-python","patch_set":17,"id":"7a3c09a3_8dcf96af","line":7158,"range":{"start_line":7158,"start_character":34,"end_line":7158,"end_character":47},"in_reply_to":"7a3c09a3_03bc6b6b","updated":"2017-01-13 16:27:01.000000000","message":"For future reference, as per Matthew Booth on IRC root_disk.create_snap() is a no-op for most cases, but is used for Rbd rollback.","commit_id":"d26a86ed872550f081b254b39a173c65213de3e7"},{"author":{"_account_id":9555,"name":"Matthew Booth","email":"mbooth@redhat.com","username":"MatthewBooth"},"change_message_id":"e408025a62801a08b29dbd06e25966cef1fc2bbd","unresolved":false,"context_lines":[{"line_number":7155,"context_line":"            root_disk.ensure_backing()"},{"line_number":7156,"context_line":""},{"line_number":7157,"context_line":"            # We snapshot the root disk before modifying it"},{"line_number":7158,"context_line":"            root_disk.create_snap(libvirt_utils.RESIZE_SNAPSHOT_NAME)"},{"line_number":7159,"context_line":""},{"line_number":7160,"context_line":"            if resize_instance:"},{"line_number":7161,"context_line":"                root_disk.resize(instance.flavor.root_gb * units.Gi)"}],"source_content_type":"text/x-python","patch_set":17,"id":"7a3c09a3_03bc6b6b","line":7158,"range":{"start_line":7158,"start_character":34,"end_line":7158,"end_character":47},"in_reply_to":"9a57fde8_2a878062","updated":"2017-01-13 10:37:50.000000000","message":"Not sure I understand the question. Under what other circumstances would we create a snapshot?","commit_id":"d26a86ed872550f081b254b39a173c65213de3e7"}]}