)]}'
{"nova/virt/libvirt/driver.py":[{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"fdaf2f421ad002e8d654e2d72a62ccd37bc7e5b1","unresolved":false,"context_lines":[{"line_number":1607,"context_line":"                        snapshot_backend.snapshot_extract(out_path,"},{"line_number":1608,"context_line":"                                                          image_format)"},{"line_number":1609,"context_line":"                except libvirt.libvirtError as ex:"},{"line_number":1610,"context_line":"                    error_code \u003d ex.get_error_code()"},{"line_number":1611,"context_line":"                    msg \u003d (_(\u0027Error from libvirt while instance create \u0027"},{"line_number":1612,"context_line":"                             \u0027snapshot: [Error Code %(error_code)s] %(ex)s\u0027)"},{"line_number":1613,"context_line":"                           % {\u0027error_code\u0027: error_code, \u0027ex\u0027: ex})"}],"source_content_type":"text/x-python","patch_set":6,"id":"1aa78d24_b792e349","line":1610,"range":{"start_line":1610,"start_character":20,"end_line":1610,"end_character":52},"updated":"2016-07-08 01:38:38.000000000","message":"I didn\u0027t think we should continue upload the image in line 1616, as we can\u0027t ensure the snapshot is finished. And we may needs some cleanup.","commit_id":"c336835c4a447eb9f5eb2d26bd0c269db92f8354"},{"author":{"_account_id":17532,"name":"Tina Kevin","email":"song.ruixia@zte.com.cn","username":"SongRuixia"},"change_message_id":"7c03385ac88e2492030c80e2adf76bb65d7a425d","unresolved":false,"context_lines":[{"line_number":1607,"context_line":"                        snapshot_backend.snapshot_extract(out_path,"},{"line_number":1608,"context_line":"                                                          image_format)"},{"line_number":1609,"context_line":"                except libvirt.libvirtError as ex:"},{"line_number":1610,"context_line":"                    error_code \u003d ex.get_error_code()"},{"line_number":1611,"context_line":"                    msg \u003d (_(\u0027Error from libvirt while instance create \u0027"},{"line_number":1612,"context_line":"                             \u0027snapshot: [Error Code %(error_code)s] %(ex)s\u0027)"},{"line_number":1613,"context_line":"                           % {\u0027error_code\u0027: error_code, \u0027ex\u0027: ex})"}],"source_content_type":"text/x-python","patch_set":6,"id":"1aa78d24_6d19cc79","line":1610,"range":{"start_line":1610,"start_character":20,"end_line":1610,"end_character":52},"in_reply_to":"1aa78d24_b792e349","updated":"2016-07-08 02:39:25.000000000","message":"If there is libvirterror and raise, it cannot continue upload the image, the case that there has no error will upload the image. I think the code is right.\n\nThere really should be add some cleanup for error case.","commit_id":"c336835c4a447eb9f5eb2d26bd0c269db92f8354"}]}