)]}'
{"nova/api/openstack/compute/contrib/consoles.py":[{"author":{"_account_id":1812,"name":"p-draigbrady","email":"P@draigBrady.com","username":"p-draigbrady"},"change_message_id":"19a4039d889d608260a20ffed0a3ea53e63c334f","unresolved":false,"context_lines":[{"line_number":41,"context_line":"            console_type \u003d body[\u0027os-getVNCConsole\u0027].get(\u0027type\u0027)"},{"line_number":42,"context_line":"        except KeyError:"},{"line_number":43,"context_line":"            console_type \u003d \"novnc\""},{"line_number":44,"context_line":"            pass"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"        try:"},{"line_number":47,"context_line":"            instance \u003d self.compute_api.get(context, id)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAPn%2F%2F1wU%3D","line":44,"updated":"2013-06-20 01:16:38.000000000","message":"This \"pass\" is redundant.\n\nYou mightn\u0027t need an exception anyway as the python idiom for get() or \"default\" is:\n\n    console_type \u003d body[...].get(\u0027type\u0027, \u0027novnc\u0027)","commit_id":"11661e2171ea93a9c7b438dfe51fc387b8a90f2e"},{"author":{"_account_id":1525,"name":"Rafi Khardalian","email":"rafi@metacloud.com","username":"rkhardalian"},"change_message_id":"6fde803989d66a6cce698e662cc610ca5c7c2700","unresolved":false,"context_lines":[{"line_number":41,"context_line":"            console_type \u003d body[\u0027os-getVNCConsole\u0027].get(\u0027type\u0027)"},{"line_number":42,"context_line":"        except KeyError:"},{"line_number":43,"context_line":"            console_type \u003d \"novnc\""},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"        try:"},{"line_number":46,"context_line":"            instance \u003d self.compute_api.get(context, id)"},{"line_number":47,"context_line":"            output \u003d self.compute_api.get_vnc_console(context,"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAPn%2F%2F1Fs%3D","line":44,"updated":"2013-06-20 08:17:59.000000000","message":"The reason I\u0027m using try/except as opposed to a default value on get() is that the body dict won\u0027t even contain \u0027os-getVNCConsole\u0027, since we would have just come from the Spice function.","commit_id":"071d3cb42c87d48ff1c554a4bc61c0f91f6fdb4c"},{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"aeac710212328a23b9bec2187ce18b784b7f67c2","unresolved":false,"context_lines":[{"line_number":74,"context_line":"        except exception.InstanceNotReady as e:"},{"line_number":75,"context_line":"            raise webob.exc.HTTPConflict(explanation\u003de.format_message())"},{"line_number":76,"context_line":"        except exception.ConsoleTypeUnavailable:"},{"line_number":77,"context_line":"            return self.get_vnc_console(req, id, body)"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"        return {\u0027console\u0027: {\u0027type\u0027: console_type, \u0027url\u0027: output[\u0027url\u0027]}}"},{"line_number":80,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAPn%2F%2FopM%3D","line":77,"updated":"2013-06-26 09:24:26.000000000","message":"This is completely wrong. The \u0027get_spice_console\u0027 method  absolutely must *NOT* return information on a VNC console. They are completely separate protocols which are not at all compatible. If the caller wants to support VNC, they can simply call \u0027get_vnc_console\u0027 themselves if they were unable to get the spice console details.","commit_id":"071d3cb42c87d48ff1c554a4bc61c0f91f6fdb4c"}]}