)]}'
{"nova/compute/api.py":[{"author":{"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},"change_message_id":"2d63c36f893ccdde5b461df3047bf2f1745ab877","unresolved":false,"context_lines":[{"line_number":2471,"context_line":"        all_instance_metadata \u003d self.db.instance_metadata_get_all(context,"},{"line_number":2472,"context_line":"                                                                  search_filts)"},{"line_number":2473,"context_line":"        search_opts \u003d {\u0027deleted\u0027: False}"},{"line_number":2474,"context_line":"        instances \u003d self.get_all(context, search_opts\u003dsearch_opts)"},{"line_number":2475,"context_line":"        my_name \u003d self.get_all_instance_metadata.__name__"},{"line_number":2476,"context_line":"        return_set \u003d []"},{"line_number":2477,"context_line":"        uuid_to_instance \u003d dict(map(lambda(x): (x.get(\u0027uuid\u0027), x), instances))"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAPn%2F%2FY7E%3D","line":2474,"updated":"2013-07-02 20:56:26.000000000","message":"Wow, this is really going to suck.  Although it\u0027s limited to EC2 API only.   Do we really need to pass \u0027instance\u0027 to target?   It seems like this would be much better with just {} as target.  Ie, just remove the @wrap_check_policy and have this as the first line:\n\ncheck_policy(context, \u0027get_all_instance_metadata\u0027, {})","commit_id":"e371f51c7b31aeb1eddefe59df3684278e6ff893"},{"author":{"_account_id":6661,"name":"Burt Holzman","email":"holzman@gmail.com","username":"burt"},"change_message_id":"75cd158d70ce93ce1f72b63e23278592354dc641","unresolved":false,"context_lines":[{"line_number":2471,"context_line":"        all_instance_metadata \u003d self.db.instance_metadata_get_all(context,"},{"line_number":2472,"context_line":"                                                                  search_filts)"},{"line_number":2473,"context_line":"        search_opts \u003d {\u0027deleted\u0027: False}"},{"line_number":2474,"context_line":"        instances \u003d self.get_all(context, search_opts\u003dsearch_opts)"},{"line_number":2475,"context_line":"        my_name \u003d self.get_all_instance_metadata.__name__"},{"line_number":2476,"context_line":"        return_set \u003d []"},{"line_number":2477,"context_line":"        uuid_to_instance \u003d dict(map(lambda(x): (x.get(\u0027uuid\u0027), x), instances))"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAPn%2F%2FYxc%3D","line":2474,"in_reply_to":"AAAAPn%2F%2FY7E%3D","updated":"2013-07-02 21:27:52.000000000","message":"I disagree, that would be even more broken. The default policy is admin_or_owner -- so that policy check would only succeed for admin since it\u0027s comparing the metadata owner against None. We\u0027d be better off removing the policy check entirely, but that also seems wrong. Should user A be able to fetch user B\u0027s metadata? (I don\u0027t think you can in EC2).\n\nThis isn\u0027t terrific, but I don\u0027t see a better way.","commit_id":"e371f51c7b31aeb1eddefe59df3684278e6ff893"}]}