)]}'
{"nova/tests/unit/api/openstack/compute/test_server_diagnostics.py":[{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"b4311c1e33774dfaf9a652b56affd37e78cdd6cd","unresolved":false,"context_lines":[{"line_number":80,"context_line":"        self.assertEqual(409, res.status_int)"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"    @mock.patch.object(compute_api.API, \u0027get_diagnostics\u0027,"},{"line_number":83,"context_line":"                       side_effect\u003dexception.InstanceNotReady(\u0027fake message\u0027))"},{"line_number":84,"context_line":"    @mock.patch.object(compute_api.API, \u0027get\u0027, fake_instance_get)"},{"line_number":85,"context_line":"    def test_get_diagnostics_raise_instance_not_ready(self,"},{"line_number":86,"context_line":"                      mock_get_diagnostics):"}],"source_content_type":"text/x-python","patch_set":1,"id":"1aa78d24_eddc1775","line":83,"updated":"2016-07-06 07:54:22.000000000","message":"I prefer you fake instance with None value in the host field. Otherwise, without your fix, this unittest still can pass.","commit_id":"36da13b4e05ffaf9afab9d715ba4a619cde29c28"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"64cb089d71beb4bb352a7a7289271bce440aa447","unresolved":false,"context_lines":[{"line_number":81,"context_line":"        self.assertEqual(409, res.status_int)"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"    @mock.patch.object(compute_api.API, \u0027get\u0027)"},{"line_number":84,"context_line":"    def test_get_diagnostics_raise_instance_not_ready(self, mock_get):"},{"line_number":85,"context_line":"        mock_get.return_value \u003d fake_instance.fake_instance_obj("},{"line_number":86,"context_line":"            \u0027context\u0027, uuid\u003dUUID, host\u003dNone)"},{"line_number":87,"context_line":"        req \u003d self._get_request()"}],"source_content_type":"text/x-python","patch_set":2,"id":"1aa78d24_dc6c6737","line":84,"range":{"start_line":84,"start_character":8,"end_line":84,"end_character":53},"updated":"2016-07-06 09:37:53.000000000","message":"I prefer to separate 2 cases \nunit test is to make code test on specified code branch....\nmaybe a test for the api layer and another for compute api layer?","commit_id":"009e013fec442d9b563f46546887c2640cd45df8"},{"author":{"_account_id":12175,"name":"Eli Qiao","email":"qiaoliyong@gmail.com","username":"Eli"},"change_message_id":"f938f719ad39708c9617f7f2f4e06079023cb748","unresolved":false,"context_lines":[{"line_number":81,"context_line":"        self.assertEqual(409, res.status_int)"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"    @mock.patch.object(compute_api.API, \u0027get\u0027)"},{"line_number":84,"context_line":"    def test_get_diagnostics_raise_instance_not_ready(self, mock_get):"},{"line_number":85,"context_line":"        mock_get.return_value \u003d fake_instance.fake_instance_obj("},{"line_number":86,"context_line":"            \u0027context\u0027, uuid\u003dUUID, host\u003dNone)"},{"line_number":87,"context_line":"        req \u003d self._get_request()"}],"source_content_type":"text/x-python","patch_set":2,"id":"1aa78d24_482083f7","line":84,"range":{"start_line":84,"start_character":8,"end_line":84,"end_character":53},"in_reply_to":"1aa78d24_dc6c6737","updated":"2016-07-07 02:11:55.000000000","message":"Done","commit_id":"009e013fec442d9b563f46546887c2640cd45df8"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"e12b4d3663d23503ee6ce5eba343151b3c678f47","unresolved":false,"context_lines":[{"line_number":83,"context_line":"    @mock.patch.object(compute_api.API, \u0027get\u0027)"},{"line_number":84,"context_line":"    def test_get_diagnostics_raise_instance_not_ready(self, mock_get):"},{"line_number":85,"context_line":"        mock_get.return_value \u003d fake_instance.fake_instance_obj("},{"line_number":86,"context_line":"            \u0027context\u0027, uuid\u003dUUID, host\u003dNone)"},{"line_number":87,"context_line":"        req \u003d self._get_request()"},{"line_number":88,"context_line":"        res \u003d req.get_response(self.router)"},{"line_number":89,"context_line":"        self.assertEqual(409, res.status_int)"}],"source_content_type":"text/x-python","patch_set":3,"id":"1aa78d24_7fa1b2f7","line":86,"updated":"2016-07-07 02:59:34.000000000","message":"we don\u0027t need this , just mock the get_diagnostic should be fine","commit_id":"ab4f6dab481ef8e9225dada8c2b33afb2cbaafb0"}]}