)]}'
{"tox.ini":[{"author":{"_account_id":18602,"name":"Gábor Antal","email":"antal@inf.u-szeged.hu","username":"antal"},"change_message_id":"58db25a009c8fdea57f2d8ffa015f25a7cbcf1c1","unresolved":false,"context_lines":[{"line_number":7,"context_line":"usedevelop \u003d True"},{"line_number":8,"context_line":"# tox is silly... these need to be separated by a newline...."},{"line_number":9,"context_line":"whitelist_externals \u003d bash"},{"line_number":10,"context_line":"                      find"},{"line_number":11,"context_line":"                      rm"},{"line_number":12,"context_line":"install_command \u003d pip install -c{env:UPPER_CONSTRAINTS_FILE:https://git.openstack.org/cgit/openstack/requirements/plain/upper-constraints.txt} {opts} {packages}"},{"line_number":13,"context_line":"setenv \u003d VIRTUAL_ENV\u003d{envdir}"}],"source_content_type":"text/x-properties","patch_set":1,"id":"1aa78d24_4ba88fdb","line":10,"range":{"start_line":10,"start_character":22,"end_line":10,"end_character":26},"updated":"2016-07-06 18:28:16.000000000","message":"As I see, find also should be removed from the whitelist externals, as only the removed lines use it.","commit_id":"55625d7591fd1fd4736c9ad6965c67fa979b3af0"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"2f5f92641b345a3f00835460374034a589fa8443","unresolved":false,"context_lines":[{"line_number":7,"context_line":"usedevelop \u003d True"},{"line_number":8,"context_line":"# tox is silly... these need to be separated by a newline...."},{"line_number":9,"context_line":"whitelist_externals \u003d bash"},{"line_number":10,"context_line":"                      find"},{"line_number":11,"context_line":"                      rm"},{"line_number":12,"context_line":"install_command \u003d pip install -c{env:UPPER_CONSTRAINTS_FILE:https://git.openstack.org/cgit/openstack/requirements/plain/upper-constraints.txt} {opts} {packages}"},{"line_number":13,"context_line":"setenv \u003d VIRTUAL_ENV\u003d{envdir}"}],"source_content_type":"text/x-properties","patch_set":1,"id":"1aa78d24_cc2fb086","line":10,"range":{"start_line":10,"start_character":22,"end_line":10,"end_character":26},"in_reply_to":"1aa78d24_4ba88fdb","updated":"2016-07-11 16:15:19.000000000","message":"Is this not used on line 93?","commit_id":"55625d7591fd1fd4736c9ad6965c67fa979b3af0"},{"author":{"_account_id":18602,"name":"Gábor Antal","email":"antal@inf.u-szeged.hu","username":"antal"},"change_message_id":"0714be76329020357eb5ed0a6d1c9f794ae7b828","unresolved":false,"context_lines":[{"line_number":7,"context_line":"usedevelop \u003d True"},{"line_number":8,"context_line":"# tox is silly... these need to be separated by a newline...."},{"line_number":9,"context_line":"whitelist_externals \u003d bash"},{"line_number":10,"context_line":"                      find"},{"line_number":11,"context_line":"                      rm"},{"line_number":12,"context_line":"install_command \u003d pip install -c{env:UPPER_CONSTRAINTS_FILE:https://git.openstack.org/cgit/openstack/requirements/plain/upper-constraints.txt} {opts} {packages}"},{"line_number":13,"context_line":"setenv \u003d VIRTUAL_ENV\u003d{envdir}"}],"source_content_type":"text/x-properties","patch_set":1,"id":"1aa78d24_07d6b326","line":10,"range":{"start_line":10,"start_character":22,"end_line":10,"end_character":26},"in_reply_to":"1aa78d24_cc2fb086","updated":"2016-07-11 16:37:29.000000000","message":"As I think it is not used on line 93. The reason why I think it this way: Actually, bash runs on line 93, and find gets called from the inside of this bash, and we only get the result of this run. Also, if you remove the find from here, and runs tox, you will not get any warning about command which is not on the white list, so I think it can be removed.","commit_id":"55625d7591fd1fd4736c9ad6965c67fa979b3af0"}]}