)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"dc0967a361d2bac0200db1e0a513a5821d39d041","unresolved":false,"context_lines":[{"line_number":12,"context_line":"      * consoleauth_manager"},{"line_number":13,"context_line":"      * cert_manager"},{"line_number":14,"context_line":"      * scheduler_manager"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: Idc049b455a7df483556cfba0c34d5fcfb3deb3ec"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"9ad45d7e_38b195e2","line":15,"updated":"2016-08-09 10:40:02.000000000","message":"Nit: this should really be part of the blueprint.","commit_id":"2e9e5eabdd4da0c046ca8294ef8bcc306822c2d3"},{"author":{"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},"change_message_id":"985d6a88af0e4e7013c8c6408c8655bf64da6777","unresolved":false,"context_lines":[{"line_number":12,"context_line":"      * consoleauth_manager"},{"line_number":13,"context_line":"      * cert_manager"},{"line_number":14,"context_line":"      * scheduler_manager"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: Idc049b455a7df483556cfba0c34d5fcfb3deb3ec"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"3ac371cc_002390be","line":15,"in_reply_to":"9ad45d7e_38b195e2","updated":"2016-08-15 16:56:00.000000000","message":"+1","commit_id":"2e9e5eabdd4da0c046ca8294ef8bcc306822c2d3"}],"nova/cmd/cert.py":[{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"f52bafebe84436681bae493f39164ebf2ce2620a","unresolved":false,"context_lines":[{"line_number":29,"context_line":"from nova import version"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"CONF \u003d nova.conf.CONF"},{"line_number":32,"context_line":"MANAGER \u003d \u0027nova.cert.manager.CertManager\u0027"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"def main():"}],"source_content_type":"text/x-python","patch_set":18,"id":"fa6399be_b60f612d","line":32,"updated":"2016-10-18 11:37:58.000000000","message":"This isn\u0027t very attractive - IMHO we should be importing the actual class and referencing that directly.\n\neg here we should do\n\n from nova.cert import manager","commit_id":"6842627f2c7f524b8d5ebd3fd798a4a8d658641d"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"233a56336e2f56ededeb3c4ab0cb06e9a7d0c74a","unresolved":false,"context_lines":[{"line_number":29,"context_line":"from nova import version"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"CONF \u003d nova.conf.CONF"},{"line_number":32,"context_line":"MANAGER \u003d \u0027nova.cert.manager.CertManager\u0027"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"def main():"}],"source_content_type":"text/x-python","patch_set":18,"id":"9a629dbe_9e3367f6","line":32,"in_reply_to":"ba5da102_2db07bdd","updated":"2016-11-14 11:18:48.000000000","message":"\u003e Enhancing the Service class to accept manager class instead of string would be the better way as you mentioned. But tests will have to remember the service manager classes. Would that be okay?\n\nThey have to \"remember\" the classpath as things stand, right? If so, this doesn\u0027t sound like much of a change and would implicitly validate the path (Python would fail immediately on a broken import)","commit_id":"6842627f2c7f524b8d5ebd3fd798a4a8d658641d"},{"author":{"_account_id":18337,"name":"Sujitha","email":"sujitha.neti@intel.com","username":"Sujitha"},"change_message_id":"f0cf6f440989b49352f756c7dbf01be6934bf225","unresolved":false,"context_lines":[{"line_number":29,"context_line":"from nova import version"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"CONF \u003d nova.conf.CONF"},{"line_number":32,"context_line":"MANAGER \u003d \u0027nova.cert.manager.CertManager\u0027"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"def main():"}],"source_content_type":"text/x-python","patch_set":18,"id":"ba5da102_2db07bdd","line":32,"in_reply_to":"fa6399be_b60f612d","updated":"2016-10-26 16:49:19.000000000","message":"Thanks for the review Daniel.\n\nI added a variable for Manager so that it can be called in the tests. This avoids each test to remember the service manager classes.  Also using __name__ only gives only the class name which can\u0027t be used for import. I need to append this to the module name. But I don\u0027t think that would be attractive.\n\nEnhancing the Service class to accept manager class instead of string would be the better way as you mentioned. But tests will have to remember the service manager classes. Would that be okay?\n\nPlease suggest.","commit_id":"6842627f2c7f524b8d5ebd3fd798a4a8d658641d"},{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"f52bafebe84436681bae493f39164ebf2ce2620a","unresolved":false,"context_lines":[{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    server \u003d service.Service.create(binary\u003d\u0027nova-cert\u0027,"},{"line_number":49,"context_line":"                                    topic\u003dCONF.cert_topic,"},{"line_number":50,"context_line":"                                    manager\u003dMANAGER)"},{"line_number":51,"context_line":"    service.serve(server)"},{"line_number":52,"context_line":"    service.wait()"}],"source_content_type":"text/x-python","patch_set":18,"id":"fa6399be_16256dad","line":50,"updated":"2016-10-18 11:37:58.000000000","message":"...and then here do\n\n  manager\u003dmanager.CertManager.__name__\n\nEven better would be to enhance the Service class. Instead of accepting only a \u0027manager\u0027 as a string, which is then imported to get a class, it should allow to directly accept a class","commit_id":"6842627f2c7f524b8d5ebd3fd798a4a8d658641d"}],"nova/cmd/scheduler.py":[{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"f5f39eb1d254a8fc154a9baf7e73024e088e153a","unresolved":false,"context_lines":[{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    server \u003d service.Service.create(binary\u003d\u0027nova-scheduler\u0027,"},{"line_number":43,"context_line":"                         topic\u003dCONF.scheduler_topic,"},{"line_number":44,"context_line":"                         manager\u003d\u0027nova.scheduler.manager.SchedulerManager\u0027)"},{"line_number":45,"context_line":"    service.serve(server)"},{"line_number":46,"context_line":"    service.wait()"}],"source_content_type":"text/x-python","patch_set":15,"id":"3a98d1f4_9f756565","line":44,"updated":"2016-10-03 13:50:24.000000000","message":"Nit: I wish this file was the only place we ever get these manager class paths from.\n\nCould we maybe create the service in a function in here, so that can get called by the tests? Or maybe just share a constant for the manager class, although I am hoping we will remove the topic conf soon as well, so maybe better to try the function.\n\nThats assuming the dependency tree works OK, but it should be OK for the tests.","commit_id":"52f931012dbc799ac20cd59328956ba8b3a9b2ae"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"efe45b4037d4ab97ba98332c4df045518fecad7d","unresolved":false,"context_lines":[{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    server \u003d service.Service.create(binary\u003d\u0027nova-scheduler\u0027,"},{"line_number":43,"context_line":"                         topic\u003dCONF.scheduler_topic,"},{"line_number":44,"context_line":"                         manager\u003d\u0027nova.scheduler.manager.SchedulerManager\u0027)"},{"line_number":45,"context_line":"    service.serve(server)"},{"line_number":46,"context_line":"    service.wait()"}],"source_content_type":"text/x-python","patch_set":15,"id":"1a95cdbc_c7a10dfa","line":44,"in_reply_to":"1a95cdbc_174a67ac","updated":"2016-10-07 16:13:37.000000000","message":"Ah, good question.\n\nMaybe just a constant in this file would do the trick, thinking about it. That should stop us needing new fixtures for the moment.\n\nOr maybe even just store the kwargs dict for the service.create call? Thats a bit odd though.","commit_id":"52f931012dbc799ac20cd59328956ba8b3a9b2ae"},{"author":{"_account_id":18337,"name":"Sujitha","email":"sujitha.neti@intel.com","username":"Sujitha"},"change_message_id":"aa26b2e1326b80e9c018b9b3000be7357c9fe0d8","unresolved":false,"context_lines":[{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    server \u003d service.Service.create(binary\u003d\u0027nova-scheduler\u0027,"},{"line_number":43,"context_line":"                         topic\u003dCONF.scheduler_topic,"},{"line_number":44,"context_line":"                         manager\u003d\u0027nova.scheduler.manager.SchedulerManager\u0027)"},{"line_number":45,"context_line":"    service.serve(server)"},{"line_number":46,"context_line":"    service.wait()"}],"source_content_type":"text/x-python","patch_set":15,"id":"1a95cdbc_174a67ac","line":44,"in_reply_to":"3a98d1f4_9f756565","updated":"2016-10-06 21:30:53.000000000","message":"Since this is a starter script for scheduler service, would it be ok to write a function here  and get it called by the tests? \n\nI think ServiceFixture would be the right place to get the manager classes. All tests use this fixture to start service. So can I add the manager class in there.\n\nhttps://github.com/openstack/nova/blob/master/nova/tests/fixtures.py#L53\n\nPlease suggest which one would be better.","commit_id":"52f931012dbc799ac20cd59328956ba8b3a9b2ae"}],"nova/conf/service.py":[{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"f5f39eb1d254a8fc154a9baf7e73024e088e153a","unresolved":false,"context_lines":[{"line_number":182,"context_line":"               deprecated_for_removal\u003dTrue,"},{"line_number":183,"context_line":"               deprecated_since\u003d\u002713.0.0\u0027,"},{"line_number":184,"context_line":"               help\u003d\u0027Full class name for the Manager for cert\u0027),"},{"line_number":185,"context_line":"    # NOTE(sdague): the network_manager has a bunch of different in"},{"line_number":186,"context_line":"    # tree classes that are still legit options. In Newton we should"},{"line_number":187,"context_line":"    # turn this into a selector."},{"line_number":188,"context_line":"    cfg.StrOpt(\u0027network_manager\u0027,"},{"line_number":189,"context_line":"               choices\u003d["},{"line_number":190,"context_line":"                   \u0027nova.network.manager.FlatManager\u0027,"}],"source_content_type":"text/x-python","patch_set":15,"id":"3a98d1f4_1fecf528","side":"PARENT","line":187,"range":{"start_line":185,"start_character":4,"end_line":187,"end_character":32},"updated":"2016-10-03 13:50:24.000000000","message":"Nit; we should have left this comment it, but honestly, I think now we delete this when we remove nova-network. As such, I am OK removing this comment for now.","commit_id":"d5f113de34589933c23a7cecc25ca0bf5f47207d"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"f5f39eb1d254a8fc154a9baf7e73024e088e153a","unresolved":false,"context_lines":[{"line_number":173,"context_line":"               default\u003d\u0027nova.network.manager.VlanManager\u0027,"},{"line_number":174,"context_line":"               help\u003d\u0027Full class name for the Manager for network\u0027)"},{"line_number":175,"context_line":"]"},{"line_number":176,"context_line":""},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"def register_opts(conf):"},{"line_number":179,"context_line":"    conf.register_opts(service_opts)"}],"source_content_type":"text/x-python","patch_set":15,"id":"3a98d1f4_3f7a9188","line":176,"updated":"2016-10-03 13:50:24.000000000","message":"There are some other ones that are hiding, like conductor:\nhttps://github.com/openstack/nova/blob/master/nova/conf/conductor.py#L51\n\nBut we can do that in a follow up.","commit_id":"52f931012dbc799ac20cd59328956ba8b3a9b2ae"}],"nova/tests/functional/api_sample_tests/test_certificates.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"c1d44cbf383e1a85469ac7fa724308165088c3b8","unresolved":false,"context_lines":[{"line_number":27,"context_line":"        self.stub_out(\u0027nova.crypto.fetch_ca\u0027, fake_crypto.fetch_ca)"},{"line_number":28,"context_line":"        self.stub_out(\u0027nova.crypto.generate_x509_cert\u0027,"},{"line_number":29,"context_line":"                      fake_crypto.generate_x509_cert)"},{"line_number":30,"context_line":"        self.cert \u003d self.start_service(\u0027cert\u0027, manager\u003d"},{"line_number":31,"context_line":"                              \u0027nova.cert.manager.CertManager\u0027)"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    def test_create_certificates(self):"}],"source_content_type":"text/x-python","patch_set":13,"id":"3a98d1f4_92fc4140","line":30,"range":{"start_line":30,"start_character":47,"end_line":30,"end_character":55},"updated":"2016-09-28 15:44:58.000000000","message":"nit: could you move this to the next line?","commit_id":"e11b0efc7fd310c9c14eb4b0687d5d0a5844f52d"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"1a282f3c219dfca58c965a2439fe386172059c4a","unresolved":false,"context_lines":[{"line_number":29,"context_line":"        self.stub_out(\u0027nova.crypto.generate_x509_cert\u0027,"},{"line_number":30,"context_line":"                      fake_crypto.generate_x509_cert)"},{"line_number":31,"context_line":"        self.cert \u003d self.start_service(\u0027cert\u0027,"},{"line_number":32,"context_line":"                                      manager\u003dcert.MANAGER)"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    def test_create_certificates(self):"},{"line_number":35,"context_line":"        response \u003d self._do_post(\u0027os-certificates\u0027,"}],"source_content_type":"text/x-python","patch_set":18,"id":"fa6399be_c21e615e","line":32,"range":{"start_line":32,"start_character":38,"end_line":32,"end_character":45},"updated":"2016-10-13 16:30:25.000000000","message":"Nit: indent not quite correct, will not block on that.","commit_id":"6842627f2c7f524b8d5ebd3fd798a4a8d658641d"}],"nova/tests/functional/api_sample_tests/test_consoles.py":[{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"1a282f3c219dfca58c965a2439fe386172059c4a","unresolved":false,"context_lines":[{"line_number":27,"context_line":"        self.flags(console_host\u003d\u0027fake\u0027)"},{"line_number":28,"context_line":"        self.flags(console_driver\u003d\u0027nova.console.fake.FakeConsoleProxy\u0027)"},{"line_number":29,"context_line":"        self.console \u003d self.start_service(\u0027console\u0027, host\u003d\u0027fake\u0027,"},{"line_number":30,"context_line":"                                         manager\u003dconsole.MANAGER)"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    def _create_consoles(self, server_uuid):"},{"line_number":33,"context_line":"        response \u003d self._do_post(\u0027servers/%s/consoles\u0027 % server_uuid,"}],"source_content_type":"text/x-python","patch_set":18,"id":"fa6399be_e22365a5","line":30,"updated":"2016-10-13 16:30:25.000000000","message":"Nit: indent not quite correct, will not block on that.","commit_id":"6842627f2c7f524b8d5ebd3fd798a4a8d658641d"}],"nova/tests/functional/integrated_helpers.py":[{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"1f36a04bcd0f591c662603b8125f6fa437366251","unresolved":false,"context_lines":[{"line_number":91,"context_line":""},{"line_number":92,"context_line":"    def _setup_scheduler_service(self):"},{"line_number":93,"context_line":"        self.flags(scheduler_driver\u003d\u0027chance_scheduler\u0027)"},{"line_number":94,"context_line":"        return self.start_service(\u0027scheduler\u0027, manager\u003d"},{"line_number":95,"context_line":"                          \u0027nova.scheduler.manager.SchedulerManager\u0027)"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"    def _setup_services(self):"}],"source_content_type":"text/x-python","patch_set":13,"id":"5a8bc5a2_267b537c","line":94,"range":{"start_line":94,"start_character":47,"end_line":94,"end_character":54},"updated":"2016-09-27 13:56:26.000000000","message":"Nit: I prefer key and value to be on the same line","commit_id":"e11b0efc7fd310c9c14eb4b0687d5d0a5844f52d"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"c1d44cbf383e1a85469ac7fa724308165088c3b8","unresolved":false,"context_lines":[{"line_number":91,"context_line":""},{"line_number":92,"context_line":"    def _setup_scheduler_service(self):"},{"line_number":93,"context_line":"        self.flags(scheduler_driver\u003d\u0027chance_scheduler\u0027)"},{"line_number":94,"context_line":"        return self.start_service(\u0027scheduler\u0027, manager\u003d"},{"line_number":95,"context_line":"                          \u0027nova.scheduler.manager.SchedulerManager\u0027)"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"    def _setup_services(self):"}],"source_content_type":"text/x-python","patch_set":13,"id":"3a98d1f4_32a44d56","line":94,"range":{"start_line":94,"start_character":47,"end_line":94,"end_character":54},"in_reply_to":"5a8bc5a2_267b537c","updated":"2016-09-28 15:44:58.000000000","message":"+1","commit_id":"e11b0efc7fd310c9c14eb4b0687d5d0a5844f52d"},{"author":{"_account_id":10618,"name":"Pavel Kholkin","email":"p.v.holkin@mail.ru","username":"pkholkin"},"change_message_id":"8f58bd78b0cad9613169bbcd19b63a0aa4dacc82","unresolved":false,"context_lines":[{"line_number":99,"context_line":"                                            manager\u003dCONF.conductor.manager)"},{"line_number":100,"context_line":"        self.compute \u003d self._setup_compute_service()"},{"line_number":101,"context_line":"        self.consoleauth \u003d self.start_service(\u0027consoleauth\u0027,"},{"line_number":102,"context_line":"                      manager\u003d\u0027nova.consoleauth.manager.ConsoleAuthManager\u0027)"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"        self.network \u003d self.start_service(\u0027network\u0027)"},{"line_number":105,"context_line":"        self.scheduler \u003d self._setup_scheduler_service()"}],"source_content_type":"text/x-python","patch_set":15,"id":"1a95cdbc_692f6bf6","line":102,"range":{"start_line":102,"start_character":8,"end_line":102,"end_character":22},"updated":"2016-10-06 14:10:46.000000000","message":"indent is different from the same above, maybe make them the equal?","commit_id":"52f931012dbc799ac20cd59328956ba8b3a9b2ae"}],"nova/tests/functional/libvirt/test_numa_servers.py":[{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"1a282f3c219dfca58c965a2439fe386172059c4a","unresolved":false,"context_lines":[{"line_number":85,"context_line":"        self.flags(scheduler_default_filters\u003dCONF.scheduler_default_filters"},{"line_number":86,"context_line":"                   + [\u0027NUMATopologyFilter\u0027])"},{"line_number":87,"context_line":"        return self.start_service(\u0027scheduler\u0027,"},{"line_number":88,"context_line":"                                 manager\u003dscheduler.MANAGER)"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"    def _run_build_test(self, flavor_id, filter_mock, end_status\u003d\u0027ACTIVE\u0027):"},{"line_number":91,"context_line":""}],"source_content_type":"text/x-python","patch_set":18,"id":"fa6399be_623035e9","line":88,"updated":"2016-10-13 16:30:25.000000000","message":"Nit: indent not quite correct, will not block on that.","commit_id":"6842627f2c7f524b8d5ebd3fd798a4a8d658641d"}],"nova/tests/functional/notification_sample_tests/notification_sample_base.py":[{"author":{"_account_id":10618,"name":"Pavel Kholkin","email":"p.v.holkin@mail.ru","username":"pkholkin"},"change_message_id":"8f58bd78b0cad9613169bbcd19b63a0aa4dacc82","unresolved":false,"context_lines":[{"line_number":76,"context_line":""},{"line_number":77,"context_line":"        self.start_service(\u0027conductor\u0027, manager\u003dCONF.conductor.manager)"},{"line_number":78,"context_line":"        self.start_service(\u0027scheduler\u0027,"},{"line_number":79,"context_line":"                      manager\u003d \u0027nova.scheduler.manager.SchedulerManager\u0027)"},{"line_number":80,"context_line":"        self.start_service(\u0027network\u0027)"},{"line_number":81,"context_line":"        self.compute \u003d self.start_service(\u0027compute\u0027)"},{"line_number":82,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"1a95cdbc_89de773d","line":79,"range":{"start_line":79,"start_character":30,"end_line":79,"end_character":31},"updated":"2016-10-06 14:10:46.000000000","message":"remove \u0027 \u0027","commit_id":"52f931012dbc799ac20cd59328956ba8b3a9b2ae"}],"nova/tests/functional/regressions/test_bug_1548980.py":[{"author":{"_account_id":10618,"name":"Pavel Kholkin","email":"p.v.holkin@mail.ru","username":"pkholkin"},"change_message_id":"8f58bd78b0cad9613169bbcd19b63a0aa4dacc82","unresolved":false,"context_lines":[{"line_number":55,"context_line":"        self.network \u003d self.start_service(\u0027network\u0027)"},{"line_number":56,"context_line":"        self.compute \u003d self.start_service(\u0027compute\u0027)"},{"line_number":57,"context_line":"        self.consoleauth \u003d self.start_service(\u0027consoleauth\u0027,"},{"line_number":58,"context_line":"                 manager\u003d\u0027nova.consoleauth.manager.ConsoleAuthManager\u0027)"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"        self.useFixture(cast_as_call.CastAsCall(self.stubs))"},{"line_number":61,"context_line":"        self.addCleanup(nova.tests.unit.image.fake.FakeImageService_reset)"}],"source_content_type":"text/x-python","patch_set":15,"id":"1a95cdbc_49a2afaf","line":58,"range":{"start_line":58,"start_character":8,"end_line":58,"end_character":17},"updated":"2016-10-06 14:10:46.000000000","message":"indent","commit_id":"52f931012dbc799ac20cd59328956ba8b3a9b2ae"}],"nova/tests/unit/console/test_console.py":[{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"410b2fd65d143b127f0e4faecd4c6b3d5652d2ac","unresolved":false,"context_lines":[{"line_number":17,"context_line":"\"\"\"Tests For Console proxy.\"\"\""},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"import mock"},{"line_number":20,"context_line":"from oslo_utils import importutils"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"from nova.compute import rpcapi as compute_rpcapi"},{"line_number":23,"context_line":"import nova.conf"}],"source_content_type":"text/x-python","patch_set":17,"id":"1a95cdbc_cd5c9e4d","side":"PARENT","line":20,"updated":"2016-10-10 10:02:45.000000000","message":"Deleted too much? :)","commit_id":"d5f113de34589933c23a7cecc25ca0bf5f47207d"}],"releasenotes/notes/remove-deprecated-manager-classes-options-1af872a560c3f7a9.yaml":[{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"566a8228bc03d05890cf18a22de7f6efe35f643f","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - Below options in DEFAULT section which were deprecated in"},{"line_number":4,"context_line":"    Mitaka has been completely removed in Newton."},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"      * console_manager"},{"line_number":7,"context_line":"      * consoleauth_manager"},{"line_number":8,"context_line":"      * cert_manager"},{"line_number":9,"context_line":"      * scheduler_manager"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"1aa78d24_2a193c7a","line":6,"updated":"2016-07-14 16:00:30.000000000","message":"This doesn\u0027t quite look right:\nhttp://docs-draft.openstack.org/53/338553/7/check/gate-nova-releasenotes/bd5792f//releasenotes/build/html/unreleased.html#upgrade-notes\n\nLooks like they got this one to work, incase that helps:\nhttps://github.com/openstack/nova/blob/master/releasenotes/notes/mutable-config-e7e82b3d7c38f3a5.yaml","commit_id":"89b7552b2aed4be18775918b58fe3e33026373c0"},{"author":{"_account_id":18337,"name":"Sujitha","email":"sujitha.neti@intel.com","username":"Sujitha"},"change_message_id":"b55cafbeafc9aa133b1499491914e330ef948d32","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - Below options in DEFAULT section which were deprecated in"},{"line_number":4,"context_line":"    Mitaka has been completely removed in Newton."},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"      * console_manager"},{"line_number":7,"context_line":"      * consoleauth_manager"},{"line_number":8,"context_line":"      * cert_manager"},{"line_number":9,"context_line":"      * scheduler_manager"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"1aa78d24_c6bd0c69","line":6,"in_reply_to":"1aa78d24_2a193c7a","updated":"2016-07-14 19:33:33.000000000","message":"Done","commit_id":"89b7552b2aed4be18775918b58fe3e33026373c0"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"d6481b01f58172a4f0991d2457d3fcc340f653c3","unresolved":false,"context_lines":[{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Below options in DEFAULT section which were deprecated in"},{"line_number":5,"context_line":"    Mitaka has been completely removed in Newton."},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"    * console_manager"},{"line_number":8,"context_line":"    * consoleauth_manager"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"9ad45d7e_98724148","line":5,"updated":"2016-08-09 10:39:36.000000000","message":"Nit: I wonder about mentioning what the alternative is, but since there is no valid alternative for these settings, this is fine.","commit_id":"2e9e5eabdd4da0c046ca8294ef8bcc306822c2d3"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"c1d44cbf383e1a85469ac7fa724308165088c3b8","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Below options in DEFAULT section which were deprecated in"},{"line_number":5,"context_line":"    Mitaka has been completely removed in Ocata."},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"    * console_manager"},{"line_number":8,"context_line":"    * consoleauth_manager"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"3a98d1f4_2d5cf224","line":5,"range":{"start_line":4,"start_character":4,"end_line":5,"end_character":48},"updated":"2016-09-28 15:44:58.000000000","message":"How about the following wording, taken from \u0027remove-deprecated-cinder-options-newton\u0027?\n\n    The following deprecated configuration options have been removed\n    from the ``DEFAULT`` section of nova.conf:","commit_id":"e11b0efc7fd310c9c14eb4b0687d5d0a5844f52d"}]}