)]}'
{"etc/nova/rootwrap.d/compute.filters":[{"author":{"_account_id":6802,"name":"Joel Coffman","email":"jmc7tp@gmail.com","username":"joel-coffman"},"change_message_id":"bb4e060a019d65a2e8746a08c290f52290c30bac","unresolved":false,"context_lines":[{"line_number":224,"context_line":""},{"line_number":225,"context_line":"# nova/volume/encryptors/cryptsetup.py:"},{"line_number":226,"context_line":"# nova/volume/encryptors/luks.py:"},{"line_number":227,"context_line":"ln: RegExpFilter, ln, root, ln, --symbolic, --force, .*, .*"},{"line_number":228,"context_line":""},{"line_number":229,"context_line":"# nova/volume/encryptors.py:"},{"line_number":230,"context_line":"# nova/virt/libvirt/dmcrypt.py:"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"dada55a8_ac3cb9c8","line":227,"updated":"2016-07-20 21:42:45.000000000","message":"This filter allows symbolic links to be created anywhere. Is it possible to restrict the location?","commit_id":"691f0e8922c738645083e1235859b5c398e7ccbb"}],"nova/volume/encryptors/luks.py":[{"author":{"_account_id":6802,"name":"Joel Coffman","email":"jmc7tp@gmail.com","username":"joel-coffman"},"change_message_id":"bb4e060a019d65a2e8746a08c290f52290c30bac","unresolved":false,"context_lines":[{"line_number":127,"context_line":"                                    run_as_root\u003dTrue, check_exit_code\u003dTrue)"},{"line_number":128,"context_line":"        for line in info.split(\u0027\\n\u0027):"},{"line_number":129,"context_line":"            if line.strip().startswith(\u0027device:\u0027) \u003e 0:"},{"line_number":130,"context_line":"                original_device \u003d line[line.index(\u0027/\u0027):].strip()"},{"line_number":131,"context_line":"                break"},{"line_number":132,"context_line":"        utils.execute(\u0027cryptsetup\u0027, \u0027luksClose\u0027, self.dev_name,"},{"line_number":133,"context_line":"                      run_as_root\u003dTrue, check_exit_code\u003dTrue,"}],"source_content_type":"text/x-python","patch_set":1,"id":"dada55a8_6c0da1e7","line":130,"updated":"2016-07-20 21:42:45.000000000","message":"This assumes that all paths are absolute. Wouldn\u0027t it be better to just strip \"device:\" from the beginning and assume that the rest is the path?","commit_id":"691f0e8922c738645083e1235859b5c398e7ccbb"},{"author":{"_account_id":6802,"name":"Joel Coffman","email":"jmc7tp@gmail.com","username":"joel-coffman"},"change_message_id":"bb4e060a019d65a2e8746a08c290f52290c30bac","unresolved":false,"context_lines":[{"line_number":136,"context_line":"        if original_device:"},{"line_number":137,"context_line":"            utils.execute(\u0027ln\u0027, \u0027--symbolic\u0027, \u0027--force\u0027,"},{"line_number":138,"context_line":"                          original_device, self.symlink_path,"},{"line_number":139,"context_line":"                          run_as_root\u003dTrue, check_exit_code\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":1,"id":"dada55a8_ec7511fa","line":139,"updated":"2016-07-20 21:42:45.000000000","message":"This command appears to update the symlink to point to the encrypted device.\n\nWhy is this necessary? Won\u0027t the symlink have to be reset when the volume is (re)attached to the instance in order for the instance to read the data?","commit_id":"691f0e8922c738645083e1235859b5c398e7ccbb"}]}