)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":2506,"name":"devdatta-kulkarni","email":"kulkarni.devdatta@gmail.com","username":"devdatta-kulkarni"},"change_message_id":"8636b6fa22053d6174f7ccadc6a1aa24f6ac64cb","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This test highlights a bug in _create_images_and_backing, which is"},{"line_number":14,"context_line":"passing a full path in place of a disk name. This will be fixed by"},{"line_number":15,"context_line":"removing the call to _create_images_and_backing in a subsequent"},{"line_number":16,"context_line":"commit."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"This also allows us to validate the future removal of the call to"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"bacf61ea_65507ad5","line":15,"updated":"2016-08-03 16:47:03.000000000","message":"Are you saying that the call to _create_images_and_backing from inside the _hard_reboot method need to be removed to fix the issue of passing full path instead of disk name?\n\nOr, am I misunderstanding the comment?","commit_id":"0cdaaa1a2449c5e7ab07061480fbc9c2420dd21c"}],"nova/tests/unit/virt/libvirt/test_driver.py":[{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"b0851121152799e564add505dedd72f284ce6897","unresolved":false,"context_lines":[{"line_number":11381,"context_line":""},{"line_number":11382,"context_line":"        # We should have called cache() on the root and ephemeral disks"},{"line_number":11383,"context_line":"        disks[\u0027disk\u0027].cache.assert_called_once()"},{"line_number":11384,"context_line":"        disks[\u0027disk.local\u0027].cache.assert_called_once()"},{"line_number":11385,"context_line":""},{"line_number":11386,"context_line":"        mock_destroy.assert_called_once_with(instance)"},{"line_number":11387,"context_line":"        mock_undefine.assert_called_once_with(instance)"}],"source_content_type":"text/x-python","patch_set":10,"id":"3ac371cc_5e2bae30","line":11384,"updated":"2016-08-15 15:33:53.000000000","message":"assert_called_once() isn\u0027t a method in py27 unittest.mock.Mock.","commit_id":"83e8330afbe96e5f4f6373d81c162e7b52c57ab7"},{"author":{"_account_id":9555,"name":"Matthew Booth","email":"mbooth@redhat.com","username":"MatthewBooth"},"change_message_id":"8a9d6e664963b0c47552142649b68f1d438a5b67","unresolved":false,"context_lines":[{"line_number":11381,"context_line":""},{"line_number":11382,"context_line":"        # We should have called cache() on the root and ephemeral disks"},{"line_number":11383,"context_line":"        disks[\u0027disk\u0027].cache.assert_called_once()"},{"line_number":11384,"context_line":"        disks[\u0027disk.local\u0027].cache.assert_called_once()"},{"line_number":11385,"context_line":""},{"line_number":11386,"context_line":"        mock_destroy.assert_called_once_with(instance)"},{"line_number":11387,"context_line":"        mock_undefine.assert_called_once_with(instance)"}],"source_content_type":"text/x-python","patch_set":10,"id":"3ac371cc_c704ce7f","line":11384,"in_reply_to":"3ac371cc_5e2bae30","updated":"2016-08-16 09:06:31.000000000","message":"See previous.","commit_id":"83e8330afbe96e5f4f6373d81c162e7b52c57ab7"},{"author":{"_account_id":10224,"name":"Feodor Tersin","email":"ftersin@hotmail.com","username":"ftersin"},"change_message_id":"2817775343c4c844aae191e42cf8fd5df3d4c793","unresolved":false,"context_lines":[{"line_number":11399,"context_line":""},{"line_number":11400,"context_line":"        backend \u003d self.useFixture(fake_imagebackend.ImageBackendFixture())"},{"line_number":11401,"context_line":""},{"line_number":11402,"context_line":"        with mock.patch(\u0027os.path.exists\u0027, return_value\u003dTrue):"},{"line_number":11403,"context_line":"            drvr._hard_reboot(self.context, instance, network_info,"},{"line_number":11404,"context_line":"                              block_device_info)"},{"line_number":11405,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"9a89bdaa_da05c9c2","line":11402,"updated":"2016-09-05 16:39:39.000000000","message":"What logic do we mock here?","commit_id":"5d9cc913ffdc3eb1326d9aa4e50007f72d204222"},{"author":{"_account_id":10224,"name":"Feodor Tersin","email":"ftersin@hotmail.com","username":"ftersin"},"change_message_id":"3c6424ca2e8a3d332e5ec4b7a639332ab0104a54","unresolved":false,"context_lines":[{"line_number":11399,"context_line":""},{"line_number":11400,"context_line":"        backend \u003d self.useFixture(fake_imagebackend.ImageBackendFixture())"},{"line_number":11401,"context_line":""},{"line_number":11402,"context_line":"        with mock.patch(\u0027os.path.exists\u0027, return_value\u003dTrue):"},{"line_number":11403,"context_line":"            drvr._hard_reboot(self.context, instance, network_info,"},{"line_number":11404,"context_line":"                              block_device_info)"},{"line_number":11405,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"9a89bdaa_7fcba61e","line":11402,"in_reply_to":"9a89bdaa_beec632a","updated":"2016-09-06 15:30:14.000000000","message":"heh... Unlike just stubbing of writting on disk (which obviously, w/o additional comments lets us assume that it merely prevents pollution of working folders), this does some sensible - returns True. If you mock write_to_file with custom return_value or other features, i\u0027ll ask you to explain it as well.","commit_id":"5d9cc913ffdc3eb1326d9aa4e50007f72d204222"},{"author":{"_account_id":9555,"name":"Matthew Booth","email":"mbooth@redhat.com","username":"MatthewBooth"},"change_message_id":"d0323431434888f4a782261616c438581fecc507","unresolved":false,"context_lines":[{"line_number":11399,"context_line":""},{"line_number":11400,"context_line":"        backend \u003d self.useFixture(fake_imagebackend.ImageBackendFixture())"},{"line_number":11401,"context_line":""},{"line_number":11402,"context_line":"        with mock.patch(\u0027os.path.exists\u0027, return_value\u003dTrue):"},{"line_number":11403,"context_line":"            drvr._hard_reboot(self.context, instance, network_info,"},{"line_number":11404,"context_line":"                              block_device_info)"},{"line_number":11405,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"9a89bdaa_beec632a","line":11402,"in_reply_to":"9a89bdaa_da05c9c2","updated":"2016-09-06 09:29:59.000000000","message":"Good question. The fact that I can\u0027t remember is an immediate argument in favour of commenting mocks :)","commit_id":"5d9cc913ffdc3eb1326d9aa4e50007f72d204222"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"893a9443e51840e64587a2a98566ea5196f148b2","unresolved":false,"context_lines":[{"line_number":11345,"context_line":""},{"line_number":11346,"context_line":"        disks \u003d backend.disks"},{"line_number":11347,"context_line":""},{"line_number":11348,"context_line":"        # NOTE(mdbooth): _create_images_and_backing() passes a full path a"},{"line_number":11349,"context_line":"        # \u0027disk_name\u0027 when creating a disk. This is wrong, but happens to"},{"line_number":11350,"context_line":"        # work due to handling by each individual backend. This will be"},{"line_number":11351,"context_line":"        # fixed in a subsequent commit."}],"source_content_type":"text/x-python","patch_set":13,"id":"9a629dbe_b98a2e62","line":11348,"updated":"2016-11-11 20:29:17.000000000","message":"\"passes a full path a\"? :)","commit_id":"125ab522c9fb21741f6c2e5a3c12602808dccee8"},{"author":{"_account_id":9555,"name":"Matthew Booth","email":"mbooth@redhat.com","username":"MatthewBooth"},"change_message_id":"64fe6cf5eeff0892970445e388c0d5ef42cf7a88","unresolved":false,"context_lines":[{"line_number":11345,"context_line":""},{"line_number":11346,"context_line":"        disks \u003d backend.disks"},{"line_number":11347,"context_line":""},{"line_number":11348,"context_line":"        # NOTE(mdbooth): _create_images_and_backing() passes a full path a"},{"line_number":11349,"context_line":"        # \u0027disk_name\u0027 when creating a disk. This is wrong, but happens to"},{"line_number":11350,"context_line":"        # work due to handling by each individual backend. This will be"},{"line_number":11351,"context_line":"        # fixed in a subsequent commit."}],"source_content_type":"text/x-python","patch_set":13,"id":"7a77a97e_6a25f108","line":11348,"in_reply_to":"9a629dbe_b98a2e62","updated":"2016-11-21 13:55:30.000000000","message":"Done","commit_id":"125ab522c9fb21741f6c2e5a3c12602808dccee8"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"7004c9fd29756c1137da4447c0b81f2bf954a3f0","unresolved":false,"context_lines":[{"line_number":11417,"context_line":""},{"line_number":11418,"context_line":"        backend \u003d self.useFixture(fake_imagebackend.ImageBackendFixture())"},{"line_number":11419,"context_line":""},{"line_number":11420,"context_line":"        with mock.patch(\u0027os.path.exists\u0027, return_value\u003dTrue):"},{"line_number":11421,"context_line":"            drvr._hard_reboot(self.context, instance, network_info,"},{"line_number":11422,"context_line":"                              block_device_info)"},{"line_number":11423,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"7a77a97e_fe118eb0","line":11420,"range":{"start_line":11420,"start_character":8,"end_line":11420,"end_character":61},"updated":"2016-11-22 14:18:29.000000000","message":"I couldn\u0027t spot any calls to this function in the code. The closest approximation I could find was \u0027ensure_tree\u0027, but that calls \u0027os.path.isdir\u0027 [1] and only in some situations. Is it necessary?\n\n[1] https://github.com/openstack/oslo.utils/blob/7a52daac/oslo_utils/fileutils.py#L33","commit_id":"eb4306f228d2c74ef2cc131d391149a2ce9b34b0"}]}