)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"2a3462c41294f53224bbd9207ca838ef12d4ccc6","unresolved":false,"context_lines":[{"line_number":11,"context_line":"breakages in live-migrate, but in Mitaka we only work with Liberty."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I5f1e0904c34c4fe26fc75998441602925d2f0593"},{"line_number":14,"context_line":"Fixes-bug: 1598860"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"dada55a8_9b15f24a","line":14,"range":{"start_line":14,"start_character":0,"end_line":14,"end_character":9},"updated":"2016-07-25 18:43:47.000000000","message":"I think this needs to be Closes-Bug","commit_id":"f17d96f1eb59d86939f8e381cfa3e58d43816362"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"24bdf55d792b3fdb5b4d4dfff77250c4d3e1fd38","unresolved":false,"context_lines":[{"line_number":11,"context_line":"breakages in live-migrate, but in Mitaka we only work with Liberty."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I5f1e0904c34c4fe26fc75998441602925d2f0593"},{"line_number":14,"context_line":"Fixes-bug: 1598860"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"dada55a8_1b4726bd","line":14,"range":{"start_line":14,"start_character":0,"end_line":14,"end_character":9},"in_reply_to":"dada55a8_9b15f24a","updated":"2016-07-26 08:09:09.000000000","message":"Whoops, I went back in time there.","commit_id":"f17d96f1eb59d86939f8e381cfa3e58d43816362"}],"nova/compute/rpcapi.py":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"4373c33d173f45d9fcdadf983b17cae65ba7d2dc","unresolved":false,"context_lines":[{"line_number":363,"context_line":"        if service_version !\u003d 0:"},{"line_number":364,"context_line":"            LAST_VERSION \u003d version_cap"},{"line_number":365,"context_line":"        else:"},{"line_number":366,"context_line":"            LOG.debug(\"Not caching, as min service_version is 0.\")"},{"line_number":367,"context_line":""},{"line_number":368,"context_line":"        LOG.info(_LI(\u0027Automatically selected compute RPC version %(rpc)s \u0027"},{"line_number":369,"context_line":"                     \u0027from minimum service version %(service)i\u0027),"}],"source_content_type":"text/x-python","patch_set":1,"id":"1aa78d24_2aea2674","line":366,"range":{"start_line":366,"start_character":22,"end_line":366,"end_character":65},"updated":"2016-07-07 15:41:07.000000000","message":"I think this probably needs to be a little more descriptive or removed. Operators (and most developers) probably won\u0027t understand what that means without more words in it.","commit_id":"a4e475c4cb17e9d7dc96177ee376d854f91a6d87"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"351f130d96fd0b8633d924881d93fb9260355207","unresolved":false,"context_lines":[{"line_number":347,"context_line":"        # this result, because we will get a better answer next time."},{"line_number":348,"context_line":"        # As a sane default, return the version from the last release."},{"line_number":349,"context_line":"        if service_version \u003d\u003d 0:"},{"line_number":350,"context_line":"            LOG.debug(\"Not caching compute RPC version_cap, becuase min \""},{"line_number":351,"context_line":"                      \"service_version is 0. Please ensure a nova-compute \""},{"line_number":352,"context_line":"                      \"service has been started. Defaulting to Mitaka RPC.\")"},{"line_number":353,"context_line":"            return self.VERSION_ALIASES[\"mitaka\"]"}],"source_content_type":"text/x-python","patch_set":2,"id":"1aa78d24_1df20d06","line":350,"range":{"start_line":350,"start_character":60,"end_line":350,"end_character":67},"updated":"2016-07-07 17:02:00.000000000","message":"\"because\"","commit_id":"892545b04882dd846ba3f2b8861fa05cab7c626b"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"76b5bbc85439a6e1b187513e6934187f18b95302","unresolved":false,"context_lines":[{"line_number":347,"context_line":"        # this result, because we will get a better answer next time."},{"line_number":348,"context_line":"        # As a sane default, return the version from the last release."},{"line_number":349,"context_line":"        if service_version \u003d\u003d 0:"},{"line_number":350,"context_line":"            LOG.debug(\"Not caching compute RPC version_cap, becuase min \""},{"line_number":351,"context_line":"                      \"service_version is 0. Please ensure a nova-compute \""},{"line_number":352,"context_line":"                      \"service has been started. Defaulting to Mitaka RPC.\")"},{"line_number":353,"context_line":"            return self.VERSION_ALIASES[\"mitaka\"]"}],"source_content_type":"text/x-python","patch_set":2,"id":"1aa78d24_69aff27d","line":350,"range":{"start_line":350,"start_character":60,"end_line":350,"end_character":67},"in_reply_to":"1aa78d24_1df20d06","updated":"2016-07-08 09:57:37.000000000","message":"dang it.","commit_id":"892545b04882dd846ba3f2b8861fa05cab7c626b"},{"author":{"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},"change_message_id":"55ca297851533d533d5b124163ccda9b5580b1d0","unresolved":false,"context_lines":[{"line_number":347,"context_line":"        # this result, because we will get a better answer next time."},{"line_number":348,"context_line":"        # As a sane default, return the version from the last release."},{"line_number":349,"context_line":"        if service_version \u003d\u003d 0:"},{"line_number":350,"context_line":"            LOG.debug(\"Not caching compute RPC version_cap, because min \""},{"line_number":351,"context_line":"                      \"service_version is 0. Please ensure a nova-compute \""},{"line_number":352,"context_line":"                      \"service has been started. Defaulting to Mitaka RPC.\")"},{"line_number":353,"context_line":"            return self.VERSION_ALIASES[\"mitaka\"]"}],"source_content_type":"text/x-python","patch_set":4,"id":"fad55976_c0787792","line":350,"range":{"start_line":350,"start_character":16,"end_line":350,"end_character":21},"updated":"2016-07-15 18:32:24.000000000","message":"This seems like an important information, shouldn\u0027t this be logged with info level?","commit_id":"f17d96f1eb59d86939f8e381cfa3e58d43816362"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"82f10c8363f102233cfa050fe138d89439e1a6c8","unresolved":false,"context_lines":[{"line_number":347,"context_line":"        # this result, because we will get a better answer next time."},{"line_number":348,"context_line":"        # As a sane default, return the version from the last release."},{"line_number":349,"context_line":"        if service_version \u003d\u003d 0:"},{"line_number":350,"context_line":"            LOG.debug(\"Not caching compute RPC version_cap, because min \""},{"line_number":351,"context_line":"                      \"service_version is 0. Please ensure a nova-compute \""},{"line_number":352,"context_line":"                      \"service has been started. Defaulting to Mitaka RPC.\")"},{"line_number":353,"context_line":"            return self.VERSION_ALIASES[\"mitaka\"]"}],"source_content_type":"text/x-python","patch_set":4,"id":"dada55a8_bfd28132","line":350,"range":{"start_line":350,"start_character":16,"end_line":350,"end_character":21},"in_reply_to":"fad55976_c0787792","updated":"2016-07-25 08:14:04.000000000","message":"The problem should just resolve its-self. I could see an argument for a warning, but it seems best to not worry the admin about this level of detail as they are unlikely to need to take any actions.","commit_id":"f17d96f1eb59d86939f8e381cfa3e58d43816362"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"bde9389fb56b60a3c23e02fcf4200545583a4fd3","unresolved":false,"context_lines":[{"line_number":350,"context_line":"            LOG.debug(\"Not caching compute RPC version_cap, because min \""},{"line_number":351,"context_line":"                      \"service_version is 0. Please ensure a nova-compute \""},{"line_number":352,"context_line":"                      \"service has been started. Defaulting to Mitaka RPC.\")"},{"line_number":353,"context_line":"            return self.VERSION_ALIASES[\"mitaka\"]"},{"line_number":354,"context_line":""},{"line_number":355,"context_line":"        history \u003d service_obj.SERVICE_VERSION_HISTORY"},{"line_number":356,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":4,"id":"1aa78d24_b43cd4c8","line":353,"range":{"start_line":353,"start_character":41,"end_line":353,"end_character":47},"updated":"2016-07-13 02:39:00.000000000","message":"So when we get to ocata, are we going to have to change this to newton?","commit_id":"f17d96f1eb59d86939f8e381cfa3e58d43816362"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"2d243e1bd4fb43436bdebff769a7f9ef55963aa2","unresolved":false,"context_lines":[{"line_number":350,"context_line":"            LOG.debug(\"Not caching compute RPC version_cap, because min \""},{"line_number":351,"context_line":"                      \"service_version is 0. Please ensure a nova-compute \""},{"line_number":352,"context_line":"                      \"service has been started. Defaulting to Mitaka RPC.\")"},{"line_number":353,"context_line":"            return self.VERSION_ALIASES[\"mitaka\"]"},{"line_number":354,"context_line":""},{"line_number":355,"context_line":"        history \u003d service_obj.SERVICE_VERSION_HISTORY"},{"line_number":356,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":4,"id":"fad55976_14577903","line":353,"range":{"start_line":353,"start_character":41,"end_line":353,"end_character":47},"in_reply_to":"1aa78d24_b43cd4c8","updated":"2016-07-15 16:44:46.000000000","message":"Well, we could. Ideally just change it to something that is less likely to cause problems.\n\nHonestly, its tempting to just not allow any messages to be sent in this case. Need to think on that more.","commit_id":"f17d96f1eb59d86939f8e381cfa3e58d43816362"},{"author":{"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},"change_message_id":"55ca297851533d533d5b124163ccda9b5580b1d0","unresolved":false,"context_lines":[{"line_number":350,"context_line":"            LOG.debug(\"Not caching compute RPC version_cap, because min \""},{"line_number":351,"context_line":"                      \"service_version is 0. Please ensure a nova-compute \""},{"line_number":352,"context_line":"                      \"service has been started. Defaulting to Mitaka RPC.\")"},{"line_number":353,"context_line":"            return self.VERSION_ALIASES[\"mitaka\"]"},{"line_number":354,"context_line":""},{"line_number":355,"context_line":"        history \u003d service_obj.SERVICE_VERSION_HISTORY"},{"line_number":356,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":4,"id":"fad55976_a090e396","line":353,"range":{"start_line":353,"start_character":41,"end_line":353,"end_character":47},"in_reply_to":"fad55976_14577903","updated":"2016-07-15 18:32:24.000000000","message":"Not in this patch, but I think in the longer run we should fix the code to not have any hardcoded default level. This does not seems to be manageable.","commit_id":"f17d96f1eb59d86939f8e381cfa3e58d43816362"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"82f10c8363f102233cfa050fe138d89439e1a6c8","unresolved":false,"context_lines":[{"line_number":350,"context_line":"            LOG.debug(\"Not caching compute RPC version_cap, because min \""},{"line_number":351,"context_line":"                      \"service_version is 0. Please ensure a nova-compute \""},{"line_number":352,"context_line":"                      \"service has been started. Defaulting to Mitaka RPC.\")"},{"line_number":353,"context_line":"            return self.VERSION_ALIASES[\"mitaka\"]"},{"line_number":354,"context_line":""},{"line_number":355,"context_line":"        history \u003d service_obj.SERVICE_VERSION_HISTORY"},{"line_number":356,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":4,"id":"dada55a8_7ff129cd","line":353,"range":{"start_line":353,"start_character":41,"end_line":353,"end_character":47},"in_reply_to":"fad55976_a090e396","updated":"2016-07-25 08:14:04.000000000","message":"So I think long term, this will be a hardcoded min_supported variable that we can enforce in the RPC pin config.","commit_id":"f17d96f1eb59d86939f8e381cfa3e58d43816362"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"2c62fe5d7e96693ce2d8ddcfbb1383dd5a9d3e1d","unresolved":false,"context_lines":[{"line_number":350,"context_line":"            LOG.debug(\"Not caching compute RPC version_cap, because min \""},{"line_number":351,"context_line":"                      \"service_version is 0. Please ensure a nova-compute \""},{"line_number":352,"context_line":"                      \"service has been started. Defaulting to Mitaka RPC.\")"},{"line_number":353,"context_line":"            return self.VERSION_ALIASES[\"mitaka\"]"},{"line_number":354,"context_line":""},{"line_number":355,"context_line":"        history \u003d service_obj.SERVICE_VERSION_HISTORY"},{"line_number":356,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":5,"id":"dada55a8_84a2ae49","line":353,"range":{"start_line":353,"start_character":41,"end_line":353,"end_character":47},"updated":"2016-07-25 20:11:05.000000000","message":"mmm, that means that we need to update this line for each new release,right?\n\nCouldn\u0027t we rather try to find the last stable RPC API version, like doing self.VERSION_ALIASES[-1] ?","commit_id":"f8f4b796b4e60533eea326d22920dcb73ffc61ca"},{"author":{"_account_id":14819,"name":"Timofey Durakov","email":"timofei.nd@gmail.com","username":"tdurakov"},"change_message_id":"aa6abfa662d4be7378491b3b44c92b10059a03d2","unresolved":false,"context_lines":[{"line_number":350,"context_line":"            LOG.debug(\"Not caching compute RPC version_cap, because min \""},{"line_number":351,"context_line":"                      \"service_version is 0. Please ensure a nova-compute \""},{"line_number":352,"context_line":"                      \"service has been started. Defaulting to Mitaka RPC.\")"},{"line_number":353,"context_line":"            return self.VERSION_ALIASES[\"mitaka\"]"},{"line_number":354,"context_line":""},{"line_number":355,"context_line":"        history \u003d service_obj.SERVICE_VERSION_HISTORY"},{"line_number":356,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":5,"id":"dada55a8_8aef3986","line":353,"range":{"start_line":353,"start_character":41,"end_line":353,"end_character":47},"in_reply_to":"dada55a8_84a2ae49","updated":"2016-07-26 10:13:20.000000000","message":"VERSION_ALIASES is a dict, so an order of elements is not guaranteed.","commit_id":"f8f4b796b4e60533eea326d22920dcb73ffc61ca"}],"nova/tests/unit/compute/test_rpcapi.py":[{"author":{"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},"change_message_id":"55ca297851533d533d5b124163ccda9b5580b1d0","unresolved":false,"context_lines":[{"line_number":76,"context_line":"        self.flags(compute\u003d\u0027auto\u0027, group\u003d\u0027upgrade_levels\u0027)"},{"line_number":77,"context_line":"        compute_rpcapi.LAST_VERSION \u003d None"},{"line_number":78,"context_line":"        rpcapi \u003d compute_rpcapi.ComputeAPI()"},{"line_number":79,"context_line":"        self.assertEqual(\u00274.11\u0027, rpcapi.client.version_cap)"},{"line_number":80,"context_line":"        mock_get_min.assert_called_once_with(mock.ANY, \u0027nova-compute\u0027)"},{"line_number":81,"context_line":"        self.assertIsNone(compute_rpcapi.LAST_VERSION)"},{"line_number":82,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"fad55976_200fd3e2","line":79,"range":{"start_line":79,"start_character":26,"end_line":79,"end_character":30},"updated":"2016-07-15 18:32:24.000000000","message":"I think you should leave a comment here that this number corresponds to Mitaka compute version and needs to be changed if the default value is changed in code. Also just better code readability.","commit_id":"f17d96f1eb59d86939f8e381cfa3e58d43816362"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"82f10c8363f102233cfa050fe138d89439e1a6c8","unresolved":false,"context_lines":[{"line_number":76,"context_line":"        self.flags(compute\u003d\u0027auto\u0027, group\u003d\u0027upgrade_levels\u0027)"},{"line_number":77,"context_line":"        compute_rpcapi.LAST_VERSION \u003d None"},{"line_number":78,"context_line":"        rpcapi \u003d compute_rpcapi.ComputeAPI()"},{"line_number":79,"context_line":"        self.assertEqual(\u00274.11\u0027, rpcapi.client.version_cap)"},{"line_number":80,"context_line":"        mock_get_min.assert_called_once_with(mock.ANY, \u0027nova-compute\u0027)"},{"line_number":81,"context_line":"        self.assertIsNone(compute_rpcapi.LAST_VERSION)"},{"line_number":82,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"dada55a8_3fce9183","line":79,"range":{"start_line":79,"start_character":26,"end_line":79,"end_character":30},"in_reply_to":"fad55976_200fd3e2","updated":"2016-07-25 08:14:04.000000000","message":"Its really a min_supported, but we need more work to resolve that properly.","commit_id":"f17d96f1eb59d86939f8e381cfa3e58d43816362"}]}